coreboot-gerrit April 2023

coreboot-gerrit@coreboot.org

1 participants
5761 discussions

[M] Change in coreboot[master]: soc/amd/common/psp_verstage: Map/unmap boot device on need basis
by Raul Rangel (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Jason Glenesk, Matt DeVillier, Martin Roth, Fred Reitberger, Karthik Ramasubramanian, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74606 ) Change subject: soc/amd/common/psp_verstage: Map/unmap boot device on need basis ...................................................................... Patch Set 1: (3 comments) File src/soc/amd/common/psp_verstage/boot_dev.c: https://review.coreboot.org/c/coreboot/+/74606/comment/673b683e_520045b3 PS1, Line 22: svc_map_spi_rom Will this set mapping to NULL on failure? https://review.coreboot.org/c/coreboot/+/74606/comment/263c1f1f_11a2db88 PS1, Line 22: size Does this have any alignment restrictions? File src/soc/amd/common/psp_verstage/fch.c: https://review.coreboot.org/c/coreboot/+/74606/comment/30935194_740276b1 PS1, Line 100: SpiBiosSmnBase Is this really a `void *`? -- To view, visit https://review.coreboot.org/c/coreboot/+/74606 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd44ea7b2a366e9269debcab4186d1fc71651db2 Gerrit-Change-Number: 74606 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 24 Apr 2023 15:35:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/google/skyrim: Add mainboard chip.h
by Raul Rangel (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Jason Nien, Jon Murphy, Martin Roth, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74609 ) Change subject: mb/google/skyrim: Add mainboard chip.h ...................................................................... Patch Set 8: (1 comment) File src/mainboard/google/skyrim/variants/baseboard/devicetree.cb: https://review.coreboot.org/c/coreboot/+/74609/comment/ddb33b4f_5d36bf59 PS8, Line 2: chip mainboard/google/skyrim/variants/baseboard Hrmm, I agree with Arthur, this looks strange. The goal is to just include a mainboard specific `.h` in the `static.c`. We can either make the device tree parser look for a mainboard/devicetree.h, or we can include a mainboard specific header in the soc/amd/mendocino/chip.h. The former is probably the least surprising. -- To view, visit https://review.coreboot.org/c/coreboot/+/74609 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic609d294135e2982064cb1c1fe6eac98dc24086f Gerrit-Change-Number: 74609 Gerrit-PatchSet: 8 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Mark Hasemeyer <markhas(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Mark Hasemeyer <markhas(a)google.com> Gerrit-Comment-Date: Mon, 24 Apr 2023 15:25:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim/var/markarth: Change to read the eMMC clkreq instead
by Karthik Ramasubramanian (Code Review) 24 Apr '23

24 Apr '23

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74583 ) Change subject: mb/google/skyrim/var/markarth: Change to read the eMMC clkreq instead ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/skyrim/variants/markarth/port_descriptors.c: https://review.coreboot.org/c/coreboot/+/74583/comment/3ab3106f_71e78578 PS4, Line 77: 115 Just a note: This change is functionally right. But in the future instead of number, I would prefer to use GPIO_115 as defined in soc/gpio.h. Jon is working on fixing it for Skyrim program - atleast fixable for port_descriptors.c. So no further effort required. We learnt that in older SoCs, GPIO_NNN != NNN. -- To view, visit https://review.coreboot.org/c/coreboot/+/74583 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a9225473a6ae1ba01dc8e5d982c4999f073267e Gerrit-Change-Number: 74583 Gerrit-PatchSet: 4 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chao Gui <chaogui(a)google.com> Gerrit-Reviewer: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Patrick Huang <patrick.huang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Mon, 24 Apr 2023 15:23:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: soc/amd/common/block: Add missing cbfs_unmap().
by Raul Rangel (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Jason Glenesk, Matt DeVillier, Grzegorz Bernacki, Tim Van Patten, Fred Reitberger, Karthik Ramasubramanian, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74716 ) Change subject: soc/amd/common/block: Add missing cbfs_unmap(). ...................................................................... Patch Set 1: (2 comments) File src/soc/amd/common/block/cpu/update_microcode.c: https://review.coreboot.org/c/coreboot/+/74716/comment/c47bfc18_1be89108 PS1, Line 83: struct microcode *ucode = NULL; This variable is only valid inside the `if` block below. https://review.coreboot.org/c/coreboot/+/74716/comment/6a003d30_bfdb9663 PS1, Line 114: ucode cache_valid should be false now. -- To view, visit https://review.coreboot.org/c/coreboot/+/74716 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbebe7401e9f5a5312da1216408bf42fa2449db1 Gerrit-Change-Number: 74716 Gerrit-PatchSet: 1 Gerrit-Owner: Grzegorz Bernacki Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Konrad Adamczyk <konrada(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Attention: Grzegorz Bernacki Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 24 Apr 2023 15:20:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/amd/mayan: Update DXIO descriptors per schematics
by Anand Vaikar (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Jason Glenesk, ritul guru, Paul Menzel, Fred Reitberger, Felix Held. Anand Vaikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74191 ) Change subject: mb/amd/mayan: Update DXIO descriptors per schematics ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74191/comment/c1ac9d08_52b612b0 PS2, Line 7: for mayan > This was lost in the latest patch set good catch, thanks. I have fixed it. -- To view, visit https://review.coreboot.org/c/coreboot/+/74191 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b536f8a1ff4eab06f37aec0f25704525dc1b64e Gerrit-Change-Number: 74191 Gerrit-PatchSet: 5 Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 24 Apr 2023 15:12:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Fred Reitberger <reitbergerfred(a)gmail.com> Comment-In-Reply-To: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/amd/mayan: Update DXIO descriptors per schematics
by Anand Vaikar (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Jason Glenesk, ritul guru, Paul Menzel, Anand Vaikar, Felix Held. Hello build bot (Jenkins), Jason Glenesk, ritul guru, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/74191 to look at the new patch set (#5). Change subject: mb/amd/mayan: Update DXIO descriptors per schematics ...................................................................... mb/amd/mayan: Update DXIO descriptors per schematics Change-Id: I8b536f8a1ff4eab06f37aec0f25704525dc1b64e Signed-off-by: Anand Vaikar <a.vaikar2021(a)gmail.com> --- M src/mainboard/amd/mayan/port_descriptors.c 1 file changed, 81 insertions(+), 33 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/74191/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/74191 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b536f8a1ff4eab06f37aec0f25704525dc1b64e Gerrit-Change-Number: 74191 Gerrit-PatchSet: 5 Gerrit-Owner: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Anand Vaikar <a.vaikar2021(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[master]: drivers/i2c: Add PI7C9X2G608GP PCIe switch driver (pi608gp)
by Paul Menzel (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Mario Scheithauer, Lean Sheng Tan, Werner Zeh, Jan Samek. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74433 ) Change subject: drivers/i2c: Add PI7C9X2G608GP PCIe switch driver (pi608gp) ...................................................................... Patch Set 12: (6 comments) File src/drivers/i2c/pi608gp/pi608gp.h: https://review.coreboot.org/c/coreboot/+/74433/comment/a565ad91_2ab97501 PS12, Line 10: #define DEEMPH_LVL_MV(_LVL, _LVL_10) {.lvl = _LVL, .lvl_10 = _LVL_10} Add spaces after { and before }? File src/drivers/i2c/pi608gp/pi608gp.c: https://review.coreboot.org/c/coreboot/+/74433/comment/3ec4b4bf_58b7666d PS12, Line 17: /* Only some of the available registers are implemented. : For a full list, see the PI7C9X2G608GP datasheet. */ As it’s not in a function body you could use: /* * […] */ https://review.coreboot.org/c/coreboot/+/74433/comment/ecf9b76a_be4fa8a3 PS12, Line 26: level Add the unit to the name? https://review.coreboot.org/c/coreboot/+/74433/comment/b53cd293_d155f7f1 PS12, Line 48: { 0, 0} Use spaces consistently? https://review.coreboot.org/c/coreboot/+/74433/comment/8aaad4fb_87d21b6a PS12, Line 54: uint8_t Please use int [1]? [1]: https://notabs.org/coding/smallIntsBigPenalty.htm https://review.coreboot.org/c/coreboot/+/74433/comment/cc4c6ebe_e74c8e1f PS12, Line 71: /* Compose the SMBus message for register read init operation (from MSB to LSB): : Byte 1: 7:3 = Rsvd., 2:0 = Command, : Byte 2: 7:4 = Rsvd., 3:0 = Port Select[4:1], : Byte 3: 7 = Port Select[0], 6 = Rsvd., 5:2 = Byte Enable, 1:0 = Reg. Addr. [11:10], : Byte 4: 7:0 = Reg. Addr.[9:2] (Reg. Addr. [1:0] fixed to 0). */ Maybe use non-concise form? -- To view, visit https://review.coreboot.org/c/coreboot/+/74433 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id191c4e97b99da58efd3ba38bf8cca3603ece4d5 Gerrit-Change-Number: 74433 Gerrit-PatchSet: 12 Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Jan Samek <jan.samek(a)siemens.com> Gerrit-Comment-Date: Mon, 24 Apr 2023 15:10:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Revert "util/ifdtool: Add option to create FMAP template"
by Matt DeVillier (Code Review) 24 Apr '23

24 Apr '23

Attention is currently required from: Felix Singer, Martin L Roth, Patrick Rudolph, Subrata Banik, Stefan Reinauer, Kapil Porwal, Maximilian Brune, Angel Pons, Lean Sheng Tan. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74692 ) Change subject: Revert "util/ifdtool: Add option to create FMAP template" ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/74692/comment/e44b60ca_665a0dfb PS2, Line 11: Above commit inserts multiple IFD regions not present into the default : FMAP template, some of which overlap, resulting in far less space : available for BIOS region / CBFS. > Did you have issues with an IFD on a board? Was the IFD faulty somehow? I'm having issues building all of the google/glados variants (Skylake). This is what the generated fmap.fmd ends up being: FLASH@4278190080 0x01000000 { SI_DESC@0x0 0x1000 SI_ME@0x1000 0x1FF000 SI_IE@0x7FFF000 0x1000 SI_10GBE0@0x7FFF000 0x1000 SI_10GBE1@0x7FFF000 0x1000 (null)@0x7FFF000 0x1000 (null)@0x7FFF000 0x1000 SI_PTT@0x7FFF000 0x1000 SI_BIOS@12255232 4521984 { RW_MRC_CACHE@0 0x10000 SMMSTORE@65536 0x40000 RO_VPD@327680 0x4000 FMAP@344064 0x200 COREBOOT(CBFS)@344576 4177408 } } the error I get building is: FMAP build/util/cbfstool/fmaptool -h build/fmap_config.h build/fmap.fmd build/fmap.fmap syntax error FATAL: Failed while processing provided descriptor it seems possible this is an issue with ifdtool, since using the `-p sklkbl` flag produces a layout with those bogus fields. Running ifdtool without `-p` shows the correct layout: without -p: Found Region Section FLREG0: 0x00000000 Flash Region 0 (Flash Descriptor): 00000000 - 00000fff FLREG1: 0x0fff0200 Flash Region 1 (BIOS): 00200000 - 00ffffff FLREG2: 0x01ff0001 Flash Region 2 (Intel ME): 00001000 - 001fffff FLREG3: 0x00007fff Flash Region 3 (GbE): 00fff000 - 00000fff (unused) FLREG4: 0x00007fff Flash Region 4 (Platform Data): 00fff000 - 00000fff (unused) with -p sklkbl (which is what the build system is doing): Found Region Section FLREG0: 0x00000000 Flash Region 0 (Flash Descriptor): 00000000 - 00000fff FLREG1: 0x0fff0200 Flash Region 1 (BIOS): 00200000 - 00ffffff FLREG2: 0x01ff0001 Flash Region 2 (Intel ME): 00001000 - 001fffff FLREG3: 0x00007fff Flash Region 3 (GbE): 07fff000 - 00000fff (unused) FLREG4: 0x00007fff Flash Region 4 (Platform Data): 07fff000 - 00000fff (unused) FLREG5: 0x00007fff Flash Region 5 (Device Exp1): 07fff000 - 00000fff (unused) FLREG6: 0x00007fff Flash Region 6 (Secondary BIOS): 07fff000 - 00000fff (unused) FLREG8: 0x00007fff Flash Region 8 (EC): 07fff000 - 00000fff (unused) FLREG9: 0x00007fff Flash Region 9 (Device Exp2): 07fff000 - 00000fff (unused) FLREG10: 0xffffffff Flash Region 10 (IE): 07fff000 - 07ffffff FLREG11: 0xffffffff Flash Region 11 (10GbE_0): 07fff000 - 07ffffff FLREG12: 0xffffffff Flash Region 12 (10GbE_1): 07fff000 - 07ffffff FLREG13: 0xffffffff Flash Region 13 (Reserved): 07fff000 - 07ffffff FLREG14: 0xffffffff Flash Region 14 (Reserved): 07fff000 - 07ffffff FLREG15: 0xffffffff Flash Region 15 (PTT): 07fff000 - 07ffffff -- To view, visit https://review.coreboot.org/c/coreboot/+/74692 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7cbcbe16d508787f5c8aae4889199185890f0dc7 Gerrit-Change-Number: 74692 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Bill XIE <persmule(a)hardenedlinux.org> Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Mon, 24 Apr 2023 14:34:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: asus/p2b: Remove MADT LAPIC
by Felix Held (Code Review) 24 Apr '23

24 Apr '23

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74472 ) Change subject: asus/p2b: Remove MADT LAPIC ...................................................................... Patch Set 5: (1 comment) File src/southbridge/intel/i82371eb/Kconfig: https://review.coreboot.org/c/coreboot/+/74472/comment/0e9ba713_66574346 PS4, Line 2: select ACPI_COMMON_MADT_LAPIC > hadn't looked a those yet oh, i already reviewed the first of those two -- To view, visit https://review.coreboot.org/c/coreboot/+/74472 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e2fbf358cf644665b897afb0a9404abb5ca1df2 Gerrit-Change-Number: 74472 Gerrit-PatchSet: 5 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Branden Waldner <scruffy99(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 24 Apr 2023 14:26:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: asus/p2b: Remove MADT LAPIC
by Felix Held (Code Review) 24 Apr '23

24 Apr '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74472 ) Change subject: asus/p2b: Remove MADT LAPIC ...................................................................... asus/p2b: Remove MADT LAPIC Fix after 'commit 69a13964ea6c ("sb,soc/amd,intel: Add and use ACPI_COMMON_MADT_LAPIC")' broke interrupt delivery in kernel. Apparently combination of LAPIC without IOAPIC is too rare to be well supported. Change-Id: I5e2fbf358cf644665b897afb0a9404abb5ca1df2 Signed-off-by: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/74472 Reviewed-by: Branden Waldner <scruffy99(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> --- M src/mainboard/emulation/qemu-i440fx/Kconfig M src/southbridge/intel/i82371eb/Kconfig 2 files changed, 21 insertions(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Branden Waldner: Looks good to me, but someone else must approve diff --git a/src/mainboard/emulation/qemu-i440fx/Kconfig b/src/mainboard/emulation/qemu-i440fx/Kconfig index f02c92d..5bf95b2 100644 --- a/src/mainboard/emulation/qemu-i440fx/Kconfig +++ b/src/mainboard/emulation/qemu-i440fx/Kconfig @@ -2,6 +2,7 @@ config BOARD_SPECIFIC_OPTIONS def_bool y + select ACPI_COMMON_MADT_LAPIC select CPU_QEMU_X86 select NO_ECAM_MMCONF_SUPPORT select SOUTHBRIDGE_INTEL_I82371EB diff --git a/src/southbridge/intel/i82371eb/Kconfig b/src/southbridge/intel/i82371eb/Kconfig index 08ffb00..03e70a6 100644 --- a/src/southbridge/intel/i82371eb/Kconfig +++ b/src/southbridge/intel/i82371eb/Kconfig @@ -1,5 +1,4 @@ config SOUTHBRIDGE_INTEL_I82371EB - select ACPI_COMMON_MADT_LAPIC select ACPI_INTEL_HARDWARE_SLEEP_VALUES select SOUTHBRIDGE_INTEL_COMMON_SMBUS select SOUTHBRIDGE_INTEL_COMMON_RTC -- To view, visit https://review.coreboot.org/c/coreboot/+/74472 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5e2fbf358cf644665b897afb0a9404abb5ca1df2 Gerrit-Change-Number: 74472 Gerrit-PatchSet: 5 Gerrit-Owner: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Branden Waldner <scruffy99(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2023