coreboot-gerrit March 2023

coreboot-gerrit@coreboot.org

1 participants
4880 discussions

[S] Change in coreboot[master]: mb/siemens/mc_ehl2: Fix GPIO settings
by Jan Samek (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Mario Scheithauer, Werner Zeh. Jan Samek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73341 ) Change subject: mb/siemens/mc_ehl2: Fix GPIO settings ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/73341 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I266612f041b749aa83b366497b4211fc075c7bd7 Gerrit-Change-Number: 73341 Gerrit-PatchSet: 1 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Wed, 01 Mar 2023 12:16:00 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/siemens/mc_ehl4: Disable TPM
by Werner Zeh (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Mario Scheithauer. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72429 ) Change subject: mb/siemens/mc_ehl4: Disable TPM ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/72429/comment/052eac21_5e9702c7 PS2, Line 7: Disable TPM How about 'Remove TMP from devicetree'? -- To view, visit https://review.coreboot.org/c/coreboot/+/72429 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieebbf12fc844573ffadb089da78062dd2033517a Gerrit-Change-Number: 72429 Gerrit-PatchSet: 2 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Comment-Date: Wed, 01 Mar 2023 12:15:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/siemens/mc_ehl: Move TPM Kconfig switches to variants
by Werner Zeh (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Mario Scheithauer. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72428 ) Change subject: mb/siemens/mc_ehl: Move TPM Kconfig switches to variants ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/72428/comment/a91317d8_0d9e5ad3 PS2, Line 9: Elkhartlake Elkhart Lake -- To view, visit https://review.coreboot.org/c/coreboot/+/72428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic73ccd1b52e57c1cf1dd7337b0e28beaadbece8e Gerrit-Change-Number: 72428 Gerrit-PatchSet: 2 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Comment-Date: Wed, 01 Mar 2023 12:14:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/siemens/mc_ehl4: Add new board variant based on mc_ehl1
by Werner Zeh (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Paul Menzel, Mario Scheithauer. Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72427 ) Change subject: mb/siemens/mc_ehl4: Add new board variant based on mc_ehl1 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72427 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c1f2cf4a3dcae58895f6d14a7fce46b2825e6ba Gerrit-Change-Number: 72427 Gerrit-PatchSet: 2 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jan Samek <jan.samek(a)siemens.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Comment-Date: Wed, 01 Mar 2023 12:13:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Generate LP5 RAM ID for `K3KL6L60GM-MGCT`
by Eric Lai (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Ivy Jian. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73344 ) Change subject: mb/google/rex: Generate LP5 RAM ID for `K3KL6L60GM-MGCT` ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73344 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0925ccec014c9c535178ed3d908e60889df624d Gerrit-Change-Number: 73344 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 01 Mar 2023 11:52:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: spd/lp5: Add SPD for Samsung K3KL6L60GM-MGCT
by Eric Lai (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Dinesh Gehlot, Ivy Jian, Eran Mitrani. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73343 ) Change subject: spd/lp5: Add SPD for Samsung K3KL6L60GM-MGCT ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73343 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64b2623bc8da94c1fd3a935ec5368cdc6e76505b Gerrit-Change-Number: 73343 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <eranmitrani(a)gmail.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Eran Mitrani <eranmitrani(a)gmail.com> Gerrit-Comment-Date: Wed, 01 Mar 2023 11:52:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Generate LP5 RAM ID for `H58G56BK7BX068`
by Eric Lai (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Dinesh Gehlot, Kapil Porwal, Ivy Jian. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73342 ) Change subject: mb/google/rex: Generate LP5 RAM ID for `H58G56BK7BX068` ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73342 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9eea7e277628992be9b7768a678a50425444002a Gerrit-Change-Number: 73342 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Wed, 01 Mar 2023 11:51:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex: Generate LP5 RAM ID for `K3KL6L60GM-MGCT`
by Subrata Banik (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Tarun Tuli, Kapil Porwal. Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/73344 ) Change subject: mb/google/rex: Generate LP5 RAM ID for `K3KL6L60GM-MGCT` ...................................................................... mb/google/rex: Generate LP5 RAM ID for `K3KL6L60GM-MGCT` Add the support LP5 RAM parts for rex: DRAM Part Name ID to assign K3KL6L60GM-MGCT 3 (0011) BUG=b:270708359 TEST=emerge-rex coreboot Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: Id0925ccec014c9c535178ed3d908e60889df624d --- M src/mainboard/google/rex/variants/rex0/memory/Makefile.inc M src/mainboard/google/rex/variants/rex0/memory/dram_id.generated.txt M src/mainboard/google/rex/variants/rex0/memory/mem_parts_used.txt 3 files changed, 20 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/73344/1 diff --git a/src/mainboard/google/rex/variants/rex0/memory/Makefile.inc b/src/mainboard/google/rex/variants/rex0/memory/Makefile.inc index 2a7ecdc..ee6d6e8 100644 --- a/src/mainboard/google/rex/variants/rex0/memory/Makefile.inc +++ b/src/mainboard/google/rex/variants/rex0/memory/Makefile.inc @@ -7,3 +7,4 @@ SPD_SOURCES += spd/lp5/set-0/spd-1.hex # ID = 0(0b0000) Parts = MT62F512M32D2DR-031 WT:B SPD_SOURCES += spd/lp5/set-0/spd-7.hex # ID = 1(0b0001) Parts = MT62F1G32D2DS-026 WT:B, H58G56BK7BX068 SPD_SOURCES += spd/lp5/set-0/spd-8.hex # ID = 2(0b0010) Parts = MT62F2G32D4DS-026 WT:B +SPD_SOURCES += spd/lp5/set-0/spd-9.hex # ID = 3(0b0011) Parts = K3KL6L60GM-MGCT diff --git a/src/mainboard/google/rex/variants/rex0/memory/dram_id.generated.txt b/src/mainboard/google/rex/variants/rex0/memory/dram_id.generated.txt index 995220c..47da118 100644 --- a/src/mainboard/google/rex/variants/rex0/memory/dram_id.generated.txt +++ b/src/mainboard/google/rex/variants/rex0/memory/dram_id.generated.txt @@ -8,3 +8,4 @@ MT62F1G32D2DS-026 WT:B 1 (0001) MT62F2G32D4DS-026 WT:B 2 (0010) H58G56BK7BX068 1 (0001) +K3KL6L60GM-MGCT 3 (0011) diff --git a/src/mainboard/google/rex/variants/rex0/memory/mem_parts_used.txt b/src/mainboard/google/rex/variants/rex0/memory/mem_parts_used.txt index 0513b71..c952558 100644 --- a/src/mainboard/google/rex/variants/rex0/memory/mem_parts_used.txt +++ b/src/mainboard/google/rex/variants/rex0/memory/mem_parts_used.txt @@ -13,3 +13,4 @@ MT62F1G32D2DS-026 WT:B MT62F2G32D4DS-026 WT:B H58G56BK7BX068 +K3KL6L60GM-MGCT -- To view, visit https://review.coreboot.org/c/coreboot/+/73344 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id0925ccec014c9c535178ed3d908e60889df624d Gerrit-Change-Number: 73344 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: spd/lp5: Add SPD for Samsung K3KL6L60GM-MGCT
by Subrata Banik (Code Review) 01 Mar '23

01 Mar '23

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/73343 ) Change subject: spd/lp5: Add SPD for Samsung K3KL6L60GM-MGCT ...................................................................... spd/lp5: Add SPD for Samsung K3KL6L60GM-MGCT This adds support for Samsung K3KL6L60GM-MGCT chips. BUG=b:270708359 TEST=util/spd_tools/bin/spd_gen spd/lp5/memory_parts.json lp5 Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I64b2623bc8da94c1fd3a935ec5368cdc6e76505b --- M spd/lp5/memory_parts.json M spd/lp5/set-0/parts_spd_manifest.generated.txt M spd/lp5/set-0/spd-9.hex M spd/lp5/set-1/parts_spd_manifest.generated.txt M spd/lp5/set-1/spd-9.hex 5 files changed, 33 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/73343/1 diff --git a/spd/lp5/memory_parts.json b/spd/lp5/memory_parts.json index 5d6be0e..2332459 100644 --- a/spd/lp5/memory_parts.json +++ b/spd/lp5/memory_parts.json @@ -133,6 +133,17 @@ } }, { + "name": "K3KL6L60GM-MGCT", + "attribs": { + "densityPerDieGb": 8, + "diesPerPackage": 2, + "bitWidthPerChannel": 16, + "ranksPerChannel": 1, + "speedMbps": 7500, + "lp5x": true + } + }, + { "name": "K3KL8L80CM-MGCT", "attribs": { "densityPerDieGb": 16, diff --git a/spd/lp5/set-0/parts_spd_manifest.generated.txt b/spd/lp5/set-0/parts_spd_manifest.generated.txt index b42b19f..d9a3d6b 100644 --- a/spd/lp5/set-0/parts_spd_manifest.generated.txt +++ b/spd/lp5/set-0/parts_spd_manifest.generated.txt @@ -14,6 +14,7 @@ K3LKCKC0BM-MGCP,spd-6.hex MT62F1G32D2DS-026 WT:B,spd-7.hex MT62F2G32D4DS-026 WT:B,spd-8.hex +K3KL6L60GM-MGCT,spd-9.hex K3KL8L80CM-MGCT,spd-7.hex K3KL9L90CM-MGCT,spd-8.hex H58G66BK7BX067,spd-8.hex diff --git a/spd/lp5/set-0/spd-9.hex b/spd/lp5/set-0/spd-9.hex index 4b6e854..a6a8280 100644 --- a/spd/lp5/set-0/spd-9.hex +++ b/spd/lp5/set-0/spd-9.hex @@ -1,11 +1,11 @@ -23 10 13 0E 15 1A F9 08 00 00 00 00 0A 01 00 00 -00 00 0A 00 00 00 00 00 AA 00 90 A8 90 90 06 C0 +23 10 15 0E 15 1A 95 08 00 00 00 00 02 01 00 00 +00 00 09 00 00 00 00 00 AB 00 90 A8 90 90 06 C0 03 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 +00 00 00 00 00 00 00 00 00 00 00 C9 00 C5 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 diff --git a/spd/lp5/set-1/parts_spd_manifest.generated.txt b/spd/lp5/set-1/parts_spd_manifest.generated.txt index b42b19f..d9a3d6b 100644 --- a/spd/lp5/set-1/parts_spd_manifest.generated.txt +++ b/spd/lp5/set-1/parts_spd_manifest.generated.txt @@ -14,6 +14,7 @@ K3LKCKC0BM-MGCP,spd-6.hex MT62F1G32D2DS-026 WT:B,spd-7.hex MT62F2G32D4DS-026 WT:B,spd-8.hex +K3KL6L60GM-MGCT,spd-9.hex K3KL8L80CM-MGCT,spd-7.hex K3KL9L90CM-MGCT,spd-8.hex H58G66BK7BX067,spd-8.hex diff --git a/spd/lp5/set-1/spd-9.hex b/spd/lp5/set-1/spd-9.hex index 87cef90..73f10a5 100644 --- a/spd/lp5/set-1/spd-9.hex +++ b/spd/lp5/set-1/spd-9.hex @@ -1,11 +1,11 @@ -23 11 13 0E 85 19 F9 18 00 40 00 00 0A 02 00 00 +23 11 13 0E 85 19 95 18 00 40 00 00 02 02 00 00 00 00 03 00 00 00 00 00 2B 00 90 A8 90 90 06 C0 03 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -00 00 00 00 00 00 00 00 00 00 00 B9 00 C1 00 00 +00 00 00 00 00 00 00 00 00 00 00 C9 00 93 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -- To view, visit https://review.coreboot.org/c/coreboot/+/73343 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I64b2623bc8da94c1fd3a935ec5368cdc6e76505b Gerrit-Change-Number: 73343 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/rex: Generate LP5 RAM ID for `H58G56BK7BX068`
by Subrata Banik (Code Review) 01 Mar '23

01 Mar '23

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/73342 ) Change subject: mb/google/rex: Generate LP5 RAM ID for `H58G56BK7BX068` ...................................................................... mb/google/rex: Generate LP5 RAM ID for `H58G56BK7BX068` Add the support LP5 RAM parts for rex: DRAM Part Name ID to assign H58G56BK7BX068 1 (0001) BUG=b:270708359 TEST=emerge-rex coreboot Signed-off-by: Subrata Banik <subratabanik(a)google.com> Change-Id: I9eea7e277628992be9b7768a678a50425444002a --- M src/mainboard/google/rex/variants/rex0/memory/Makefile.inc M src/mainboard/google/rex/variants/rex0/memory/dram_id.generated.txt M src/mainboard/google/rex/variants/rex0/memory/mem_parts_used.txt 3 files changed, 20 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/73342/1 diff --git a/src/mainboard/google/rex/variants/rex0/memory/Makefile.inc b/src/mainboard/google/rex/variants/rex0/memory/Makefile.inc index cc10fdd..2a7ecdc 100644 --- a/src/mainboard/google/rex/variants/rex0/memory/Makefile.inc +++ b/src/mainboard/google/rex/variants/rex0/memory/Makefile.inc @@ -5,5 +5,5 @@ SPD_SOURCES = SPD_SOURCES += spd/lp5/set-0/spd-1.hex # ID = 0(0b0000) Parts = MT62F512M32D2DR-031 WT:B -SPD_SOURCES += spd/lp5/set-0/spd-7.hex # ID = 1(0b0001) Parts = MT62F1G32D2DS-026 WT:B +SPD_SOURCES += spd/lp5/set-0/spd-7.hex # ID = 1(0b0001) Parts = MT62F1G32D2DS-026 WT:B, H58G56BK7BX068 SPD_SOURCES += spd/lp5/set-0/spd-8.hex # ID = 2(0b0010) Parts = MT62F2G32D4DS-026 WT:B diff --git a/src/mainboard/google/rex/variants/rex0/memory/dram_id.generated.txt b/src/mainboard/google/rex/variants/rex0/memory/dram_id.generated.txt index 9cba730..995220c 100644 --- a/src/mainboard/google/rex/variants/rex0/memory/dram_id.generated.txt +++ b/src/mainboard/google/rex/variants/rex0/memory/dram_id.generated.txt @@ -7,3 +7,4 @@ MT62F512M32D2DR-031 WT:B 0 (0000) MT62F1G32D2DS-026 WT:B 1 (0001) MT62F2G32D4DS-026 WT:B 2 (0010) +H58G56BK7BX068 1 (0001) diff --git a/src/mainboard/google/rex/variants/rex0/memory/mem_parts_used.txt b/src/mainboard/google/rex/variants/rex0/memory/mem_parts_used.txt index 6df34eb..0513b71 100644 --- a/src/mainboard/google/rex/variants/rex0/memory/mem_parts_used.txt +++ b/src/mainboard/google/rex/variants/rex0/memory/mem_parts_used.txt @@ -12,3 +12,4 @@ MT62F512M32D2DR-031 WT:B MT62F1G32D2DS-026 WT:B MT62F2G32D4DS-026 WT:B +H58G56BK7BX068 -- To view, visit https://review.coreboot.org/c/coreboot/+/73342 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9eea7e277628992be9b7768a678a50425444002a Gerrit-Change-Number: 73342 Gerrit-PatchSet: 1 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2023