coreboot-gerrit March 2023

coreboot-gerrit@coreboot.org

1 participants
4880 discussions

[S] Change in coreboot[master]: vc/siemens/hwilib: Change uint32_t return type to size_t
by Mario Scheithauer (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Werner Zeh, Jan Samek. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72667 ) Change subject: vc/siemens/hwilib: Change uint32_t return type to size_t ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72667 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0a623f55b596297cdb6e17232828b9536c9a43e6 Gerrit-Change-Number: 72667 Gerrit-PatchSet: 1 Gerrit-Owner: Jan Samek <jan.samek(a)siemens.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Attention: Jan Samek <jan.samek(a)siemens.com> Gerrit-Comment-Date: Wed, 01 Mar 2023 13:29:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: drivers/net/phy/m88e1512: Add a way to set output impedance manually
by Mario Scheithauer (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Werner Zeh. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73018 ) Change subject: drivers/net/phy/m88e1512: Add a way to set output impedance manually ...................................................................... Patch Set 2: (1 comment) File src/drivers/net/phy/m88e1512/m88e1512.c: https://review.coreboot.org/c/coreboot/+/73018/comment/860e0c42_cb25c0d5 PS1, Line 84: Force with a second register write the new values > What about 'Activate the new setting. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/73018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I87fa03aa49514cdc33d2911d7f23386c8f69d95b Gerrit-Change-Number: 73018 Gerrit-PatchSet: 2 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Wed, 01 Mar 2023 13:25:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: amdfwtool:combo: Move the filling of field "lookup" into function
by Fred Reitberger (Code Review) 01 Mar '23

01 Mar '23

Fred Reitberger has submitted this change. ( https://review.coreboot.org/c/coreboot/+/66853 ) Change subject: amdfwtool:combo: Move the filling of field "lookup" into function ...................................................................... amdfwtool:combo: Move the filling of field "lookup" into function This filling does not need to be done separately. Change-Id: I53051349923dce40f4fc3f747ab41a93a3798823 Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/66853 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Fred Reitberger <reitbergerfred(a)gmail.com> --- M util/amdfwtool/amdfwtool.c 1 file changed, 17 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Fred Reitberger: Looks good to me, approved diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index 0d5acee..19a9438 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -632,8 +632,9 @@ switch (cookie) { case PSP2_COOKIE: - /* caller is responsible for lookup mode */ cdir->header.cookie = cookie; + /* lookup mode is hardcoded for now. */ + cdir->header.lookup = 1; cdir->header.num_entries = count; cdir->header.reserved[0] = 0; cdir->header.reserved[1] = 0; @@ -2604,7 +2605,6 @@ combo_dir->entries[0].lvl2_addr = BUFF_TO_RUN_MODE(ctx, pspdir, AMD_ADDR_REL_BIOS); - combo_dir->header.lookup = 1; fill_dir_header(combo_dir, 1, PSP2_COOKIE, &ctx); } -- To view, visit https://review.coreboot.org/c/coreboot/+/66853 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I53051349923dce40f4fc3f747ab41a93a3798823 Gerrit-Change-Number: 66853 Gerrit-PatchSet: 10 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: amdfwtool: Remove the hints of flag --combo-capable
by Fred Reitberger (Code Review) 01 Mar '23

01 Mar '23

Fred Reitberger has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73281 ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: amdfwtool: Remove the hints of flag --combo-capable ...................................................................... amdfwtool: Remove the hints of flag --combo-capable A few references to "--combo-capable" were left after commit 4bfb36ed68154d8ee6fc77a6b2bf79938cae9e8a Change-Id: I6f425db2a8b86d7ad928baee6bc7b07e5190ba37 Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/73281 Reviewed-by: Fred Reitberger <reitbergerfred(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M util/amdfwtool/amdfwtool.c 1 file changed, 16 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Fred Reitberger: Looks good to me, approved diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c index b946a1b..0d5acee 100644 --- a/util/amdfwtool/amdfwtool.c +++ b/util/amdfwtool/amdfwtool.c @@ -122,7 +122,7 @@ * * Modern generations supporting the combo directories require the * pointer to be at offset 0x14 of the Embedded Firmware Structure, - * regardless of the type of directory used. The --combo-capable + * regardless of the type of directory used. The --use-combo * argument enforces this placement. * * TODO: Future work may require fully implementing the PSP_COMBO feature. @@ -189,9 +189,6 @@ printf("--gec <FILE> Add GEC blob\n"); printf("\nPSP options:\n"); - printf("--combo-capable Place PSP directory pointer at Embedded\n"); - printf(" Firmware\n"); - printf(" offset able to support combo directory\n"); printf("--use-combo Use the COMBO layout\n"); printf("--multilevel Generate primary and secondary tables\n"); printf("--nvram <FILE> Add nvram binary\n"); -- To view, visit https://review.coreboot.org/c/coreboot/+/73281 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f425db2a8b86d7ad928baee6bc7b07e5190ba37 Gerrit-Change-Number: 73281 Gerrit-PatchSet: 4 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: drivers/net/phy/m88e1512: Add a way to set output impedance manually
by build bot (Jenkins) (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Mario Scheithauer. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73018 ) Change subject: drivers/net/phy/m88e1512: Add a way to set output impedance manually ...................................................................... Patch Set 2: (1 comment) Commit Message: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-171236): https://review.coreboot.org/c/coreboot/+/73018/comment/63ffd445_dab88e15 PS2, Line 16: https://web.archive.org/web/20230125074158/https://www.marvell.com/content/… Possible unwrapped commit description (prefer a maximum 72 chars per line) -- To view, visit https://review.coreboot.org/c/coreboot/+/73018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I87fa03aa49514cdc33d2911d7f23386c8f69d95b Gerrit-Change-Number: 73018 Gerrit-PatchSet: 2 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Comment-Date: Wed, 01 Mar 2023 13:24:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: drivers/net/phy/m88e1512: Add a way to set output impedance manually
by Mario Scheithauer (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Mario Scheithauer. Hello build bot (Jenkins), Werner Zeh, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/73018 to look at the new patch set (#2). Change subject: drivers/net/phy/m88e1512: Add a way to set output impedance manually ...................................................................... drivers/net/phy/m88e1512: Add a way to set output impedance manually This patch provides the functionality to set the RGMII output impedance manually. To ensure that no race condition occurs, the driver strength values for PMOS and NMOS should be written to the RGMII output impedance calibration override register first and then the force bit should be enabled with a second write to this register. Link to the Marvell PHY 88E1512 datasheet: https://web.archive.org/web/20230125074158/https://www.marvell.com/content/… Change-Id: I87fa03aa49514cdc33d2911d7f23386c8f69d95b Signed-off-by: Mario Scheithauer <mario.scheithauer(a)siemens.com> --- M src/drivers/net/phy/m88e1512/chip.h M src/drivers/net/phy/m88e1512/m88e1512.c M src/drivers/net/phy/m88e1512/m88e1512.h 3 files changed, 47 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/73018/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I87fa03aa49514cdc33d2911d7f23386c8f69d95b Gerrit-Change-Number: 73018 Gerrit-PatchSet: 2 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-MessageType: newpatchset

1 0

[XL] Change in coreboot[master]: mainboard/protectli/vault_ehl: Add initial structure
by Krystian Hebel (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Kacper Stojek, Artur Kowalski, Michał Kopeć, Elyes Haouas, Piotr Król. Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72407 ) Change subject: mainboard/protectli/vault_ehl: Add initial structure ...................................................................... Patch Set 15: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/72407 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia00c27117d48b76db306d3f988f159fc5d50e4a0 Gerrit-Change-Number: 72407 Gerrit-PatchSet: 15 Gerrit-Owner: Kacper Stojek Gerrit-Reviewer: Artur Kowalski <artur.kowalski(a)3mdeb.com> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kacper Stojek Gerrit-Attention: Artur Kowalski <artur.kowalski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Comment-Date: Wed, 01 Mar 2023 13:23:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/siemens/mc_ehl4: Remove TPM from devicetree
by Mario Scheithauer (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Werner Zeh. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72429 ) Change subject: mb/siemens/mc_ehl4: Remove TPM from devicetree ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/72429/comment/f4b46a30_61452d05 PS2, Line 7: Disable TPM > How about 'Remove TMP from devicetree'? Done Patchset: PS3: Sounds better. Thanks! -- To view, visit https://review.coreboot.org/c/coreboot/+/72429 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieebbf12fc844573ffadb089da78062dd2033517a Gerrit-Change-Number: 72429 Gerrit-PatchSet: 3 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Wed, 01 Mar 2023 13:19:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/siemens/mc_ehl: Move TPM Kconfig switches to variants
by Mario Scheithauer (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Werner Zeh. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72428 ) Change subject: mb/siemens/mc_ehl: Move TPM Kconfig switches to variants ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/72428/comment/dcbe30ed_509ad25f PS2, Line 9: Elkhartlake > Elkhart Lake Done -- To view, visit https://review.coreboot.org/c/coreboot/+/72428 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic73ccd1b52e57c1cf1dd7337b0e28beaadbece8e Gerrit-Change-Number: 72428 Gerrit-PatchSet: 3 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Wed, 01 Mar 2023 13:18:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/siemens/mc_ehl4: Add new board variant based on mc_ehl1
by Mario Scheithauer (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Paul Menzel. Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72427 ) Change subject: mb/siemens/mc_ehl4: Add new board variant based on mc_ehl1 ...................................................................... Patch Set 3: (1 comment) Patchset: PS1: > Hi Paul, I think Angel wrote this idea already at the mc_ehl3 implementation (70688: mb/siemens/mc_e […] Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/72427 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c1f2cf4a3dcae58895f6d14a7fce46b2825e6ba Gerrit-Change-Number: 72427 Gerrit-PatchSet: 3 Gerrit-Owner: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jan Samek <jan.samek(a)siemens.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 01 Mar 2023 13:17:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2023