coreboot-gerrit March 2023

coreboot-gerrit@coreboot.org

1 participants
4880 discussions

[S] Change in coreboot[master]: acpi/ec: Handle new host event EC_HOST_EVENT_BODY_DETECT_CHANGE
by Karthik Ramasubramanian (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Raul Rangel, Jason Nien, Martin Roth, Tim Van Patten, Boris Mittelberg. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73298 ) Change subject: acpi/ec: Handle new host event EC_HOST_EVENT_BODY_DETECT_CHANGE ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73298 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iabeb7891489a209f45504804355f1fa817082976 Gerrit-Change-Number: 73298 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Boris Mittelberg <bmbm(a)google.com> Gerrit-Comment-Date: Wed, 01 Mar 2023 15:30:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: spd/lp5: Modify Hynix LPDDR5X memory Speed
by Karthik Ramasubramanian (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Frank Wu, John Su, Tarun Tuli, Chao Gui, Dtrain Hsu, Subrata Banik, Nick Vaccaro, Eric Lai, Martin Roth. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73251 ) Change subject: spd/lp5: Modify Hynix LPDDR5X memory Speed ...................................................................... Patch Set 3: (1 comment) File spd/lp5/memory_parts.json: https://review.coreboot.org/c/coreboot/+/73251/comment/8ee768e9_01cee749 PS1, Line 207: "speedMbps": 8533, > @nva Sorry pressed enter too soon. Adding Nick, Subrata and Tarun for visibility. Not sure if ADL supports LP5x at full speeds. Please share your inputs. -- To view, visit https://review.coreboot.org/c/coreboot/+/73251 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I813fc1495836dbe33de426cf41a1f58c8e8a046e Gerrit-Change-Number: 73251 Gerrit-PatchSet: 3 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chao Gui <chaogui(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-CC: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Chao Gui <chaogui(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Wed, 01 Mar 2023 15:04:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: John Su <john_su(a)compal.corp-partner.google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: spd/lp5: Modify Hynix LPDDR5X memory Speed
by Karthik Ramasubramanian (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Frank Wu, John Su, Tarun Tuli, Chao Gui, Dtrain Hsu, Subrata Banik, Nick Vaccaro, Eric Lai, Martin Roth. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73251 ) Change subject: spd/lp5: Modify Hynix LPDDR5X memory Speed ...................................................................... Patch Set 3: (1 comment) File spd/lp5/memory_parts.json: https://review.coreboot.org/c/coreboot/+/73251/comment/edc7fa78_d6b7bda5 PS1, Line 207: "speedMbps": 8533, > This memory part is also used in omnigul. […] @nva -- To view, visit https://review.coreboot.org/c/coreboot/+/73251 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I813fc1495836dbe33de426cf41a1f58c8e8a046e Gerrit-Change-Number: 73251 Gerrit-PatchSet: 3 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chao Gui <chaogui(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-CC: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Chao Gui <chaogui(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Comment-Date: Wed, 01 Mar 2023 15:03:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: John Su <john_su(a)compal.corp-partner.google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util: Fix compilation on musl-libc systems
by Fabian Groffen (Code Review) 01 Mar '23

01 Mar '23

Fabian Groffen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/73358 ) Change subject: util: Fix compilation on musl-libc systems ...................................................................... util: Fix compilation on musl-libc systems Add some includes, use linux guard instead of __GLIBC__ where applicable. Uses ioperm instead of deprecated iopl. Signed-off-by: Fabian Groffen <grobian(a)gentoo.org> Change-Id: I99613007aa9feddcb1041f31085cdeb195ff7a68 --- M src/arch/x86/include/arch/mmio.h M util/inteltool/inteltool.h M util/superiotool/superiotool.c M util/superiotool/superiotool.h 4 files changed, 25 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/73358/1 diff --git a/src/arch/x86/include/arch/mmio.h b/src/arch/x86/include/arch/mmio.h index c2aa0fb..b2a37a0 100644 --- a/src/arch/x86/include/arch/mmio.h +++ b/src/arch/x86/include/arch/mmio.h @@ -5,6 +5,10 @@ #include <stdint.h> +#ifndef __always_inline +#define __always_inline inline +#endif + static __always_inline uint8_t read8(const volatile void *addr) { return *((volatile uint8_t *)(addr)); diff --git a/util/inteltool/inteltool.h b/util/inteltool/inteltool.h index 130e63c..490c70e 100644 --- a/util/inteltool/inteltool.h +++ b/util/inteltool/inteltool.h @@ -9,7 +9,7 @@ #include <stdint.h> -#if defined(__GLIBC__) +#if defined(linux) #include <sys/io.h> #endif #if (defined(__MACH__) && defined(__APPLE__)) diff --git a/util/superiotool/superiotool.c b/util/superiotool/superiotool.c index ed18c13..bd1c345 100644 --- a/util/superiotool/superiotool.c +++ b/util/superiotool/superiotool.c @@ -324,8 +324,8 @@ if ((io_fd = open("/dev/io", O_RDWR)) < 0) { perror("/dev/io"); #else - if (iopl(3) < 0) { - perror("iopl"); + if (ioperm(0, 6000, 1) < 0) { + perror("ioperm"); #endif printf("Superiotool must be run as root.\n"); exit(1); diff --git a/util/superiotool/superiotool.h b/util/superiotool/superiotool.h index a621ae5..1f6b3e95 100644 --- a/util/superiotool/superiotool.h +++ b/util/superiotool/superiotool.h @@ -8,7 +8,7 @@ #include <stdint.h> #include <string.h> #include <getopt.h> -#if defined(__GLIBC__) +#if defined(linux) #include <sys/io.h> #endif #if (defined(__MACH__) && defined(__APPLE__)) @@ -24,6 +24,9 @@ # endif #endif +#include <sys/types.h> +#include <stdint.h> + #if defined(__FreeBSD__) #include <sys/types.h> #include <machine/cpufunc.h> @@ -89,6 +92,7 @@ __asm__ __volatile__ ("inl %1,%0":"=a" (value):"Nd" (port)); return value; } + #endif #define USAGE "Usage: superiotool [-d] [-e] [-a] [-l] [-V] [-v] [-h]\n\n\ -- To view, visit https://review.coreboot.org/c/coreboot/+/73358 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I99613007aa9feddcb1041f31085cdeb195ff7a68 Gerrit-Change-Number: 73358 Gerrit-PatchSet: 1 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: soc/intel/xeon_sp/spr: Select DISABLE_ACPI_HIBERNATE to remove S4 state
by Felix Held (Code Review) 01 Mar '23

01 Mar '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73248 ) Change subject: soc/intel/xeon_sp/spr: Select DISABLE_ACPI_HIBERNATE to remove S4 state ...................................................................... soc/intel/xeon_sp/spr: Select DISABLE_ACPI_HIBERNATE to remove S4 state Server platform doesn't have S4 state so select DISABLE_ACPI_HIBERNATE to remove S4 state from available sleepstates. Signed-off-by: Tim Chu <Tim.Chu(a)quantatw.com> Change-Id: Ie5ddb1a98cd5bbd854b915c93694d1ebcb9bddd2 Reviewed-on: https://review.coreboot.org/c/coreboot/+/73248 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> --- M src/soc/intel/xeon_sp/spr/Kconfig 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Jonathan Zhang: Looks good to me, approved diff --git a/src/soc/intel/xeon_sp/spr/Kconfig b/src/soc/intel/xeon_sp/spr/Kconfig index b1d92cf..6ecf382 100644 --- a/src/soc/intel/xeon_sp/spr/Kconfig +++ b/src/soc/intel/xeon_sp/spr/Kconfig @@ -7,6 +7,7 @@ select MICROCODE_BLOB_NOT_HOOKED_UP select SAVE_MRC_AFTER_FSPS select SOC_INTEL_MEM_MAPPED_PM_CONFIGURATION + select DISABLE_ACPI_HIBERNATE config CHIPSET_DEVICETREE string -- To view, visit https://review.coreboot.org/c/coreboot/+/73248 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie5ddb1a98cd5bbd854b915c93694d1ebcb9bddd2 Gerrit-Change-Number: 73248 Gerrit-PatchSet: 2 Gerrit-Owner: Shuming Chu (Shuming) <s1218944(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[master]: mb/asus/p8x7x-series: Refactor mainboard_get_spd()
by Elyes Haouas (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Nico Huber, Angel Pons, Arthur Heymans, Keith Hui. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61540 ) Change subject: mb/asus/p8x7x-series: Refactor mainboard_get_spd() ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: would you please remove useless <northbridge/intel/sandybridge/raminit_native.h> or send a new patch removing them. -- To view, visit https://review.coreboot.org/c/coreboot/+/61540 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3b9c616a6c722e1f0fc124ced225efdcadb46b25 Gerrit-Change-Number: 61540 Gerrit-PatchSet: 4 Gerrit-Owner: Keith Hui <buurin(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Keith Hui <buurin(a)gmail.com> Gerrit-Comment-Date: Wed, 01 Mar 2023 15:00:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX
by Fabian Groffen (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Kevin Keijzer, Felix Singer, Angel Pons, Arthur Heymans, Nicholas Chin, Elyes Haouas. Fabian Groffen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73097 ) Change subject: mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: ok.... gerrit made a new review for Kevin's fixes in https://review.coreboot.org/c/coreboot/+/73357 -- To view, visit https://review.coreboot.org/c/coreboot/+/73097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6a6eb3e922920f4afbcb7828cd2b779b9caebcb Gerrit-Change-Number: 73097 Gerrit-PatchSet: 3 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kevin Keijzer Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Keijzer Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 01 Mar 2023 14:48:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/asrock/b75m-itx: Fix S3 suspend to RAM
by Fabian Groffen (Code Review) 01 Mar '23

01 Mar '23

Fabian Groffen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/73357 ) Change subject: mb/asrock/b75m-itx: Fix S3 suspend to RAM ...................................................................... mb/asrock/b75m-itx: Fix S3 suspend to RAM Signed-off-by: Fabian Groffen <grobian(a)gentoo.org> Change-Id: Ia6a6bb0002943a2697b35d3ae05a0d848df3fce6 --- M src/mainboard/asrock/b75m-itx/Kconfig A src/mainboard/asrock/b75m-itx/cmos.default A src/mainboard/asrock/b75m-itx/cmos.layout M src/mainboard/asrock/b75m-itx/devicetree.cb 4 files changed, 117 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/73357/1 diff --git a/src/mainboard/asrock/b75m-itx/Kconfig b/src/mainboard/asrock/b75m-itx/Kconfig index 80bb59e..8b0c6ff 100644 --- a/src/mainboard/asrock/b75m-itx/Kconfig +++ b/src/mainboard/asrock/b75m-itx/Kconfig @@ -15,6 +15,8 @@ select SOUTHBRIDGE_INTEL_C216 select USE_NATIVE_RAMINIT select MAINBOARD_HAS_LIBGFXINIT + select HAVE_OPTION_TABLE + select HAVE_CMOS_DEFAULT config MAINBOARD_DIR default "asrock/b75m-itx" diff --git a/src/mainboard/asrock/b75m-itx/cmos.default b/src/mainboard/asrock/b75m-itx/cmos.default new file mode 100644 index 0000000..23386fb --- /dev/null +++ b/src/mainboard/asrock/b75m-itx/cmos.default @@ -0,0 +1,7 @@ +boot_option=Fallback +debug_level=Debug +nmi=Disable +power_on_after_fail=Disable +sata_mode=AHCI +gfx_uma_size=64M +cpu_fan_tach_src=CPU_FAN1 diff --git a/src/mainboard/asrock/b75m-itx/cmos.layout b/src/mainboard/asrock/b75m-itx/cmos.layout new file mode 100644 index 0000000..ac88ee9 --- /dev/null +++ b/src/mainboard/asrock/b75m-itx/cmos.layout @@ -0,0 +1,96 @@ +## SPDX-License-Identifier: GPL-2.0-only + +# ----------------------------------------------------------------- +entries + +# ----------------------------------------------------------------- +0 120 r 0 reserved_memory + +# ----------------------------------------------------------------- +# RTC_BOOT_BYTE (coreboot hardcoded) +384 1 e 2 boot_option +388 4 h 0 reboot_counter + +# ----------------------------------------------------------------- +# coreboot config options: console +395 4 e 3 debug_level + +# coreboot config options: southbridge +408 1 e 1 nmi + +409 2 e 4 power_on_after_fail +411 2 e 5 sata_mode + +# coreboot config options: northbridge +416 5 e 6 gfx_uma_size + +# coreboot config options: mainboard-specific +421 2 e 7 cpu_fan_tach_src + +# coreboot config options: check sums +984 16 h 0 check_sum + +# ----------------------------------------------------------------- + +enumerations +#ID value text + +# Generic on/off enum +1 0 Disable +1 1 Enable + +# boot_option +2 0 Fallback +2 1 Normal + +# debug_level +3 0 Emergency +3 1 Alert +3 2 Critical +3 3 Error +3 4 Warning +3 5 Notice +3 6 Info +3 7 Debug +3 8 Spew + +# power_on_after_fail +4 0 Disable +4 1 Enable +4 2 Keep + +# sata_mode +5 0 AHCI +5 1 Compatible +5 2 Legacy + +# gfx_uma_size (Intel IGP Video RAM size) +6 0 32M +6 1 64M +6 2 96M +6 3 128M +6 4 160M +6 5 192M +6 6 224M +6 7 256M +6 8 288M +6 9 320M +6 10 352M +6 11 384M +6 12 416M +6 13 448M +6 14 480M +6 15 512M +6 16 1024M + +# cpu_fan_header (select which header provides the tachometer +# signal to the Super I/O on its CPUFANIN input) +7 0 None +7 1 CPU_FAN1 +7 2 CPU_FAN2 +7 3 Both + +# ----------------------------------------------------------------- +checksums + +checksum 392 423 984 diff --git a/src/mainboard/asrock/b75m-itx/devicetree.cb b/src/mainboard/asrock/b75m-itx/devicetree.cb index 756b5b6..c46b468 100644 --- a/src/mainboard/asrock/b75m-itx/devicetree.cb +++ b/src/mainboard/asrock/b75m-itx/devicetree.cb @@ -115,9 +115,10 @@ device pnp 2e.a on # ACPI irq 0xe0 = 0x01 irq 0xe3 = 0x14 + irq 0xe4 = 0x10 # + enable 3VSBSW irq 0xe6 = 0x4c irq 0xe9 = 0x02 - irq 0xf0 = 0x20 + irq 0xf0 = 0x20 # + pin 70 = 3VSBSW end device pnp 2e.b off end # HWM, front panel LED device pnp 2e.d on end # VID -- To view, visit https://review.coreboot.org/c/coreboot/+/73357 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6a6bb0002943a2697b35d3ae05a0d848df3fce6 Gerrit-Change-Number: 73357 Gerrit-PatchSet: 1 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-CC: Kevin Keijzer <kevin(a)quietlife.nl> Gerrit-MessageType: newchange

1 0

[L] Change in coreboot[master]: mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX
by Fabian Groffen (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Kevin Keijzer, Felix Singer, Angel Pons, Arthur Heymans, Nicholas Chin, Elyes Haouas. Fabian Groffen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73097 ) Change subject: mb/asrock/b75m-itx: Add Sandy/Ivy Bridge board B75M-ITX ...................................................................... Patch Set 3: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/73097/comment/22f35278_875feb7c PS3, Line 25: Working: > S3 suspend/resume can be added, provided you implement the fix I found. Done https://review.coreboot.org/c/coreboot/+/73097/comment/d4000e1c_7a6750ba PS3, Line 41: - DVI graphics output > This can be moved to working. Done File src/mainboard/asrock/b75m-itx/devicetree.cb: https://review.coreboot.org/c/coreboot/+/73097/comment/49072a9a_57ca81fe PS3, Line 115: device pnp 2e.a on # ACPI : irq 0xe0 = 0x01 : irq 0xe3 = 0x14 : irq 0xe6 = 0x4c : irq 0xe9 = 0x02 : irq 0xf0 = 0x20 : end > Change this to: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/73097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6a6eb3e922920f4afbcb7828cd2b779b9caebcb Gerrit-Change-Number: 73097 Gerrit-PatchSet: 3 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Kevin Keijzer Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Keijzer Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Wed, 01 Mar 2023 14:47:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kevin Keijzer Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/starlabs/starbook/adl: Enable the PchHdaAudioLinkHdaEnable UPD
by Michał Żygowski (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Sean Rhodes. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71979 ) Change subject: mb/starlabs/starbook/adl: Enable the PchHdaAudioLinkHdaEnable UPD ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71979 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie3493af340a42035ee537d83b1542be1b87d8f9c Gerrit-Change-Number: 71979 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Wed, 01 Mar 2023 14:44:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2023