coreboot-gerrit March 2023

coreboot-gerrit@coreboot.org

1 participants
4880 discussions

[M] Change in coreboot[master]: soc/intel/cmn/blk: Request pre-reset EC boot timestamps
by Dinesh Gehlot (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Bora Guvendik, Hannah Williams, Subrata Banik, Jay Patel. Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72931 ) Change subject: soc/intel/cmn/blk: Request pre-reset EC boot timestamps ...................................................................... Patch Set 9: (1 comment) Patchset: PS8: > > If you see "EC returned error result code 1" in cbmem -1 logs in romstage, then you probably need […] Similar observation, Timestamps are same and "EC returned error result code 1" is appeared in boot logs. Please share the bug with relevant CL's. -- To view, visit https://review.coreboot.org/c/coreboot/+/72931 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iecb88eaa085759ea9430708d45abf1ca69727ce9 Gerrit-Change-Number: 72931 Gerrit-PatchSet: 9 Gerrit-Owner: Jay Patel <jay2.patel(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Dinesh Gehlot <digehlot(a)google.com> Gerrit-CC: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jay Patel <jay2.patel(a)intel.com> Gerrit-Comment-Date: Wed, 01 Mar 2023 05:36:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Jay Patel <jay2.patel(a)intel.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/rex: Enable SoundWire codecs
by Eric Lai (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Tarun Tuli, Eran Mitrani, Subrata Banik, Kapil Porwal, Dinesh Gehlot. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73280 ) Change subject: mb/google/rex: Enable SoundWire codecs ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > do we need FW config for it? I saw it. Overlooked LoL. -- To view, visit https://review.coreboot.org/c/coreboot/+/73280 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e11dc642ff686ba7da23ed76332f7f10e60fade Gerrit-Change-Number: 73280 Gerrit-PatchSet: 3 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Comment-Date: Wed, 01 Mar 2023 05:24:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/google/rex: Enable SoundWire codecs
by Ivy Jian (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Tarun Tuli, Eran Mitrani, Subrata Banik, Kapil Porwal, Dinesh Gehlot. Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73280 ) Change subject: mb/google/rex: Enable SoundWire codecs ...................................................................... Patch Set 3: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/73280/comment/7027fd8c_b95eb24c PS3, Line 15: | Intel Meteorlake| +--->| Realtek CS42L42 | Cirrus Logic https://review.coreboot.org/c/coreboot/+/73280/comment/f4651aca_3c182f56 PS3, Line 37: HDAS.SNDW.SW00 - Realtek CS42L42 - Headphone Codec Cirrus Logic -- To view, visit https://review.coreboot.org/c/coreboot/+/73280 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e11dc642ff686ba7da23ed76332f7f10e60fade Gerrit-Change-Number: 73280 Gerrit-PatchSet: 3 Gerrit-Owner: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Comment-Date: Wed, 01 Mar 2023 05:21:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: commit-msg: Match the Signed-off-by line with name and mail address
by Bao Zheng (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Zheng Bao. Hello Zheng Bao, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/73340 to review the following change. Change subject: commit-msg: Match the Signed-off-by line with name and mail address ...................................................................... commit-msg: Match the Signed-off-by line with name and mail address Change-Id: I42cc399e79b65928a6aef87c51e5476c7158d166 Signed-off-by: Zheng Bao <fishbaozi(a)gmail.com> --- M util/gitconfig/commit-msg 1 file changed, 11 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/73340/1 diff --git a/util/gitconfig/commit-msg b/util/gitconfig/commit-msg index 99c8941..08f04ff 100755 --- a/util/gitconfig/commit-msg +++ b/util/gitconfig/commit-msg @@ -166,7 +166,7 @@ git hash-object -t commit --stdin } -if ! grep -qi '^[[:space:]]*Signed-off-by:' "$MSG"; then +if ! grep -qi '^[[:space:]]*Signed-off-by:.\+<.\+@.\+>' "$MSG"; then printf "\nError: No Signed-off-by line in the commit message.\n" exit 1 fi -- To view, visit https://review.coreboot.org/c/coreboot/+/73340 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I42cc399e79b65928a6aef87c51e5476c7158d166 Gerrit-Change-Number: 73340 Gerrit-PatchSet: 1 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Attention: Zheng Bao Gerrit-MessageType: newchange

1 0

[S] Change in blobs[master]: soc/mediatek/mt8188: Add scramble switch support as 0.1.1
by Xixi Chen (Code Review) 01 Mar '23

01 Mar '23

Xixi Chen has uploaded this change for review. ( https://review.coreboot.org/c/blobs/+/73339 ) Change subject: soc/mediatek/mt8188: Add scramble switch support as 0.1.1 ...................................................................... soc/mediatek/mt8188: Add scramble switch support as 0.1.1 Add scramble config switch to support both production build and serial build. BUG=b:269049451 TEST=build pass and confirm enable/disable scramble successfully Signed-off-by: Xi Chen <xixi.chen(a)mediatek.corp-partner.google.com> Change-Id: I7bf751e19d6df32bbd40b9dacad16fb99253d2ae --- M soc/mediatek/mt8188/dram.elf M soc/mediatek/mt8188/dram.elf.md5 M soc/mediatek/mt8188/dram_release_notes.txt 3 files changed, 29 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/39/73339/1 diff --git a/soc/mediatek/mt8188/dram.elf b/soc/mediatek/mt8188/dram.elf old mode 100644 new mode 100755 index 7f22c27..a682e88 --- a/soc/mediatek/mt8188/dram.elf +++ b/soc/mediatek/mt8188/dram.elf Binary files differ diff --git a/soc/mediatek/mt8188/dram.elf.md5 b/soc/mediatek/mt8188/dram.elf.md5 index dc9d076..5c4b731 100644 --- a/soc/mediatek/mt8188/dram.elf.md5 +++ b/soc/mediatek/mt8188/dram.elf.md5 @@ -1 +1 @@ -2ab5d7370e14bae8c8199c7be9128d9e *dram.elf +2f1c79839e0a78d16c19b039d05a650a *dram.elf diff --git a/soc/mediatek/mt8188/dram_release_notes.txt b/soc/mediatek/mt8188/dram_release_notes.txt index 8613b3d..8513755 100644 --- a/soc/mediatek/mt8188/dram_release_notes.txt +++ b/soc/mediatek/mt8188/dram_release_notes.txt @@ -1,3 +1,15 @@ +# 0.1.1 + +1. Add scramble switch for production build and serial build compatiblity. + Fix fast-k single rank wrong register bit. + +2. Included changes: + +- CL:*5498291 mtk-dramk/common: Add scramble switch +- CL:*5504769 mtk-dramk/common: Copy soc/emi.h to dramk/common from coreboot +- CL:*5533692 mtk-dramk/mt8188: Fix fast-k single rank wrong register bit + + # 0.1.0 1. A local build. -- To view, visit https://review.coreboot.org/c/blobs/+/73339 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: I7bf751e19d6df32bbd40b9dacad16fb99253d2ae Gerrit-Change-Number: 73339 Gerrit-PatchSet: 1 Gerrit-Owner: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[master]: mb/google/rex: Enable audio BT offload
by Uday Bhat (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Tarun Tuli, Subrata Banik, Ravishankar Sarawadi, Kapil Porwal. Uday Bhat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72881 ) Change subject: mb/google/rex: Enable audio BT offload ...................................................................... Patch Set 6: Code-Review+1 (1 comment) File src/mainboard/google/rex/variants/rex0/gpio.c: https://review.coreboot.org/c/coreboot/+/72881/comment/7c7cc2a9_40605426 PS4, Line 370: PAD_CFG_NF(GPP_VGPIO30, NONE, DEEP, NF3), /* BT_I2S_BCLK */ : PAD_CFG_NF(GPP_VGPIO31, NONE, DEEP, NF3), /* BT_I2S_SYNC */ : PAD_CFG_NF(GPP_VGPIO32, NONE, DEEP, NF3), /* BT_I2S_SDO */ : PAD_CFG_NF(GPP_VGPIO33, NONE, DEEP, NF3), /* BT_I2S_SDI */ > These values should be NF2 as I2S1 needs to be used for BT offload […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/72881 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I46e9702add37464122ffc78826ebf8a6c5b5b07c Gerrit-Change-Number: 72881 Gerrit-PatchSet: 6 Gerrit-Owner: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Uday Bhat <uday.m.bhat(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.corp-partner.google.com> Gerrit-CC: Uday M Bhat Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Comment-Date: Wed, 01 Mar 2023 03:45:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Uday Bhat <uday.m.bhat(a)intel.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/skyrim/var/markarth: Update RAM ID table
by John Su (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Frank Wu, Dtrain Hsu, Jason Nien, Eric Lai, Martin Roth. Hello Frank Wu, build bot (Jenkins), Dtrain Hsu, Jason Nien, Eric Lai, Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/73252 to look at the new patch set (#2). Change subject: mb/google/skyrim/var/markarth: Update RAM ID table ...................................................................... mb/google/skyrim/var/markarth: Update RAM ID table Add new ram_id:0011 for Hynix H58G56BK8BX068. Add new ram_id:0100 for Hynix H58G66BK8BX067. The RAM ID table has been assigned as: DRAM Part Name ID to assign K3KL8L80CM-MGCT 0 (0000) H58G56BK7BX068 0 (0000) MT62F1G32D2DS-026 WT:B 0 (0000) K3KL9L90CM-MGCT 1 (0001) H58G66BK7BX067 1 (0001) MT62F2G32D4DS-026 WT:B 1 (0001) MT62F512M32D2DR-031 WT:B 2 (0010) H58G56BK8BX068 3 (0011) H58G66BK8BX067 4 (0100) BUG=b:270629852 BRANCH=None TEST=FW_NAME=markarth emerge-skyrim coreboot Change-Id: Ida5c8354af71cd92c056a33e38d1fadfc5704977 Signed-off-by: John Su <john_su(a)compal.corp-partner.google.com> --- M src/mainboard/google/skyrim/variants/markarth/memory/Makefile.inc M src/mainboard/google/skyrim/variants/markarth/memory/dram_id.generated.txt M src/mainboard/google/skyrim/variants/markarth/memory/mem_parts_used.txt 3 files changed, 35 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/73252/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/73252 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ida5c8354af71cd92c056a33e38d1fadfc5704977 Gerrit-Change-Number: 73252 Gerrit-PatchSet: 2 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-CC: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: acpi: Add function to print debug string directly from formatted string
by Cliff Huang (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Lance Zhao, Bora Guvendik, Hannah Williams, Jakub Czapiga, Jérémy Compostella, Paul Menzel, Tim Wawrzynczak, Nick Vaccaro. Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73113 ) Change subject: acpi: Add function to print debug string directly from formatted string ...................................................................... Patch Set 2: (1 comment) File src/include/acpi/acpigen.h: https://review.coreboot.org/c/coreboot/+/73113/comment/5b35b0de_1ed78db4 PS2, Line 508: acpigen_write_debug > okay. I will change the function name to acpigen_write_debug_sprintf(). […] With acpigen_write_debug_sprintf(), the following functions won't be needed and therefore to be removed from this code review. acpigen_concatenate_string_string() acpigen_concatenate_string_int() acpigen_write_debug_concatenate_string_string() anacpigen_write_debug_concatenate_string_int() -- To view, visit https://review.coreboot.org/c/coreboot/+/73113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id4a42e5854516a22b7bc4559c2ed08680722c5ba Gerrit-Change-Number: 73113 Gerrit-PatchSet: 2 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Wed, 01 Mar 2023 03:23:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Lance Zhao <lance.zhao(a)gmail.com> Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com> Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: spd/lp5: Modify Hynix LPDDR5X memory Speed
by John Su (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Frank Wu, Chao Gui, Dtrain Hsu, Subrata Banik, Eric Lai, Martin Roth, Karthik Ramasubramanian. John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73251 ) Change subject: spd/lp5: Modify Hynix LPDDR5X memory Speed ...................................................................... Patch Set 3: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/73251 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I813fc1495836dbe33de426cf41a1f58c8e8a046e Gerrit-Change-Number: 73251 Gerrit-PatchSet: 3 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Chao Gui <chaogui(a)google.com> Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com> Gerrit-CC: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-CC: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-CC: Rex Chou <rex_chou(a)compal.corp-partner.google.com> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com> Gerrit-Attention: Chao Gui <chaogui(a)google.com> Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 01 Mar 2023 03:23:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: acpi: Add function to print debug string directly from formatted string
by Cliff Huang (Code Review) 01 Mar '23

01 Mar '23

Attention is currently required from: Lance Zhao, Bora Guvendik, Hannah Williams, Jakub Czapiga, Jérémy Compostella, Paul Menzel, Tim Wawrzynczak, Nick Vaccaro. Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73113 ) Change subject: acpi: Add function to print debug string directly from formatted string ...................................................................... Patch Set 2: (1 comment) File src/include/acpi/acpigen.h: https://review.coreboot.org/c/coreboot/+/73113/comment/3e32cea5_d2dd9fb4 PS2, Line 508: acpigen_write_debug > Okay. Let me spend some time and come back on this. okay. I will change the function name to acpigen_write_debug_sprintf(). The purpose of this function is to resolve the string that can be finalized in the C side rather than deferring to ACPI so that Concatenate() won't be needed. For the messages that contains the value from the Objects, like Local[n], Arg[n], and Name objects, ACPI Concatenate() will still be needed to construct the final string. ACPI Printf() can be used for this purpose. However, it is a micro and it does not have OP code. acpigen won't be able to expand the macro into proper nested Concatenate() functions and final Debug() based on its 'fmt' string format. We could still use Fprintf() and Printf() in .asl source files for DSDT. The decoded .dsl will have the expanded Concatenate() and Debug() functions instead. -- To view, visit https://review.coreboot.org/c/coreboot/+/73113 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id4a42e5854516a22b7bc4559c2ed08680722c5ba Gerrit-Change-Number: 73113 Gerrit-PatchSet: 2 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Wed, 01 Mar 2023 03:12:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Lance Zhao <lance.zhao(a)gmail.com> Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com> Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2023