Johnny Lin has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/72590 )
Change subject: mb/intel/archercity_crb: select CONSOLE_OVERRIDE_LOGLEVEL
......................................................................
Abandoned
merged into CB:71968 patchset 20
--
To view, visit https://review.coreboot.org/c/coreboot/+/72590
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88822a30b4d642f53d90645fae343dc14fe0a0fc
Gerrit-Change-Number: 72590
Gerrit-PatchSet: 3
Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-Reviewer: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Shelly Chang has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/73376 )
Change subject: soc/intel/xeon_sp/spr: Use common codeflow for MP init in spr
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/73376
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f0ddab09a5d099f8dbd417cbbcd11660aad1644
Gerrit-Change-Number: 73376
Gerrit-PatchSet: 1
Gerrit-Owner: Shelly Chang <Shelly_Chang(a)wiwynn.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Attention is currently required from: Simon Chou, Jonathan Zhang, Paul Menzel, Tim Chu.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71969 )
Change subject: configs/builder: add default config for Intel Archer City CRB
......................................................................
Patch Set 9:
(1 comment)
File configs/builder/config.intel.crb.ac:
https://review.coreboot.org/c/coreboot/+/71969/comment/eac1b7cf_f6c4bb1b
PS2, Line 14: CONFIG_FSP_T_FILE="site-local/archercity/Server_T.fd"
: CONFIG_FSP_M_FILE="site-local/archercity/Server_M.fd"
: CONFIG_FSP_S_FILE="site-local/archercity/Server_S.fd"
: CONFIG_IFD_BIN_PATH="site-local/archercity/descriptor.bin"
: CONFIG_ME_BIN_PATH="site-local/archercity/me.bin"
: CONFIG_CPU_UCODE_BINARIES="site-local/archercity/mbf806f8.mcb"
> Thank you for the answers. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/71969
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15aefc3edb2d22fc00d854850e948fe2048a992e
Gerrit-Change-Number: 71969
Gerrit-PatchSet: 9
Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Christian Walter <christian.walter(a)9elements.com>
Gerrit-CC: Jian-Ming Wang <jianmingW(a)supermicro.com>
Gerrit-CC: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-CC: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: TimLiu-SMCI <timliu(a)supermicro.com.tw>
Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Fri, 03 Mar 2023 08:54:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Simon Chou <simonchou(a)supermicro.com.tw>
Comment-In-Reply-To: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Comment-In-Reply-To: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Christian Walter, Arthur Heymans, Shelly Chang, Tim Chu.
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73376 )
Change subject: soc/intel/xeon_sp/spr: Use common codeflow for MP init in spr
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
Please abandon it, it's merged into CB:72443 "soc/intel/xeon_sp/spr: Add ramstage code" in patchset 8 because it's needed to avoid Jenkin build error
SCONFIG mainboard/intel/archercity_crb/devicetree.cb
line 36: lapic: syntax error
--
To view, visit https://review.coreboot.org/c/coreboot/+/73376
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f0ddab09a5d099f8dbd417cbbcd11660aad1644
Gerrit-Change-Number: 73376
Gerrit-PatchSet: 1
Gerrit-Owner: Shelly Chang <Shelly_Chang(a)wiwynn.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Shelly Chang <Shelly_Chang(a)wiwynn.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Comment-Date: Fri, 03 Mar 2023 08:53:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jonathan Zhang, Johnny Lin, Tim Chu.
Johnny Lin has uploaded a new patch set (#9) to the change originally created by Simon Chou. ( https://review.coreboot.org/c/coreboot/+/71969 )
Change subject: configs/builder: add default config for Intel Archer City CRB
......................................................................
configs/builder: add default config for Intel Archer City CRB
... which is based on Intel Sapphire Rapids Scalable Processor
chipset which was product launched on Jan. 10 2023.
The site-local/* files are Intel binaries that are not published
yet but coreboot build validation system would skip these binaries
when they are in "site-local" directory.
Change-Id: I15aefc3edb2d22fc00d854850e948fe2048a992e
Signed-off-by: Johnny Lin <johnny_lin(a)wiwynn.com>
---
A configs/builder/config.intel.crb.ac
1 file changed, 40 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/71969/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/71969
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15aefc3edb2d22fc00d854850e948fe2048a992e
Gerrit-Change-Number: 71969
Gerrit-PatchSet: 9
Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Reviewer: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Christian Walter <christian.walter(a)9elements.com>
Gerrit-CC: Jian-Ming Wang <jianmingW(a)supermicro.com>
Gerrit-CC: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-CC: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: TimLiu-SMCI <timliu(a)supermicro.com.tw>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Patrick Rudolph, Jonathan Zhang, Simon Chou, Paul Menzel, Arthur Heymans.
Johnny Lin has uploaded a new patch set (#20) to the change originally created by Simon Chou. ( https://review.coreboot.org/c/coreboot/+/71968 )
Change subject: mb/intel: add Archer City CRB support
......................................................................
mb/intel: add Archer City CRB support
Intel Archer City CRB is a dual socket CRB with Intel Sapphire Rapids
Scalable Processor chipset. The chipset also includes Emmitsburg PCH.
Change-Id: Ic02634cd615e2245e394f10aad24b0430cf5cd17
Signed-off-by: Jonathan Zhang <jonzhang(a)meta.com>
Signed-off-by: Johnny Lin <johnny_lin(a)wiwynn.com>
---
A src/mainboard/intel/archercity_crb/Kconfig
A src/mainboard/intel/archercity_crb/Kconfig.name
A src/mainboard/intel/archercity_crb/Makefile.inc
A src/mainboard/intel/archercity_crb/acpi/platform.asl
A src/mainboard/intel/archercity_crb/board.fmd
A src/mainboard/intel/archercity_crb/board_info.txt
A src/mainboard/intel/archercity_crb/bootblock.c
A src/mainboard/intel/archercity_crb/devicetree.cb
A src/mainboard/intel/archercity_crb/dsdt.asl
A src/mainboard/intel/archercity_crb/include/mainboard_ras.h
A src/mainboard/intel/archercity_crb/include/sprsp_ac_iio.h
A src/mainboard/intel/archercity_crb/ramstage.c
A src/mainboard/intel/archercity_crb/romstage.c
13 files changed, 501 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/71968/20
--
To view, visit https://review.coreboot.org/c/coreboot/+/71968
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic02634cd615e2245e394f10aad24b0430cf5cd17
Gerrit-Change-Number: 71968
Gerrit-PatchSet: 20
Gerrit-Owner: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Jingle Hsu <jingle_hsu(a)wiwynn.com>
Gerrit-CC: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-CC: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Shelly Chang <Shelly_Chang(a)wiwynn.com>
Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Attention: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: newpatchset
Attention is currently required from: TimLiu-SMCI, Johnny Lin, Christian Walter, Angel Pons, Jian-Ming Wang, Arthur Heymans, Srinidhi N Kaushik, Shelly Chang.
Johnny Lin has uploaded a new patch set (#8) to the change originally created by Jonathan Zhang. ( https://review.coreboot.org/c/coreboot/+/72443 )
Change subject: soc/intel/xeon_sp/spr: Add ramstage code
......................................................................
soc/intel/xeon_sp/spr: Add ramstage code
Change-Id: I128fdc6e58c49fb5abf911d6ffa91e7411f6d1e2
Signed-off-by: Jonathan Zhang <jonzhang(a)meta.com>
Signed-off-by: Johnny Lin <johnny_lin(a)wiwynn.com>
---
A src/soc/intel/xeon_sp/spr/Makefile.inc
A src/soc/intel/xeon_sp/spr/chip.c
A src/soc/intel/xeon_sp/spr/chip.h
M src/soc/intel/xeon_sp/spr/chipset.cb
A src/soc/intel/xeon_sp/spr/cpu.c
A src/soc/intel/xeon_sp/spr/crashlog.c
A src/soc/intel/xeon_sp/spr/numa.c
A src/soc/intel/xeon_sp/spr/ramstage.c
A src/soc/intel/xeon_sp/spr/reset.c
A src/soc/intel/xeon_sp/spr/xhci.c
10 files changed, 872 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/72443/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/72443
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I128fdc6e58c49fb5abf911d6ffa91e7411f6d1e2
Gerrit-Change-Number: 72443
Gerrit-PatchSet: 8
Gerrit-Owner: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Jian-Ming Wang <jianmingW(a)supermicro.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Simon Chou <simonchou(a)supermicro.com.tw>
Gerrit-Reviewer: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Reviewer: TimLiu-SMCI <timliu(a)supermicro.com.tw>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Shuming Chu (Shuming) <s1218944(a)gmail.com>
Gerrit-CC: Tim Chu <Tim.Chu(a)quantatw.com>
Gerrit-Attention: TimLiu-SMCI <timliu(a)supermicro.com.tw>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Jian-Ming Wang <jianmingW(a)supermicro.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Srinidhi N Kaushik <srinidhi.n.kaushik(a)intel.com>
Gerrit-Attention: Shelly Chang <Shelly_Chang(a)wiwynn.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Frank Wu, Jason Glenesk, Raul Rangel, Jason Nien, EricKY Cheng, Matt DeVillier, Isaac Lee, Martin Roth, Tim Van Patten, Fred Reitberger, Felix Held.
Chris Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73124 )
Change subject: soc/amd/mendocino: Remove the SPL DPTC parameter
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/skyrim/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/73124/comment/7dd00919_cf4796a9
PS6, Line 263: # Remove the sustained_power_limit_mW when STT is enabled
: register "sustained_power_limit_mW" = "15000"
> Should the sustained_power_limit_mW move to skyrim/overridetree.cb from here? […]
It may need to submit another CL if we want to move 'sustained_power_limit_mW' from the baseboard to each variant. This is because there are still other variants that follow the baseboard and STT has not been enabled yet. If we move 'sustained_power_limit_mW' to 'skyrim/overridetree', it would mean that we need to apply the same value to each variant, which would be duplicated."
--
To view, visit https://review.coreboot.org/c/coreboot/+/73124
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e6dad7d24883f8aadce83ebac401ecd4137d61a
Gerrit-Change-Number: 73124
Gerrit-PatchSet: 6
Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Isaac Lee <isaaclee(a)google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Tim Van Patten <timvp(a)google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 03 Mar 2023 08:20:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-MessageType: comment