Attention is currently required from: Frank Wu, Jason Glenesk, Raul Rangel, Jason Nien, EricKY Cheng, Matt DeVillier, Isaac Lee, Chris Wang, Martin Roth, Fred Reitberger, Felix Held.
Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73124 )
Change subject: soc/amd/mendocino: Remove the SPL DPTC parameter
......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/skyrim/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/73124/comment/5873ef2a_b6e24e3f
PS6, Line 263: # Remove the sustained_power_limit_mW when STT is enabled
: register "sustained_power_limit_mW" = "15000"
> It may need to submit another CL if we want to move 'sustained_power_limit_mW' from the baseboard to […]
I'm leaning towards Frank's suggestion, since the current comment is not entirely accurate. STT is enabled for Frostflow and Whiterun, but this setting will still be applied (although only via the FSP during boot), so it can't/won't be removed.
While `sustained_power_limit_mW` would be duplicated for the boards that need it, we don't want it configured for every board. The current split is:
STT Enabled:
* Frostflow
* Whiterun
STT Disabled:
* Skyrim
* Markarth
* Crystaldrift
It does look better to set the value in the each `overridetree.cb` that wants it (STT disabled), so it can be removed if/when STT is enabled for that board. Additionally, it prevents `sustained_power_limit_mW` from being set for boards that do have STT enabled.
--
To view, visit https://review.coreboot.org/c/coreboot/+/73124
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e6dad7d24883f8aadce83ebac401ecd4137d61a
Gerrit-Change-Number: 73124
Gerrit-PatchSet: 6
Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com>
Gerrit-Attention: EricKY Cheng <ericky_cheng(a)compal.corp-partner.google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Isaac Lee <isaaclee(a)google.com>
Gerrit-Attention: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 03 Mar 2023 16:28:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Comment-In-Reply-To: Chris Wang <chris.wang(a)amd.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Angel Pons, Arthur Heymans, Keith Hui, Elyes Haouas.
Hello Felix Singer, build bot (Jenkins), Angel Pons, Arthur Heymans,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61540
to look at the new patch set (#7).
Change subject: mb/asus/p8x7x-series: Refactor mainboard_get_spd()
......................................................................
mb/asus/p8x7x-series: Refactor mainboard_get_spd()
This mainboard-specific hook of Sandy/Ivy native RAM init sequence,
likely generated by autoport, is the same for all variants.
Consolidate them into a separate unit at the baseboard level.
Also drop the matching header from variants that do not also support
MRC raminit.
Build tested on all variants.
Change-Id: I3b9c616a6c722e1f0fc124ced225efdcadb46b25
Signed-off-by: Keith Hui <buurin(a)gmail.com>
---
M src/mainboard/asus/p8x7x-series/Makefile.inc
A src/mainboard/asus/p8x7x-series/early_init.c
M src/mainboard/asus/p8x7x-series/variants/p8c_ws/early_init.c
M src/mainboard/asus/p8x7x-series/variants/p8h77-v/early_init.c
M src/mainboard/asus/p8x7x-series/variants/p8z77-m/early_init.c
M src/mainboard/asus/p8x7x-series/variants/p8z77-m_pro/early_init.c
M src/mainboard/asus/p8x7x-series/variants/p8z77-v/early_init.c
M src/mainboard/asus/p8x7x-series/variants/p8z77-v_lx2/early_init.c
8 files changed, 31 insertions(+), 52 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/61540/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/61540
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b9c616a6c722e1f0fc124ced225efdcadb46b25
Gerrit-Change-Number: 61540
Gerrit-PatchSet: 7
Gerrit-Owner: Keith Hui <buurin(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Keith Hui <buurin(a)gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Glenesk, ritul guru, Matt DeVillier, Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73372 )
Change subject: soc/amd/phoenix: Update phoenix2 VGA BIOS ID
......................................................................
Patch Set 1:
(1 comment)
File src/soc/amd/phoenix/Kconfig:
https://review.coreboot.org/c/coreboot/+/73372/comment/fb929e63_a2cbdbac
PS1, Line 247: 1002,15c8
> if choose VGA_BIOS_ID=1002,1205 then getting below error: […]
it's expected that the first attempt here will fail:
rom_header = cbfs_boot_map_optionrom(dev->vendor, dev->device);
then the remapping function map_oprom_vendev gets called and returns the vbios file that we'll need to retrieve. due to the first cbfs_boot_map_optionrom call to expectedly fail, rom_header will be NULL and due to that this code will be run
rom_header = cbfs_boot_map_optionrom(mapped_vendev >> 16, mapped_vendev & 0xffff);
this is how the remapping works.
When using 1002,15c8 as VGA_BIOS_ID, things will end up working for the 1002,15c8 id, since map_oprom_vendev will be called unconditionally and due to it remapping the ID, the pci id mismatch check later on will be skipped, but it's not the correct solution. in the case of the 1002,1205 device, having VGA_BIOS_ID set to 1002,15c8 won't work as expected. in that case, cbfs_boot_map_optionrom(dev->vendor, dev->device) would return null and map_oprom_vendev expectedly won't do any remapping, so the cbfs_boot_map_optionrom(mapped_vendev >> 16, mapped_vendev & 0xffff) call will also return null
--
To view, visit https://review.coreboot.org/c/coreboot/+/73372
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie035baf7a0908e1e6382c1810926647bf7182f6c
Gerrit-Change-Number: 73372
Gerrit-PatchSet: 1
Gerrit-Owner: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Comment-Date: Fri, 03 Mar 2023 14:55:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ritul guru <ritul.bits(a)gmail.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Nicholas Chin.
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59704 )
Change subject: mb/dell: Add Latitude E6400
......................................................................
Patch Set 12:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59704/comment/c63308c4_e8d34540
PS12, Line 32: SD card slot
Is this under the traditional PCI bus (1e.0)? If so, the effective content of acpi/ich9_pci_irqs.asl (What the "Method (_PRT)" for "Device (PCIB)" does) had better be collected from the vendor DSDT, as Thinkpad T400 does not have any traditional PCI device.
Since this commit has been merged, the improvement of acpi/ich9_pci_irqs.asl should be performed in a new commit.
--
To view, visit https://review.coreboot.org/c/coreboot/+/59704
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I516ebbf4390a3f6d242050da8d35dc267b8b3a28
Gerrit-Change-Number: 59704
Gerrit-PatchSet: 12
Gerrit-Owner: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com>
Gerrit-Comment-Date: Fri, 03 Mar 2023 13:49:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Michał Żygowski, Subrata Banik.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72069 )
Change subject: soc/intel/alderlake: Select SOC_INTEL_COMMON_BLOCK_VTD
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/72069
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I226305fa547e9d9ea541a5806d543aa358bce28d
Gerrit-Change-Number: 72069
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Fri, 03 Mar 2023 13:43:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Michał Żygowski, Subrata Banik, Tim Wawrzynczak, Angel Pons.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68556 )
Change subject: soc/intel/alderlake/hsphy.c: Handle case with DMA protection
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68556
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I88edda26a027b557eeaba80426a5b7be7199507d
Gerrit-Change-Number: 68556
Gerrit-PatchSet: 8
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 03 Mar 2023 13:43:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Michał Żygowski, Subrata Banik.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68450 )
Change subject: soc/intel/alderlake: Hook the VT-d DMA protection option
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68450
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iecaa3d04f1447b7e73507ca57a0d23d42e24d663
Gerrit-Change-Number: 68450
Gerrit-PatchSet: 9
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Comment-Date: Fri, 03 Mar 2023 13:42:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Michał Żygowski, Angel Pons.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68449 )
Change subject: intelblocks/vtd: Add VT-d block with DMA protection API
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/68449
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7edf982457c1139624e5cd383788eda41d6a948
Gerrit-Change-Number: 68449
Gerrit-PatchSet: 9
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Elias Souza <eliascontato(a)protonmail.com>
Gerrit-Reviewer: Michał Kopeć <michal.kopec(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-CC: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 03 Mar 2023 13:40:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment