Attention is currently required from: Tarun Tuli, Sridhar Siricilla.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72871 )
Change subject: soc/intel/meteorlake: Update soc_intel_meteorlake_config structure
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72871/comment/f0d6d2a7_aac4b986
PS1, Line 7: soc/intel/meteorlake: Update soc_intel_meteorlake_config structure
Please be more specific. Maybe:
> Remove unsupported hybrid_storage_mode config
https://review.coreboot.org/c/coreboot/+/72871/comment/a7a46418_8ff735b0
PS1, Line 10: since hybrid storage is no longer
: supported on Meteor Lake platform
What is the source for that statement?
--
To view, visit https://review.coreboot.org/c/coreboot/+/72871
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I40ec3775b827ab6e1ebd4778c6c8e13eac1944e5
Gerrit-Change-Number: 72871
Gerrit-PatchSet: 1
Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Comment-Date: Tue, 07 Feb 2023 12:41:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin.
Liju-Clr Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72748 )
Change subject: mb/google/geralt: Add support for VM18 in regulator.c
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/72748/comment/849027cd_c4d0ebc4
PS4, Line 7: API
> There's no new API added. How about `Add support for VM18 in regulator. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/72748
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13bafbe10a18a18e253575fd107c9b415f28ef01
Gerrit-Change-Number: 72748
Gerrit-PatchSet: 5
Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Comment-Date: Tue, 07 Feb 2023 12:36:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Yidi Lin.
Hello Hung-Te Lin, build bot (Jenkins), Rex-BC Chen, Yu-Ping Wu, Yidi Lin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/72749
to look at the new patch set (#7).
Change subject: mb/google/geralt: Add power-on sequence for BOE_TV110C9M_LL0
......................................................................
mb/google/geralt: Add power-on sequence for BOE_TV110C9M_LL0
For Geralt, we use BOE_TV110C9M_LL0 as MIPI firmware display, so add the
power-on sequence for BOE_TV110C9M_LL0.
BUG=b:244208960
TEST=test firmware display pass for BOE_TV110C9M_LL0 on Geralt.
Change-Id: I3ef0b2e26d8cc0dc35c2985363ee4c3557dac8a9
Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Signed-off-by: Liju-Clr Chen <liju-clr.chen(a)mediatek.com>
---
M src/mainboard/google/geralt/panel.c
M src/mainboard/google/geralt/panel.h
M src/mainboard/google/geralt/panel_geralt.c
M src/soc/mediatek/mt8188/Makefile.inc
4 files changed, 75 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/72749/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/72749
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3ef0b2e26d8cc0dc35c2985363ee4c3557dac8a9
Gerrit-Change-Number: 72749
Gerrit-PatchSet: 7
Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Liju-Clr Chen, Paul Menzel, Yu-Ping Wu, Yidi Lin.
Hello Hung-Te Lin, build bot (Jenkins), Rex-BC Chen, Yidi Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/72839
to look at the new patch set (#4).
Change subject: mb/google/geralt: Init MT6359P only once in ramstage
......................................................................
mb/google/geralt: Init MT6359P only once in ramstage
The regulator APIs are called by firmware display and SD card.
mt6359p_init() will call pmic_efuse_setting(), so pmic_efuse_setting()
will be called twice. 11 msecs will be increased on booting time.
Therefore, move mt6359p_init() to mainboard.c to initialize mt6359p only
once in ramstage.
BUG=b:244208960
TEST=test firmware display pass for BOE_TV110C9M_LL0 on Geralt.
Change-Id: I29498d186ba5665ae20e84985174fc10f8d4accd
Signed-off-by: Liju-Clr Chen <liju-clr.chen(a)mediatek.com>
---
M src/mainboard/google/geralt/mainboard.c
M src/soc/mediatek/mt8188/msdc.c
2 files changed, 22 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/72839/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/72839
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29498d186ba5665ae20e84985174fc10f8d4accd
Gerrit-Change-Number: 72839
Gerrit-PatchSet: 4
Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Liju-Clr Chen.
Hello Hung-Te Lin, build bot (Jenkins), Rex-BC Chen, Yu-Ping Wu, Yidi Lin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/72748
to look at the new patch set (#5).
Change subject: mb/google/geralt: Add support for VM18 in regulator.c
......................................................................
mb/google/geralt: Add support for VM18 in regulator.c
Add regulator VM18 support to supply power for BOE_TV110C9M_LL0.
BUG=b:244208960
TEST=test firmware display pass for BOE_TV110C9M_LL0 on Geralt.
Change-Id: I13bafbe10a18a18e253575fd107c9b415f28ef01
Signed-off-by: Sen Chu <sen.chu(a)mediatek.corp-partner.google.com>
Signed-off-by: Liju-Clr Chen <liju-clr.chen(a)mediatek.com>
---
M src/mainboard/google/geralt/regulator.c
1 file changed, 20 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/72748/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/72748
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13bafbe10a18a18e253575fd107c9b415f28ef01
Gerrit-Change-Number: 72748
Gerrit-PatchSet: 5
Gerrit-Owner: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Liju-Clr Chen <liju-clr.chen(a)mediatek.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Held.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/72757
to look at the new patch set (#5).
Change subject: acpi/acpigen.h: Drop deprecated ACPI OP codes
......................................................................
acpi/acpigen.h: Drop deprecated ACPI OP codes
Clean up the values according to ACPI specs:
https://uefi.org/specs/ACPI/6.5/20_AML_Specification.html?highlight=aml%20b…
Change-Id: I51e7f8dc6c0bfef0816ab4da6d96cb0fac873ee8
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/include/acpi/acpigen.h
1 file changed, 14 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/72757/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/72757
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51e7f8dc6c0bfef0816ab4da6d96cb0fac873ee8
Gerrit-Change-Number: 72757
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset