coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[S] Change in coreboot[main]: acpi/acpi_gic: Add GIC ITS subtable
by Nico Huber (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Angel Pons, Cliff Huang, Lance Zhao, Maximilian Brune, Naresh Solanki, Patrick Rudolph, Paul Menzel, Tim Wawrzynczak. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78115?usp=email ) Change subject: acpi/acpi_gic: Add GIC ITS subtable ...................................................................... Patch Set 4: (1 comment) File src/acpi/acpi_gic.c: https://review.coreboot.org/c/coreboot/+/78115/comment/cde24e15_3904776f : PS4, Line 85: } Is this weak implementation necessary? The other platform_*() functions above don't have one. -- To view, visit https://review.coreboot.org/c/coreboot/+/78115?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1bcb3ad24de64cbba8aeef7ba7254d3157e0dc43 Gerrit-Change-Number: 78115 Gerrit-PatchSet: 4 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Comment-Date: Tue, 21 Nov 2023 15:16:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/intel/mtlrvp: define a new config for Chrome EC.
by Deepti Deshatty (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Balaji Manigandan, Krishna P Bhat D, Paul Menzel. Deepti Deshatty has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79211?usp=email ) Change subject: mb/intel/mtlrvp: define a new config for Chrome EC. ...................................................................... Patch Set 3: (1 comment) Commit Message: PS2: > Please see similar comments as in Change-Id I788dbeaad05e5d6904fb2c7c681a0bf653dc7d84. Acknowledged -- To view, visit https://review.coreboot.org/c/coreboot/+/79211?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0b85cc48d5cefadb52edbb27bf6cf370b27c395f Gerrit-Change-Number: 79211 Gerrit-PatchSet: 3 Gerrit-Owner: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Comment-Date: Tue, 21 Nov 2023 15:14:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/intel/mtlrvp: add 512KB SI_EC FMAP region
by Deepti Deshatty (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Balaji Manigandan, Deepti Deshatty, Krishna P Bhat D, Paul Menzel. Deepti Deshatty has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79209?usp=email ) Change subject: mb/intel/mtlrvp: add 512KB SI_EC FMAP region ...................................................................... Patch Set 5: (10 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79209/comment/270f7478_2cecf17a : PS4, Line 7: add SI_EC region in flash map > Add 512 kB SI_EC FMAP region fo MEC1723 change is applicable for all MTLRVP variants, hence removing MEC1723 https://review.coreboot.org/c/coreboot/+/79209/comment/02cd2fe6_9aa2e593 : PS4, Line 7: mtlrvp > Please extend the prefix: mb/intel/mtlrvp. Done https://review.coreboot.org/c/coreboot/+/79209/comment/94d769e9_d26fff89 : PS4, Line 9: booted with > “booted with”? What do you mean? i have updated the commit message to provide clear details. https://review.coreboot.org/c/coreboot/+/79209/comment/96792905_418058e4 : PS4, Line 9: do > does Acknowledged https://review.coreboot.org/c/coreboot/+/79209/comment/610d70d0_9b38da27 : PS4, Line 9: microchip > Microship Microship is right https://review.coreboot.org/c/coreboot/+/79209/comment/3c90fbbf_a7671cae : PS4, Line 9: MTLRVP > Use “MTLRVP for Chrome OS”? Acknowledged https://review.coreboot.org/c/coreboot/+/79209/comment/890f7f27_851caf37 : PS4, Line 11: Using MEC1723 for chrome helps in RVP BOM convergence. > Sorry, I do not understand what you mean. I have updated the commit message, kindly check. https://review.coreboot.org/c/coreboot/+/79209/comment/00c6c75e_1d5f1ed7 : PS4, Line 16: This patch adds SI_EC region similar to windows. > Please add a blank line above to separate paragraphs. Done https://review.coreboot.org/c/coreboot/+/79209/comment/b01a4f3b_c9113c74 : PS4, Line 9: MTLRVP booted with microchip EC1723 which do not have an : internal flash memory similar to the windows RVP designs. : Using MEC1723 for chrome helps in RVP BOM convergence. : : EC, AP shares the same external SPI flash. EC ROM will : download the EC firmware from external SPI to internal SRAM : for execution. : This patch adds SI_EC region similar to windows. > Please reflow to use all of the allowed text width of 72 characters per line. Done https://review.coreboot.org/c/coreboot/+/79209/comment/e2bd99aa_6d65a879 : PS4, Line 16: This patch adds SI_EC region similar to windows. > “This patch adds” is redundant in a commit message. Maybe use imperative mood: […] No, Coreboot firmware is exclusive to Chrome OS. In this context, Windows designs employ embedded controllers without built-in flash memory. -- To view, visit https://review.coreboot.org/c/coreboot/+/79209?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I788dbeaad05e5d6904fb2c7c681a0bf653dc7d84 Gerrit-Change-Number: 79209 Gerrit-PatchSet: 5 Gerrit-Owner: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Deepti Deshatty <deepti.deshatty(a)intel.corp-partner.google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.corp-partner.google.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Comment-Date: Tue, 21 Nov 2023 15:13:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/intel/mtlrvp: define a new config for Chrome EC.
by Deepti Deshatty (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Balaji Manigandan, Deepti Deshatty, Deepti Deshatty, Krishna P Bhat D. Hello Balaji Manigandan, Deepti Deshatty, Krishna P Bhat D, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79211?usp=email to look at the new patch set (#3). Change subject: mb/intel/mtlrvp: define a new config for Chrome EC. ...................................................................... mb/intel/mtlrvp: define a new config for Chrome EC. Introduce new config MTL_CHROME_EC_SHARED_SPI, tailored for Chrome ECs utilizing an external shared SPI flash. BUG=b:289783489 TEST=emerge-rex coreboot chromeos-bootimage is successful Change-Id: I0b85cc48d5cefadb52edbb27bf6cf370b27c395f Signed-off-by: Deepti Deshatty <deepti.deshatty(a)intel.corp-partner.google.com> --- M src/mainboard/intel/mtlrvp/Kconfig 1 file changed, 11 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/79211/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/79211?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0b85cc48d5cefadb52edbb27bf6cf370b27c395f Gerrit-Change-Number: 79211 Gerrit-PatchSet: 3 Gerrit-Owner: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Deepti Deshatty <deepti.deshatty(a)intel.corp-partner.google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.corp-partner.google.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/intel/mtlrvp: add 512KB SI_EC FMAP region
by Deepti Deshatty (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Balaji Manigandan, Deepti Deshatty, Deepti Deshatty, Krishna P Bhat D. Hello Balaji Manigandan, Deepti Deshatty, Krishna P Bhat D, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79209?usp=email to look at the new patch set (#5). Change subject: mb/intel/mtlrvp: add 512KB SI_EC FMAP region ...................................................................... mb/intel/mtlrvp: add 512KB SI_EC FMAP region This patch introduces the 512KB SI_EC FMAP region for storing the EC firmware, a necessary addition to support EC chips without internal flash memory. As a testing platform, the MTLRVP Chrome SKU is utilized in conjunction with the Microchip EC1723, and the changes are verified. BUG=b:289783489 TEST=build "emerge-rex coreboot chromeos-bootimage" is successful Change-Id: I788dbeaad05e5d6904fb2c7c681a0bf653dc7d84 Signed-off-by: Deepti Deshatty <deepti.deshatty(a)intel.corp-partner.google.com> --- M src/mainboard/intel/mtlrvp/chromeos.fmd 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/79209/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/79209?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I788dbeaad05e5d6904fb2c7c681a0bf653dc7d84 Gerrit-Change-Number: 79209 Gerrit-PatchSet: 5 Gerrit-Owner: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Deepti Deshatty <deepti.deshatty(a)intel.corp-partner.google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.corp-partner.google.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: acpi: Enable 64bit ECAM resource
by Angel Pons (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Cliff Huang, David Milosevic, Lance Zhao, Maximilian Brune, Naresh Solanki, Nico Huber, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79096?usp=email ) Change subject: acpi: Enable 64bit ECAM resource ...................................................................... Patch Set 1: (1 comment) File src/acpi/dsdt_top.asl: https://review.coreboot.org/c/coreboot/+/79096/comment/5c4688ff_cc22d526 : PS1, Line 64: ResourceProducer If you look at the ACPI spec, it *seems* to suggest that "Producer" is the right thing: https://uefi.org/htmlspecs/ACPI_Spec_6_4_html/19_ASL_Reference/ACPI_Source_… > ResourceUsage specifies whether the Memory range is consumed by this device (ResourceConsumer) or passed on to child devices (ResourceProducer). If nothing is specified, then ResourceConsumer is assumed. But the Linux doc linked in the comment (https://www.kernel.org/doc/Documentation/PCI/acpi-info.rst) says the following: > ACPI defines a Consumer/Producer bit to distinguish the bridge registers ("Consumer") from the bridge apertures ("Producer") [4, 5], but early BIOSes didn't use that bit correctly. The result is that the current ACPI spec defines Consumer/Producer only for the Extended Address Space descriptors; the bit should be ignored in the older QWord/DWord/Word Address Space descriptors. Consequently, OSes have to assume all QWord/DWord/Word descriptors are windows. Which suggests that this distinction is irrelevant, and: > PNP0C02 "motherboard" devices are basically a catch-all. There's no programming model for them other than "don't use these resources for anything else." So a PNP0C02 _CRS should claim any address space that is (1) not claimed by _CRS under any other device object in the ACPI namespace and (2) should not be assigned by the OS to something else. Which says this is just a catch-all in the form of a motherboard resource. TL;DR I think ResourceConsumer may be more accurate. -- To view, visit https://review.coreboot.org/c/coreboot/+/79096?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idb049d848f2311e27df5279a10c33f9fab259c08 Gerrit-Change-Number: 79096 Gerrit-PatchSet: 1 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Comment-Date: Tue, 21 Nov 2023 14:57:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: arch/x86/mmu: Port armv8 MMU to x86_64
by Benjamin Doron (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Patrick Rudolph. Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30119?usp=email ) Change subject: arch/x86/mmu: Port armv8 MMU to x86_64 ...................................................................... Patch Set 18: (2 comments) Patchset: PS18: I've updated this + made the tree use dynamic page tables, when there are and have support for SMM to add in a follow-up. I'll push those as follow-ups after I do some debugging: QEMU Q35 seems to overflow SMRAM, it seems to triple fault when jumping to the entrypoint which is outside SMRAM and therefore, unmapped File src/arch/x86/mmu.c: https://review.coreboot.org/c/coreboot/+/30119/comment/bf1c8020_1600e1f8 : PS16, Line 335: (uint64_t *)cbmem_add(CBMEM_ID_PAGE, pages * 4 * KiB); > > It might be even better to have page tables in heap. […] romstage generates only if necessary. ramstage's tables are the primary ones used. Even assuming that SMM can read CBMEM (I looked briefly and I couldn't see it compiled in), we've discussed this off Gerrit and I agree it's not safe. Allowing ring-0 to control SMM's memory access doesn't sound good to me. Unless I misunderstood, I believe we've decided SMM needs different page tables? -- To view, visit https://review.coreboot.org/c/coreboot/+/30119?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6e8b46e65925823a84b8ccd647c7d6848aa20992 Gerrit-Change-Number: 30119 Gerrit-PatchSet: 18 Gerrit-Owner: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Comment-Date: Tue, 21 Nov 2023 14:49:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Rudolph <patrick.rudolph(a)9elements.com> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: acpi: Enable 64bit ECAM resource
by Nico Huber (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Angel Pons, Cliff Huang, David Milosevic, Lance Zhao, Maximilian Brune, Naresh Solanki, Patrick Rudolph. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79096?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: acpi: Enable 64bit ECAM resource ...................................................................... Patch Set 1: (1 comment) File src/acpi/dsdt_top.asl: https://review.coreboot.org/c/coreboot/+/79096/comment/15e680da_fedd1eb5 : PS1, Line 64: ResourceProducer Is this correct? Comment and commit message say 'Consumption'. -- To view, visit https://review.coreboot.org/c/coreboot/+/79096?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Idb049d848f2311e27df5279a10c33f9fab259c08 Gerrit-Change-Number: 79096 Gerrit-PatchSet: 1 Gerrit-Owner: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com> Gerrit-Attention: Naresh Solanki <naresh.solanki(a)9elements.com> Gerrit-Comment-Date: Tue, 21 Nov 2023 14:33:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: acpi.c: Fix generating pointer to cb_tables located >4G
by Nico Huber (Code Review) 21 Nov '23

21 Nov '23

Attention is currently required from: Angel Pons, Arthur Heymans, Benjamin Doron, Cliff Huang, Eric Lai, Felix Held, Lance Zhao, Lean Sheng Tan, Maximilian Brune, Tim Wawrzynczak. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76181?usp=email ) Change subject: acpi.c: Fix generating pointer to cb_tables located >4G ...................................................................... Patch Set 7: (2 comments) File src/acpi/acpi.c: https://review.coreboot.org/c/coreboot/+/76181/comment/418fcebd_0227e18c : PS7, Line 301: base + size `base + size - 1` because UINT32_MAX is also `4G - 1`. https://review.coreboot.org/c/coreboot/+/76181/comment/70bb9286_3771461a : PS7, Line 304: producer Shouldn't this be a 'consumer'? AIUI, `ResourceProducer` is meant for parent devices that make a resource range available to their children. -- To view, visit https://review.coreboot.org/c/coreboot/+/76181?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1bc553b18d08cee502b765166227810f8e619631 Gerrit-Change-Number: 76181 Gerrit-PatchSet: 7 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Benjamin Doron <benjamin.doron00(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 21 Nov 2023 14:31:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Update fsp submodule to upstream master
by Felix Singer (Code Review) 21 Nov '23

21 Nov '23

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79004?usp=email ) Change subject: Update fsp submodule to upstream master ...................................................................... Update fsp submodule to upstream master Updating from commit id 481ea7c: 2023-09-19 15:21:38 -0700 - (Move to RaptorLakeFspBinPkg.dec) to commit id bb12f17: 2023-10-31 16:00:43 +0800 - (Elkhart Lake MR7 FSP) This brings in 5 new commits: bb12f17 Elkhart Lake MR7 FSP 0d6bf96 Elkhart Lake MR7 FSP 88845b6 IoT ADL-S MR6 (4115_09) FSP 8c99965 IoT ADL-P MR5 (4115_09) FSP 6c549ee IoT ADL-N MR2 (4282_00) Change-Id: I9fe65d830061c93ceac549dc7f41e7a98646a0a3 Signed-off-by: Martin Roth <gaumless(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79004 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Lean Sheng Tan <sheng.tan(a)9elements.com> Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> --- M 3rdparty/fsp 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve Lean Sheng Tan: Looks good to me, approved build bot (Jenkins): Verified diff --git a/3rdparty/fsp b/3rdparty/fsp index 481ea7c..bb12f17 160000 --- a/3rdparty/fsp +++ b/3rdparty/fsp @@ -1 +1 @@ -Subproject commit 481ea7cf0bae0107c3e14aa746e52657647142f3 +Subproject commit bb12f17b07700a40c0033da345eae0c1cd487b73 -- To view, visit https://review.coreboot.org/c/coreboot/+/79004?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9fe65d830061c93ceac549dc7f41e7a98646a0a3 Gerrit-Change-Number: 79004 Gerrit-PatchSet: 5 Gerrit-Owner: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023