coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[S] Change in coreboot[main]: mb/google/corsola: Use fw_config to differentiate audio amps
by Ruihai Zhou (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Hung-Te Lin, Xuxin Xiong, Yang Wu, Yidi Lin, Yu-Ping Wu. Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79309?usp=email ) Change subject: mb/google/corsola: Use fw_config to differentiate audio amps ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/79309?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5f887f5e0d16dc14039fb12b636257d01339b2de Gerrit-Change-Number: 79309 Gerrit-PatchSet: 1 Gerrit-Owner: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Ruihai Zhou <zhouruihai(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yang Wu <wuyang5(a)huaqin.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Wed, 29 Nov 2023 00:51:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: arch/x86/Makefile.inc: Do not pass CPPFLAGS to linker
by Julius Werner (Code Review) 29 Nov '23

29 Nov '23

Julius Werner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79218?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: arch/x86/Makefile.inc: Do not pass CPPFLAGS to linker ...................................................................... arch/x86/Makefile.inc: Do not pass CPPFLAGS to linker We seem to be passing CPPFLAGS to linker in x86 arch ramstage. This is superflous as these are only meant to be compiler flags and should not be passed to the linker. Change-Id: Ia3cd51be6be252aa796191cf0d2cd91d393c8878 Signed-off-by: Srinivas Hegde <srinivashegde(a)google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/79218 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Julius Werner <jwerner(a)chromium.org> Reviewed-by: Jérémy Compostella <jeremy.compostella(a)intel.com> --- M src/arch/x86/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Jérémy Compostella: Looks good to me, but someone else must approve Julius Werner: Looks good to me, approved diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc index 75b9d3d..62294a6 100644 --- a/src/arch/x86/Makefile.inc +++ b/src/arch/x86/Makefile.inc @@ -317,7 +317,7 @@ $(objcbfs)/ramstage.debug: $(objgenerated)/ramstage.o $(call src-to-obj,ramstage,$(CONFIG_MEMLAYOUT_LD_FILE)) @printf " CC $(subst $(obj)/,,$(@))\n" - $(LD_ramstage) $(CPPFLAGS) $(LDFLAGS_ramstage) -o $@ -L$(obj) $< -T $(call src-to-obj,ramstage,$(CONFIG_MEMLAYOUT_LD_FILE)) + $(LD_ramstage) $(LDFLAGS_ramstage) -o $@ -L$(obj) $< -T $(call src-to-obj,ramstage,$(CONFIG_MEMLAYOUT_LD_FILE)) $(objgenerated)/ramstage.o: $$(ramstage-objs) $(COMPILER_RT_ramstage) $$(ramstage-libs) @printf " CC $(subst $(obj)/,,$(@))\n" -- To view, visit https://review.coreboot.org/c/coreboot/+/79218?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia3cd51be6be252aa796191cf0d2cd91d393c8878 Gerrit-Change-Number: 79218 Gerrit-PatchSet: 6 Gerrit-Owner: Srinivas Hegde <srinivashegde(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: mb/google/rex/var/deku: Enable LAN0, LAN1
by Eran Mitrani (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Subrata Banik. Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79292?usp=email ) Change subject: mb/google/rex/var/deku: Enable LAN0, LAN1 ...................................................................... Patch Set 4: (1 comment) This change is ready for review. Patchset: PS1: > you can take a look into CL: https://review.coreboot. […] I rebased this CL on the previous gpio.c CL. Since KConfig, and devicetree are set for the baseboard ovis, The only difference I see is that for Ovis we have: PAD_CFG_GPI_SCI_LOW(GPP_D18, NONE, DEEP, EDGE_SINGLE), While for Deku I have PAD_CFG_GPI_IRQ_WAKE(GPP_D01, NONE, PLTRST, LEVEL, INVERT), PAD_CFG_GPI_IRQ_WAKE(GPP_E04, NONE, PLTRST, LEVEL, INVERT), So if I understand you correctly, it should only be routed to SCI. I corrected that. (Ovis is missing the other LAN, so it would need to be corrected in another CL for Ovis) -- To view, visit https://review.coreboot.org/c/coreboot/+/79292?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8980dabc7f9fc731a2b60c599e1e48c9b11dabb4 Gerrit-Change-Number: 79292 Gerrit-PatchSet: 4 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Wed, 29 Nov 2023 00:26:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8188: Support loading OP-TEE via an SMC
by Yidi Lin (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Hung-Te Lin, Kiwi Liu, Paul Menzel, Yu-Ping Wu. Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78801?usp=email ) Change subject: soc/mediatek/mt8188: Support loading OP-TEE via an SMC ...................................................................... Patch Set 16: (1 comment) File src/soc/mediatek/mt8188/Makefile.inc: https://review.coreboot.org/c/coreboot/+/78801/comment/4a2227ed_a2fa2d01 : PS15, Line 62: BL31_MAKEARGS > Done Please update the codebase and rebase the patch after CB:79333 is merged. -- To view, visit https://review.coreboot.org/c/coreboot/+/78801?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic38c8beb59c090ae56c5be6821dd8625435609e9 Gerrit-Change-Number: 78801 Gerrit-PatchSet: 16 Gerrit-Owner: Kiwi Liu <kiwi.liu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Kiwi Liu <kiwi.liu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: jason-ch chen <Jason-ch.Chen(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kiwi Liu <kiwi.liu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 29 Nov 2023 00:15:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kiwi Liu <kiwi.liu(a)mediatek.corp-partner.google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: Update arm-trusted-firmware submodule to upstream master
by Yidi Lin (Code Review) 29 Nov '23

29 Nov '23

Yidi Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/79333?usp=email ) Change subject: Update arm-trusted-firmware submodule to upstream master ...................................................................... Update arm-trusted-firmware submodule to upstream master Updating from commit id 88b2d8134: 2023-09-06 11:26:32 +0200 - (Merge "fix(scmi): add parameter for plat_scmi_clock_rates_array" into integration) to commit id e7486343d: 2023-11-28 22:48:16 +0100 - (Merge changes from topic "xlnx_fitimage_check" into integration) This brings in 451 new commits. Change-Id: I75a89c6f0d60ccccd8ff42954416666dabef717f Signed-off-by: Yidi Lin <yidilin(a)chromium.org> --- M 3rdparty/arm-trusted-firmware 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/79333/1 diff --git a/3rdparty/arm-trusted-firmware b/3rdparty/arm-trusted-firmware index 88b2d81..e748634 160000 --- a/3rdparty/arm-trusted-firmware +++ b/3rdparty/arm-trusted-firmware @@ -1 +1 @@ -Subproject commit 88b2d81345dfd84902aae586a743d00ac5df2f48 +Subproject commit e7486343d46a0d60047233adfd8a64436bbac1fd -- To view, visit https://review.coreboot.org/c/coreboot/+/79333?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I75a89c6f0d60ccccd8ff42954416666dabef717f Gerrit-Change-Number: 79333 Gerrit-PatchSet: 1 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: soc/amd/genoa: Implement romstage
by Felix Held (Code Review) 28 Nov '23

28 Nov '23

Attention is currently required from: Arthur Heymans, Martin L Roth, Varshit Pandya. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76514?usp=email ) Change subject: soc/amd/genoa: Implement romstage ...................................................................... Patch Set 6: Code-Review+1 (1 comment) File src/soc/amd/genoa/romstage.c: https://review.coreboot.org/c/coreboot/+/76514/comment/a1dd7136_ef73fbeb : PS6, Line 3: #include <cbmem.h> might be good to sort the include -- To view, visit https://review.coreboot.org/c/coreboot/+/76514?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic2837c4a2b0ec8dcd9dd99602f9c073999c36139 Gerrit-Change-Number: 76514 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Varshit Pandya <pandyavarshit(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 28 Nov 2023 22:30:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: vendorcode/amd/opensil: Implement cbmem_top_chipset
by Felix Held (Code Review) 28 Nov '23

28 Nov '23

Attention is currently required from: Arthur Heymans, Martin L Roth. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76513?usp=email ) Change subject: vendorcode/amd/opensil: Implement cbmem_top_chipset ...................................................................... Patch Set 6: (1 comment) File src/vendorcode/amd/opensil/genoa_poc/romstage.c: https://review.coreboot.org/c/coreboot/+/76513/comment/f037bda9_5701b551 : PS6, Line 16: top_mem i'd replace this with top_mem - CONFIG_SMM_TSEG_SIZE and drop line 14. the should result in the same behavior, but be a bit easier to follow -- To view, visit https://review.coreboot.org/c/coreboot/+/76513?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I269663414f4d8e39eb218cd6348bfce7989a79f9 Gerrit-Change-Number: 76513 Gerrit-PatchSet: 6 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 28 Nov 2023 22:28:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: arch/x86/Makefile.inc: Do not pass CPPFLAGS to linker
by Srinivas Hegde (Code Review) 28 Nov '23

28 Nov '23

Attention is currently required from: Arthur Heymans, Martin L Roth, Paul Menzel. Srinivas Hegde has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79218?usp=email ) Change subject: arch/x86/Makefile.inc: Do not pass CPPFLAGS to linker ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/79218/comment/e5b60f58_cb7e46f8 : PS4, Line 10: ramstage. This is superflous as these are only meant to be compiler flags and should not be passed to the linker. > Please wrap at 72 characters max. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79218?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia3cd51be6be252aa796191cf0d2cd91d393c8878 Gerrit-Change-Number: 79218 Gerrit-PatchSet: 5 Gerrit-Owner: Srinivas Hegde <srinivashegde(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Tue, 28 Nov 2023 22:28:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: arch/x86/Makefile.inc: Do not pass CPPFLAGS to linker
by Srinivas Hegde (Code Review) 28 Nov '23

28 Nov '23

Attention is currently required from: Arthur Heymans, Paul Menzel, Srinivas Hegde. Hello Julius Werner, Jérémy Compostella, Patrick Georgi, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79218?usp=email to look at the new patch set (#5). Change subject: arch/x86/Makefile.inc: Do not pass CPPFLAGS to linker ...................................................................... arch/x86/Makefile.inc: Do not pass CPPFLAGS to linker We seem to be passing CPPFLAGS to linker in x86 arch ramstage. This is superflous as these are only meant to be compiler flags and should not be passed to the linker. Change-Id: Ia3cd51be6be252aa796191cf0d2cd91d393c8878 Signed-off-by: Srinivas Hegde <srinivashegde(a)google.com> --- M src/arch/x86/Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/79218/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/79218?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia3cd51be6be252aa796191cf0d2cd91d393c8878 Gerrit-Change-Number: 79218 Gerrit-PatchSet: 5 Gerrit-Owner: Srinivas Hegde <srinivashegde(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Srinivas Hegde <srinivashegde(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: mb/google/brox: Fix configuration for TPM
by Shelley Chen (Code Review) 28 Nov '23

28 Nov '23

Attention is currently required from: Eric Lai, Ivy Jian, Nick Vaccaro, Paul Menzel. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79102?usp=email ) Change subject: mb/google/brox: Fix configuration for TPM ...................................................................... Patch Set 7: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79102/comment/222c746f_487486af : PS6, Line 9: GPP_E1 > Nit: GPP_E1 -> GPP_E2 Done https://review.coreboot.org/c/coreboot/+/79102/comment/fba3def1_892e0538 : PS6, Line 9: i2c1 > Nit: i2c4 Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79102?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I0ecaa6fcfc05c3c2e55f857d7a4e59fe46096bb5 Gerrit-Change-Number: 79102 Gerrit-PatchSet: 7 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-CC: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ivy Jian <ivy.jian(a)quanta.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Tue, 28 Nov 2023 22:00:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023