Attention is currently required from: Bill XIE, Felix Held, Fred Reitberger, Jason Glenesk, Julius Werner, Kyösti Mälkki, Matt DeVillier, Patrick Georgi, Paul Menzel, Werner Zeh.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78623?usp=email )
Change subject: Kconfig: Decrease default HEAP_SIZE from 1 MiB to 512 KiB
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10:
Right, I agree with Nico in his comment in the next patch in this chain - Let's just combine the two. :)
--
To view, visit https://review.coreboot.org/c/coreboot/+/78623?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib1de1eb8487df5bdf004e544d40667833a291515
Gerrit-Change-Number: 78623
Gerrit-PatchSet: 10
Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)9elements.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)9elements.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 01 Nov 2023 23:24:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Bill XIE, Felix Held, Fred Reitberger, Jason Glenesk, Julius Werner, Kyösti Mälkki, Matt DeVillier, Patrick Georgi, Paul Menzel, Werner Zeh.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78623?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: Kconfig: Decrease default HEAP_SIZE from 1 MiB to 512 KiB
......................................................................
Patch Set 10:
(2 comments)
Patchset:
PS10:
We probably don't want to reduce the sizes of the heaps that were larger than 512KB. You should probably look through the last patch for those files and pull in the changes to their Kconfigs that were removed.
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/78623/comment/14a2f45a_107e2c1e :
PS10, Line 753: hex
Looking at the state of things before the patch this is replacing, you probably want to add the line:
```
default 0x100000 if FLATTENED_DEVICE_TREE
```
--
To view, visit https://review.coreboot.org/c/coreboot/+/78623?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib1de1eb8487df5bdf004e544d40667833a291515
Gerrit-Change-Number: 78623
Gerrit-PatchSet: 10
Gerrit-Owner: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)9elements.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Bill XIE <persmule(a)hardenedlinux.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com>
Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)9elements.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com>
Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 01 Nov 2023 23:22:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Cliff Huang, David Milosevic, Lance Zhao, Maximilian Brune, Nico Huber, Patrick Rudolph, Tim Wawrzynczak.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78071?usp=email )
Change subject: acpi: Add PPTT support
......................................................................
Patch Set 9:
(3 comments)
Patchset:
PS9:
Kconfig LGTM.
Please rebase on top of the current main branch to get a full jenkins run.
File src/acpi/acpi_pptt.c:
https://review.coreboot.org/c/coreboot/+/78071/comment/7b26dc4f_8d9b8975 :
PS8, Line 127: setup_topology(node->sibling, parent_ref, current);
> To be honest, I find it harder to understand/read when we mix recursion with loops. […]
Would separating the recursion into a pair of functions, one for node->sibling and one for node->child, make it easier to understand?
Since it is complex, maybe also add some documentation with an example.
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/78071/comment/bb4e97cf_08b9a465 :
PS9, Line 1392: /* As defined in ACPI 6.4 */
Not really a complaint about this patch, but maybe it's time to start looking at splitting up this header into a bunch of separate headers that get included by acpi.h? It's just getting quite long, so splitting it up into separate files could allow us to work on things a little more easly, and maybe with fewer conflicts.
Obviously the acpi_tables enum would stay in here, but the rest could go into acpi/acpi_pptt.h or something.
If you think that's appropriate, it could be done either in this patch or a follow on. If you don't think it's reasonable, feel free to ack this comment and carry on.
--
To view, visit https://review.coreboot.org/c/coreboot/+/78071?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia119e1ba15756704668116bdbc655190ec94ff10
Gerrit-Change-Number: 78071
Gerrit-PatchSet: 9
Gerrit-Owner: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Reviewer: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-CC: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Lance Zhao <lance.zhao(a)gmail.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-Comment-Date: Wed, 01 Nov 2023 23:13:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: David Milosevic <David.Milosevic(a)9elements.com>
Gerrit-MessageType: comment
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78871?usp=email )
Change subject: Documentation: order distributions alphabetically
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Please delete this one. The delete button is hidden in the right top corner under the menu with the 3 dots.
--
To view, visit https://review.coreboot.org/c/coreboot/+/78871?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaca67107cbd1e54072aed37e2e7eeb727e9e17b8
Gerrit-Change-Number: 78871
Gerrit-PatchSet: 1
Gerrit-Owner: Markus Meissner
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Comment-Date: Wed, 01 Nov 2023 23:03:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Markus Meissner, Paul Menzel.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78864?usp=email )
Change subject: Documentation: order distributions alphabetically
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
Thank you!
--
To view, visit https://review.coreboot.org/c/coreboot/+/78864?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I95d4347791988087d90992b45120ff34ba2da1c5
Gerrit-Change-Number: 78864
Gerrit-PatchSet: 2
Gerrit-Owner: Markus Meissner
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Markus Meissner
Gerrit-Comment-Date: Wed, 01 Nov 2023 23:02:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Paul Menzel.
Markus Meissner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78864?usp=email )
Change subject: Documentation: order distributions alphabetically
......................................................................
Patch Set 2:
(1 comment)
File Documentation/distributions.md:
https://review.coreboot.org/c/coreboot/+/78864/comment/17489566_63a9a65f :
PS1, Line 67: ## After-market firmware
> While on it, please reorder these as well
good point -> done
--
To view, visit https://review.coreboot.org/c/coreboot/+/78864?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I95d4347791988087d90992b45120ff34ba2da1c5
Gerrit-Change-Number: 78864
Gerrit-PatchSet: 2
Gerrit-Owner: Markus Meissner
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Wed, 01 Nov 2023 22:59:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Markus Meissner, Paul Menzel.
Hello Felix Singer, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78864?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review+1 by Felix Singer, Verified+1 by build bot (Jenkins)
Change subject: Documentation: order distributions alphabetically
......................................................................
Documentation: order distributions alphabetically
Change-Id: I95d4347791988087d90992b45120ff34ba2da1c5
Signed-off-by: Markus Meissner <coder(a)safemailbox.de>
---
M Documentation/distributions.md
1 file changed, 35 insertions(+), 36 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/78864/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/78864?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I95d4347791988087d90992b45120ff34ba2da1c5
Gerrit-Change-Number: 78864
Gerrit-PatchSet: 2
Gerrit-Owner: Markus Meissner
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Markus Meissner
Gerrit-MessageType: newpatchset
Markus Meissner has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/78872?usp=email )
Change subject: Documentation: order distributions alphabetically
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/78872?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ida1d8bcbace80c97d85e9a1fa38a4cac351f8036
Gerrit-Change-Number: 78872
Gerrit-PatchSet: 1
Gerrit-Owner: Markus Meissner
Gerrit-MessageType: abandon
Markus Meissner has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78872?usp=email )
Change subject: Documentation: order distributions alphabetically
......................................................................
Documentation: order distributions alphabetically
Change-Id: Ida1d8bcbace80c97d85e9a1fa38a4cac351f8036
Signed-off-by: Markus Meissner <coder(a)safemailbox.de>
---
M Documentation/distributions.md
1 file changed, 35 insertions(+), 36 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/78872/1
diff --git a/Documentation/distributions.md b/Documentation/distributions.md
index 219c659..1134970 100644
--- a/Documentation/distributions.md
+++ b/Documentation/distributions.md
@@ -8,6 +8,15 @@
## Hardware shipping with coreboot
+### ChromeOS Devices
+
+All ChromeOS devices ([Chromebooks](https://chromebookdb.com/), Chromeboxes,
+Chromebit, etc) released from 2012 onward use coreboot for their main system
+firmware. Additionally, starting with the 2013 Chromebook Pixel, the firmware
+running on the Embedded Controller (EC) – a small microcontroller which provides
+functions like battery management, keyboard support, and sensor interfacing –
+is open source as well.
+
### Nitrokey
[Nitrokey](https://nitrokey.com) is a german IT security hardware vendor which
@@ -27,15 +36,6 @@
and the firmware is equipped with important security features such as measured
boot, verified boot, TPM integration and UEFI Secure Boot.
-### ChromeOS Devices
-
-All ChromeOS devices ([Chromebooks](https://chromebookdb.com/), Chromeboxes,
-Chromebit, etc) released from 2012 onward use coreboot for their main system
-firmware. Additionally, starting with the 2013 Chromebook Pixel, the firmware
-running on the Embedded Controller (EC) – a small microcontroller which provides
-functions like battery management, keyboard support, and sensor interfacing –
-is open source as well.
-
### PC Engines APUs
[PC Engines](https://pcengines.ch) designs and sells embedded PC hardware that
@@ -43,6 +43,13 @@
third party, [3mdeb](https://3mdeb.com). They provide current and tested
firmware binaries on [GitHub](https://pcengines.github.io).
+### Purism
+
+[Purism](https://www.puri.sm) sells laptops with a focus on user privacy and
+security; part of that effort is to minimize the amount of proprietary and/or
+binary code. Their laptops ship with a blob-free OS and coreboot firmware
+with a neutralized Intel Management Engine (ME) and SeaBIOS as the payload.
+
### Star Labs
[Star Labs](https://starlabs.systems/) offers a range of laptops designed and
@@ -57,23 +64,8 @@
Firmware](https://github.com/system76/firmware-open), an open source
distribution of coreboot, edk2, and System76 firmware applications.
-### Purism
-
-[Purism](https://www.puri.sm) sells laptops with a focus on user privacy and
-security; part of that effort is to minimize the amount of proprietary and/or
-binary code. Their laptops ship with a blob-free OS and coreboot firmware
-with a neutralized Intel Management Engine (ME) and SeaBIOS as the payload.
-
## After-market firmware
-### Libreboot
-
-[Libreboot](https://libreboot.org) is a downstream coreboot distribution that
-provides ready-made firmware images for supported devices: those which can be
-built entirely from source code. Their copy of the coreboot repository is
-therefore stripped of all devices that require binary components to boot.
-
-
### Dasharo
[Dasharo](https://dasharo.com/) is an open-source based firmware distribution
@@ -84,18 +76,6 @@
Contributions are welcome,
[this document](https://docs.dasharo.com/ways-you-can-help-us/).
-### MrChromebox
-
-[MrChromebox](https://mrchromebox.tech/) provides upstream coreboot firmware
-images for the vast majority of x86-based Chromebooks and Chromeboxes, using
-edk2 as the payload to provide a modern UEFI bootloader. Why replace
-coreboot with coreboot? Mr Chromebox's images are built using upstream
-coreboot (vs Google's older, static tree/branch), include many features and
-fixes not found in the stock firmware, and offer much broader OS compatibility
-(i.e., they run Windows as well as Linux). They also offer updated CPU
-microcode, as well as firmware updates for the device's embedded controller
-(EC). This firmware "takes the training wheels off" your ChromeOS device :)
-
### Heads
[Heads](http://osresearch.net) is an open source custom firmware and OS
@@ -109,6 +89,25 @@
of specific hardware platforms and flash security features with custom coreboot
firmware and a Linux boot loader in ROM.
+### Libreboot
+
+[Libreboot](https://libreboot.org) is a downstream coreboot distribution that
+provides ready-made firmware images for supported devices: those which can be
+built entirely from source code. Their copy of the coreboot repository is
+therefore stripped of all devices that require binary components to boot.
+
+### MrChromebox
+
+[MrChromebox](https://mrchromebox.tech/) provides upstream coreboot firmware
+images for the vast majority of x86-based Chromebooks and Chromeboxes, using
+edk2 as the payload to provide a modern UEFI bootloader. Why replace
+coreboot with coreboot? Mr Chromebox's images are built using upstream
+coreboot (vs Google's older, static tree/branch), include many features and
+fixes not found in the stock firmware, and offer much broader OS compatibility
+(i.e., they run Windows as well as Linux). They also offer updated CPU
+microcode, as well as firmware updates for the device's embedded controller
+(EC). This firmware "takes the training wheels off" your ChromeOS device :)
+
### Skulls
[Skulls](https://github.com/merge/skulls) provides firmware images for
--
To view, visit https://review.coreboot.org/c/coreboot/+/78872?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ida1d8bcbace80c97d85e9a1fa38a4cac351f8036
Gerrit-Change-Number: 78872
Gerrit-PatchSet: 1
Gerrit-Owner: Markus Meissner
Gerrit-MessageType: newchange
Markus Meissner has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/78871?usp=email )
Change subject: Documentation: order distributions alphabetically
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/78871?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaca67107cbd1e54072aed37e2e7eeb727e9e17b8
Gerrit-Change-Number: 78871
Gerrit-PatchSet: 1
Gerrit-Owner: Markus Meissner
Gerrit-MessageType: abandon