coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3036 discussions

[S] Change in coreboot[main]: soc/intel/meteorlake: Consolidate settings for enabling tracehub
by Kane Chen (Code Review) 02 Nov '23

02 Nov '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Subrata Banik, Tarun. Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78648?usp=email ) Change subject: soc/intel/meteorlake: Consolidate settings for enabling tracehub ...................................................................... Patch Set 4: (1 comment) File src/soc/intel/meteorlake/Kconfig: https://review.coreboot.org/c/coreboot/+/78648/comment/3e8437b9_55917423 : PS4, Line 360: SOC_INTEL_COMMON_BLOCK_TRACEHUB > i hope u don't want to enable this Kconfig by default for rex ? yes, i don't want to enable it by default. thank you -- To view, visit https://review.coreboot.org/c/coreboot/+/78648?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie830fe2fd38e3456497bea37fe42ca60d26ca305 Gerrit-Change-Number: 78648 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Nov 2023 08:22:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A
by Subrata Banik (Code Review) 02 Nov '23

02 Nov '23

Attention is currently required from: Anson Tseng, Daniel Peng, Karthik Ramasubramanian, Shou-Chieh Hsu. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78792?usp=email ) Change subject: mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A ...................................................................... Patch Set 2: (1 comment) File spd/lp4x/set-1/parts_spd_manifest.generated.txt: https://review.coreboot.org/c/coreboot/+/78792/comment/c7f5b63b_2b28e0b4 : PS2, Line 36: CXDB4CBAM-ML-A,spd-11.hex should't this be a separate CL ? -- To view, visit https://review.coreboot.org/c/coreboot/+/78792?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iff2ed16bcbc9b0755e60a284246aa928625fa26a Gerrit-Change-Number: 78792 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Anson Tseng <ansontseng(a)google.com> Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 02 Nov 2023 08:21:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: libpayload/libc/getopt_long: Use common GCD
by Yu-Ping Wu (Code Review) 02 Nov '23

02 Nov '23

Attention is currently required from: Julius Werner, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78887?usp=email ) Change subject: libpayload/libc/getopt_long: Use common GCD ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78887?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib9dd1d2f658d4411c36d0198774819690686a393 Gerrit-Change-Number: 78887 Gerrit-PatchSet: 2 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Thu, 02 Nov 2023 08:19:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: arch/arm64/arch_timer: Fix possible overflow in multiplication
by Yu-Ping Wu (Code Review) 02 Nov '23

02 Nov '23

1 0

[M] Change in coreboot[main]: Use common GCD function
by Yu-Ping Wu (Code Review) 02 Nov '23

02 Nov '23

Attention is currently required from: Arthur Heymans, Julius Werner, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78799?usp=email ) Change subject: Use common GCD function ...................................................................... Patch Set 4: (1 comment) File src/northbridge/intel/ironlake/quickpath.c: https://review.coreboot.org/c/coreboot/+/78799/comment/4f1cfb77_e8d9724c : PS4, Line 20: static unsigned int lcm(unsigned int a, unsigned int b) u32 -- To view, visit https://review.coreboot.org/c/coreboot/+/78799?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I30e4b02a9ca6a15c9bc4edcf4143ffa13a21a732 Gerrit-Change-Number: 78799 Gerrit-PatchSet: 4 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Thu, 02 Nov 2023 08:13:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: Use common GCD function
by Yu-Ping Wu (Code Review) 02 Nov '23

02 Nov '23

Attention is currently required from: Arthur Heymans, Julius Werner, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78799?usp=email ) Change subject: Use common GCD function ...................................................................... Patch Set 4: (1 comment) File src/drivers/analogix/anx7625/anx7625.c: https://review.coreboot.org/c/coreboot/+/78799/comment/1055f9dd_e16cc773 : PS4, Line 157: static void anx7625_reduction_of_a_fraction(unsigned long *_a, Can we change the types of a, b, m, n (and others) to `u32`? -- To view, visit https://review.coreboot.org/c/coreboot/+/78799?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I30e4b02a9ca6a15c9bc4edcf4143ffa13a21a732 Gerrit-Change-Number: 78799 Gerrit-PatchSet: 4 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Thu, 02 Nov 2023 08:11:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A
by Daniel Peng (Code Review) 02 Nov '23

02 Nov '23

Attention is currently required from: Anson Tseng, Karthik Ramasubramanian, Shou-Chieh Hsu, Subrata Banik. Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78792?usp=email ) Change subject: mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Could any reviewer submit this CL if no concern? Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/78792?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iff2ed16bcbc9b0755e60a284246aa928625fa26a Gerrit-Change-Number: 78792 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Anson Tseng <ansontseng(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 02 Nov 2023 08:09:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: commonlib: Add GCD function
by Yu-Ping Wu (Code Review) 02 Nov '23

02 Nov '23

Attention is currently required from: Arthur Heymans, Julius Werner, Paul Menzel, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78798?usp=email ) Change subject: commonlib: Add GCD function ...................................................................... Patch Set 4: (2 comments) File src/commonlib/bsd/gcd.c: https://review.coreboot.org/c/coreboot/+/78798/comment/7f6cce4f_d95aa4b0 : PS2, Line 10: if (a == 0 || b == 0) > Done. `gcd(0, 123)` is mathematically well-defined. In addition, if this is taken out, then `gcd(1, 0)` and `gcd(0, 1)` will be different behaviors, which is even more confusing. Therefore I'm fine with adding this back. File tests/commonlib/bsd/gcd-test.c: https://review.coreboot.org/c/coreboot/+/78798/comment/64c88e5a_d9fd9b73 : PS4, Line 7: { Add some edge cases here such as ``` gcd32(1, 1); gcd32(1, 123); gcd32(123, 1); gcd32(1, UINT32_MAX); gcd32(UINT32_MAX, 1); gcd32(UINT32_MAX, UINT32_MAX); ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/78798?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I21819cda4299b3809b8ca7a95cbdc6a87e4b3481 Gerrit-Change-Number: 78798 Gerrit-PatchSet: 4 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Thu, 02 Nov 2023 08:06:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: tests: Add support for running unit tests on CrOS SDK
by Hsuan-ting Chen (Code Review) 02 Nov '23

02 Nov '23

Hsuan-ting Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78875?usp=email ) Change subject: tests: Add support for running unit tests on CrOS SDK ...................................................................... tests: Add support for running unit tests on CrOS SDK Add support for running `make unit-tests` under CrOS SDK by applying two changes in tests/Makefile.common * Respect VBOOT_SOURCE while including generic headers. * Use host cmoka if possible. BUG=none TEST=make clean-unit-tests && VBOOT_SOURCE=/path/to/vboot_reference/ make unit-tests -j TEST=make clean-unit-tests && make unit-tests -j (with cmocka) TEST=make clean-unit-tests && make unit-tests -j (without cmocka) BRANCH=none Change-Id: Id3bb3726c91167d2dd648d748763a3948787f28d --- M Makefile M Makefile.inc M tests/Makefile.common 3 files changed, 7 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/75/78875/1 diff --git a/Makefile b/Makefile index 29597c8..b0a99146 100644 --- a/Makefile +++ b/Makefile @@ -15,6 +15,7 @@ additional-dirs := +VBOOT_SOURCE ?= $(abspath 3rdparty/vboot) VBOOT_HOST_BUILD ?= $(abspath $(objutil)/vboot_lib) COREBOOT_EXPORTS := COREBOOT_EXPORTS diff --git a/Makefile.inc b/Makefile.inc index 22a4646..047c955 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -460,7 +460,6 @@ endif CPPFLAGS_common := -Isrc -Isrc/include -Isrc/commonlib/include -Isrc/commonlib/bsd/include -I$(obj) -VBOOT_SOURCE ?= 3rdparty/vboot CPPFLAGS_common += -I$(VBOOT_SOURCE)/firmware/include CPPFLAGS_common += -include $(src)/include/kconfig.h CPPFLAGS_common += -include $(src)/include/rules.h diff --git a/tests/Makefile.common b/tests/Makefile.common index e51d253..f1d47ce 100644 --- a/tests/Makefile.common +++ b/tests/Makefile.common @@ -36,7 +36,7 @@ TEST_INCLUDES += -I$(src) -I$(src)/include -I$(src)/commonlib/include \ -I$(src)/commonlib/bsd/include -I$(src)/arch/x86/include \ - -I$(top)/3rdparty/vboot/firmware/include + -I$(VBOOT_SOURCE)/firmware/include # Path for Kconfig autoheader TEST_INCLUDES += -I$(dir $(TEST_KCONFIG_AUTOHEADER)) @@ -151,11 +151,15 @@ # Link against Cmocka if not disabled ifeq ($(strip $(filter-out 0 n no,$($(1)-no_test_framework))),) +HAVE_CMOCKA := $(shell $(HOSTPKG_CONFIG) --exists cmocka && echo 1) +ifeq ($(HAVE_CMOCKA),) $($(1)-objs): TEST_CFLAGS += -I$(cmockasrc)/include -$($(1)-bin): TEST_LDFLAGS += -L$(cmockaobj)/src -lcmocka -Wl,-rpath=$(cmockaobj)/src +$($(1)-bin): TEST_LDFLAGS += -L$(cmockaobj)/src -Wl,-rpath=$(cmockaobj)/src $($(1)-bin): TEST_CFLAGS += -I$(cmockasrc)/include $($(1)-bin): $(CMOCKA_LIB) endif +$($(1)-bin): TEST_LDFLAGS += -lcmocka +endif $($(1)-bin): $($(1)-objs) $($(1)-sysobjs) $(HOSTCC) $$^ $($(1)-cflags) $$(TEST_LDFLAGS) -o $$@ -- To view, visit https://review.coreboot.org/c/coreboot/+/78875?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id3bb3726c91167d2dd648d748763a3948787f28d Gerrit-Change-Number: 78875 Gerrit-PatchSet: 1 Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com> Gerrit-CC: Hsuan Ting Chen <roccochen(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in coreboot[main]: soc/intel/meteorlake: Consolidate settings for enabling tracehub
by Subrata Banik (Code Review) 02 Nov '23

02 Nov '23

Attention is currently required from: Eran Mitrani, Kane Chen, Kapil Porwal, Tarun. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78648?usp=email ) Change subject: soc/intel/meteorlake: Consolidate settings for enabling tracehub ...................................................................... Patch Set 4: Code-Review+1 (1 comment) File src/soc/intel/meteorlake/Kconfig: https://review.coreboot.org/c/coreboot/+/78648/comment/1638eadd_7c9dc4cf : PS4, Line 360: SOC_INTEL_COMMON_BLOCK_TRACEHUB i hope u don't want to enable this Kconfig by default for rex ? -- To view, visit https://review.coreboot.org/c/coreboot/+/78648?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie830fe2fd38e3456497bea37fe42ca60d26ca305 Gerrit-Change-Number: 78648 Gerrit-PatchSet: 4 Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Nov 2023 07:54:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023