coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[S] Change in coreboot[main]: mb/google/brya/var/marasov: Enable Wi-Fi sar table for Intel module
by Daniel Peng (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Eric Lai, Karthik Ramasubramanian, Kyle Lin, Nick Vaccaro, Paul Menzel, Subrata Banik. Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77789?usp=email ) Change subject: mb/google/brya/var/marasov: Enable Wi-Fi sar table for Intel module ...................................................................... Patch Set 7: Code-Review+1 This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/77789?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5b5c6bea6c2c916fb682044218ec7b3a5d2659f6 Gerrit-Change-Number: 77789 Gerrit-PatchSet: 7 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kyle Lin <kylelinck(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 03 Nov 2023 02:31:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/brya/var/marasov: Enable wifi sar table for Intel module
by Eric Lai (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Daniel Peng, Nick Vaccaro. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78310?usp=email ) Change subject: mb/google/brya/var/marasov: Enable wifi sar table for Intel module ...................................................................... Patch Set 3: -Code-Review -- To view, visit https://review.coreboot.org/c/coreboot/+/78310?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b5c6bea6c2c916fb682044218ec7b3a5d2659f6 Gerrit-Change-Number: 78310 Gerrit-PatchSet: 3 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kyle Lin <kylelinck(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Comment-Date: Fri, 03 Nov 2023 02:02:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/corsola: Enable FW_CONFIG and FW_CONFIG_SOURCE_CHROMEEC_CBI
by Hung-Te Lin (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Yidi Lin, Yu-Ping Wu. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78905?usp=email ) Change subject: mb/google/corsola: Enable FW_CONFIG and FW_CONFIG_SOURCE_CHROMEEC_CBI ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78905?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6c12041d3666907c884f5a50a12c1433c2085961 Gerrit-Change-Number: 78905 Gerrit-PatchSet: 1 Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 03 Nov 2023 01:23:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: arch/arm64/arch_timer: Fix possible overflow in multiplication
by Julius Werner (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Arthur Heymans, Paul Menzel, Yidi Lin, Yu-Ping Wu. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78800?usp=email ) Change subject: arch/arm64/arch_timer: Fix possible overflow in multiplication ...................................................................... Patch Set 7: (1 comment) File src/arch/arm64/arch_timer.c: https://review.coreboot.org/c/coreboot/+/78800/comment/f80c935e_950d3e54 : PS7, Line 21: 1000000 Could use USECS_PER_SEC here as well. -- To view, visit https://review.coreboot.org/c/coreboot/+/78800?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I366667de05392913150414f0fa9058725be71c52 Gerrit-Change-Number: 78800 Gerrit-PatchSet: 7 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 03 Nov 2023 01:13:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: doc/soc/intel/xeon_sp: Add Xeon-SP coreboot community preview guide
by Shuo Liu (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Anjaneya "Reddy" Chagam, David Hendricks, Jonathan Zhang. Shuo Liu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78787?usp=email ) Change subject: doc/soc/intel/xeon_sp: Add Xeon-SP coreboot community preview guide ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: Thanks all! I made update accordingly, could you please review again? -- To view, visit https://review.coreboot.org/c/coreboot/+/78787?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie2ffc1722a4a26d6039b6642efa95bf072d896ad Gerrit-Change-Number: 78787 Gerrit-PatchSet: 7 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-CC: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Comment-Date: Fri, 03 Nov 2023 01:13:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: libpayload/libc/time: Fix possible overflow in multiplication
by Julius Werner (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Yidi Lin. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78888?usp=email ) Change subject: libpayload/libc/time: Fix possible overflow in multiplication ...................................................................... Patch Set 4: (2 comments) File payloads/libpayload/libc/time.c: https://review.coreboot.org/c/coreboot/+/78888/comment/cbb2c4c2_3a5f2949 : PS4, Line 181: 1000000 nit: might look better to initialize `mult` earlier and use it here. Actually, might look nicer to use USECS_PER_SEC to initialize `mult` rather than the raw number, too. https://review.coreboot.org/c/coreboot/+/78888/comment/9c10c058_b929617b : PS4, Line 189: * hz to uint32_t. This is architecture-independent code, so this comment doesn't belong here. I think the best option is to change timer_hz() to return a uint32_t (for the rdtsc.c case it should be good enough to add an assert that the multiplication doesn't overflow, we should be able to assume in practice that the timestamp counters will never be that fast). -- To view, visit https://review.coreboot.org/c/coreboot/+/78888?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia55532490651fcf47128b83a8554751f050bcc89 Gerrit-Change-Number: 78888 Gerrit-PatchSet: 4 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 03 Nov 2023 01:12:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: doc/soc/intel/xeon_sp: Add Xeon-SP coreboot community preview guide
by Shuo Liu (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Anjaneya "Reddy" Chagam, David Hendricks, Jonathan Zhang, Shuo Liu. Hello Anjaneya "Reddy" Chagam, David Hendricks, Felix Singer, Jonathan Zhang, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78787?usp=email to look at the new patch set (#7). Change subject: doc/soc/intel/xeon_sp: Add Xeon-SP coreboot community preview guide ...................................................................... doc/soc/intel/xeon_sp: Add Xeon-SP coreboot community preview guide The community preview branch for coreboot on latest Xeon Scalable processor is opensource at: https://review.coreboot.org/plugins/gitiles/intel-dev-pub/. Change-Id: Ie2ffc1722a4a26d6039b6642efa95bf072d896ad Signed-off-by: Shuo Liu <shuo.liu(a)intel.com> --- M Documentation/soc/intel/index.md A Documentation/soc/intel/xeon_sp/community_preview_guide.md A Documentation/soc/intel/xeon_sp/index.md 3 files changed, 124 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/78787/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/78787?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie2ffc1722a4a26d6039b6642efa95bf072d896ad Gerrit-Change-Number: 78787 Gerrit-PatchSet: 7 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-CC: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[main]: libpayload/libc/getopt_long: Use common GCD
by Julius Werner (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Yidi Lin. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78887?usp=email ) Change subject: libpayload/libc/getopt_long: Use common GCD ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78887?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib9dd1d2f658d4411c36d0198774819690686a393 Gerrit-Change-Number: 78887 Gerrit-PatchSet: 4 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 03 Nov 2023 01:04:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: arch/arm64/arch_timer: Fix possible overflow in multiplication
by Julius Werner (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Arthur Heymans, Paul Menzel, Yidi Lin, Yu-Ping Wu. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78800?usp=email ) Change subject: arch/arm64/arch_timer: Fix possible overflow in multiplication ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: > Can you take a look at the space usage for each symbol (iirc it's already under somewhere in the bui […] Hmm... if you shuffle the memlayout (src/soc/qualcomm/sc7280/memlayout.ld) around a bit you can probably make it work. For example, I think you can probably move VBOOT2_WORK to the end of the SSRAM area (there seems to be some empty space there), and then expand the bootblock (shifting everything else down a bit) to encompass the hole left by that. -- To view, visit https://review.coreboot.org/c/coreboot/+/78800?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I366667de05392913150414f0fa9058725be71c52 Gerrit-Change-Number: 78800 Gerrit-PatchSet: 7 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 03 Nov 2023 01:04:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: doc/soc/intel/xeon_sp: Add Xeon-SP coreboot community preview guide
by Shuo Liu (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Anjaneya "Reddy" Chagam, David Hendricks, Jonathan Zhang, Shuo Liu. Hello Anjaneya "Reddy" Chagam, David Hendricks, Felix Singer, Jonathan Zhang, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78787?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by Shuo Liu, Code-Review-1 by David Hendricks, Verified+1 by build bot (Jenkins) Change subject: doc/soc/intel/xeon_sp: Add Xeon-SP coreboot community preview guide ...................................................................... doc/soc/intel/xeon_sp: Add Xeon-SP coreboot community preview guide The community preview branch for coreboot on latest Xeon Scalable processor is opensource at: https://review.coreboot.org/plugins/gitiles/intel-dev-pub/. Change-Id: Ie2ffc1722a4a26d6039b6642efa95bf072d896ad Signed-off-by: Shuo Liu <shuo.liu(a)intel.com> --- M Documentation/soc/intel/index.md A Documentation/soc/intel/xeon_sp/community_preview_guide.md A Documentation/soc/intel/xeon_sp/index.md 3 files changed, 124 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/78787/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/78787?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie2ffc1722a4a26d6039b6642efa95bf072d896ad Gerrit-Change-Number: 78787 Gerrit-PatchSet: 6 Gerrit-Owner: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Reviewer: Shuo Liu <shuo.liu(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Chen, Gang C <gang.c.chen(a)intel.com> Gerrit-CC: Jincheng Li <jincheng.li(a)intel.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Jonathan Zhang <jon.zhixiong.zhang(a)gmail.com> Gerrit-Attention: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Attention: Shuo Liu <shuo.liu(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023