coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3037 discussions

[XS] Change in coreboot[master]: mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A
by Daniel Peng (Code Review) 03 Nov '23

03 Nov '23

Daniel Peng has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/78792?usp=email ) Change subject: mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A ...................................................................... Abandoned Move the branch from master to main. -- To view, visit https://review.coreboot.org/c/coreboot/+/78792?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iff2ed16bcbc9b0755e60a284246aa928625fa26a Gerrit-Change-Number: 78792 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

[XS] Change in coreboot[main]: soc/mediatek/mt8188: Support loading BL32 image from rootfs
by Yu-Ping Wu (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Hung-Te Lin, Kiwi Liu, Paul Menzel, Yidi Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78801?usp=email ) Change subject: soc/mediatek/mt8188: Support loading BL32 image from rootfs ...................................................................... Patch Set 13: (8 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78801/comment/9e3983c0_f4795156 : PS1, Line 7: optee > What does this prefix mean? Done https://review.coreboot.org/c/coreboot/+/78801/comment/5715c4d6_be38fb1c : PS1, Line 7: loading > Please use imperative mood: Load BL32 image from rootfs Done https://review.coreboot.org/c/coreboot/+/78801/comment/4f4469d4_c31821b7 : PS1, Line 9: loading of BL32 image from rootfs > Please elaborate and give the reason/motivation for the change. Done Commit Message: https://review.coreboot.org/c/coreboot/+/78801/comment/2273880e_44cd6493 : PS13, Line 7: BL32 image from rootfs OP-TEE via an SMC https://review.coreboot.org/c/coreboot/+/78801/comment/bd929b54_5ff4d11f : PS13, Line 10: BL32 image from rootfs OP-TEE via an SMC from rootfs https://review.coreboot.org/c/coreboot/+/78801/comment/769dfdbe_12865804 : PS13, Line 11: BL32 the OP-TEE File src/soc/mediatek/mt8188/Makefile.inc: https://review.coreboot.org/c/coreboot/+/78801/comment/250d37dd_0f2b8914 : PS13, Line 62: CROS_WIDEVINE_SMC Where does `CROS_WIDEVINE_SMC` come from? I can't find it in the TF-A repo. https://review.coreboot.org/c/coreboot/+/78801/comment/f0b5218e_f83a29f8 : PS13, Line 61: PLAT=mt8188 SPD=opteed OPTEE_ALLOW_SMC_LOAD=1 \ : PLAT_XLAT_TABLES_DYNAMIC=1 CROS_WIDEVINE_SMC=1 > Is there any reason that the parameters should be in the same line ? I agree. Please rewrite as: ``` BL31_MAKEARGS += PLAT=mt8188 BL31_MAKEARGS += SPD=opteed OPTEE_ALLOW_SMC_LOAD=1 PLAT_XLAT_TABLES_DYNAMIC=1 ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/78801?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic38c8beb59c090ae56c5be6821dd8625435609e9 Gerrit-Change-Number: 78801 Gerrit-PatchSet: 13 Gerrit-Owner: Kiwi Liu <kiwi.liu(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kiwi Liu <kiwi.liu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yidi Lin <yidilin(a)google.com> Gerrit-Comment-Date: Fri, 03 Nov 2023 07:09:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: fmap: Eliminate some impossible code paths
by Yu-Ping Wu (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Jakub Czapiga, Julius Werner. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78904?usp=email ) Change subject: fmap: Eliminate some impossible code paths ...................................................................... Patch Set 1: (4 comments) File src/lib/fmap.c: https://review.coreboot.org/c/coreboot/+/78904/comment/f68bdb0c_103fc9c0 : PS1, Line 36: 0x%x %#x https://review.coreboot.org/c/coreboot/+/78904/comment/354d4de1_eb4a6f41 : PS1, Line 36: FMAP missing or corrupted Is it more straightforward to say `Invalid FMAP signature`? https://review.coreboot.org/c/coreboot/+/78904/comment/06d23592_dea6d29f : PS1, Line 37: FMAP_OFFSET); indent https://review.coreboot.org/c/coreboot/+/78904/comment/5cc019ec_03b1d6eb : PS1, Line 125: if (!CONFIG(NO_FMAP_CACHE) && ENV_ROMSTAGE_OR_BEFORE) Also `&& !ENV_SMM`? -- To view, visit https://review.coreboot.org/c/coreboot/+/78904?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I7b8251dd6b34fe4f63865ebc44b9a8a103f32a57 Gerrit-Change-Number: 78904 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Fri, 03 Nov 2023 06:40:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A
by Daniel Peng (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Anson Tseng, Eric Lai, Karthik Ramasubramanian, Paul Menzel, Shou-Chieh Hsu, Subrata Banik. Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78792?usp=email ) Change subject: mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Thanks for the suggestion. I'll abandon this CL and separate to 2 CLs. 1.spd/lp4x: Add SPD for CXDB4CBAM-ML-A in parts_spd_manifest.generated.txt https://review.coreboot.org/c/coreboot/+/78891 2.mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A https://review.coreboot.org/c/coreboot/+/78892 Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/78792?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iff2ed16bcbc9b0755e60a284246aa928625fa26a Gerrit-Change-Number: 78792 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Anson Tseng <ansontseng(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 03 Nov 2023 06:38:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[master]: mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A
by Daniel Peng (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Anson Tseng, Eric Lai, Karthik Ramasubramanian, Paul Menzel, Shou-Chieh Hsu, Subrata Banik. Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78792?usp=email ) Change subject: mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A ...................................................................... Patch Set 2: -Code-Review (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/78792/comment/c5a17dd0_0e517966 : PS2, Line 7: mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A > Please make it a statement by adding a verb (in imperative mood). […] Done Patchset: PS2: > woops if add the new SPD, please separate it Done PS2: Thanks for the suggestion. I'll abandon this CL and separate to 2 CLs. 1.spd/lp4x: Add SPD for CXDB4CBAM-ML-A in parts_spd_manifest.generated.txt https://review.coreboot.org/c/coreboot/+/78891 2.mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A https://review.coreboot.org/c/coreboot/+/78892 Thanks. File spd/lp4x/set-1/parts_spd_manifest.generated.txt: https://review.coreboot.org/c/coreboot/+/78792/comment/c67065c4_1ea513af : PS2, Line 36: CXDB4CBAM-ML-A,spd-11.hex > +1. This should be a separate CL. Also where is the update to memory_parts. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/78792?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iff2ed16bcbc9b0755e60a284246aa928625fa26a Gerrit-Change-Number: 78792 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Anson Tseng <ansontseng(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 03 Nov 2023 06:37:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A
by Daniel Peng (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Anson Tseng, Eric Lai, Karthik Ramasubramanian, Martin L Roth, Paul Menzel, Shou-Chieh Hsu, Subrata Banik. Hello Anson Tseng, Eric Lai, Karthik Ramasubramanian, Martin L Roth, Paul Menzel, Shou-Chieh Hsu, Subrata Banik, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78892?usp=email to look at the new patch set (#2). Change subject: mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A ...................................................................... mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A Add support for the new memory CXDB4CBAM-ML-A. BUG=b:304932936 BRANCH=firmware-dedede-13606.B TEST=Run command "go run \ ./util/spd_tools/src/part_id_gen/part_id_gen.go \ JSL lp4x src/mainboard/google/dedede/variants/pirika/memory/ \ src/mainboard/google/dedede/variants/pirika/memory/\ mem_parts_used.txt" And confirm boot normally on mainboard with CXDB4CBAM-ML-A memory. Change-Id: Iff2ed16bcbc9b0755e60a284246aa928625fa26a Signed-off-by: Daniel_Peng <Daniel_Peng(a)pegatron.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/pirika/memory/Makefile.inc M src/mainboard/google/dedede/variants/pirika/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/pirika/memory/mem_parts_used.txt 3 files changed, 5 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/78892/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78892?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iff2ed16bcbc9b0755e60a284246aa928625fa26a Gerrit-Change-Number: 78892 Gerrit-PatchSet: 2 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Anson Tseng <ansontseng(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A
by Daniel Peng (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Anson Tseng, Eric Lai, Karthik Ramasubramanian, Martin L Roth, Paul Menzel, Shou-Chieh Hsu, Subrata Banik. Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78892?usp=email ) Change subject: mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/78892?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iff2ed16bcbc9b0755e60a284246aa928625fa26a Gerrit-Change-Number: 78892 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Anson Tseng <ansontseng(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 03 Nov 2023 06:34:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: spd/lp4x: Add SPD for CXDB4CBAM-ML-A in parts_spd_manifest.generated.txt
by Daniel Peng (Code Review) 03 Nov '23

03 Nov '23

Attention is currently required from: Anson Tseng, Eric Lai, Karthik Ramasubramanian, Martin L Roth, Paul Menzel, Shou-Chieh Hsu, Subrata Banik. Daniel Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78891?usp=email ) Change subject: spd/lp4x: Add SPD for CXDB4CBAM-ML-A in parts_spd_manifest.generated.txt ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/78891?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia33a94a1784f865b4776ad9107e25e87420f944f Gerrit-Change-Number: 78891 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Anson Tseng <ansontseng(a)google.com> Gerrit-Reviewer: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Anson Tseng <ansontseng(a)google.com> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 03 Nov 2023 06:33:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A
by Daniel Peng (Code Review) 03 Nov '23

03 Nov '23

Daniel Peng has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78892?usp=email ) Change subject: mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A ...................................................................... mb/google/dedede/var/pirika: Support for CXMT CXDB4CBAM-ML-A Add the new memory support: CXDB4CBAM-ML-A BUG=b:304932936 BRANCH=firmware-dedede-13606.B TEST=Run command "go run \ ./util/spd_tools/src/part_id_gen/part_id_gen.go \ JSL lp4x src/mainboard/google/dedede/variants/pirika/memory/ \ src/mainboard/google/dedede/variants/pirika/memory/\ mem_parts_used.txt" And confirm boot normally on mainboard with CXDB4CBAM-ML-A memory. Change-Id: Iff2ed16bcbc9b0755e60a284246aa928625fa26a Signed-off-by: Daniel_Peng <Daniel_Peng(a)pegatron.corp-partner.google.com> --- M src/mainboard/google/dedede/variants/pirika/memory/Makefile.inc M src/mainboard/google/dedede/variants/pirika/memory/dram_id.generated.txt M src/mainboard/google/dedede/variants/pirika/memory/mem_parts_used.txt 3 files changed, 5 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/78892/1 diff --git a/src/mainboard/google/dedede/variants/pirika/memory/Makefile.inc b/src/mainboard/google/dedede/variants/pirika/memory/Makefile.inc index 66919de..8b4d130 100644 --- a/src/mainboard/google/dedede/variants/pirika/memory/Makefile.inc +++ b/src/mainboard/google/dedede/variants/pirika/memory/Makefile.inc @@ -1,7 +1,8 @@ # SPDX-License-Identifier: GPL-2.0-or-later # This is an auto-generated file. Do not edit!! # Generated by: -# /tmp/go-build352956073/b001/exe/part_id_gen JSL lp4x src/mainboard/google/dedede/variants/pirika/memory/ src/mainboard/google/dedede/variants/pirika/memory/mem_parts_used.txt +# /tmp/go-build469829719/b001/exe/part_id_gen JSL lp4x src/mainboard/google/dedede/variants/pirika/memory/ src/mainboard/google/dedede/variants/pirika/memory/mem_parts_used.txt SPD_SOURCES = SPD_SOURCES += spd/lp4x/set-1/spd-1.hex # ID = 0(0b0000) Parts = H9HCNNNBKMMLXR-NEE, K4U6E3S4AA-MGCR, K4U6E3S4AB-MGCL +SPD_SOURCES += spd/lp4x/set-1/spd-11.hex # ID = 1(0b0001) Parts = CXDB4CBAM-ML-A diff --git a/src/mainboard/google/dedede/variants/pirika/memory/dram_id.generated.txt b/src/mainboard/google/dedede/variants/pirika/memory/dram_id.generated.txt index 7a6b135..76ab7e0 100644 --- a/src/mainboard/google/dedede/variants/pirika/memory/dram_id.generated.txt +++ b/src/mainboard/google/dedede/variants/pirika/memory/dram_id.generated.txt @@ -1,9 +1,10 @@ # SPDX-License-Identifier: GPL-2.0-or-later # This is an auto-generated file. Do not edit!! # Generated by: -# /tmp/go-build352956073/b001/exe/part_id_gen JSL lp4x src/mainboard/google/dedede/variants/pirika/memory/ src/mainboard/google/dedede/variants/pirika/memory/mem_parts_used.txt +# /tmp/go-build469829719/b001/exe/part_id_gen JSL lp4x src/mainboard/google/dedede/variants/pirika/memory/ src/mainboard/google/dedede/variants/pirika/memory/mem_parts_used.txt DRAM Part Name ID to assign H9HCNNNBKMMLXR-NEE 0 (0000) K4U6E3S4AA-MGCR 0 (0000) K4U6E3S4AB-MGCL 0 (0000) +CXDB4CBAM-ML-A 1 (0001) diff --git a/src/mainboard/google/dedede/variants/pirika/memory/mem_parts_used.txt b/src/mainboard/google/dedede/variants/pirika/memory/mem_parts_used.txt index a6490b2..b93cdbf 100644 --- a/src/mainboard/google/dedede/variants/pirika/memory/mem_parts_used.txt +++ b/src/mainboard/google/dedede/variants/pirika/memory/mem_parts_used.txt @@ -1,3 +1,4 @@ H9HCNNNBKMMLXR-NEE K4U6E3S4AA-MGCR K4U6E3S4AB-MGCL +CXDB4CBAM-ML-A -- To view, visit https://review.coreboot.org/c/coreboot/+/78892?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Iff2ed16bcbc9b0755e60a284246aa928625fa26a Gerrit-Change-Number: 78892 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: spd/lp4x: Add SPD for CXDB4CBAM-ML-A in parts_spd_manifest.generated.txt
by Daniel Peng (Code Review) 03 Nov '23

03 Nov '23

Daniel Peng has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78891?usp=email ) Change subject: spd/lp4x: Add SPD for CXDB4CBAM-ML-A in parts_spd_manifest.generated.txt ...................................................................... spd/lp4x: Add SPD for CXDB4CBAM-ML-A in parts_spd_manifest.generated.txt Add CXMT CXDB4CBAM-ML-A to match SPD spd-11.hex. BUG=b:304932936 TEST=NONE Change-Id: Ia33a94a1784f865b4776ad9107e25e87420f944f Signed-off-by: Daniel Peng <Daniel_Peng(a)pegatron.corp-partner.google.com> --- M spd/lp4x/set-1/parts_spd_manifest.generated.txt 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/78891/1 diff --git a/spd/lp4x/set-1/parts_spd_manifest.generated.txt b/spd/lp4x/set-1/parts_spd_manifest.generated.txt index 34e455b..3a9201d 100644 --- a/spd/lp4x/set-1/parts_spd_manifest.generated.txt +++ b/spd/lp4x/set-1/parts_spd_manifest.generated.txt @@ -33,3 +33,4 @@ H54G68CYRBX248,spd-2.hex K4UCE3Q4AB-MGCL,spd-2.hex CXDB4ABAM-ML,spd-11.hex +CXDB4CBAM-ML-A,spd-11.hex -- To view, visit https://review.coreboot.org/c/coreboot/+/78891?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia33a94a1784f865b4776ad9107e25e87420f944f Gerrit-Change-Number: 78891 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023