coreboot-gerrit November 2023

coreboot-gerrit@coreboot.org

1 participants
3036 discussions

[XS] Change in coreboot[main]: Kconfig: Move rustccfg file to a more benign place
by Felix Singer (Code Review) 30 Nov '23

30 Nov '23

Attention is currently required from: Martin L Roth, Patrick Georgi. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79342?usp=email ) Change subject: Kconfig: Move rustccfg file to a more benign place ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/79342?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I532fde9625dbf7463752ef1af525b77d12676c93 Gerrit-Change-Number: 79342 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Wed, 29 Nov 2023 23:12:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/google/rex/variants/deku: Add GPIO configuration
by Eran Mitrani (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Paul Menzel, Tarun. Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78960?usp=email ) Change subject: mb/google/rex/variants/deku: Add GPIO configuration ...................................................................... Patch Set 7: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78960/comment/ce8e136a_e58058a1 : PS6, Line 10: From > from Done -- To view, visit https://review.coreboot.org/c/coreboot/+/78960?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ib37a7ebf0aca788d14fafea0f97e364beafb4c4d Gerrit-Change-Number: 78960 Gerrit-PatchSet: 7 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Wed, 29 Nov 2023 22:59:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/rex/var/deku: Enable LAN0, LAN1
by Eran Mitrani (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Paul Menzel, Subrata Banik, Tarun. Eran Mitrani has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79292?usp=email ) Change subject: mb/google/rex/var/deku: Enable LAN0, LAN1 ...................................................................... Patch Set 7: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/79292/comment/aafe5cd8_b59e7fb1 : PS4, Line 9: Add overridetree.cb entry to configure the LAN0 LAN1 devices. > Maybe add an introductory sentence. google/deku is a Chromebox featuring two LAN ports. Done File src/mainboard/google/rex/variants/deku/overridetree.cb: https://review.coreboot.org/c/coreboot/+/79292/comment/0762781d_e66fe160 : PS4, Line 72: #PCIE7 LAN1 card > Please add a space after the #. Done https://review.coreboot.org/c/coreboot/+/79292/comment/516d66e9_a9804877 : PS4, Line 87: #PCIE10 LAN0 card > Please add a space after the #. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/79292?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8980dabc7f9fc731a2b60c599e1e48c9b11dabb4 Gerrit-Change-Number: 79292 Gerrit-PatchSet: 7 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Wed, 29 Nov 2023 22:58:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: superio/smsc: Add support for the SCH555x series
by Máté Kukri (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Martin L Roth. Máté Kukri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64359?usp=email ) Change subject: superio/smsc: Add support for the SCH555x series ...................................................................... Patch Set 4: (1 comment) Patchset: PS2: > The reason I have pushed a rebase is because somebody else wanted to use the optiplex 7020 port. […] I've looked at this again, and based on the complexity of the sch5545 code, I think this would take more effort than I'd like to spend on this, and I don't think this is blocking the Optiplex 7020 port from being usable. -- To view, visit https://review.coreboot.org/c/coreboot/+/64359?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I9323198f1139cd0c3dd37f977ae7693b721654f4 Gerrit-Change-Number: 64359 Gerrit-PatchSet: 4 Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Comment-Date: Wed, 29 Nov 2023 22:57:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Máté Kukri <kukri.mate(a)gmail.com> Comment-In-Reply-To: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/rex/var/deku: Enable LAN0, LAN1
by Eran Mitrani (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Kapil Porwal, Tarun. Hello Dinesh Gehlot, Kapil Porwal, Subrata Banik, Tarun, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/79292?usp=email to look at the new patch set (#6). Change subject: mb/google/rex/var/deku: Enable LAN0, LAN1 ...................................................................... mb/google/rex/var/deku: Enable LAN0, LAN1 google/deku is a Chromebox featuring two LAN ports. Add overridetree.cb entry to configure the LAN0 LAN1 devices. BUG=b:305793886 TEST=Built FW image correctly. Signed-off-by: Eran Mitrani <mitrani(a)google.com> Change-Id: I8980dabc7f9fc731a2b60c599e1e48c9b11dabb4 --- M src/mainboard/google/rex/variants/deku/gpio.c M src/mainboard/google/rex/variants/deku/overridetree.cb 2 files changed, 32 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/79292/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/79292?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I8980dabc7f9fc731a2b60c599e1e48c9b11dabb4 Gerrit-Change-Number: 79292 Gerrit-PatchSet: 6 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Dinesh Gehlot <digehlot(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[main]: mb/dell: Add OptiPlex 7020/9020 port
by Máté Kukri (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Angel Pons, Michael Büchler, Michael Niewöhner, Michał Żygowski, Paul Menzel. Máté Kukri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55232?usp=email ) Change subject: mb/dell: Add OptiPlex 7020/9020 port ...................................................................... Patch Set 27: (8 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/55232/comment/c1276ca4_3eaa0ba3 : PS22, Line 12: Linux > Please document the version of the Linux kernel used for testing, and the payload you used. I've tested many kernel versions ranging from 4.4 to present day now, all worked. https://review.coreboot.org/c/coreboot/+/55232/comment/61ed688a_b36311e0 : PS22, Line 15: VGA BIOS > Executed by SeaBIOS or by coreboot? Been tested with both, but libgfxinit is the focus, and this port has been used by a few people for 2 years. File src/mainboard/dell/optiplex_7020/Kconfig: https://review.coreboot.org/c/coreboot/+/55232/comment/b3193ed3_a363333d : PS5, Line 23: needs flashed > needs to be Acknowledged https://review.coreboot.org/c/coreboot/+/55232/comment/21c2a870_a1429232 : PS5, Line 23: than > then Acknowledged File src/mainboard/dell/optiplex_7020/bootblock.c: https://review.coreboot.org/c/coreboot/+/55232/comment/eda90a52_1813f898 : PS8, Line 108: // Changes LED color among a few other things (extracted from Dell's FW) > Here's an idea: If you know how to control LEDs, you can implement die_notify() and make some LEDs b […] Acknowledged File src/mainboard/dell/optiplex_7020/dsdt.asl: https://review.coreboot.org/c/coreboot/+/55232/comment/8aa13f9c_e998442d : PS1, Line 20: Scope (\_SB) : { : Device (PCI0) : { : #include <northbridge/intel/haswell/acpi/hostbridge.asl> : #include <southbridge/intel/lynxpoint/acpi/pch.asl> : } : } > I usually write this as follows: […] Done File src/mainboard/dell/optiplex_7020/gma-mainboard.ads: https://review.coreboot.org/c/coreboot/+/55232/comment/e8637c82_bf1511d5 : PS1, Line 11: -- TODO: Add DP ports to the list > I added all of them, I don't have many DP displays to test things with. Acknowledged File src/mainboard/dell/optiplex_9020/devicetree.cb: https://review.coreboot.org/c/coreboot/+/55232/comment/6d26d64f_ce62e809 : PS25, Line 39: device pci 1c.1 off end : > The mini tower (MT) variant has two additional slots compared to the UFF variant: […] I've implemented this now. -- To view, visit https://review.coreboot.org/c/coreboot/+/55232?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie7c7089f443aef9890711c4412209bceb1f1e96a Gerrit-Change-Number: 55232 Gerrit-PatchSet: 27 Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michael Büchler <michael.buechler(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Michael Büchler <michael.buechler(a)posteo.net> Gerrit-Comment-Date: Wed, 29 Nov 2023 22:51:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Máté Kukri <kukri.mate(a)gmail.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Comment-In-Reply-To: Michael Büchler <michael.buechler(a)posteo.net> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[main]: mb/dell: Add OptiPlex 7020/9020 port
by Máté Kukri (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Angel Pons, Michael Büchler, Michał Żygowski, Máté Kukri. Hello Angel Pons, Martin L Roth, Michael Büchler, Patrick Rudolph, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55232?usp=email to look at the new patch set (#29). Change subject: mb/dell: Add OptiPlex 7020/9020 port ...................................................................... mb/dell: Add OptiPlex 7020/9020 port The OptiPlex 7020 and 9020 use physically identical motherboards. Each model comes in the following form factors: - 7020: SFF, MT - 9020: USFF (not currently supported), SFF, MT (7020 SFF) Boots Linux and Windows 10: - Tested with an i3-4160 and i5-4460 - DRAM init works using the MRC (4G, 4G+4G) - iGPU init works using libgfxinit (VGA, 2x DP) - PCIe 16x: tested, ok - PCIe 4x: tested, ok - All USB2 and USB3 ports work - SMSC SCH5555 Super I/O: serial works, PS/2 untested - Audio: back and front output works, internal speaker works, mic inputs untested - Ethernet: tested, works (9020 MT) - Tested by Michael Büchler (thanks for the overridetree) Change-Id: Ie7c7089f443aef9890711c4412209bceb1f1e96a Signed-off-by: Mate Kukri <kukri.mate(a)gmail.com> --- A src/mainboard/dell/optiplex_9020/Kconfig A src/mainboard/dell/optiplex_9020/Kconfig.name A src/mainboard/dell/optiplex_9020/Makefile.inc A src/mainboard/dell/optiplex_9020/acpi/ec.asl A src/mainboard/dell/optiplex_9020/acpi/platform.asl A src/mainboard/dell/optiplex_9020/acpi/superio.asl A src/mainboard/dell/optiplex_9020/board_info.txt A src/mainboard/dell/optiplex_9020/bootblock.c A src/mainboard/dell/optiplex_9020/cmos.default A src/mainboard/dell/optiplex_9020/cmos.layout A src/mainboard/dell/optiplex_9020/data.vbt A src/mainboard/dell/optiplex_9020/devicetree.cb A src/mainboard/dell/optiplex_9020/dsdt.asl A src/mainboard/dell/optiplex_9020/gma-mainboard.ads A src/mainboard/dell/optiplex_9020/gpio.c A src/mainboard/dell/optiplex_9020/hda_verb.c A src/mainboard/dell/optiplex_9020/mainboard.c A src/mainboard/dell/optiplex_9020/overridetree_mt.cb A src/mainboard/dell/optiplex_9020/romstage.c 19 files changed, 697 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/55232/29 -- To view, visit https://review.coreboot.org/c/coreboot/+/55232?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie7c7089f443aef9890711c4412209bceb1f1e96a Gerrit-Change-Number: 55232 Gerrit-PatchSet: 29 Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michael Büchler <michael.buechler(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Büchler <michael.buechler(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[main]: mb/dell: Add OptiPlex 7020/9020 port
by Máté Kukri (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Angel Pons, Michael Büchler, Michał Żygowski, Máté Kukri. Hello Angel Pons, Martin L Roth, Michael Büchler, Patrick Rudolph, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55232?usp=email to look at the new patch set (#28). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: mb/dell: Add OptiPlex 7020/9020 port ...................................................................... mb/dell: Add OptiPlex 7020/9020 port The OptiPlex 7020 and 9020 use physically identical motherboards. Each model comes in the following form factors: - 7020: SFF, MT - 9020: USFF (not currently supported), SFF, MT (7020 SFF) Boots Linux and Windows 10: - Tested with an i3-4160 and i5-4460 - DRAM init works using the MRC (4G, 4G+4G) - iGPU init works using libgfxinit (VGA, 2x DP) - PCIe 16x: tested, ok - PCIe 4x: tested, ok - All USB2 and USB3 ports work - SMSC SCH5555 Super I/O: serial works, PS/2 untested - Audio: back and front output works, internal speaker works, mic inputs untested - Ethernet: tested, works (9020 MT) - Tested by Michael Büchler (thanks for the overridetree) Change-Id: Ie7c7089f443aef9890711c4412209bceb1f1e96a Signed-off-by: Mate Kukri <kukri.mate(a)gmail.com> --- A src/mainboard/dell/optiplex_9020/Kconfig A src/mainboard/dell/optiplex_9020/Kconfig.name A src/mainboard/dell/optiplex_9020/Makefile.inc A src/mainboard/dell/optiplex_9020/acpi/ec.asl A src/mainboard/dell/optiplex_9020/acpi/platform.asl A src/mainboard/dell/optiplex_9020/acpi/superio.asl A src/mainboard/dell/optiplex_9020/board_info.txt A src/mainboard/dell/optiplex_9020/bootblock.c A src/mainboard/dell/optiplex_9020/cmos.default A src/mainboard/dell/optiplex_9020/cmos.layout A src/mainboard/dell/optiplex_9020/data.vbt A src/mainboard/dell/optiplex_9020/devicetree.cb A src/mainboard/dell/optiplex_9020/dsdt.asl A src/mainboard/dell/optiplex_9020/gma-mainboard.ads A src/mainboard/dell/optiplex_9020/gpio.c A src/mainboard/dell/optiplex_9020/hda_verb.c A src/mainboard/dell/optiplex_9020/mainboard.c A src/mainboard/dell/optiplex_9020/overridetree_mt.cb A src/mainboard/dell/optiplex_9020/romstage.c 19 files changed, 700 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/55232/28 -- To view, visit https://review.coreboot.org/c/coreboot/+/55232?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie7c7089f443aef9890711c4412209bceb1f1e96a Gerrit-Change-Number: 55232 Gerrit-PatchSet: 28 Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michael Büchler <michael.buechler(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Büchler <michael.buechler(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[L] Change in coreboot[main]: mb/dell: Add OptiPlex 7020/9020 port
by Máté Kukri (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Angel Pons, Michael Büchler, Michał Żygowski, Máté Kukri. Hello Angel Pons, Martin L Roth, Michael Büchler, Patrick Rudolph, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55232?usp=email to look at the new patch set (#27). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: mb/dell: Add OptiPlex 7020/9020 port ...................................................................... mb/dell: Add OptiPlex 7020/9020 port The OptiPlex 7020 and 9020 use physically identical motherboards. Each model comes in the following form factors: - 7020: SFF, MT - 9020: USFF (not currently supported), SFF, MT (7020 SFF) Boots Linux and Windows 10: - Tested with an i3-4160 and i5-4460 - DRAM init works using the MRC (4G, 4G+4G) - iGPU init works using libgfxinit (VGA, 2x DP) - PCIe 16x: tested, ok - PCIe 4x: tested, ok - All USB2 and USB3 ports work - SMSC SCH5555 Super I/O: serial works, PS/2 untested - Audio: back and front output works, internal speaker works, mic inputs untested - Ethernet: tested, works (9020 MT) - Tested by Michael Büchler (thanks for the overridetree) Change-Id: Ie7c7089f443aef9890711c4412209bceb1f1e96a Signed-off-by: Mate Kukri <kukri.mate(a)gmail.com> --- A src/mainboard/dell/optiplex_9020/Kconfig A src/mainboard/dell/optiplex_9020/Kconfig.name A src/mainboard/dell/optiplex_9020/Makefile.inc A src/mainboard/dell/optiplex_9020/acpi/ec.asl A src/mainboard/dell/optiplex_9020/acpi/platform.asl A src/mainboard/dell/optiplex_9020/acpi/superio.asl A src/mainboard/dell/optiplex_9020/board_info.txt A src/mainboard/dell/optiplex_9020/bootblock.c A src/mainboard/dell/optiplex_9020/cmos.default A src/mainboard/dell/optiplex_9020/cmos.layout A src/mainboard/dell/optiplex_9020/data.vbt A src/mainboard/dell/optiplex_9020/devicetree.cb A src/mainboard/dell/optiplex_9020/dsdt.asl A src/mainboard/dell/optiplex_9020/gma-mainboard.ads A src/mainboard/dell/optiplex_9020/gpio.c A src/mainboard/dell/optiplex_9020/hda_verb.c A src/mainboard/dell/optiplex_9020/mainboard.c A src/mainboard/dell/optiplex_9020/overridetree_mt.cb A src/mainboard/dell/optiplex_9020/romstage.c 19 files changed, 698 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/55232/27 -- To view, visit https://review.coreboot.org/c/coreboot/+/55232?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie7c7089f443aef9890711c4412209bceb1f1e96a Gerrit-Change-Number: 55232 Gerrit-PatchSet: 27 Gerrit-Owner: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Michael Büchler <michael.buechler(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <rudolphpatrick05(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Máté Kukri <kukri.mate(a)gmail.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Michael Büchler <michael.buechler(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: Post-build control of serial
by Simon Glass (Code Review) 29 Nov '23

29 Nov '23

Attention is currently required from: Angel Pons, Arthur Heymans, Jérémy Compostella, Karthik Ramasubramanian, Paul Menzel, Simon Glass, Stefan Reinauer. Hello Felix Singer, Jérémy Compostella, Karthik Ramasubramanian, Patrick Georgi, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/77712?usp=email to look at the new patch set (#7). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: Post-build control of serial ...................................................................... Post-build control of serial Use the new 'coreboot Control Block' (CCB) to control console output, including the very first bootblock banner. Provide a feature in cbfstool to enable and disable the console output. BUG=none BRANCH=none TEST=make (to build coreboot) $ cbfstool build/coreboot.rom ccb-get -n console console=loud First try this to see that the bootblock outputs its banner: $ qemu-system-i386 -bios build/coreboot.rom -nographic |head -5 [NOTE ] coreboot-4.21 Fri Nov 17 12:09:01 UTC 2023 x86_32 bootblock starting (log level: 7)... ... Now set it to silent and try again, to see that the bootblock output is suppressed, so that the first output shown is the romstage: $ cbfstool build/coreboot.rom ccb-get -n console -V silent console=silent $ qemu-system-i386 -bios build/coreboot.rom -nographic (no output) Change-Id: I04e946b33035a493e833500351a0483761252613 Signed-off-by: Simon Glass <sjg(a)chromium.org> --- M Documentation/util/cbfstool/ccb.md M src/commonlib/include/commonlib/ccb.h M src/console/console.c M src/console/init.c M src/include/console/streams.h M util/cbfstool/cbfstool.c 6 files changed, 78 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/77712/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/77712?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I04e946b33035a493e833500351a0483761252613 Gerrit-Change-Number: 77712 Gerrit-PatchSet: 7 Gerrit-Owner: Simon Glass <sjg(a)chromium.org> Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Simon Glass <sjg(a)chromium.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Simon Glass <sjg(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit November 2023