coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[S] Change in coreboot[master]: mb/google/rex/var/karis: sync CBI FW_CONFIG definitions
by Kapil Porwal (Code Review) 04 Oct '23

04 Oct '23

Attention is currently required from: Eran Mitrani, Jakub Czapiga, Tarun, YH Lin. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78182?usp=email ) Change subject: mb/google/rex/var/karis: sync CBI FW_CONFIG definitions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78182?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e4965c009edc595f24c04ac82d81aa0e723bbf3 Gerrit-Change-Number: 78182 Gerrit-PatchSet: 1 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Wed, 04 Oct 2023 11:15:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex/var/karis: add hook for WiFi SAR table
by Kapil Porwal (Code Review) 04 Oct '23

04 Oct '23

Attention is currently required from: Eran Mitrani, Jakub Czapiga, Tarun, YH Lin. Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78181?usp=email ) Change subject: mb/google/rex/var/karis: add hook for WiFi SAR table ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78181?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic989024ab9eb0fc439fc701c335a85986c4cfec5 Gerrit-Change-Number: 78181 Gerrit-PatchSet: 1 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Wed, 04 Oct 2023 11:14:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/joxer: Config I2C frequency
by Derek Huang (Code Review) 04 Oct '23

04 Oct '23

Attention is currently required from: Felix Held, Ivan Chen, Mark Hsieh, Nick Vaccaro, Subrata Banik, Tarun Tuli. Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78218?usp=email ) Change subject: mb/google/nissa/var/joxer: Config I2C frequency ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78218?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I17dd1cb7800d00669f86fc6e2b350757695da881 Gerrit-Change-Number: 78218 Gerrit-PatchSet: 1 Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Ivan Chen <yulunchen(a)google.com> Gerrit-Attention: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 04 Oct 2023 11:11:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/joxer: Config I2C frequency
by Mark Hsieh (Code Review) 04 Oct '23

04 Oct '23

Attention is currently required from: Derek Huang, Felix Held, Ivan Chen, Tarun Tuli. Mark Hsieh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78218?usp=email ) Change subject: mb/google/nissa/var/joxer: Config I2C frequency ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/78218?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I17dd1cb7800d00669f86fc6e2b350757695da881 Gerrit-Change-Number: 78218 Gerrit-PatchSet: 1 Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Derek Huang <derekhuang(a)google.com> Gerrit-Attention: Ivan Chen <yulunchen(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 04 Oct 2023 10:44:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/uldren: Remove fw_config probe for TS and TP
by Dtrain Hsu (Code Review) 04 Oct '23

04 Oct '23

Attention is currently required from: Nick Vaccaro, Subrata Banik. Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77538?usp=email ) Change subject: mb/google/nissa/var/uldren: Remove fw_config probe for TS and TP ...................................................................... Patch Set 6: (2 comments) Patchset: PS6: > Also consider server center can set FW config for TP to unknown? Can that work? Preventing service center forget to set fw_config, remove fw_config probe for TS and TP is better. PS6: > https://review.coreboot. […] The ap log is from local build nissa branch, ``` [INFO ] \_SB.PCI0.I2C0.TPMI: I2C TPM at I2C: 00:50 [SPEW ] I2C TX abort detected (00000001) [SPEW ] \_SB.PCI0.I2C1.H02C: WDT Touchscreen at I2C: 00:2c -- NOT FOUND, skipping [SPEW ] I2C TX abort detected (00000001) [SPEW ] \_SB.PCI0.I2C1.D010: ELAN Touchscreen at I2C: 00:10 -- NOT FOUND, skipping [INFO ] \_SB.PCI0.I2C1.H016: ELAN Touchscreen at I2C: 00:16 [SPEW ] I2C TX abort detected (00000001) [SPEW ] \_SB.PCI0.I2C1.H05D: Goodix Touchscreen at I2C: 00:5d -- NOT FOUND, skipping [SPEW ] I2C TX abort detected (00000001) [SPEW ] \_SB.PCI0.I2C1.H040: G2TOUCH Touchscreen at I2C: 00:40 -- NOT FOUND, skipping [SPEW ] I2C TX abort detected (00000001) [SPEW ] \_SB.PCI0.I2C1.H03C: WDT Touchscreen at I2C: 00:3c -- NOT FOUND, skipping [INFO ] \_SB.PCI0.I2C3.CRUS: Cirrus Logic CS42l42 Audio Codec address 048h irq 0 [SPEW ] I2C TX abort detected (00000001) [SPEW ] \_SB.PCI0.I2C5.D015: ELAN Touchpad at I2C: 00:15 -- NOT FOUND, skipping [INFO ] \_SB.PCI0.I2C5.H02C: Goodix Touchpad at I2C: 00:2c ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/77538?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I66f12ae478f74c019c53ee5e77f7e0f9c324e758 Gerrit-Change-Number: 77538 Gerrit-PatchSet: 6 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Comment-Date: Wed, 04 Oct 2023 10:15:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <ericllai(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: configs: Clean up config.google.skyrim.with_binaries defconfig
by Felix Held (Code Review) 04 Oct '23

04 Oct '23

Attention is currently required from: Matt DeVillier, Paul Menzel. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78195?usp=email ) Change subject: configs: Clean up config.google.skyrim.with_binaries defconfig ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File configs/config.google_skyrim.with_binaries: https://review.coreboot.org/c/coreboot/+/78195/comment/3a51c192_017e21d2 : PS1, Line 11: CONFIG_FSP_M_FILE="3rdparty/amd_blobs/mendocino/MENDOCINO_M.fd" : CONFIG_FSP_S_FILE="3rdparty/amd_blobs/mendocino/MENDOCINO_S.fd" > those are the defaults for mendocino now, so those two lines should probably just be dropped. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/78195?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6d355b838d30dca64a9e6206eb6000763cc105a1 Gerrit-Change-Number: 78195 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 04 Oct 2023 09:59:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/geralt: Remove SAMSUNG_ATANA33XC20 panel support
by Felix Held (Code Review) 04 Oct '23

04 Oct '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78210?usp=email ) Change subject: mb/google/geralt: Remove SAMSUNG_ATANA33XC20 panel support ...................................................................... mb/google/geralt: Remove SAMSUNG_ATANA33XC20 panel support This panel is never actually enabled on Geralt. The derived project won't use this panel either. Therefore, remove this panel support. BUG=none BRANCH=none TEST=emerge-geralt coreboot Change-Id: I97ed5b341724ed42098b2c17d0eb75eab881dbb1 Signed-off-by: Yidi Lin <yidilin(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78210 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> --- M src/mainboard/google/geralt/panel_geralt.c 1 file changed, 0 insertions(+), 19 deletions(-) Approvals: build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved diff --git a/src/mainboard/google/geralt/panel_geralt.c b/src/mainboard/google/geralt/panel_geralt.c index 443703d..455f759 100644 --- a/src/mainboard/google/geralt/panel_geralt.c +++ b/src/mainboard/google/geralt/panel_geralt.c @@ -24,11 +24,6 @@ gpio_output(GPIO_MIPI_BL_PWM_1V8, 0); } -static void configure_edp_backlight(void) -{ - gpio_output(GPIO_AP_DISP_BKLTEN, 0); -} - static void power_on_mipi_boe_tv110c9m_ll0(void) { const struct tps65132s_reg_setting reg_settings[] = { @@ -61,13 +56,6 @@ mdelay(6); } -static void power_on_edp_samsung_atana33xc20(void) -{ - gpio_output(GPIO_EN_PP3300_EDP_DISP_X, 1); - gpio_set_pull(GPIO_EDP_HPD_1V8, GPIO_PULL_ENABLE, GPIO_PULL_UP); - gpio_set_mode(GPIO_EDP_HPD_1V8, 4); -} - static struct panel_description panels[] = { [1] = { .name = "BOE_TV110C9M_LL0", @@ -76,13 +64,6 @@ .disp_path = DISP_PATH_MIPI, .pwm_ctrl_gpio = true, }, - [11] = { - .name = "SAMSUNG_ATANA33XC20", - .power_on = power_on_edp_samsung_atana33xc20, - .configure_panel_backlight = configure_edp_backlight, - .disp_path = DISP_PATH_EDP, - .pwm_ctrl_gpio = false, - }, }; struct panel_description *get_panel_description(uint32_t panel_id) -- To view, visit https://review.coreboot.org/c/coreboot/+/78210?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I97ed5b341724ed42098b2c17d0eb75eab881dbb1 Gerrit-Change-Number: 78210 Gerrit-PatchSet: 4 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in coreboot[main]: mb/google/geralt: Update voltage mapping tables for RAM ID and LCMD ID
by Felix Held (Code Review) 04 Oct '23

04 Oct '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78209?usp=email ) Change subject: mb/google/geralt: Update voltage mapping tables for RAM ID and LCMD ID ...................................................................... mb/google/geralt: Update voltage mapping tables for RAM ID and LCMD ID The tolerance of ADC voltage table is too small. Update the table values accordring to the suggestion from the hardware team. The patch is prepared for the derived projects. There is no actual issue now. BRANCH=none BUG=b:301908091 TEST=check firmware screen Change-Id: I3bde30b6bbe79c81e276f23f4110715c3278d42c Signed-off-by: Yidi Lin <yidilin(a)chromium.org> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78209 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Yu-Ping Wu <yupingso(a)google.com> --- M src/mainboard/google/geralt/boardid.c 1 file changed, 23 insertions(+), 27 deletions(-) Approvals: build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved diff --git a/src/mainboard/google/geralt/boardid.c b/src/mainboard/google/geralt/boardid.c index 3a08c6d..4c53a81 100644 --- a/src/mainboard/google/geralt/boardid.c +++ b/src/mainboard/google/geralt/boardid.c @@ -9,7 +9,7 @@ /* board_id is provided by ec/google/chromeec/ec_boardid.c */ -#define ADC_LEVELS 12 +#define ADC_LEVELS 8 enum { /* RAM IDs */ @@ -20,38 +20,34 @@ PANEL_ID_LOW_CHANNEL = 5, }; -static const unsigned int ram_voltages[ADC_LEVELS] = { +static const unsigned int ram_voltages[] = { /* ID : Voltage (unit: uV) */ - [0] = 74300, - [1] = 211700, - [2] = 318800, - [3] = 428600, - [4] = 541700, - [5] = 665800, - [6] = 781400, - [7] = 900000, - [8] = 1023100, - [9] = 1137000, - [10] = 1240000, - [11] = 1342600, + [0] = 74296, + [1] = 211673, + [2] = 365055, + [3] = 524272, + [4] = 706302, + [5] = 899119, + [6] = 1108941, + [7] = 1342616, }; -static const unsigned int panel_voltages[ADC_LEVELS] = { +_Static_assert(ARRAY_SIZE(ram_voltages) == ADC_LEVELS, "Wrong array size of ram_voltages"); + +static const unsigned int panel_voltages[] = { /* ID : Voltage (unit: uV) */ - [0] = 0, - [1] = 283000, - [2] = 394000, - [3] = 503000, - [4] = 608000, - [5] = 712000, - [6] = 823000, - [7] = 937000, - [8] = 1046000, - [9] = 1155000, - [10] = 1277000, - [11] = 1434000, + [0] = 0, + [1] = 282774, + [2] = 472379, + [3] = 652542, + [4] = 830258, + [5] = 1011767, + [6] = 1209862, + [7] = 1427880, }; +_Static_assert(ARRAY_SIZE(panel_voltages) == ADC_LEVELS, "Wrong array size of panel_voltages"); + static const unsigned int *adc_voltages[] = { [RAM_ID_LOW_CHANNEL] = ram_voltages, [RAM_ID_HIGH_CHANNEL] = ram_voltages, -- To view, visit https://review.coreboot.org/c/coreboot/+/78209?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3bde30b6bbe79c81e276f23f4110715c3278d42c Gerrit-Change-Number: 78209 Gerrit-PatchSet: 4 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[main]: mb/google/brya/var/yavilla: Add VCM power control sequence
by Felix Held (Code Review) 04 Oct '23

04 Oct '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78170?usp=email ) Change subject: mb/google/brya/var/yavilla: Add VCM power control sequence ...................................................................... mb/google/brya/var/yavilla: Add VCM power control sequence Add VCM power control to configure 2.8V and reset pin, and VCM can be powered on/off properly. BUG=b:292907385 TEST=Run ITS test Change-Id: I242025836fd50076a40ffcc4e5d4a5d5bc6fb4d0 Signed-off-by: Serin Yeh <serin.yeh(a)intel.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/78170 Reviewed-by: Derek Huang <derekhuang(a)google.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/brya/variants/yavilla/overridetree.cb 1 file changed, 18 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Derek Huang: Looks good to me, approved Serin Yeh: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/brya/variants/yavilla/overridetree.cb b/src/mainboard/google/brya/variants/yavilla/overridetree.cb index d31a8f9..ee5a3b6 100644 --- a/src/mainboard/google/brya/variants/yavilla/overridetree.cb +++ b/src/mainboard/google/brya/variants/yavilla/overridetree.cb @@ -375,12 +375,11 @@ register "gpio_panel.gpio[2].gpio_num" = "GPP_D3" # WCAM_RST_L #_ON - register "on_seq.ops_cnt" = "5" + register "on_seq.ops_cnt" = "4" register "on_seq.ops[0]" = "SEQ_OPS_CLK_ENABLE(0, 0)" register "on_seq.ops[1]" = "SEQ_OPS_GPIO_ENABLE(0, 5)" register "on_seq.ops[2]" = "SEQ_OPS_GPIO_ENABLE(1, 5)" - register "on_seq.ops[3]" = "SEQ_OPS_GPIO_DISABLE(2, 5)" - register "on_seq.ops[4]" = "SEQ_OPS_GPIO_ENABLE(2, 5)" + register "on_seq.ops[3]" = "SEQ_OPS_GPIO_ENABLE(2, 5)" #_OFF register "off_seq.ops_cnt" = "4" @@ -400,6 +399,22 @@ register "device_type" = "INTEL_ACPI_CAMERA_VCM" register "vcm_compat" = ""dongwoon,dw9714"" + register "has_power_resource" = "1" + register "max_dstate_for_probe" = "ACPI_DEVICE_SLEEP_D3_COLD" + + #Controls + register "gpio_panel.gpio[0].gpio_num" = "GPP_D15" # EN_PP2800_WCAM_X + register "gpio_panel.gpio[1].gpio_num" = "GPP_D3" # WCAM_RST_L + + #_ON + register "on_seq.ops_cnt" = "2" + register "on_seq.ops[0]" = "SEQ_OPS_GPIO_ENABLE(0, 5)" + register "on_seq.ops[1]" = "SEQ_OPS_GPIO_ENABLE(1, 5)" + + #_OFF + register "off_seq.ops_cnt" = "2" + register "off_seq.ops[1]" = "SEQ_OPS_GPIO_DISABLE(1, 0)" + register "off_seq.ops[0]" = "SEQ_OPS_GPIO_DISABLE(0, 0)" device i2c 0C on probe WFC WFC_MIPI_OVTI8856 -- To view, visit https://review.coreboot.org/c/coreboot/+/78170?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I242025836fd50076a40ffcc4e5d4a5d5bc6fb4d0 Gerrit-Change-Number: 78170 Gerrit-PatchSet: 2 Gerrit-Owner: Serin Yeh <serin.yeh(a)intel.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Serin Yeh <serin.yeh(a)intel.corp-partner.google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Andy Yeh <andy.yeh(a)intel.com> Gerrit-CC: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: merged

1 0

[XS] Change in coreboot[main]: mb/starlabs/starbook/{adl,rpl}: Remove unnecessary entries
by Felix Held (Code Review) 04 Oct '23

04 Oct '23

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/78198?usp=email ) Change subject: mb/starlabs/starbook/{adl,rpl}: Remove unnecessary entries ...................................................................... mb/starlabs/starbook/{adl,rpl}: Remove unnecessary entries Certain devices are enabled in Alder Lakes chipset.cb, so remove them from the devicetree. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I929af0bed6c2e1024b4787424a8fe466edce5a36 Reviewed-on: https://review.coreboot.org/c/coreboot/+/78198 Reviewed-by: Matt DeVillier <matt.devillier(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/starlabs/starbook/variants/adl/devicetree.cb M src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb 2 files changed, 0 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved diff --git a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb index ed48757..50c54b9 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/adl/devicetree.cb @@ -93,7 +93,6 @@ device generic 0 on end end end - device ref heci1 on end device ref sata on register "sata_salp_support" = "1" register "sata_ports_enable[1]" = "1" diff --git a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb index 976f990..1eaab18 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb +++ b/src/mainboard/starlabs/starbook/variants/rpl/devicetree.cb @@ -113,7 +113,6 @@ device generic 0 on end end end - device ref heci1 on end device ref pcie_rp5 on # WiFi chip drivers/wifi/generic register "wake" = "GPE0_PME_B0" -- To view, visit https://review.coreboot.org/c/coreboot/+/78198?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I929af0bed6c2e1024b4787424a8fe466edce5a36 Gerrit-Change-Number: 78198 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023