Ivan Jager has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78239?usp=email )
Change subject: cbfs: Restore 32-bit padding in cbfs_header
......................................................................
cbfs: Restore 32-bit padding in cbfs_header
It was changed from a fixed size 1 array to a to a flexible array
in 242bac0e162ca9a9258f61b0674b0dced5bcc01a
which resulted in a change to the serialized format as the
header size was no longer the same.
That broke other tools that read CBFS files, like diffoscope
https://github.com/NixOS/nixpkgs/issues/256896
Change-Id: I4199dcc4823469c5986ac967a55b1c85cc62f780
Signed-off-by: Ivan Jager <aij+git(a)mrph.org>
---
M src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/78239/1
diff --git a/src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h b/src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h
index 07d3d9d..cebaf83 100644
--- a/src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h
+++ b/src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h
@@ -60,7 +60,7 @@
uint32_t align; /* fixed to 64 bytes */
uint32_t offset;
uint32_t architecture;
- uint32_t pad[];
+ uint32_t pad[1];
} __packed;
/* this used to be flexible, but wasn't ever set to something different. */
--
To view, visit https://review.coreboot.org/c/coreboot/+/78239?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4199dcc4823469c5986ac967a55b1c85cc62f780
Gerrit-Change-Number: 78239
Gerrit-PatchSet: 1
Gerrit-Owner: Ivan Jager
Gerrit-MessageType: newchange
Attention is currently required from: David Wu, Eran Mitrani, Kapil Porwal, Subrata Banik, Tarun.
Tyler Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78254?usp=email )
Change subject: mb/google/rex/var/karis: Correct devicetree touchscreen settings
......................................................................
Patch Set 5:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/78254?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6c7815b81eb47fb41e58233fde512ac6b9c000a7
Gerrit-Change-Number: 78254
Gerrit-PatchSet: 5
Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Comment-Date: Thu, 05 Oct 2023 12:16:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Eran Mitrani, Kane Chen, Kapil Porwal, Paul Menzel, Ravishankar Sarawadi, Tarun.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78252?usp=email )
Change subject: soc/intel/meteorlake: Reserve IOE P2SB MMIO correctly
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/78252?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie55f7975277b390f776e44596c42e426ba9cd235
Gerrit-Change-Number: 78252
Gerrit-PatchSet: 3
Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Comment-Date: Thu, 05 Oct 2023 12:15:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Eran Mitrani, Eric Lai, Kapil Porwal, Paul Menzel, Ravishankar Sarawadi, Tarun.
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78252?usp=email )
Change subject: soc/intel/meteorlake: Reserve IOE P2SB MMIO correctly
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78252/comment/5a7f032a_96505cf8 :
PS2, Line 10: code requires
> … code that requires …?
Done
https://review.coreboot.org/c/coreboot/+/78252/comment/7442d190_3bb097a6 :
PS2, Line 11: insrc/soc/intel/common/acpi/pcie_clk.asl
> Missing space after *in*.
Done
https://review.coreboot.org/c/coreboot/+/78252/comment/7db91648_9079b8a0 :
PS2, Line 13: TEST=suspend_stress_test 50 cycle pass, type-c display OK on screebo
> Did it also succeed before your change?
yes, i just wanted to make sure no regression.
--
To view, visit https://review.coreboot.org/c/coreboot/+/78252?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie55f7975277b390f776e44596c42e426ba9cd235
Gerrit-Change-Number: 78252
Gerrit-PatchSet: 3
Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Comment-Date: Thu, 05 Oct 2023 11:51:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Eran Mitrani, Eric Lai, Kane Chen, Kapil Porwal, Ravishankar Sarawadi, Tarun.
Hello Eran Mitrani, Eric Lai, Kapil Porwal, Ravishankar Sarawadi, Subrata Banik, Tarun, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/78252?usp=email
to look at the new patch set (#3).
Change subject: soc/intel/meteorlake: Reserve IOE P2SB MMIO correctly
......................................................................
soc/intel/meteorlake: Reserve IOE P2SB MMIO correctly
The original code only reserves IOM mmio, but there is other asl
code that requires to program ioe p2sb mmio such as IOE PCIE clk request
control. See \_SB.ECLK.CLKD in src/soc/intel/common/acpi/pcie_clk.asl
TEST=suspend_stress_test 50 cycle pass, type-c display OK on screebo
Change-Id: Ie55f7975277b390f776e44596c42e426ba9cd235
Signed-off-by: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
---
M src/soc/intel/meteorlake/p2sb.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/78252/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/78252?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie55f7975277b390f776e44596c42e426ba9cd235
Gerrit-Change-Number: 78252
Gerrit-PatchSet: 3
Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Eran Mitrani, Eric Lai, Kane Chen, Kapil Porwal, Ravishankar Sarawadi, Tarun.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78252?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/intel/meteorlake: Reserve IOE P2SB MMIO correctly
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78252/comment/20cd9659_c3b4299c :
PS2, Line 10: code requires
… code that requires …?
https://review.coreboot.org/c/coreboot/+/78252/comment/73600659_e5083fa1 :
PS2, Line 11: insrc/soc/intel/common/acpi/pcie_clk.asl
Missing space after *in*.
https://review.coreboot.org/c/coreboot/+/78252/comment/cde0a920_6b43dd78 :
PS2, Line 13: TEST=suspend_stress_test 50 cycle pass, type-c display OK on screebo
Did it also succeed before your change?
--
To view, visit https://review.coreboot.org/c/coreboot/+/78252?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie55f7975277b390f776e44596c42e426ba9cd235
Gerrit-Change-Number: 78252
Gerrit-PatchSet: 2
Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Eric Lai <ericllai(a)google.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com>
Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Comment-Date: Thu, 05 Oct 2023 11:49:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Eran Mitrani, Kapil Porwal, Sukumar Ghorai, Tarun.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78250?usp=email )
Change subject: mb/google/{rex,ovis}: Disable package C-state auto demotion for rex & ovis
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
LTGM, @Kapil will test and get back
--
To view, visit https://review.coreboot.org/c/coreboot/+/78250?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ia4cf4a7cb6bd5eaae26197b55f9385c078960d7b
Gerrit-Change-Number: 78250
Gerrit-PatchSet: 3
Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Comment-Date: Thu, 05 Oct 2023 11:48:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Eran Mitrani, Eric Lai, Jakub Czapiga, Kapil Porwal, Sumeet R Pawnikar, Tarun.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78180?usp=email )
Change subject: mb/google/rex/var/rex0: update dptf thermal settings
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/78180?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6580652d6165946e98ecf1b46ace3352cd34dcdf
Gerrit-Change-Number: 78180
Gerrit-PatchSet: 2
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun <tstuli(a)gmail.com>
Gerrit-Attention: Eran Mitrani <mitrani(a)google.com>
Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tarun <tstuli(a)gmail.com>
Gerrit-Comment-Date: Thu, 05 Oct 2023 11:47:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment