coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[XS] Change in coreboot[main]: soc/intel/meteorlake: Reserve IOE P2SB MMIO correctly
by Kane Chen (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Eran Mitrani, Eric Lai, Kane Chen, Kapil Porwal, Ravishankar Sarawadi, Subrata Banik, Tarun. Hello Eran Mitrani, Eric Lai, Kapil Porwal, Ravishankar Sarawadi, Subrata Banik, Tarun, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78252?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by Eric Lai, Verified+1 by build bot (Jenkins) Change subject: soc/intel/meteorlake: Reserve IOE P2SB MMIO correctly ...................................................................... soc/intel/meteorlake: Reserve IOE P2SB MMIO correctly The original code only reserves IOM mmio, but there is other asl code requires to program ioe p2sb mmio such as IOE PCIE clk request control. See \_SB.ECLK.CLKD insrc/soc/intel/common/acpi/pcie_clk.asl TEST=suspend_stress_test 50 cycle pass, type-c display OK on screebo Change-Id: Ie55f7975277b390f776e44596c42e426ba9cd235 Signed-off-by: Kane Chen <kane.chen(a)intel.corp-partner.google.com> --- M src/soc/intel/meteorlake/p2sb.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/78252/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78252?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ie55f7975277b390f776e44596c42e426ba9cd235 Gerrit-Change-Number: 78252 Gerrit-PatchSet: 2 Gerrit-Owner: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kane Chen <kane.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/karis: Correct touchscreen settings
by Tyler Wang (Code Review) 05 Oct '23

05 Oct '23

Tyler Wang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78254?usp=email ) Change subject: mb/google/rex/var/karis: Correct touchscreen settings ...................................................................... mb/google/rex/var/karis: Correct touchscreen settings If use "detect = 1" in touchscreen setting, it will be no function. Set overridetree touchscreen setting from "detect = 1" to "probe = 1", make touchscreen can be probed by ACPI. BUG=b:303130400 TEST=emerge-rex coreboot Change-Id: I6c7815b81eb47fb41e58233fde512ac6b9c000a7 --- M src/mainboard/google/rex/variants/karis/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/78254/1 diff --git a/src/mainboard/google/rex/variants/karis/overridetree.cb b/src/mainboard/google/rex/variants/karis/overridetree.cb index 98769de..30a5c2d 100644 --- a/src/mainboard/google/rex/variants/karis/overridetree.cb +++ b/src/mainboard/google/rex/variants/karis/overridetree.cb @@ -369,7 +369,7 @@ register "generic.hid" = ""ELAN90FC"" register "generic.desc" = ""ELAN Touchscreen"" register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C07_IRQ)" - register "generic.detect" = "1" + register "generic.probed" = "1" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C01)" register "generic.reset_delay_ms" = "150" register "generic.reset_off_delay_ms" = "1" -- To view, visit https://review.coreboot.org/c/coreboot/+/78254?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6c7815b81eb47fb41e58233fde512ac6b9c000a7 Gerrit-Change-Number: 78254 Gerrit-PatchSet: 1 Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

[M] Change in coreboot[main]: mb/google/geralt: Update voltage mapping tables for RAM ID and LCMD ID
by 9elements QA (Code Review) 05 Oct '23

05 Oct '23

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78209?usp=email ) Change subject: mb/google/geralt: Update voltage mapping tables for RAM ID and LCMD ID ...................................................................... Patch Set 4: Automatic boot test returned (PASS/FAIL/TOTAL): 11 / 1 / 12 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES_ and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/187099 PASS: x86_32 "Hermes CFL" , build config PRODRIVE_HERMES and payload TianoCore_UefiPayloadPkg : https://lava.9esec.io/r/187097 PASS: x86_32 "ThinkPad T500" , build config LENOVO_T500 and payload SeaBIOS : https://lava.9esec.io/r/187096 PASS: x86_32 "HP Z220 SFF Workstation" , build config HP_Z220_SFF_WORKSTATION and payload LinuxBoot_BB_kexec : https://lava.9esec.io/r/187095 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload TianoCore : https://lava.9esec.io/r/187094 PASS: x86_64 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC.X86_64 and payload SeaBIOS : https://lava.9esec.io/r/187093 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload TianoCore : https://lava.9esec.io/r/187092 PASS: x86_32 "HP Compaq 8200 Elite SFF PC" , build config HP_COMPAQ_8200_ELITE_SFF_PC and payload SeaBIOS : https://lava.9esec.io/r/187091 FAIL: x86_64 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_X86_64 and payload SeaBIOS : https://lava.9esec.io/r/187090 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ASAN and payload SeaBIOS : https://lava.9esec.io/r/187089 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX_ and payload SeaBIOS : https://lava.9esec.io/r/187088 PASS: x86_32 "QEMU x86 i440fx/piix4" , build config EMULATION_QEMU_X86_I440FX and payload SeaBIOS : https://lava.9esec.io/r/187087 Please note: This test is under development and might not be accurate at all! -- To view, visit https://review.coreboot.org/c/coreboot/+/78209?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I3bde30b6bbe79c81e276f23f4110715c3278d42c Gerrit-Change-Number: 78209 Gerrit-PatchSet: 4 Gerrit-Owner: Yidi Lin <yidilin(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 05 Oct 2023 11:20:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/pirrha: Turn off SD card power signal in s0ix
by Eric Lai (Code Review) 05 Oct '23

05 Oct '23

Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/77998?usp=email ) Change subject: mb/google/nissa/var/pirrha: Turn off SD card power signal in s0ix ...................................................................... mb/google/nissa/var/pirrha: Turn off SD card power signal in s0ix Turn off GPP_H13 (EN_PP3300_SD_X) in s0ix for power saving. It reduces about 3mW of power consumption in s0ix on pirrha proto board. BUG=b:300845527 TEST=Built and verified GPP_H13 voltage was 0V in s0ix. Also verified SD card worked after s0ix for 20 times. Change-Id: I5ec53820276e50f5b8b01584595118cf2dc4c95c Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/77998 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org> Reviewed-by: Derek Huang <derekhuang(a)google.com> Reviewed-by: Eric Lai <ericllai(a)google.com> --- M src/mainboard/google/brya/variants/pirrha/Makefile.inc M src/mainboard/google/brya/variants/pirrha/include/variant/gpio.h A src/mainboard/google/brya/variants/pirrha/variant.c 3 files changed, 19 insertions(+), 0 deletions(-) Approvals: Derek Huang: Looks good to me, approved Eric Lai: Looks good to me, approved build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve diff --git a/src/mainboard/google/brya/variants/pirrha/Makefile.inc b/src/mainboard/google/brya/variants/pirrha/Makefile.inc index bc560b8..c74104c 100644 --- a/src/mainboard/google/brya/variants/pirrha/Makefile.inc +++ b/src/mainboard/google/brya/variants/pirrha/Makefile.inc @@ -4,4 +4,5 @@ romstage-y += memory.c ramstage-$(CONFIG_FW_CONFIG) += fw_config.c +ramstage-$(CONFIG_FW_CONFIG) += variant.c ramstage-y += gpio.c diff --git a/src/mainboard/google/brya/variants/pirrha/include/variant/gpio.h b/src/mainboard/google/brya/variants/pirrha/include/variant/gpio.h index c4fe342..b98b09d 100644 --- a/src/mainboard/google/brya/variants/pirrha/include/variant/gpio.h +++ b/src/mainboard/google/brya/variants/pirrha/include/variant/gpio.h @@ -5,4 +5,6 @@ #include <baseboard/gpio.h> +#define SD_CARD_POWER GPP_H13 + #endif diff --git a/src/mainboard/google/brya/variants/pirrha/variant.c b/src/mainboard/google/brya/variants/pirrha/variant.c new file mode 100644 index 0000000..1b8c263 --- /dev/null +++ b/src/mainboard/google/brya/variants/pirrha/variant.c @@ -0,0 +1,16 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <chip.h> +#include <baseboard/variants.h> +#include <variant/gpio.h> +#include <acpi/acpigen.h> + +void variant_generate_s0ix_hook(enum s0ix_entry entry) +{ + return; + + if (entry == S0IX_ENTRY) + acpigen_soc_clear_tx_gpio(SD_CARD_POWER); + else if (entry == S0IX_EXIT) + acpigen_soc_set_tx_gpio(SD_CARD_POWER); +} -- To view, visit https://review.coreboot.org/c/coreboot/+/77998?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5ec53820276e50f5b8b01584595118cf2dc4c95c Gerrit-Change-Number: 77998 Gerrit-PatchSet: 4 Gerrit-Owner: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Shou-Chieh Hsu <shouchieh(a)google.com> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: mb/google/rex/var/karis: sync CBI FW_CONFIG definitions
by Eric Lai (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Eran Mitrani, Jakub Czapiga, Tarun, YH Lin. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78182?usp=email ) Change subject: mb/google/rex/var/karis: sync CBI FW_CONFIG definitions ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78182?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e4965c009edc595f24c04ac82d81aa0e723bbf3 Gerrit-Change-Number: 78182 Gerrit-PatchSet: 1 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 05 Oct 2023 10:17:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex/var/karis: add hook for WiFi SAR table
by Eric Lai (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Eran Mitrani, Jakub Czapiga, Tarun, YH Lin. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78181?usp=email ) Change subject: mb/google/rex/var/karis: add hook for WiFi SAR table ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/mainboard/google/rex/variants/karis/variant.c: https://review.coreboot.org/c/coreboot/+/78181/comment/d9bf9dbb_2bd6ce83 : PS1, Line 3: #include <chip.h> please reorder the headers. -- To view, visit https://review.coreboot.org/c/coreboot/+/78181?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic989024ab9eb0fc439fc701c335a85986c4cfec5 Gerrit-Change-Number: 78181 Gerrit-PatchSet: 1 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 05 Oct 2023 10:17:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/nissa/var/joxer: Config I2C frequency
by Eric Lai (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Felix Held, Ivan Chen, Mark Hsieh, Nick Vaccaro, Subrata Banik, Tarun Tuli. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78218?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: mb/google/nissa/var/joxer: Config I2C frequency ...................................................................... Patch Set 1: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78218/comment/e8ac5731_ecf7872e : PS1, Line 9: Measured the I2C frequency meets spec. It would be good if you list the speed before and after change. -- To view, visit https://review.coreboot.org/c/coreboot/+/78218?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I17dd1cb7800d00669f86fc6e2b350757695da881 Gerrit-Change-Number: 78218 Gerrit-PatchSet: 1 Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Derek Huang <derekhuang(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Ivan Chen <yulunchen(a)google.com> Gerrit-Attention: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 05 Oct 2023 10:16:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/myst: Enable CBFS Verification
by Eric Lai (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Jon Murphy, Karthik Ramasubramanian, Tim Van Patten. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78235?usp=email ) Change subject: mb/google/myst: Enable CBFS Verification ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78235?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I2dd3ce59f331f89660185309ccf60c53d50e4fad Gerrit-Change-Number: 78235 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jon Murphy <jpmurphy(a)google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 05 Oct 2023 10:11:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex/var/rex0: update dptf thermal settings
by Eric Lai (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Eran Mitrani, Eric Lai, Jakub Czapiga, Kapil Porwal, Subrata Banik, Sumeet R Pawnikar, Tarun. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78180?usp=email ) Change subject: mb/google/rex/var/rex0: update dptf thermal settings ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78180?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6580652d6165946e98ecf1b46ace3352cd34dcdf Gerrit-Change-Number: 78180 Gerrit-PatchSet: 2 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 05 Oct 2023 10:09:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[XS] Change in coreboot[main]: mb/google/{rex,ovis}: Disable package C-state auto demotion for rex &...
by Eric Lai (Code Review) 05 Oct '23

05 Oct '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Subrata Banik, Sukumar Ghorai, Tarun. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78250?usp=email ) Change subject: mb/google/{rex,ovis}: Disable package C-state auto demotion for rex & ovis ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/78250/comment/15beb167_368676c3 : PS3, Line 7: for rex & ovis no need, already in the title -- To view, visit https://review.coreboot.org/c/coreboot/+/78250?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ia4cf4a7cb6bd5eaae26197b55f9385c078960d7b Gerrit-Change-Number: 78250 Gerrit-PatchSet: 3 Gerrit-Owner: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Sukumar Ghorai <sukumar.ghorai(a)intel.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Thu, 05 Oct 2023 10:07:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023