coreboot-gerrit October 2023

coreboot-gerrit@coreboot.org

1 participants
3354 discussions

[XS] Change in coreboot[main]: mb/google/rex/var/karis: sync CBI FW_CONFIG definitions
by Subrata Banik (Code Review) 09 Oct '23

09 Oct '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Tarun, YH Lin. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78261?usp=email ) Change subject: mb/google/rex/var/karis: sync CBI FW_CONFIG definitions ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78261?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1e4965c009edc595f24c04ac82d81aa0e723bbf3 Gerrit-Change-Number: 78261 Gerrit-PatchSet: 2 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Mon, 09 Oct 2023 03:44:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/rex/var/karis: add hook for WiFi SAR table
by Subrata Banik (Code Review) 09 Oct '23

09 Oct '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Tarun, YH Lin. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78260?usp=email ) Change subject: mb/google/rex/var/karis: add hook for WiFi SAR table ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78260?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Ic989024ab9eb0fc439fc701c335a85986c4cfec5 Gerrit-Change-Number: 78260 Gerrit-PatchSet: 2 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Mon, 09 Oct 2023 03:44:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: mb/google/rex/var/rex0: update thermal settings to start fan earlier
by Sumeet R Pawnikar (Code Review) 09 Oct '23

09 Oct '23

Attention is currently required from: Eran Mitrani, Eric Lai, Eric Lai, Jakub Czapiga, Kapil Porwal, Subrata Banik, Tarun. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78180?usp=email ) Change subject: mb/google/rex/var/rex0: update thermal settings to start fan earlier ...................................................................... Patch Set 7: (1 comment) Patchset: PS7: As per the comment from Build bot, submitted the same patch on main branch https://review.coreboot.org/c/coreboot/+/78279 -- To view, visit https://review.coreboot.org/c/coreboot/+/78180?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6580652d6165946e98ecf1b46ace3352cd34dcdf Gerrit-Change-Number: 78180 Gerrit-PatchSet: 7 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Eric Lai <ericllai(a)google.com> Gerrit-Reviewer: Jakub Czapiga <czapiga(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eric Lai <ericllai(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jakub Czapiga <czapiga(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Mon, 09 Oct 2023 03:33:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: mb/google/rex/var/rex0: update thermal settings to start fan earlier
by Sumeet R Pawnikar (Code Review) 09 Oct '23

09 Oct '23

Sumeet R Pawnikar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/78279?usp=email ) Change subject: mb/google/rex/var/rex0: update thermal settings to start fan earlier ...................................................................... mb/google/rex/var/rex0: update thermal settings to start fan earlier Internal testing showed that CPU heatsink gets hot and temperature goes over 75C. In this situation, the fan does not even start to lower down CPU temperature. This is because of existing temperature thresholds of TSR0 and TSR1 sensors are set at 45C to start fan. With updated new settings based on tuning from thermal team, the fan starts early at 43C for TSR0 and TSR1 so the CPU temperature stays below 75C. BUG=b:302673874 TEST=Built and tested on google/rex board Signed-off-by: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.com> Change-Id: I6580652d6165946e98ecf1b46ace3352cd34dcdf --- M src/mainboard/google/rex/variants/rex0/overridetree.cb 1 file changed, 14 insertions(+), 14 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/78279/1 diff --git a/src/mainboard/google/rex/variants/rex0/overridetree.cb b/src/mainboard/google/rex/variants/rex0/overridetree.cb index 1d4ba63..034a694 100644 --- a/src/mainboard/google/rex/variants/rex0/overridetree.cb +++ b/src/mainboard/google/rex/variants/rex0/overridetree.cb @@ -186,25 +186,25 @@ [0] = { .target = DPTF_TEMP_SENSOR_0, .thresholds = { - TEMP_PCT(75, 90), - TEMP_PCT(70, 80), - TEMP_PCT(65, 70), - TEMP_PCT(60, 60), - TEMP_PCT(55, 50), - TEMP_PCT(50, 40), - TEMP_PCT(45, 30), + TEMP_PCT(70, 97), + TEMP_PCT(65, 90), + TEMP_PCT(60, 80), + TEMP_PCT(55, 75), + TEMP_PCT(50, 65), + TEMP_PCT(45, 45), + TEMP_PCT(43, 30), } }, [1] = { .target = DPTF_TEMP_SENSOR_1, .thresholds = { - TEMP_PCT(75, 90), - TEMP_PCT(70, 80), - TEMP_PCT(65, 70), - TEMP_PCT(60, 60), - TEMP_PCT(55, 50), - TEMP_PCT(50, 40), - TEMP_PCT(45, 30), + TEMP_PCT(70, 97), + TEMP_PCT(65, 90), + TEMP_PCT(60, 80), + TEMP_PCT(55, 75), + TEMP_PCT(50, 65), + TEMP_PCT(45, 45), + TEMP_PCT(43, 30), } }, [2] = { -- To view, visit https://review.coreboot.org/c/coreboot/+/78279?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I6580652d6165946e98ecf1b46ace3352cd34dcdf Gerrit-Change-Number: 78279 Gerrit-PatchSet: 1 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-MessageType: newchange

1 0

[XS] Change in coreboot[main]: mb/google/rex/var/karis: sync CBI FW_CONFIG definitions
by Sumeet R Pawnikar (Code Review) 09 Oct '23

09 Oct '23

Attention is currently required from: Eran Mitrani, Kapil Porwal, Subrata Banik, Tarun, YH Lin. Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78261?usp=email ) Change subject: mb/google/rex/var/karis: sync CBI FW_CONFIG definitions ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78261?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I1e4965c009edc595f24c04ac82d81aa0e723bbf3 Gerrit-Change-Number: 78261 Gerrit-PatchSet: 2 Gerrit-Owner: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tarun <tstuli(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Tarun <tstuli(a)gmail.com> Gerrit-Comment-Date: Mon, 09 Oct 2023 03:12:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[main]: util/amdfwtool: Check for pkg-config presence
by Raul Rangel (Code Review) 09 Oct '23

09 Oct '23

Attention is currently required from: Felix Held, Karthik Ramasubramanian, Martin Roth. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78191?usp=email ) Change subject: util/amdfwtool: Check for pkg-config presence ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78191?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: I5d604145c919e7f71680d1e095dc68cb21868319 Gerrit-Change-Number: 78191 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 09 Oct 2023 01:57:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/dedede: Wait for HPD on dibbi variants
by Sam McNally (Code Review) 09 Oct '23

09 Oct '23

Attention is currently required from: Reka Norman. Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78294?usp=email ) Change subject: mb/google/dedede: Wait for HPD on dibbi variants ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78294?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id4657b5d5a95a68ecbd9efcf3585cf96ad1e13e1 Gerrit-Change-Number: 78294 Gerrit-PatchSet: 2 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-CC: Derek Huang <derekhuang(a)google.com> Gerrit-CC: Ricky Chang <rickytlchang(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Comment-Date: Mon, 09 Oct 2023 00:25:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/dedede: Wait for HPD on dibbi variants
by Reka Norman (Code Review) 09 Oct '23

09 Oct '23

Attention is currently required from: Sam McNally. Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78294?usp=email ) Change subject: mb/google/dedede: Wait for HPD on dibbi variants ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/dedede/mainboard.c: https://review.coreboot.org/c/coreboot/+/78294/comment/f363fe56_939b0ebf : PS1, Line 54: printk(BIOS_WARNING, "No HPD GPIOs, skip waiting\n"); > `return;`? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/78294?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id4657b5d5a95a68ecbd9efcf3585cf96ad1e13e1 Gerrit-Change-Number: 78294 Gerrit-PatchSet: 2 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-CC: Derek Huang <derekhuang(a)google.com> Gerrit-CC: Ricky Chang <rickytlchang(a)google.com> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Comment-Date: Mon, 09 Oct 2023 00:25:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sam McNally <sammc(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[main]: mb/google/dedede: Wait for HPD on dibbi variants
by Reka Norman (Code Review) 09 Oct '23

09 Oct '23

Attention is currently required from: Reka Norman. Hello Sam McNally, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/78294?usp=email to look at the new patch set (#2). Change subject: mb/google/dedede: Wait for HPD on dibbi variants ...................................................................... mb/google/dedede: Wait for HPD on dibbi variants Some Type-C monitors do not immediately assert HPD. If we enter FSP-S before HDP is asserted, display initialisation may fail. So wait for HPD. This is similar to commit b40c6009141e ("mainboard/hatch: Fix puff DP output on cold boots") on puff, except we don't use google_chromeec_wait_for_displayport() since that EC command was removed for TCPMv2 (https://crrev.com/c/4221975). Instead we use the HPD signals only. By waiting for any HPD signal (Type-C or HDMI), we skip waiting if HDMI is connected, which is the same behaviour as puff and fizz. TEST=On dibbi, connect a display via a Type-C to HDMI dongle and check the dev and recovery screens are now displayed correctly. Also check the logs in the following cases: Cold reboot in dev mode, Type-C to HDMI dongle: HPD ready after 800 ms Warm reboot in dev mode, Type-C to HDMI dongle: HPD ready after 0 ms Cold/warm reboot in dev mode, direct Type-C: HPD ready after 0 ms Cold/warm reboot in dev mode, direct HDMI: HPD ready after 0 ms Cold/warm reboot in dev mode, no display: HPD not ready after 3000 ms. Abort. Change-Id: Id4657b5d5a95a68ecbd9efcf3585cf96ad1e13e1 Signed-off-by: Reka Norman <rekanorman(a)chromium.org> --- M src/mainboard/google/dedede/mainboard.c M src/mainboard/google/dedede/variants/baseboard/gpio.c M src/mainboard/google/dedede/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/dedede/variants/boxy/gpio.c M src/mainboard/google/dedede/variants/dibbi/gpio.c M src/mainboard/google/dedede/variants/taranza/gpio.c 6 files changed, 105 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/78294/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/78294?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id4657b5d5a95a68ecbd9efcf3585cf96ad1e13e1 Gerrit-Change-Number: 78294 Gerrit-PatchSet: 2 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-CC: Derek Huang <derekhuang(a)google.com> Gerrit-CC: Ricky Chang <rickytlchang(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[main]: mb/google/dedede: Wait for HPD on dibbi variants
by Sam McNally (Code Review) 09 Oct '23

09 Oct '23

Attention is currently required from: Reka Norman. Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78294?usp=email ) Change subject: mb/google/dedede: Wait for HPD on dibbi variants ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/dedede/mainboard.c: https://review.coreboot.org/c/coreboot/+/78294/comment/f7d977aa_5186d571 : PS1, Line 54: printk(BIOS_WARNING, "No HPD GPIOs, skip waiting\n"); `return;`? -- To view, visit https://review.coreboot.org/c/coreboot/+/78294?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: main Gerrit-Change-Id: Id4657b5d5a95a68ecbd9efcf3585cf96ad1e13e1 Gerrit-Change-Number: 78294 Gerrit-PatchSet: 1 Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-CC: Derek Huang <derekhuang(a)google.com> Gerrit-CC: Ricky Chang <rickytlchang(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Comment-Date: Mon, 09 Oct 2023 00:22:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2023