Attention is currently required from: Jamie Chen, Tarun Tuli, Ian Feng.
Hello build bot (Jenkins), Tarun Tuli, Dtrain Hsu, Ian Feng,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/71703
to look at the new patch set (#3).
Change subject: mb/google/brya/var/omnigul: use i2c1 for TPM
......................................................................
mb/google/brya/var/omnigul: use i2c1 for TPM
This change sets DRIVER_TPM_I2C_BUS to the i2c 1 bus for TPM for the
omnigul variant.
BUG=b:263060849
TEST=FW_NAME=omnigul emerge-brya coreboot
Change-Id: I42528d73a4f83bd409cb4a1bd51f2e4e82ee7804
Signed-off-by: jamie_chen <jamie_chen(a)compal.corp-partner.google.com>
---
M src/mainboard/google/brya/Kconfig
1 file changed, 16 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/71703/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/71703
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42528d73a4f83bd409cb4a1bd51f2e4e82ee7804
Gerrit-Change-Number: 71703
Gerrit-PatchSet: 3
Gerrit-Owner: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tarun Tuli, Kangheui Won, Reka Norman.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71677 )
Change subject: mb/google/nissa: Disable stage cache
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/71677/comment/7b40f7eb_dcb8e4e6
PS3, Line 10: don't care about
nit: can ignore
--
To view, visit https://review.coreboot.org/c/coreboot/+/71677
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8015dc0808ee19cac67c2a6573d52781c6120e8c
Gerrit-Change-Number: 71677
Gerrit-PatchSet: 3
Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Reka Norman <rekanorman(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Comment-Date: Thu, 05 Jan 2023 09:56:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli, Subrata Banik, Kangheui Won, Reka Norman, Angel Pons, Arthur Heymans.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71676 )
Change subject: Kconfig: Allow mainboards to disable stage cache
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/71676
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I243a401a112a12bb824c5447a8fecc99500f7739
Gerrit-Change-Number: 71676
Gerrit-PatchSet: 3
Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Reka Norman <rekanorman(a)google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Thu, 05 Jan 2023 09:53:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jamie Chen, Tarun Tuli, Ian Feng.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71702 )
Change subject: mb/google/brya/var/omnigul: use RPL FSP headers
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/71702
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a0afb04bea4940e13ea62c2cd0a09500b8b5335
Gerrit-Change-Number: 71702
Gerrit-PatchSet: 1
Gerrit-Owner: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 05 Jan 2023 09:46:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jamie Chen, Tarun Tuli, Ian Feng.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71703 )
Change subject: mb/google/brya/var/omnigul: use i2c1 for TPM for omnigul
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/71703/comment/a1452c2f_7e19aabd
PS1, Line 7: for omnigul
remove?
https://review.coreboot.org/c/coreboot/+/71703/comment/29485b30_9423c94a
PS1, Line 12: NA
Please fill in bug id.
--
To view, visit https://review.coreboot.org/c/coreboot/+/71703
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I42528d73a4f83bd409cb4a1bd51f2e4e82ee7804
Gerrit-Change-Number: 71703
Gerrit-PatchSet: 1
Gerrit-Owner: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 05 Jan 2023 09:43:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tarun Tuli.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71705 )
Change subject: Revert "Revert "mb/google/brya: Add romstage early graphics for brya""
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167728):
https://review.coreboot.org/c/coreboot/+/71705/comment/d0302cad_43784bb2
PS1, Line 11: Reason for revert: Reland commit 96d9b756690839c17b307a93b8a1898bd1c02ff5.
Possible unwrapped commit description (prefer a maximum 72 chars per line)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167728):
https://review.coreboot.org/c/coreboot/+/71705/comment/80ed940d_998f84ed
PS1, Line 11: Reason for revert: Reland commit 96d9b756690839c17b307a93b8a1898bd1c02ff5.
Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 96d9b7566908 ("mb/google/brya: Add romstage early graphics for brya")'
--
To view, visit https://review.coreboot.org/c/coreboot/+/71705
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I356af2b5289beed0a0f38d939f2df7242f65c345
Gerrit-Change-Number: 71705
Gerrit-PatchSet: 1
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com>
Gerrit-Comment-Date: Thu, 05 Jan 2023 09:38:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Paul Menzel, Pratikkumar V Prajapati.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71118 )
Change subject: soc/intel/common: Add Kconfig option for Intel Key Locker
......................................................................
Patch Set 13:
(1 comment)
File src/soc/intel/common/block/cpu/Kconfig:
https://review.coreboot.org/c/coreboot/+/71118/comment/07dc286b_98011b0e
PS13, Line 173: ification.html
can you indent the line?
--
To view, visit https://review.coreboot.org/c/coreboot/+/71118
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia78e9bfe7ba2fd4e45b4821c95b19b8e580dccab
Gerrit-Change-Number: 71118
Gerrit-PatchSet: 13
Gerrit-Owner: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Pratikkumar V Prajapati <pratikkumar.v.prajapati(a)intel.com>
Gerrit-Comment-Date: Thu, 05 Jan 2023 09:37:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin L Roth.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71704 )
Change subject: util/kconfig: use HOST_EXTRACFLAGS for menuconfig
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167727):
https://review.coreboot.org/c/coreboot/+/71704/comment/3eab22a5_89225bea
PS1, Line 12: This change enables using `bitbake coreboot -c menuconfig`
'sepcifies' may be misspelled - perhaps 'specifies'?
--
To view, visit https://review.coreboot.org/c/coreboot/+/71704
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I20c088c6566415a0c43f5a65109c7100e985eb15
Gerrit-Change-Number: 71704
Gerrit-PatchSet: 1
Gerrit-Owner: Aske <aske(a)geanix.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Thu, 05 Jan 2023 09:31:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment