coreboot-gerrit January 2023

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

[M] Change in coreboot[master]: soc/intel/alderlake: Inform user of memory training
by Tarun Tuli (Code Review) 05 Jan '23

05 Jan '23

Attention is currently required from: Bora Guvendik, Anil Kumar K, Hannah Williams, Cliff Huang, Jérémy Compostella, Paul Menzel, Angel Pons, Arthur Heymans, Andrey Petrov, Zhixing Ma, Nico Huber, Michał Żygowski, Subrata Banik, Nick Vaccaro. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70300 ) Change subject: soc/intel/alderlake: Inform user of memory training ...................................................................... Patch Set 42: Code-Review+1 (2 comments) Patchset: PS42: pending closure on free'ing File src/soc/intel/alderlake/romstage/fsp_params.c: https://review.coreboot.org/c/coreboot/+/70300/comment/cf5a4e38_3d00fd7f PS42, Line 372: "Your device is finishing an update. This may take 1-2 minutes.\nPlease do not turn off your device."); wondering if we want to pass const char* instead. However, I recognized this will probably get all reworked with localization in place so probably okay for now. -- To view, visit https://review.coreboot.org/c/coreboot/+/70300 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4ea15123eed1a4355c5ff7d815925032d4151de0 Gerrit-Change-Number: 70300 Gerrit-PatchSet: 42 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Comment-Date: Thu, 05 Jan 2023 15:12:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Documentation/getting_started: Add information about ost2
by Kacper Stojek (Code Review) 05 Jan '23

05 Jan '23

Attention is currently required from: Michał Żygowski, Paul Menzel. Kacper Stojek has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70853 ) Change subject: Documentation/getting_started: Add information about ost2 ...................................................................... Patch Set 4: (4 comments) File Documentation/getting_started/OST2.md: https://review.coreboot.org/c/coreboot/+/70853/comment/2b61eaac_ae9e2c59 PS2, Line 7: There are various ways to learn firmware, some are more efficient than others, > Please add a blank line above, or do not wrap the line. Done https://review.coreboot.org/c/coreboot/+/70853/comment/85d5e244_b7291e12 PS2, Line 13: cc BY-SA > Which version? https://creativecommons.org/licenses/by-sa/1.0/ […] Done https://review.coreboot.org/c/coreboot/+/70853/comment/3e2cb20c_89bab216 PS2, Line 27: There are more courses, which can be found [here](https://p.ost2.fyi/courses). > Please add the missing new line at the end of file. Done https://review.coreboot.org/c/coreboot/+/70853/comment/9e76cac8_c8897335 PS2, Line 27: more courses > Make *more courses* the link. (Maybe add *available*. […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/70853 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd97996579576b35588fc0db42c16ee20d961760 Gerrit-Change-Number: 70853 Gerrit-PatchSet: 4 Gerrit-Owner: Kacper Stojek Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 05 Jan 2023 14:53:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: Documentation/getting_started: Add information about ost2
by Kacper Stojek (Code Review) 05 Jan '23

05 Jan '23

Attention is currently required from: Xeno Kovah, Kacper Stojek. Hello build bot (Jenkins), Maciej Pijanowski, Piotr Król, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/70853 to look at the new patch set (#4). Change subject: Documentation/getting_started: Add information about ost2 ...................................................................... Documentation/getting_started: Add information about ost2 Add links to OpenSecurityTraining2 courses for newcommers Signed-off-by: Kacper Stojek <kacper.stojek(a)3mdeb.com> Change-Id: Ifd97996579576b35588fc0db42c16ee20d961760 --- A Documentation/getting_started/OST2.md M Documentation/getting_started/index.md 2 files changed, 46 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/70853/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/70853 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd97996579576b35588fc0db42c16ee20d961760 Gerrit-Change-Number: 70853 Gerrit-PatchSet: 4 Gerrit-Owner: Kacper Stojek Gerrit-Reviewer: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Xeno Kovah <xeno(a)ost.fyi> Gerrit-Attention: Kacper Stojek Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: soc/intel/common/block/early_graphics: Introduce a 200 ms delay
by Tarun Tuli (Code Review) 05 Jan '23

05 Jan '23

Attention is currently required from: Jérémy Compostella. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71656 ) Change subject: soc/intel/common/block/early_graphics: Introduce a 200 ms delay ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File src/soc/intel/common/block/graphics/early_graphics.c: https://review.coreboot.org/c/coreboot/+/71656/comment/78f2f795_d2d34e73 PS5, Line 41: * turning off the displays and the PEIM driver initialization is too nit: reference a specific bug b:264526798 -- To view, visit https://review.coreboot.org/c/coreboot/+/71656 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4ea15123eed1a4355c5ff7d815925032d4151de1 Gerrit-Change-Number: 71656 Gerrit-PatchSet: 5 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Comment-Date: Thu, 05 Jan 2023 14:47:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: Revert "Revert "mb/google/brya: Add romstage early graphics for brya""
by Tarun Tuli (Code Review) 05 Jan '23

05 Jan '23

Attention is currently required from: Jakub Czapiga, Jeremy Compostella. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71705 ) Change subject: Revert "Revert "mb/google/brya: Add romstage early graphics for brya"" ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/71705 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I356af2b5289beed0a0f38d939f2df7242f65c345 Gerrit-Change-Number: 71705 Gerrit-PatchSet: 1 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jeremy Compostella <jeremy.compostella(a)gmail.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Jeremy Compostella <jeremy.compostella(a)gmail.com> Gerrit-Comment-Date: Thu, 05 Jan 2023 14:36:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/meteorlake: provide a list of D-states to enter LPM
by Tarun Tuli (Code Review) 05 Jan '23

05 Jan '23

Attention is currently required from: Eran Mitrani, Subrata Banik. Tarun Tuli has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71644 ) Change subject: soc/intel/meteorlake: provide a list of D-states to enter LPM ...................................................................... Patch Set 7: (1 comment) File src/soc/intel/meteorlake/acpi.c: https://review.coreboot.org/c/coreboot/+/71644/comment/30a73e0b_5c0515bb PS1, Line 172: // { SA_DEVFN_CPU_PCIE1_0, ACPI_DEVICE_SLEEP_D3 }, : { SA_DEVFN_IGD, ACPI_DEVICE_SLEEP_D3 }, : { PCI_DEVFN_DPTF, ACPI_DEVICE_SLEEP_D3 }, : { PCI_DEVFN_IPU, ACPI_DEVICE_SLEEP_D3 }, : // { SA_DEVFN_CPU_PCIE6_0, ACPI_DEVICE_SLEEP_D3 }, : // { SA_DEVFN_CPU_PCIE6_2, ACPI_DEVICE_SLEEP_D3 }, : { PCI_DEVFN_TBT0, ACPI_DEVICE_SLEEP_D3 }, : { PCI_DEVFN_TBT1, ACPI_DEVICE_SLEEP_D3 }, : { PCI_DEVFN_TBT2, ACPI_DEVICE_SLEEP_D3 }, : { PCI_DEVFN_TBT3, ACPI_DEVICE_SLEEP_D3 }, : { PCI_DEVFN_GNA, ACPI_DEVICE_SLEEP_D3 }, : { PCI_DEVFN_TCSS_XHCI, ACPI_DEVICE_SLEEP_D3 }, : { PCI_DEVFN_TCSS_XDCI, ACPI_DEVICE_SLEEP_D3 }, : { SA_DEVFN_TCSS_DMA0, ACPI_DEVICE_SLEEP_D3 }, : { SA_DEVFN_TCSS_DMA1, ACPI_DEVICE_SLEEP_D3 }, : { PCI_DEVFN_VMD, ACPI_DEVICE_SLEEP_D3 }, : // { PCH_DEVFN_I2C6, ACPI_DEVICE_SLEEP_D3 }, : // { PCH_DEVFN_I2C7, ACPI_DEVICE_SLEEP_D3 }, > Tarun, […] They were based on some educated assumptions. These would be most impacted by the downstream peripheral. I think they would be fine to leave as D3. -- To view, visit https://review.coreboot.org/c/coreboot/+/71644 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If367511a29726669fe25ad2124e2f9b877a31ee8 Gerrit-Change-Number: 71644 Gerrit-PatchSet: 7 Gerrit-Owner: Eran Mitrani <mitrani(a)google.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eran Mitrani <mitrani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Comment-Date: Thu, 05 Jan 2023 14:35:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eran Mitrani <mitrani(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: mb/intel/mtlrvp: Add romstage and configure DDR5 memory parts
by Harsha B R (Code Review) 05 Jan '23

05 Jan '23

Attention is currently required from: Ashish Kumar Mishra, Wonkyu Kim, Ravishankar Sarawadi, Rizwan Qureshi, Angel Pons, Eric Lai, Tarun Tuli, Jamie Ryu, Tim Wawrzynczak, Kapil Porwal, Nick Vaccaro, Ronak Kanabar, Raj Astekar, Elyes Haouas. Harsha B R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66190 ) Change subject: mb/intel/mtlrvp: Add romstage and configure DDR5 memory parts ...................................................................... Patch Set 23: (1 comment) Patchset: PS23: > Should we die in coreboot, or let it assert and return from FSP? @Subrata, WDYT? @Eric, The implementation has been carried from the previous platform. The reason of making this statement here in coreboot than returning the control to FSP is, we have the board_id check in coreboot itself and however if this doesn't die in coreboot, the control shall return to FSP and die there (invalid condition). This even preserves the fail context wrt coreboot and FSP. Please do let us know your view here. -- To view, visit https://review.coreboot.org/c/coreboot/+/66190 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0e1a26d99e170311a89412f44b7cbb0430788f58 Gerrit-Change-Number: 66190 Gerrit-PatchSet: 23 Gerrit-Owner: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Harsha B R <harsha.b.r(a)intel.com> Gerrit-Reviewer: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-CC: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com> Gerrit-Attention: Ashish Kumar Mishra <ashish.k.mishra(a)intel.com> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Jamie Ryu <jamie.m.ryu(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Thu, 05 Jan 2023 14:32:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: soc/intel/common/block: Add Intel VGA early graphics support
by Arthur Heymans (Code Review) 05 Jan '23

05 Jan '23

Attention is currently required from: Bora Guvendik, Anil Kumar K, Hannah Williams, Cliff Huang, Jérémy Compostella, Paul Menzel, Zhixing Ma, Tarun Tuli, Nico Huber, Michał Żygowski, Subrata Banik, Kapil Porwal, Swift Geek (Sebastian Grzywna). Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70299 ) Change subject: soc/intel/common/block: Add Intel VGA early graphics support ...................................................................... Patch Set 27: (1 comment) File src/soc/intel/common/block/graphics/early_graphics.c: https://review.coreboot.org/c/coreboot/+/70299/comment/12836e49_db8ce08b PS27, Line 6: initialized > do we have support for global variables? Only .bss is supported in cache as ram stages, which is zero initialized data. .data (non zero initialized) is not supported. static variables default to 0. -- To view, visit https://review.coreboot.org/c/coreboot/+/70299 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie4ad1215e5fadd0adc1271b6bd6ddb0ea258cb5b Gerrit-Change-Number: 70299 Gerrit-PatchSet: 27 Gerrit-Owner: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Boris Mittelberg <bmbm(a)google.com> Gerrit-Reviewer: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Hannah Williams <hannah.williams(a)intel.com> Gerrit-CC: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Hannah Williams <hannah.williams(a)intel.com> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Zhixing Ma <zhixing.ma(a)intel.com> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Attention: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Comment-Date: Thu, 05 Jan 2023 13:42:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: [WIP] mb/amd/birman: Move EC FW to FMAP
by Fred Reitberger (Code Review) 05 Jan '23

05 Jan '23

Attention is currently required from: Bao Zheng, Jason Glenesk, ritul guru, Felix Held. Fred Reitberger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70695 ) Change subject: [WIP] mb/amd/birman: Move EC FW to FMAP ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > I assume putting to 0x81000 is a must. The EC can be placed at any offset that ends in 00. The first four bytes of the ROM are a signature that tells the EC where to look for its binary. To move the EC.bin anywhere, the only necessary change is the EC_sig.bin -- To view, visit https://review.coreboot.org/c/coreboot/+/70695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b19d92043790b10acd20fbfdf394d5bd67b8295 Gerrit-Change-Number: 70695 Gerrit-PatchSet: 2 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: ritul guru <ritul.bits(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 05 Jan 2023 12:59:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-MessageType: comment

1 0

[L] Change in coreboot[master]: mb/google/brya/var/omnigul: Update GPIO settings
by Jamie Chen (Code Review) 05 Jan '23

05 Jan '23

Attention is currently required from: Tarun Tuli. Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71706 ) Change subject: mb/google/brya/var/omnigul: Update GPIO settings ...................................................................... Patch Set 3: (2 comments) File src/mainboard/google/brya/variants/omnigul/gpio.c: https://review.coreboot.org/c/coreboot/+/71706/comment/b9d7c261_e103679e PS2, Line 73: resolved https://review.coreboot.org/c/coreboot/+/71706/comment/e0bed8e6_c42368dc PS2, Line 73: > trailing whitespace resolved -- To view, visit https://review.coreboot.org/c/coreboot/+/71706 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5cfaa8fce6df7f09b744fb3e0b7b1d5b6acdc79b Gerrit-Change-Number: 71706 Gerrit-PatchSet: 3 Gerrit-Owner: Jamie Chen <jamie_chen(a)compal.corp-partner.google.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Comment-Date: Thu, 05 Jan 2023 12:54:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit January 2023