coreboot-gerrit September 2022

coreboot-gerrit@coreboot.org

1 participants
4678 discussions

[L] Change in coreboot[master]: util/amdfwtool/amdfwread: List AMDFW RO binary entries
by Karthik Ramasubramanian (Code Review) 02 Sep '22

02 Sep '22

Attention is currently required from: Karthik Ramasubramanian, Felix Held. Hello build bot (Jenkins), Robert Zieba, Raul Rangel, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/66761 to look at the new patch set (#5). Change subject: util/amdfwtool/amdfwread: List AMDFW RO binary entries ...................................................................... util/amdfwtool/amdfwread: List AMDFW RO binary entries Add support to walk through PSP L1, PSP L2, BIOS L1, BIOS L2 directories and list the entries present in them. Accommodate both recovery A/B layout and normal layout. This is required to identify the location and size of each entries in the finally built amdfw.rom. This in turn can be used to perform any platform specific verification on the relevant components. BUG=None TEST=Build and list the contents of AMDFW binary. /usr/bin/amdfwread --ro-list /build/skyrim/firmware/image-skyrim.bin PSPL1: 0x48 0xd92000 0x00001000 PSPL1: 0x4a 0xd92000 0x00001000 PSPL2: 0x00 0xc31000 0x00000440 PSPL2: 0x01 0xc31500 0x00007580 PSPL2: 0x08 0xc38b00 0x0001f1a0 PSPL2: 0x02 0xc57d00 0x00016470 PSPL2: 0x09 0xc6e200 0x00000440 PSPL2: 0x0c 0xc6e700 0x00023100 PSPL2: 0x12 0xc91800 0x00015780 PSPL2: 0x0b Flag Not an Address PSPL2: 0x13 0xca7000 0x000021c0 PSPL2: 0x20 0xca9200 0x00000640 PSPL2: 0x21 0xca9900 0x00000030 PSPL2: 0x22 0xcaa000 0x00001000 PSPL2: 0x24 0xcab000 0x00003b60 PSPL2: 0x28 0xcaec00 0x00021890 PSPL2: 0x2d 0xcd0500 0x00003100 PSPL2: 0x3c 0xcd3600 0x000018c0 PSPL2: 0x45 0xcd4f00 0x00001c70 PSPL2: 0x44 0xcd6c00 0x00006610 PSPL2: 0x50 0xcdd300 0x00001a00 PSPL2: 0x51 0xcded00 0x00001020 PSPL2: 0x55 0xcdfe00 0x000005a0 PSPL2: 0x5a 0xce0400 0x00000570 PSPL2: 0x71 0xce0a00 0x00024710 PSPL2: 0x5c 0xd05200 0x00000b20 PSPL2: 0x73 0xd05e00 0x0000f640 PSPL2: 0x8d 0xd15500 0x00000030 PSPL2: 0x30 0xd15600 0x0006b550 PSPL2: 0x3a 0xd80c00 0x000006d0 PSPL2: 0x52 0xd81300 0x0000f7c0 PSPL2: 0x49 0xd93000 0x00001000 BIOSL2: 0x60 0xd94000 0x00009924 BIOSL2: 0x68 0xd9e000 0x00009924 BIOSL2: 0x61 DRAM Address BIOSL2: 0x62 0xda7a00 0x00010000 BIOSL2: 0x63 0x0 0x0001e000 BIOSL2: 0x64 0xdacd00 0x000062b0 BIOSL2: 0x65 0xdb3000 0x000004e0 BIOSL2: 0x64 0xdb3500 0x00005d30 BIOSL2: 0x65 0xdb9300 0x00000250 BIOSL2: 0x6b DRAM Address Change-Id: Ia1b8f1a2b9bc7dc6925a305cdff1442aaff182cd Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> --- M util/amdfwtool/amdfwread.c 1 file changed, 258 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/66761/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/66761 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia1b8f1a2b9bc7dc6925a305cdff1442aaff182cd Gerrit-Change-Number: 66761 Gerrit-PatchSet: 5 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: util/amdfwtool/amdfwread: Handle recovery A/B layout
by Karthik Ramasubramanian (Code Review) 02 Sep '22

02 Sep '22

Attention is currently required from: Bao Zheng, Rob Barnes, Karthik Ramasubramanian, Felix Held. Hello build bot (Jenkins), Robert Zieba, Bao Zheng, Raul Rangel, Rob Barnes, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/66554 to look at the new patch set (#7). Change subject: util/amdfwtool/amdfwread: Handle recovery A/B layout ...................................................................... util/amdfwtool/amdfwread: Handle recovery A/B layout Upcoming AMD SoCs use recovery A/B layout. Update amdfwread tool to handle it. Also add a generic read_header function to read different header types. BUG=None TEST=Run amdfwread tool against both Skyrim and Guybrush BIOS images to dump the Softfuse entry. Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> Change-Id: I6576eaebc611ab338885aed2ee087bf85da3ca15 --- M util/amdfwtool/amdfwread.c 1 file changed, 77 insertions(+), 15 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/66554/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/66554 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6576eaebc611ab338885aed2ee087bf85da3ca15 Gerrit-Change-Number: 66554 Gerrit-PatchSet: 7 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: util/amdfwtool/amdfwread: Fix AMDFW_OPT* bit mask
by Karthik Ramasubramanian (Code Review) 02 Sep '22

02 Sep '22

Attention is currently required from: Robert Zieba, Rob Barnes, Karthik Ramasubramanian, Felix Held. Hello Robert Zieba, build bot (Jenkins), Raul Rangel, Rob Barnes, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/66573 to look at the new patch set (#6). Change subject: util/amdfwtool/amdfwread: Fix AMDFW_OPT* bit mask ...................................................................... util/amdfwtool/amdfwread: Fix AMDFW_OPT* bit mask Optional arguments that involve printing information from the firmware image is mapped to bit fields with bit 31 set. But instead of just setting bit 31, bits 27 - 31 are set. Fix AMDFW_OPT* bit mask. BUG=None TEST=Build and use amdfwread to read the Soft-fuse bits from Guybrush BIOS image. Observed no changes before and after the changes. Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> Change-Id: I0d88669bace45f3332c5e56527516b2f38295a48 --- M util/amdfwtool/amdfwread.c 1 file changed, 28 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/66573/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/66573 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d88669bace45f3332c5e56527516b2f38295a48 Gerrit-Change-Number: 66573 Gerrit-PatchSet: 6 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: util/amdfwtool/amdfwread: Update relative_offset function
by Karthik Ramasubramanian (Code Review) 02 Sep '22

02 Sep '22

Attention is currently required from: Rob Barnes, Karthik Ramasubramanian, Felix Held. Hello build bot (Jenkins), Robert Zieba, Raul Rangel, Rob Barnes, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/66572 to look at the new patch set (#6). Change subject: util/amdfwtool/amdfwread: Update relative_offset function ...................................................................... util/amdfwtool/amdfwread: Update relative_offset function * AMD_ADDR_PHYSICAL refers to physical address in the memory map * AMD_ADDR_REL_BIOS is relative to the start of the BIOS image * AMD_ADDR_REL_TAB is relative to the start of concerned PSP or BIOS tables Update the relative_offset implementation accordingly. Though AMD_ADDR_REL_SLOT is defined it is not used. Removing that to simplify the relative_offset implementation so that it can be used for both PSP and BIOS firmware tables. Hence update the relative_offset function signature as well. BUG=None TEST=Build and use amdfwread to read the Soft-fuse bits from Guybrush BIOS image. Observed no changes before and after the changes. Change-Id: I74603dd08eda87393c14b746c4435eaf2bb34126 Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> --- M util/amdfwtool/amdfwread.c 1 file changed, 38 insertions(+), 19 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/66572/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/66572 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74603dd08eda87393c14b746c4435eaf2bb34126 Gerrit-Change-Number: 66572 Gerrit-PatchSet: 6 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: cpu/x86/lapic.h: Fix CONFIG_X2APIC_RUNTIME
by Kyösti Mälkki (Code Review) 02 Sep '22

02 Sep '22

Attention is currently required from: Arthur Heymans. Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67239 ) Change subject: cpu/x86/lapic.h: Fix CONFIG_X2APIC_RUNTIME ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/67239/comment/2f91cb25_10cae370 PS1, Line 10: the cpu is in x2apic mode. > > Are you sure it deadlocks without this? There is some discussion about the lack or serializations […] CB:60213 tries to explain the X2APIC_ONLY case. -- To view, visit https://review.coreboot.org/c/coreboot/+/67239 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6a71204fcff35e11613fc8363ce061b348e73496 Gerrit-Change-Number: 67239 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Fri, 02 Sep 2022 20:16:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/docker/coreboot-jenkins-node: Install cmocka
by Felix Singer (Code Review) 02 Sep '22

02 Sep '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/67272 ) Change subject: util/docker/coreboot-jenkins-node: Install cmocka ...................................................................... util/docker/coreboot-jenkins-node: Install cmocka flashrom uses cmocka for unit testing. Install it so that the CI can use it. Change-Id: I5c168e480d6f4cbfbbd175ecb035c88bfcbac00b Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/67272 Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M util/docker/coreboot-jenkins-node/Dockerfile 1 file changed, 17 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/util/docker/coreboot-jenkins-node/Dockerfile b/util/docker/coreboot-jenkins-node/Dockerfile index e11c25d..4a0c95f 100644 --- a/util/docker/coreboot-jenkins-node/Dockerfile +++ b/util/docker/coreboot-jenkins-node/Dockerfile @@ -25,6 +25,7 @@ RUN apt-get -y update && \ apt-get -y install \ default-jre-headless \ + libcmocka-dev \ liblua5.3-dev \ linkchecker \ lua5.3 \ -- To view, visit https://review.coreboot.org/c/coreboot/+/67272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c168e480d6f4cbfbbd175ecb035c88bfcbac00b Gerrit-Change-Number: 67272 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: merged

1 0

[S] Change in coreboot[master]: util/docker/coreboot-jenkins-node: Install cmocka
by Angel Pons (Code Review) 02 Sep '22

02 Sep '22

Attention is currently required from: Felix Singer, Nico Huber, Patrick Georgi, Martin L Roth, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67272 ) Change subject: util/docker/coreboot-jenkins-node: Install cmocka ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/67272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c168e480d6f4cbfbbd175ecb035c88bfcbac00b Gerrit-Change-Number: 67272 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Fri, 02 Sep 2022 18:38:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/docker/coreboot-jenkins-node: Install cmocka
by Felix Singer (Code Review) 02 Sep '22

02 Sep '22

Attention is currently required from: Nico Huber, Patrick Georgi, Martin L Roth, Thomas Heijligen. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67272 ) Change subject: util/docker/coreboot-jenkins-node: Install cmocka ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > It seems a little odd, all the other flashrom dependencies are also in coreboot-sdk. […] Removed coreboot from the commit message. -- To view, visit https://review.coreboot.org/c/coreboot/+/67272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c168e480d6f4cbfbbd175ecb035c88bfcbac00b Gerrit-Change-Number: 67272 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Fri, 02 Sep 2022 18:37:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Patrick Georgi <patrick(a)coreboot.org> Gerrit-MessageType: comment

1 0

[S] Change in coreboot[master]: util/docker/coreboot-jenkins-node: Install cmocka
by Felix Singer (Code Review) 02 Sep '22

02 Sep '22

Attention is currently required from: Martin L Roth, Thomas Heijligen. Hello build bot (Jenkins), Patrick Georgi, Martin L Roth, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/67272 to look at the new patch set (#4). Change subject: util/docker/coreboot-jenkins-node: Install cmocka ...................................................................... util/docker/coreboot-jenkins-node: Install cmocka flashrom uses cmocka for unit testing. Install it so that the CI can use it. Change-Id: I5c168e480d6f4cbfbbd175ecb035c88bfcbac00b Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M util/docker/coreboot-jenkins-node/Dockerfile 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/67272/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/67272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c168e480d6f4cbfbbd175ecb035c88bfcbac00b Gerrit-Change-Number: 67272 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: skyrim/overridetree: Enable DPTC and No Battery Mode
by Raul Rangel (Code Review) 02 Sep '22

02 Sep '22

Attention is currently required from: Jason Nien, Tim Van Patten. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67211 ) Change subject: skyrim/overridetree: Enable DPTC and No Battery Mode ...................................................................... Patch Set 3: (1 comment) File src/mainboard/google/skyrim/variants/skyrim/overridetree.cb: https://review.coreboot.org/c/coreboot/+/67211/comment/435ea537_de844919 PS3, Line 261: # Throttle (e.g., Low/No Battery) : register "vrm_current_limit_throttle_mA" = "20000" : register "vrm_maximum_current_limit_throttle_mA" = "20000" : register "vrm_soc_current_limit_throttle_mA" = "10000" I would set the values in this CL since it's the CL that enables the feature. Maybe move the `register "dptc_no_battery_mode_enable" = true` right below the `# Throttle` comment so it's obvious that bit is guarding these fields. -- To view, visit https://review.coreboot.org/c/coreboot/+/67211 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icc4084476916cc8e142908d8e58baf7124568b8b Gerrit-Change-Number: 67211 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Van Patten <timvp(a)google.com> Gerrit-Reviewer: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Nien <jason.nien(a)amd.corp-partner.google.com> Gerrit-Attention: Tim Van Patten <timvp(a)google.com> Gerrit-Comment-Date: Fri, 02 Sep 2022 18:00:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2022