coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: Makefile.inc: Move adding bootblock non-x86 targets
by Arthur Heymans (Code Review) 01 Apr '22

01 Apr '22

Attention is currently required from: Martin Roth. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63217 ) Change subject: Makefile.inc: Move adding bootblock non-x86 targets ...................................................................... Patch Set 2: (1 comment) File Makefile.inc: https://review.coreboot.org/c/coreboot/+/63217/comment/f5e269f5_311ea628 PS2, Line 1122: ifeq ($(CONFIG_ARCH_X86),y) looks like I messed up ^^ -- To view, visit https://review.coreboot.org/c/coreboot/+/63217 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I50eae4f00d171d26a221ca969086f4f294fa524b Gerrit-Change-Number: 63217 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Fri, 01 Apr 2022 16:39:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/spd_tools: Add ability to override SPD file for parts
by Robert Zieba (Code Review) 01 Apr '22

01 Apr '22

Attention is currently required from: Reka Norman, Rob Barnes, Karthik Ramasubramanian. Robert Zieba has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63281 ) Change subject: util/spd_tools: Add ability to override SPD file for parts ...................................................................... Patch Set 3: (2 comments) File util/spd_tools/README.md: https://review.coreboot.org/c/coreboot/+/63281/comment/870a6add_07dfe445 PS2, Line 467: * for in the spd directory, if it is not found there then it will be searched for in the > This order should be reversed. i.e. a local SPD file should override the common SPD file. Done https://review.coreboot.org/c/coreboot/+/63281/comment/6cf7a004_34fa5a7a PS2, Line 478: H5AN8G6NDJR-XNC,8 > I assume there's nothing preventing using one of the common generic SPDs here. e.g. […] Correct -- To view, visit https://review.coreboot.org/c/coreboot/+/63281 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I078dd04fead2bf19f53bc6ca8295187d439adc20 Gerrit-Change-Number: 63281 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Peers <epeers(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 01 Apr 2022 16:37:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rob Barnes <robbarnes(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/apl: Drop cbfs bootblock
by Arthur Heymans (Code Review) 01 Apr '22

01 Apr '22

Attention is currently required from: Andrey Petrov. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63225 ) Change subject: soc/intel/apl: Drop cbfs bootblock ...................................................................... Patch Set 2: (1 comment) File src/soc/intel/apollolake/Makefile.inc: https://review.coreboot.org/c/coreboot/+/63225/comment/17291d91_d9796710 PS1, Line 154: 0x40 > use 64 too... Done -- To view, visit https://review.coreboot.org/c/coreboot/+/63225 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8e70e080765dd7306074a8cf71c8795b8fbbb8a2 Gerrit-Change-Number: 63225 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Fri, 01 Apr 2022 16:37:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: Add new CPU ID
by Lean Sheng Tan (Code Review) 01 Apr '22

01 Apr '22

Lean Sheng Tan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63302 ) Change subject: soc/intel/alderlake: Add new CPU ID ...................................................................... soc/intel/alderlake: Add new CPU ID Add new CPU ID 0x906A3 (L0 stepping). Signed-off-by: Lean Sheng Tan <sheng.tan(a)9elements.com> Change-Id: I280da46e5fdd3792df50556e2804b3bcb346eee3 --- M src/include/cpu/intel/cpu_ids.h M src/soc/intel/alderlake/bootblock/report_platform.c M src/soc/intel/common/block/cpu/mp_init.c 3 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/63302/1 diff --git a/src/include/cpu/intel/cpu_ids.h b/src/include/cpu/intel/cpu_ids.h index f0c1baf..6d36851 100644 --- a/src/include/cpu/intel/cpu_ids.h +++ b/src/include/cpu/intel/cpu_ids.h @@ -54,6 +54,7 @@ #define CPUID_ALDERLAKE_J0 0x906a0 #define CPUID_ALDERLAKE_Q0 0x906a1 #define CPUID_ALDERLAKE_K0 0x906a2 +#define CPUID_ALDERLAKE_L0 0x906a3 #define CPUID_ALDERLAKE_R0 0x906a4 #define CPUID_ALDERLAKE_N_A0 0xb06e0 #define CPUID_METEORLAKE_A0_1 0xa06a0 diff --git a/src/soc/intel/alderlake/bootblock/report_platform.c b/src/soc/intel/alderlake/bootblock/report_platform.c index 721355c..bdce2b7 100644 --- a/src/soc/intel/alderlake/bootblock/report_platform.c +++ b/src/soc/intel/alderlake/bootblock/report_platform.c @@ -25,6 +25,7 @@ } cpu_table[] = { { CPUID_ALDERLAKE_J0, "Alderlake J0 Platform" }, { CPUID_ALDERLAKE_K0, "Alderlake K0 Platform" }, + { CPUID_ALDERLAKE_L0, "Alderlake L0 Platform" }, { CPUID_ALDERLAKE_Q0, "Alderlake Q0 Platform" }, { CPUID_ALDERLAKE_R0, "Alderlake R0 Platform" }, { CPUID_ALDERLAKE_N_A0, "Alderlake-N Platform" }, diff --git a/src/soc/intel/common/block/cpu/mp_init.c b/src/soc/intel/common/block/cpu/mp_init.c index 0305815..823f23e 100644 --- a/src/soc/intel/common/block/cpu/mp_init.c +++ b/src/soc/intel/common/block/cpu/mp_init.c @@ -72,6 +72,7 @@ { X86_VENDOR_INTEL, CPUID_ALDERLAKE_S_A0 }, { X86_VENDOR_INTEL, CPUID_ALDERLAKE_J0 }, { X86_VENDOR_INTEL, CPUID_ALDERLAKE_K0 }, + { X86_VENDOR_INTEL, CPUID_ALDERLAKE_L0 }, { X86_VENDOR_INTEL, CPUID_ALDERLAKE_Q0 }, { X86_VENDOR_INTEL, CPUID_ALDERLAKE_R0 }, { X86_VENDOR_INTEL, CPUID_ALDERLAKE_N_A0 }, -- To view, visit https://review.coreboot.org/c/coreboot/+/63302 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I280da46e5fdd3792df50556e2804b3bcb346eee3 Gerrit-Change-Number: 63302 Gerrit-PatchSet: 1 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: Override SPD file for Samsung parts
by Robert Zieba (Code Review) 01 Apr '22

01 Apr '22

Robert Zieba has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63282 ) Change subject: mb/google/guybrush/var/dewatt: Override SPD file for Samsung parts ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/63282 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibd08f109765933640ea3d0ad442873c30fa14bc4 Gerrit-Change-Number: 63282 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Fri, 01 Apr 2022 16:35:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "OWNERS: Replace * with g/cros-ap and g/chromeos-peng-sies"
by Robert Zieba (Code Review) 01 Apr '22

01 Apr '22

Robert Zieba has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/63301 ) Change subject: Revert "OWNERS: Replace * with g/cros-ap and g/chromeos-peng-sies" ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/63301 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09ab2c79324fe8ee96b389e676caf1e389f0c6f3 Gerrit-Change-Number: 63301 Gerrit-PatchSet: 1 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-CC: Reka Norman <rekanorman(a)google.com> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: soc/intel/alderlake: Update CPU IDs with correct steppings
by Lean Sheng Tan (Code Review) 01 Apr '22

01 Apr '22

Attention is currently required from: Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak, Angel Pons, Meera Ravindranath. Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63299 ) Change subject: soc/intel/alderlake: Update CPU IDs with correct steppings ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > Can I request you to split this into 2 CL […] Done. Thanks for review :) -- To view, visit https://review.coreboot.org/c/coreboot/+/63299 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I722043c493b8c3de8965bcaa13f33c907d51f284 Gerrit-Change-Number: 63299 Gerrit-PatchSet: 2 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Comment-Date: Fri, 01 Apr 2022 16:34:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "OWNERS: Replace * with g/cros-ap and g/chromeos-peng-sies"
by Robert Zieba (Code Review) 01 Apr '22

01 Apr '22

Attention is currently required from: Paul Fagerburg. Hello Paul Fagerburg, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/63301 to review the following change. Change subject: Revert "OWNERS: Replace * with g/cros-ap and g/chromeos-peng-sies" ...................................................................... Revert "OWNERS: Replace * with g/cros-ap and g/chromeos-peng-sies" This reverts commit b60e28ffe9dbbe89aaeb78aa85d3bfea4316cf24. Reason for revert: Doesn't seem to be working. I'm a member of g/cros-ap, but no longer have owners permissions. Original change's description: > OWNERS: Replace * with g/cros-ap and g/chromeos-peng-sies > > BUG=None > TEST=None > BRANCH=None > > Change-Id: I9167b349a602ee33a0c314e26e67d36db6028ce9 > Signed-off-by: Reka Norman <rekanorman(a)google.com> > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/… > Reviewed-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> > Reviewed-by: Julius Werner <jwerner(a)chromium.org> > Commit-Queue: Reka Norman <rekanorman(a)chromium.org> > Tested-by: Reka Norman <rekanorman(a)chromium.org> Bug: None Change-Id: I09ab2c79324fe8ee96b389e676caf1e389f0c6f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/… Reviewed-by: Paul Fagerburg <pfagerburg(a)chromium.org> Reviewed-by: Aaron Massey <aaronmassey(a)google.com> Owners-Override: Aaron Massey <aaronmassey(a)google.com> Commit-Queue: Paul Fagerburg <pfagerburg(a)chromium.org> Tested-by: Paul Fagerburg <pfagerburg(a)chromium.org> --- A OWNERS 1 file changed, 11 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/63301/1 diff --git a/OWNERS b/OWNERS new file mode 100644 index 0000000..f27c861 --- /dev/null +++ b/OWNERS @@ -0,0 +1,11 @@ +# For the "Find Owners" tool: Developers around the world and across platforms +pgeorgi(a)chromium.org +martinroth(a)chromium.org +kramasub(a)chromium.org +jwerner(a)chromium.org +twawrzynczak(a)chromium.org +hungte(a)chromium.org +dossym(a)chromium.org + +# Do not depend commit access on OWNERS +* -- To view, visit https://review.coreboot.org/c/coreboot/+/63301 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09ab2c79324fe8ee96b389e676caf1e389f0c6f3 Gerrit-Change-Number: 63301 Gerrit-PatchSet: 1 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-CC: Reka Norman <rekanorman(a)google.com> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/spd_tools: Add ability to override SPD file for parts
by Robert Zieba (Code Review) 01 Apr '22

01 Apr '22

Attention is currently required from: Reka Norman, Karthik Ramasubramanian. Hello build bot (Jenkins), Reka Norman, Rob Barnes, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63281 to look at the new patch set (#3). Change subject: util/spd_tools: Add ability to override SPD file for parts ...................................................................... util/spd_tools: Add ability to override SPD file for parts This commit adds the ability to override the SPD file that is used for a specific part. BUG=b:224884904 TEST=Verified that generated makefile uses specified SPD file and that it remains unchanged when this capability is not used Signed-off-by: Robert Zieba <robertzieba(a)google.com> Change-Id: I078dd04fead2bf19f53bc6ca8295187d439adc20 --- M util/spd_tools/README.md M util/spd_tools/src/part_id_gen/part_id_gen.go 2 files changed, 64 insertions(+), 27 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/63281/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/63281 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I078dd04fead2bf19f53bc6ca8295187d439adc20 Gerrit-Change-Number: 63281 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Peers <epeers(a)google.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/alderlake: Update CPU IDs with correct steppings
by Lean Sheng Tan (Code Review) 01 Apr '22

01 Apr '22

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Angel Pons, Meera Ravindranath, Lean Sheng Tan. Hello Subrata Banik, Maulik V Vaghela, Tim Wawrzynczak, Angel Pons, Meera Ravindranath, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63299 to look at the new patch set (#2). Change subject: soc/intel/alderlake: Update CPU IDs with correct steppings ...................................................................... soc/intel/alderlake: Update CPU IDs with correct steppings Update ADL CPU IDs per correct steppings. Signed-off-by: Lean Sheng Tan <sheng.tan(a)9elements.com> Change-Id: I722043c493b8c3de8965bcaa13f33c907d51f284 --- M src/drivers/intel/mipi_camera/camera.c M src/include/cpu/intel/cpu_ids.h M src/soc/intel/alderlake/bootblock/pmc_descriptor.c M src/soc/intel/alderlake/bootblock/report_platform.c M src/soc/intel/alderlake/romstage/fsp_params.c M src/soc/intel/alderlake/romstage/romstage.c M src/soc/intel/common/block/cpu/mp_init.c 7 files changed, 16 insertions(+), 16 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/63299/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63299 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I722043c493b8c3de8965bcaa13f33c907d51f284 Gerrit-Change-Number: 63299 Gerrit-PatchSet: 2 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022