coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: crota: modify DQ/ DQS table
by Tim Wawrzynczak (Code Review) 18 Apr '22

18 Apr '22

Attention is currently required from: Scott Chao. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63681 ) Change subject: crota: modify DQ/ DQS table ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63681 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If6acf8cb9474f816374743fd1e800da46958993d Gerrit-Change-Number: 63681 Gerrit-PatchSet: 4 Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Mon, 18 Apr 2022 18:50:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/common/smbus: Add support for reading spd data via smbus for DDR5
by Tim Wawrzynczak (Code Review) 18 Apr '22

18 Apr '22

Attention is currently required from: Maulik V Vaghela, Ravishankar Sarawadi, Reka Norman, Subrata Banik, Meera Ravindranath, Nick Vaccaro, Balaji Manigandan, Raj Astekar, Patrick Rudolph, Karthik Ramasubramanian. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52731 ) Change subject: soc/common/smbus: Add support for reading spd data via smbus for DDR5 ...................................................................... Patch Set 10: (5 comments) File src/soc/intel/common/block/smbus/smbuslib.c: https://review.coreboot.org/c/coreboot/+/52731/comment/245ef31f_d8aa1e70 PS7, Line 10: { 0, 1 }, : { 2, 2 }, : { 3, 47 }, : { 126, 127 }, : { 192, 213 }, : { 230, 235 }, : { 512, 520 }, : { 521, 550 }, > SPD5118, SPD5108 HUB AND SERIAL PRESENCE DETECT DEVICE STANDARD […] ping here File src/soc/intel/common/block/smbus/smbuslib.c: https://review.coreboot.org/c/coreboot/+/52731/comment/66972b75_94157e2e PS10, Line 56: /* By default, SPD5 hub accepts 1 byte addressing pointing : to the first 128 bytes of memory. MR11[2:0] selects the page : pointer to address the entire 1024 bytes of non-volatile memory */ nit: multi-line comment like this should be indented on 2nd & 3rd line, e.g. ``` /* By default, an SPD5 hub accepts 1 byte addressing pointing to the first 128 bytes of memory. MR11[2:0] selects the page pointer to address the entire 1024 bytes of non-volatile memory. */ ``` https://review.coreboot.org/c/coreboot/+/52731/comment/635a1b1a_fb8289b5 PS10, Line 62: : /* Read the SPD data over the SMBus, at the specified SPD address, : starting at the specified starting offset and read the given amount of data */ Function header comments usually look like: ``` /* * Read the SPD data over SMBus, at the specified SPD address, starting at the * specified starting offset and read the given amount of data. */ ``` https://review.coreboot.org/c/coreboot/+/52731/comment/e6e6b3e1_ae5a3be3 PS10, Line 95: /* Reset the SPD page back to page 0 on an SPD5 Hub device at the : input SPD SMbus address*/ ``` /* * Reset the SPD page back to page 0 on an SPD5 Hub device at the * input SPD SMBus address. */ ``` https://review.coreboot.org/c/coreboot/+/52731/comment/4b65b0df_c5234266 PS10, Line 124: table_select Can you drop `table_select` and just use `spd_ddr5_table` here? -- To view, visit https://review.coreboot.org/c/coreboot/+/52731 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic5e6c58f255bef86b68ce90a4f853bf4e7c7ccfe Gerrit-Change-Number: 52731 Gerrit-PatchSet: 10 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Reviewer: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Ravishankar Sarawadi <ravishankar.sarawadi(a)intel.com> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Raj Astekar <raj.astekar(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 18 Apr 2022 18:23:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com> Comment-In-Reply-To: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/qualcomm/common: Fix mem_chip_info bugs in QcLib glue
by Julius Werner (Code Review) 18 Apr '22

18 Apr '22

Attention is currently required from: Ravi Kumar Bokka. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63026 ) Change subject: soc/qualcomm/common: Fix mem_chip_info bugs in QcLib glue ...................................................................... Patch Set 13: (1 comment) File src/soc/qualcomm/common/qclib.c: https://review.coreboot.org/c/coreboot/+/63026/comment/3c7dbc1a_ce4ff495 PS12, Line 40: !") This string is missing a newline. Please fix that in a follow-up patch. -- To view, visit https://review.coreboot.org/c/coreboot/+/63026 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d59669adaf287d0eb7b58ccb0fe3f98e3d23281 Gerrit-Change-Number: 63026 Gerrit-PatchSet: 13 Gerrit-Owner: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Comment-Date: Mon, 18 Apr 2022 18:23:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/anahera{4es}: Enable power saving for Smart Card
by Tim Wawrzynczak (Code Review) 18 Apr '22

18 Apr '22

Attention is currently required from: Chen Wisley. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63648 ) Change subject: mb/google/brya/var/anahera{4es}: Enable power saving for Smart Card ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63648 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia17970f717c6ba806d9603031c486bad86e42b37 Gerrit-Change-Number: 63648 Gerrit-PatchSet: 1 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Comment-Date: Mon, 18 Apr 2022 18:02:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/cmn/fast_spi: Add API to set SPI controller VCL
by Marc Jones (Code Review) 18 Apr '22

18 Apr '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Angel Pons, Arthur Heymans, Lean Sheng Tan. Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63626 ) Change subject: soc/intel/cmn/fast_spi: Add API to set SPI controller VCL ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63626 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie9a12db1bab81779fd8e7db90221d08da3c65011 Gerrit-Change-Number: 63626 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Comment-Date: Mon, 18 Apr 2022 17:44:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/inteltool: add lockdown mode detection
by Eloy (Code Review) 18 Apr '22

18 Apr '22

Attention is currently required from: Eloy, Stefan Reinauer. Hello build bot (Jenkins), Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63702 to look at the new patch set (#2). Change subject: util/inteltool: add lockdown mode detection ...................................................................... util/inteltool: add lockdown mode detection Change-Id: I9914fe392d53be390924e60dbfb16d3c9d222f44 Signed-off-by: Eloy Degen <degeneloy(a)gmail.com> --- M util/inteltool/inteltool.c 1 file changed, 49 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/63702/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63702 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9914fe392d53be390924e60dbfb16d3c9d222f44 Gerrit-Change-Number: 63702 Gerrit-PatchSet: 2 Gerrit-Owner: Eloy Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Eloy Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/inteltool: add lockdown mode detection
by Eloy (Code Review) 18 Apr '22

18 Apr '22

Eloy has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63702 ) Change subject: util/inteltool: add lockdown mode detection ...................................................................... util/inteltool: add lockdown mode detection Change-Id: I9914fe392d53be390924e60dbfb16d3c9d222f44 --- M util/inteltool/inteltool.c 1 file changed, 49 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/63702/1 diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c index 460f3b1..741c792 100644 --- a/util/inteltool/inteltool.c +++ b/util/inteltool/inteltool.c @@ -805,9 +805,55 @@ if (iopl(3)) { perror("iopl"); #endif - printf("You need to be root.\n"); - exit(1); - } + /* Check if kernel is in lockdown mode. + * Whether this part of sysfs is considered a + * stable kernel API part is unknown, since + * there is no explicit documentation + * stating so. There does not seems to be + * any other interface for checking wether the + * kernel is in lockdown mode. Until there is + * something better, parse the sysfs file. + * Because it is a sysfs file, fseek(3) or + * stat(2) are ineffective. You can only + * iterate until the state of the file + * handle is EOF, while it is copied into + * a buffer. + */ + + FILE *lockdown_file = fopen("/sys/kernel/security/lockdown", "rb"); + if (lockdown_file != NULL){ + + /* Loop over file handler until EOF to get filesize in bytes */ + FILE *lockdown_file_get_size = fopen("/sys/kernel/security/lockdown", "rb"); + char d = fgetc(lockdown_file_get_size); + int filesize = 0; + while (d != EOF){ + d = fgetc(lockdown_file_get_size); + filesize++; + } + fclose(lockdown_file_get_size); + + /* Allocate buffer and copy file into it */ + char *buf = malloc(filesize); + char c = fgetc(lockdown_file); + for (int i = 0; i < filesize; i++) + { + buf[i] = c; + c = fgetc(lockdown_file); + } + fclose(lockdown_file); + + if(strstr(buf, "[integrity]") || strstr(buf, "[confidentiality]")) { + printf("The lockdown mode of the kernel is active. Disable UEFI secure boot.\n"); + exit(1); + } + + } /* Failed to open lockdown file, so the problem is likely missing root permissions */ + + printf("You need to be root.\n"); + exit(1); + + } #ifndef __DARWIN__ if ((fd_mem = open("/dev/mem", O_RDWR)) < 0) { -- To view, visit https://review.coreboot.org/c/coreboot/+/63702 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9914fe392d53be390924e60dbfb16d3c9d222f44 Gerrit-Change-Number: 63702 Gerrit-PatchSet: 1 Gerrit-Owner: Eloy Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: drivers/usb/pci_xhci: Add Sabrina xhci pci device id
by Jon Murphy (Code Review) 18 Apr '22

18 Apr '22

Attention is currently required from: Paul Menzel, Karthik Ramasubramanian. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63641 ) Change subject: drivers/usb/pci_xhci: Add Sabrina xhci pci device id ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/63641 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ad4555212ed38ea0f9029275345e4945855a8c3 Gerrit-Change-Number: 63641 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 18 Apr 2022 15:57:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/intel/dptf: Add support for PROP method
by Varshit B Pandya (Code Review) 18 Apr '22

18 Apr '22

Attention is currently required from: Tim Wawrzynczak, Rizwan Qureshi, Sumeet R Pawnikar, Eric Lai. Hello build bot (Jenkins), Tim Wawrzynczak, Rizwan Qureshi, Sumeet R Pawnikar, Eric Lai, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63697 to look at the new patch set (#4). Change subject: drivers/intel/dptf: Add support for PROP method ...................................................................... drivers/intel/dptf: Add support for PROP method Add PROP method under \_SB.DPTF.TPWR scope which will return static worst case rest of platform power in miliWatts. This value is static, which has to configured from devicetree of overridetree for each platform BUG=b:205928013 TEST=Build, boot brya0 and dump SSDT to check PROP method Scope (\_SB) { Device (DPTF) { Device (TPWR) { Method (PROP, 0, Serialized) { Return (XXXX) } } } } Signed-off-by: Varshit B Pandya <varshit.b.pandya(a)intel.com> Change-Id: I1415d2a9eb55cfadc3a7b41b53ecbec657002759 --- M src/drivers/intel/dptf/chip.h M src/drivers/intel/dptf/dptf.c 2 files changed, 17 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/63697/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/63697 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1415d2a9eb55cfadc3a7b41b53ecbec657002759 Gerrit-Change-Number: 63697 Gerrit-PatchSet: 4 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Poornima Tom <poornima.tom(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/var/redrix: Add alias back to RP6 WWAN device
by Tim Wawrzynczak (Code Review) 18 Apr '22

18 Apr '22

Attention is currently required from: Subrata Banik, Nick Vaccaro, Wisley Chen. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63556 ) Change subject: mb/google/brya/var/redrix: Add alias back to RP6 WWAN device ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: ping -- To view, visit https://review.coreboot.org/c/coreboot/+/63556 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8936a01bd3a6b908033a8c58bd4e84b30d199e98 Gerrit-Change-Number: 63556 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Mon, 18 Apr 2022 15:30:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022