coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: util/inteltool: add lockdown mode detection
by Eloy (Code Review) 18 Apr '22

18 Apr '22

Attention is currently required from: Stefan Reinauer. Hello build bot (Jenkins), Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63702 to look at the new patch set (#9). Change subject: util/inteltool: add lockdown mode detection ...................................................................... util/inteltool: add lockdown mode detection Fixes https://github.com/zamaudio/intelmetool/issues/20. When lockdown mode in the Linux kernel is active, it blocks privileged I/O operations. Make the error message less confusing when inteltool is run with root permissions. Change-Id: I9914fe392d53be390924e60dbfb16d3c9d222f44 Signed-off-by: Eloy Degen <degeneloy(a)gmail.com> --- M util/inteltool/inteltool.c 1 file changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/63702/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/63702 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9914fe392d53be390924e60dbfb16d3c9d222f44 Gerrit-Change-Number: 63702 Gerrit-PatchSet: 9 Gerrit-Owner: Eloy Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/inteltool: add lockdown mode detection
by Eloy (Code Review) 18 Apr '22

18 Apr '22

Attention is currently required from: Stefan Reinauer. Hello build bot (Jenkins), Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63702 to look at the new patch set (#8). Change subject: util/inteltool: add lockdown mode detection ...................................................................... util/inteltool: add lockdown mode detection Fixes https://github.com/zamaudio/intelmetool/issues/20. When lockdown mode in the Linux kernel is active, it blocks privileged I/O operations. Make the error message less confusing when inteltool is run with root permissions. Change-Id: I9914fe392d53be390924e60dbfb16d3c9d222f44 Signed-off-by: Eloy Degen <degeneloy(a)gmail.com> --- M util/inteltool/inteltool.c 1 file changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/63702/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/63702 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9914fe392d53be390924e60dbfb16d3c9d222f44 Gerrit-Change-Number: 63702 Gerrit-PatchSet: 8 Gerrit-Owner: Eloy Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: arch/x86: Add support for catching null dereferences through debug regs
by Robert Zieba (Code Review) 18 Apr '22

18 Apr '22

Attention is currently required from: Robert Zieba, Nico Huber, Raul Rangel, Arthur Heymans, Tim Wawrzynczak, Kyösti Mälkki. Hello build bot (Jenkins), Nico Huber, Raul Rangel, Angel Pons, Arthur Heymans, Tim Wawrzynczak, Kyösti Mälkki, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63657 to look at the new patch set (#6). Change subject: arch/x86: Add support for catching null dereferences through debug regs ...................................................................... arch/x86: Add support for catching null dereferences through debug regs This commit adds support for catching null dereferences and execution through x86's debug registers. This is particularly useful when running 32-bit coreboot as paging is not enabled to catch these through page faults. This commit adds three new configs to support this feature: DEBUG_HW_BREAKPOINTS, DEBUG_NULL_DEREF_BREAKPOINTS and DEBUG_NULL_DEREF_HALT. BUG=b:223902046 TEST=Ran on nipperkin device, verifying that HW breakpoints work as expected. Change-Id: I113590689046a13c2a552741bbfe7668a834354a Signed-off-by: Robert Zieba <robertzieba(a)google.com> --- M src/arch/x86/Kconfig M src/arch/x86/Makefile.inc A src/arch/x86/breakpoint.c M src/arch/x86/exception.c A src/arch/x86/include/arch/breakpoint.h A src/arch/x86/include/arch/null_breakpoint.h A src/arch/x86/null_breakpoint.c 7 files changed, 440 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/57/63657/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/63657 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I113590689046a13c2a552741bbfe7668a834354a Gerrit-Change-Number: 63657 Gerrit-PatchSet: 6 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: nb/intel/snb: Reduce scope of functions
by Felix Singer (Code Review) 18 Apr '22

18 Apr '22

Attention is currently required from: Angel Pons, Arthur Heymans. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63701 ) Change subject: nb/intel/snb: Reduce scope of functions ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63701 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idefbe15c5f7c7169d9b60079b90cd02affb261ca Gerrit-Change-Number: 63701 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 18 Apr 2022 21:06:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: coreboot_tables: Add PCIe info to coreboot table
by Julius Werner (Code Review) 18 Apr '22

18 Apr '22

Attention is currently required from: Shelley Chen, Hung-Te Lin, Nico Huber, Paul Menzel, Rex-BC Chen, Arthur Heymans, Yu-Ping Wu, Jianjun Wang. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63251 ) Change subject: coreboot_tables: Add PCIe info to coreboot table ...................................................................... Patch Set 19: (1 comment) Patchset: PS9: > I'm fine with that. coreboot table entry formats should generally not be changed after they have been introduced (although in this case if Google is the only one using this it would probably not be a big deal, but let's try to stick to it where possible). Can we figure out the Qualcomm questions before we check this in? As far as I'm aware this is their current draft patch: CB:57615. Does someone who understands PCIe better than I do follow what's going on there (is it really normal to run that much code for each register access)? Also, as far as I can see the mmio_size is set to 1MB in CB:61773, so I guess it's not always 4K? -- To view, visit https://review.coreboot.org/c/coreboot/+/63251 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6cdce21efc66aa441ec077e6fc1d5d1c6a9aafb0 Gerrit-Change-Number: 63251 Gerrit-PatchSet: 19 Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.com> Gerrit-Comment-Date: Mon, 18 Apr 2022 20:49:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shelley Chen <shchen(a)google.com> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Comment-In-Reply-To: Jianjun Wang <jianjun.wang(a)mediatek.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: docs/coding_style: Clarify use of GCC extensions
by Julius Werner (Code Review) 18 Apr '22

18 Apr '22

Attention is currently required from: Arthur Heymans, Hung-Te Lin, Nico Huber, Paul Menzel. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63660 ) Change subject: docs/coding_style: Clarify use of GCC extensions ...................................................................... Patch Set 2: (1 comment) File Documentation/contributing/coding_style.md: https://review.coreboot.org/c/coreboot/+/63660/comment/ca374833_9604a49e PS2, Line 994: "Extensions to the C Language Family" section of the GCC manual > Make it a link? As far as I'm aware, there's no way to link to any specific page on the "current" GCC version manual in a way that automatically stays up to date. I don't want to link to the 11.2 manual because this isn't supposed to be bound to only the extensions what were available at a certain time (although in practice they're not adding many new ones these days). -- To view, visit https://review.coreboot.org/c/coreboot/+/63660 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d0eb90d6729fefeb131cdd573ad51f1884afe11 Gerrit-Change-Number: 63660 Gerrit-PatchSet: 2 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 18 Apr 2022 20:37:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/intel/snb: Reduce scope of functions
by Paul Menzel (Code Review) 18 Apr '22

18 Apr '22

Attention is currently required from: Angel Pons, Arthur Heymans. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63701 ) Change subject: nb/intel/snb: Reduce scope of functions ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/63701 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idefbe15c5f7c7169d9b60079b90cd02affb261ca Gerrit-Change-Number: 63701 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 18 Apr 2022 20:30:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/inteltool: add lockdown mode detection
by Eloy (Code Review) 18 Apr '22

18 Apr '22

Attention is currently required from: Stefan Reinauer. Hello build bot (Jenkins), Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63702 to look at the new patch set (#7). Change subject: util/inteltool: add lockdown mode detection ...................................................................... util/inteltool: add lockdown mode detection Fixes https://github.com/zamaudio/intelmetool/issues/20. When lockdown mode in the Linux kernel is active, it blocks privileged I/O operations. Make the error message less confusing when inteltool is run with root permissions. Change-Id: I9914fe392d53be390924e60dbfb16d3c9d222f44 Signed-off-by: Eloy Degen <degeneloy(a)gmail.com> --- M util/inteltool/inteltool.c 1 file changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/63702/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/63702 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9914fe392d53be390924e60dbfb16d3c9d222f44 Gerrit-Change-Number: 63702 Gerrit-PatchSet: 7 Gerrit-Owner: Eloy Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/inteltool: add lockdown mode detection
by Eloy (Code Review) 18 Apr '22

18 Apr '22

Attention is currently required from: Stefan Reinauer. Hello build bot (Jenkins), Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63702 to look at the new patch set (#6). Change subject: util/inteltool: add lockdown mode detection ...................................................................... util/inteltool: add lockdown mode detection Fixes https://github.com/zamaudio/intelmetool/issues/20. When lockdown mode in the Linux kernel is active, it blocks privileged I/O operations. Make the error message less confusing when inteltool is run with root permissions. Change-Id: I9914fe392d53be390924e60dbfb16d3c9d222f44 Signed-off-by: Eloy Degen <degeneloy(a)gmail.com> --- M util/inteltool/inteltool.c 1 file changed, 42 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/63702/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/63702 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9914fe392d53be390924e60dbfb16d3c9d222f44 Gerrit-Change-Number: 63702 Gerrit-PatchSet: 6 Gerrit-Owner: Eloy Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/inteltool: add lockdown mode detection
by Eloy (Code Review) 18 Apr '22

18 Apr '22

Attention is currently required from: Stefan Reinauer. Hello build bot (Jenkins), Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63702 to look at the new patch set (#5). Change subject: util/inteltool: add lockdown mode detection ...................................................................... util/inteltool: add lockdown mode detection Fixes https://github.com/zamaudio/intelmetool/issues/20. When lockdown mode in the Linux kernel is active, it blocks privileged I/O operations. Make the error message less confusing when inteltool is run with root permissions. Change-Id: I9914fe392d53be390924e60dbfb16d3c9d222f44 Signed-off-by: Eloy Degen <degeneloy(a)gmail.com> --- M util/inteltool/inteltool.c 1 file changed, 42 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/63702/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/63702 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9914fe392d53be390924e60dbfb16d3c9d222f44 Gerrit-Change-Number: 63702 Gerrit-PatchSet: 5 Gerrit-Owner: Eloy Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022