Attention is currently required from: Scott Chao.
Hello build bot (Jenkins), Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63682
to look at the new patch set (#2).
Change subject: mb/google/brya/var/corta: limit dram speed at 4800
......................................................................
mb/google/brya/var/corta: limit dram speed at 4800
BUG=b:229549930
BRANCH=none
TEST=build and pass memory training
Signed-off-by: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Change-Id: I38f0006d478702afb382d30338f20b46641964ef
---
M src/mainboard/google/brya/variants/crota/overridetree.cb
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/63682/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/63682
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38f0006d478702afb382d30338f20b46641964ef
Gerrit-Change-Number: 63682
Gerrit-PatchSet: 2
Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Scott Chao.
Hello build bot (Jenkins), Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63681
to look at the new patch set (#5).
Change subject: mb/google/brya/var/corta: modify DQ/ DQS table
......................................................................
mb/google/brya/var/corta: modify DQ/ DQS table
BUG=b:229547171
BRANCH=none
TEST=pass memory training with error
Signed-off-by: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Change-Id: If6acf8cb9474f816374743fd1e800da46958993d
---
M src/mainboard/google/brya/variants/crota/memory.c
1 file changed, 18 insertions(+), 18 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/63681/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/63681
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6acf8cb9474f816374743fd1e800da46958993d
Gerrit-Change-Number: 63681
Gerrit-PatchSet: 5
Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Scott Chao.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63681 )
Change subject: crota: modify DQ/ DQS table
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
@Tim, I think we don't need the DQ map still can PASS the MRC training. As our per experiment.
--
To view, visit https://review.coreboot.org/c/coreboot/+/63681
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6acf8cb9474f816374743fd1e800da46958993d
Gerrit-Change-Number: 63681
Gerrit-PatchSet: 4
Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 19 Apr 2022 00:20:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Scott Chao.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63683 )
Change subject: crota: enable boot from SSD/ eMMC
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63683/comment/4234ce46_0f580549
PS4, Line 7: crota: enable boot from SSD/ eMMC
mb/google/brya/var/corta
--
To view, visit https://review.coreboot.org/c/coreboot/+/63683
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id16e292ec7557d1780516a267bd752014d98e463
Gerrit-Change-Number: 63683
Gerrit-PatchSet: 4
Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 19 Apr 2022 00:20:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Scott Chao.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63682 )
Change subject: crota: limit dram speed at 4800
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63682/comment/de9f391c_4a1964fd
PS1, Line 7: crota: limit dram speed at 4800
mb/google/brya/var/corta
--
To view, visit https://review.coreboot.org/c/coreboot/+/63682
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38f0006d478702afb382d30338f20b46641964ef
Gerrit-Change-Number: 63682
Gerrit-PatchSet: 1
Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 19 Apr 2022 00:19:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Scott Chao.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63681 )
Change subject: crota: modify DQ/ DQS table
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63681/comment/ddae97b2_c35cda7e
PS1, Line 7: crota: modify DQ/ DQS table
mb/google/brya/var/corta
--
To view, visit https://review.coreboot.org/c/coreboot/+/63681
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6acf8cb9474f816374743fd1e800da46958993d
Gerrit-Change-Number: 63681
Gerrit-PatchSet: 4
Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 19 Apr 2022 00:19:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik, Scott Chao.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63680 )
Change subject: lib: Add LPDDR5 DRAM type
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
We have issue to track this but still not confirmed by official document. TBH, there is no official doc. https://partnerissuetracker.corp.google.com/issues/223341399
--
To view, visit https://review.coreboot.org/c/coreboot/+/63680
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I98ba9e87b1a093b93434334a75c9a9252effa933
Gerrit-Change-Number: 63680
Gerrit-PatchSet: 2
Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Comment-Date: Tue, 19 Apr 2022 00:17:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Stefan Reinauer.
Hello build bot (Jenkins), Stefan Reinauer,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63702
to look at the new patch set (#10).
Change subject: util/inteltool: add lockdown mode detection
......................................................................
util/inteltool: add lockdown mode detection
Fixes https://github.com/zamaudio/intelmetool/issues/20, but for
inteltool instead of intelmetool. When lockdown mode in the Linux
kernel is active, it blocks privileged I/O operations. Make the
error message less confusing when inteltool is run with root
permissions.
Change-Id: I9914fe392d53be390924e60dbfb16d3c9d222f44
Signed-off-by: Eloy Degen <degeneloy(a)gmail.com>
---
M util/inteltool/inteltool.c
1 file changed, 39 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/63702/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/63702
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9914fe392d53be390924e60dbfb16d3c9d222f44
Gerrit-Change-Number: 63702
Gerrit-PatchSet: 10
Gerrit-Owner: Eloy
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Varshit B Pandya, Rizwan Qureshi, Tim Wawrzynczak, Sumeet R Pawnikar.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63698 )
Change subject: mb/google/brya: Configure PROP value for brya
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/63698
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id39c1e7bf35b537fca0b97bfe77b2ae3c3cf4ecc
Gerrit-Change-Number: 63698
Gerrit-PatchSet: 4
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Comment-Date: Mon, 18 Apr 2022 23:59:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Varshit B Pandya, Tim Wawrzynczak, Rizwan Qureshi, Sumeet R Pawnikar.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63697 )
Change subject: drivers/intel/dptf: Add support for PROP method
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/63697
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1415d2a9eb55cfadc3a7b41b53ecbec657002759
Gerrit-Change-Number: 63697
Gerrit-PatchSet: 4
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Poornima Tom <poornima.tom(a)intel.com>
Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Comment-Date: Mon, 18 Apr 2022 23:59:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment