coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: apple/macbook21: configure the clockgen and add C3 CPU state
by Ferass EL HAFIDI (Code Review) 20 Apr '22

20 Apr '22

Attention is currently required from: Nico Huber, Paul Menzel, Arthur Heymans, Felix Held. Ferass EL HAFIDI has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63587 ) Change subject: apple/macbook21: configure the clockgen and add C3 CPU state ...................................................................... Patch Set 9: (2 comments) Patchset: PS6: > the override devicetree will be needed for both mackbook11 and macbook21, since the c3 state is only […] I hope the new patchset fixes that File src/mainboard/apple/macbook21/cstates.c: https://review.coreboot.org/c/coreboot/+/63587/comment/e89c8422_bc299f8c PS4, Line 34: .latency = 17, > 1 likely isn't a good value here; 17 will work and is also what one of the lenovo laptops uses here. […] I'll maybe do that later. I'll mark the discussion as solved but will have that in my TODO list. -- To view, visit https://review.coreboot.org/c/coreboot/+/63587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib97f95599fbdf66aa55e936bdcb9cc0cd69b3824 Gerrit-Change-Number: 63587 Gerrit-PatchSet: 9 Gerrit-Owner: Ferass EL HAFIDI <vitali64pmemail(a)protonmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 20 Apr 2022 20:48:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Ferass EL HAFIDI <vitali64pmemail(a)protonmail.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86/postcar: Set up postcar MTRR in C code
by Paul Menzel (Code Review) 20 Apr '22

20 Apr '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Subrata Banik, Marshall Dawson, Arthur Heymans, Fred Reitberger, Kyösti Mälkki, Aaron Durbin, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54299 ) Change subject: arch/x86/postcar: Set up postcar MTRR in C code ...................................................................... Patch Set 13: (1 comment) File src/soc/amd/common/block/cpu/noncar/early_cache.c: https://review.coreboot.org/c/coreboot/+/54299/comment/da0e1487_2c5f46a8 PS13, Line 13: * We don't know the amount of variable mtrr's to preallocate space on the stack. *for* in the end? … to preallocate space on the stack for. -- To view, visit https://review.coreboot.org/c/coreboot/+/54299 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5ec10e84118197a04de0a5194336ef8bb049bba4 Gerrit-Change-Number: 54299 Gerrit-PatchSet: 13 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 20 Apr 2022 20:41:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tpm: Allow separate handling of Google Ti50 TPM
by Tim Wawrzynczak (Code Review) 20 Apr '22

20 Apr '22

Attention is currently required from: Jes Klinke, Christian Walter, Angel Pons, Julius Werner, Jett Rink. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63158 ) Change subject: tpm: Allow separate handling of Google Ti50 TPM ...................................................................... Patch Set 14: (2 comments) File src/drivers/i2c/tpm/cr50.c: https://review.coreboot.org/c/coreboot/+/63158/comment/e869f092_e2f02987 PS14, Line 506: TPM_CR50 `TPM_GOOGLE_CR50` File src/mainboard/google/brya/Kconfig: https://review.coreboot.org/c/coreboot/+/63158/comment/9011b889_56140486 PS14, Line 47: TI50 `CR50`, Nissa is the only baseboard here that uses ti50 -- To view, visit https://review.coreboot.org/c/coreboot/+/63158 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1e1f8eb9b94fc2d5689656335dc1135b47880986 Gerrit-Change-Number: 63158 Gerrit-PatchSet: 14 Gerrit-Owner: Jes Klinke <jbk(a)chromium.org> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Jett Rink <jettrink(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Jes Klinke <jbk(a)chromium.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jett Rink <jettrink(a)google.com> Gerrit-Comment-Date: Wed, 20 Apr 2022 20:38:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/purism/librem_mini: Rework front status LED to show all disk activity
by Paul Menzel (Code Review) 20 Apr '22

20 Apr '22

Attention is currently required from: Matt DeVillier. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63749 ) Change subject: mb/purism/librem_mini: Rework front status LED to show all disk activity ...................................................................... Patch Set 1: (1 comment) File src/mainboard/purism/librem_cnl/variants/librem_mini/include/variant/acpi/variant.asl: https://review.coreboot.org/c/coreboot/+/63749/comment/9f4cbb05_35e309fa PS1, Line 18: Scope (\_SB) : { : Device (LEDS) : { : Name (_HID, "PRP0001") : Name (_DDN, "GPIO LEDs device") : : Name (_CRS, ResourceTemplate () { : GpioIo ( : Exclusive, // Not shared : PullNone, // No need for pulls : 0, // Debounce timeout : 0, // Drive strength : IoRestrictionOutputOnly, // Only used as output : "\\_SB.PCI0.GPIO", // GPIO controller : 0) // Must be 0 : { : 296, // GPP_E8 - STATUSLED# : } : }) : : Name (_DSD, Package () { : ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), : Package () { : Package () { "compatible", Package() { "gpio-leds" } }, : }, : ToUUID("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), : Package () { : Package () {"led-0", "LED0"}, : } : }) : : /* : * For more information about these bindings see: : * Documentation/devicetree/bindings/leds/common.yaml, : * Documentation/devicetree/bindings/leds/leds-gpio.yaml and : * Documentation/firmware-guide/acpi/gpio-properties.rst. : */ : Name (LED0, Package () { : ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), : Package () { : Package () {"label", "blue:status"}, : Package () {"default-state", "keep"}, : Package () {"linux,default-trigger", "disk-activity"}, : Package () {"gpios", Package () {^LEDS, 0, 0, 1}}, : Package () {"retain-state-suspended", 1}, : } : }) : } : } Please use tabs. -- To view, visit https://review.coreboot.org/c/coreboot/+/63749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I34c2a5f3fd1038266f4514544abfc1020da6f85b Gerrit-Change-Number: 63749 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Wed, 20 Apr 2022 20:36:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/purism/librem_mini: Rework front status LED to show all disk activity
by Tim Wawrzynczak (Code Review) 20 Apr '22

20 Apr '22

Attention is currently required from: Matt DeVillier. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63749 ) Change subject: mb/purism/librem_mini: Rework front status LED to show all disk activity ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/mainboard/purism/librem_cnl/variants/librem_mini/include/variant/acpi/variant.asl: PS1: If you're bored, a drivers/generic/gpio_leds chip driver to generate the AML might be nice to have 😎 -- To view, visit https://review.coreboot.org/c/coreboot/+/63749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I34c2a5f3fd1038266f4514544abfc1020da6f85b Gerrit-Change-Number: 63749 Gerrit-PatchSet: 1 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Comment-Date: Wed, 20 Apr 2022 20:33:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/adl/chip.h: add unit in max_dram_speed
by Paul Menzel (Code Review) 20 Apr '22

20 Apr '22

Attention is currently required from: Scott Chao. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63735 ) Change subject: soc/intel/adl/chip.h: add unit in max_dram_speed ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63735/comment/ebb5f7e3_932fc6bc PS2, Line 9: on to Patchset: PS2: Thank you! -- To view, visit https://review.coreboot.org/c/coreboot/+/63735 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I83c780440613050c0202f95d5f64991b61d9c280 Gerrit-Change-Number: 63735 Gerrit-PatchSet: 2 Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Wed, 20 Apr 2022 20:31:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/skyrim: Update SPI settings for skyrim
by Felix Held (Code Review) 20 Apr '22

20 Apr '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63717 ) Change subject: mb/google/skyrim: Update SPI settings for skyrim ...................................................................... mb/google/skyrim: Update SPI settings for skyrim Update SPI setting as below: Normal speed:33mhz Fast speed:66mhz Alt speed:66mz TPM speed:33mhz BUG=b:225213679 TEST=boot skyrim and verify spi settings. Signed-off-by: Chris.Wang <chris.wang(a)amd.corp-partner.google.com> Change-Id: Icbe4b9f4794f7e883c3819258ede809c3c8922b0 Reviewed-on: https://review.coreboot.org/c/coreboot/+/63717 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com> Reviewed-by: Raul Rangel <rrangel(a)chromium.org> --- M src/mainboard/google/skyrim/Kconfig 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved diff --git a/src/mainboard/google/skyrim/Kconfig b/src/mainboard/google/skyrim/Kconfig index 3c2eab2..0f5469d 100644 --- a/src/mainboard/google/skyrim/Kconfig +++ b/src/mainboard/google/skyrim/Kconfig @@ -71,4 +71,22 @@ select VBOOT_SEPARATE_VERSTAGE select VBOOT_STARTS_IN_BOOTBLOCK +if !EM100 # EM100 defaults in soc/amd/common/blocks/spi/Kconfig +config EFS_SPI_READ_MODE + default 2 # Dual IO (1-1-2) + +config EFS_SPI_SPEED + default 0 # 66MHz + +config EFS_SPI_MICRON_FLAG + default 0 + +config NORMAL_READ_SPI_SPEED + default 1 # 33MHz + +config ALT_SPI_SPEED + default 0 # 66MHz + +endif # !EM100 + endif # BOARD_GOOGLE_BASEBOARD_SKYRIM -- To view, visit https://review.coreboot.org/c/coreboot/+/63717 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icbe4b9f4794f7e883c3819258ede809c3c8922b0 Gerrit-Change-Number: 63717 Gerrit-PatchSet: 2 Gerrit-Owner: Chris Wang <chris.wang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: apple/macbook21: configure the clockgen and add C3 CPU state
by Felix Held (Code Review) 20 Apr '22

20 Apr '22

Attention is currently required from: Nico Huber, Ferass EL HAFIDI, Paul Menzel, Arthur Heymans. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63587 ) Change subject: apple/macbook21: configure the clockgen and add C3 CPU state ...................................................................... Patch Set 8: (2 comments) Patchset: PS6: > Was the latest version tested? It seems `config OVERRIDE_DEVICETREE` […] the override devicetree will be needed for both mackbook11 and macbook21, since the c3 state is only not added for the imac52, so the two macbook will need the proper clockgen configuration File src/mainboard/apple/macbook21/cstates.c: https://review.coreboot.org/c/coreboot/+/63587/comment/2ee770ff_b82cf99d PS4, Line 34: .latency = 17, > That sounds like a good idea too. 1 likely isn't a good value here; 17 will work and is also what one of the lenovo laptops uses here. not sure if the vendor firmware uses some other number and it probably doesn't need to be the exact number from the vendor firmware for this to work; the value is likely some trade-off between power savings and performance. i won't complain if you just keep the 17 and mark this discussion as solved, but the best way would probably be to look at the ACPI tables from the vendor firmware and get the values from there -- To view, visit https://review.coreboot.org/c/coreboot/+/63587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib97f95599fbdf66aa55e936bdcb9cc0cd69b3824 Gerrit-Change-Number: 63587 Gerrit-PatchSet: 8 Gerrit-Owner: Ferass EL HAFIDI <vitali64pmemail(a)protonmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Evgeny Zinoviev <me(a)ch1p.io> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Ferass EL HAFIDI <vitali64pmemail(a)protonmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 20 Apr 2022 20:23:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Ferass EL HAFIDI <vitali64pmemail(a)protonmail.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/vell: increase RFI Spread Spectrum to 6%
by Felix Held (Code Review) 20 Apr '22

20 Apr '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63440 ) Change subject: mb/google/brya/var/vell: increase RFI Spread Spectrum to 6% ...................................................................... mb/google/brya/var/vell: increase RFI Spread Spectrum to 6% Increase RFI Spread Spectrum to 6% for Vell as RF team request. The default of Spread Spectrum in FSP is 1.5%, and set 1.5% in baseboard as default. BUG=b:228929196 TEST=emerge-brya coreboot and pass RF test as before Change-Id: I7cdca8f51ad18f4ab03e4e6c744b60da68263ce2 Signed-off-by: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/63440 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> --- M src/mainboard/google/brya/variants/vell/overridetree.cb 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved diff --git a/src/mainboard/google/brya/variants/vell/overridetree.cb b/src/mainboard/google/brya/variants/vell/overridetree.cb index fd5f27a..a2fe72d 100644 --- a/src/mainboard/google/brya/variants/vell/overridetree.cb +++ b/src/mainboard/google/brya/variants/vell/overridetree.cb @@ -71,6 +71,9 @@ register "usb2_ports[6]" = "USB2_PORT_MID(OC_SKIP)" register "sagv" = "SaGv_Enabled" + # FIVR RFI Spread Spectrum 6% + register "fivr_spread_spectrum" = "FIVR_SS_6" + # I2C Port Config register "serial_io_i2c_mode" = "{ [PchSerialIoIndexI2C0] = PchSerialIoPci, -- To view, visit https://review.coreboot.org/c/coreboot/+/63440 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7cdca8f51ad18f4ab03e4e6c744b60da68263ce2 Gerrit-Change-Number: 63440 Gerrit-PatchSet: 10 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Shon Wang <shon.wang(a)quanta.corp-partner.google.com> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/prodrive/atlas: Enable SPI TPM 2.0
by Felix Held (Code Review) 20 Apr '22

20 Apr '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/63720 ) Change subject: mb/prodrive/atlas: Enable SPI TPM 2.0 ...................................................................... mb/prodrive/atlas: Enable SPI TPM 2.0 Enable SPI dTPM using eSPI bus. Signed-off-by: Lean Sheng Tan <sheng.tan(a)9elements.com> Change-Id: I18ca41c143ade024ee2840b619ba777b22a2a86a Reviewed-on: https://review.coreboot.org/c/coreboot/+/63720 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/prodrive/atlas/Kconfig M src/mainboard/prodrive/atlas/devicetree.cb 2 files changed, 7 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/src/mainboard/prodrive/atlas/Kconfig b/src/mainboard/prodrive/atlas/Kconfig index 7f92b66..d9169c2 100644 --- a/src/mainboard/prodrive/atlas/Kconfig +++ b/src/mainboard/prodrive/atlas/Kconfig @@ -7,6 +7,8 @@ select HAVE_ACPI_TABLES select MAINBOARD_USES_IFD_EC_REGION select SOC_INTEL_ALDERLAKE_PCH_P + select MAINBOARD_HAS_TPM2 + select MAINBOARD_HAS_LPC_TPM if BOARD_PRODRIVE_ATLAS_BASEBOARD diff --git a/src/mainboard/prodrive/atlas/devicetree.cb b/src/mainboard/prodrive/atlas/devicetree.cb index 0170fc2..6dfb8a2 100644 --- a/src/mainboard/prodrive/atlas/devicetree.cb +++ b/src/mainboard/prodrive/atlas/devicetree.cb @@ -103,6 +103,11 @@ device ref pcie_rp10 on end device ref uart0 on end device ref uart1 on end + device ref pch_espi on + chip drivers/pc80/tpm + device pnp 0c31.0 on end + end + end device ref p2sb on end device ref hda on end device ref smbus on end -- To view, visit https://review.coreboot.org/c/coreboot/+/63720 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I18ca41c143ade024ee2840b619ba777b22a2a86a Gerrit-Change-Number: 63720 Gerrit-PatchSet: 2 Gerrit-Owner: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022