coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: RFC: Kconfig - shouw boards supported on 4.11 branch (POC)
by Martin Roth (Code Review) 21 Apr '22

21 Apr '22

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63754 ) Change subject: RFC: Kconfig - shouw boards supported on 4.11 branch (POC) ...................................................................... RFC: Kconfig - shouw boards supported on 4.11 branch (POC) This patch is a proof of concept for the idea of showing boards that are no longer supported on the master branch. They can be selected in Kconfig, but the user is told 3 different ways which branch the board is supported in. 1) When selecting the mainboard, it's in the mainboard name. 2) When exiting from Kconfig, the main menu is gone, and a note saying that the user needs to check out a branch to build that board. 3) When make is run after saving the .config file, it halts, telling the user what needs to be checked out. As a proof of concept, I've only implemented a few boards from the 4.11 branch, but the concept is similar for any board on any branch. We could check out the branch for the user, but there was debate in the leadership meeting about whether that would be expected or not, so it's not implemented in this patch, but it would be simple to add a script that would check the branch out for you. There were also concerns about the Kconfig that was generated not working correctly in the branch. That should be fixed with this change as the saved .config is very minimal. By excluding the rest of the Kconfig if a branch build is selected, the resulting Kconfig basically just has the board vendor and defaults, thus acts similar to a defconfig. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I5fe1c508e97b52a6b70b33107c6e17cc7d7faeb2 --- M Makefile M src/Kconfig M src/mainboard/Kconfig A src/mainboard/adi/Kconfig A src/mainboard/adi/Kconfig.branch A src/mainboard/adi/Kconfig.name A src/mainboard/advansus/Kconfig A src/mainboard/advansus/Kconfig.branch A src/mainboard/advansus/Kconfig.name M src/mainboard/amd/Kconfig A src/mainboard/amd/Kconfig.branch 11 files changed, 144 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/63754/1 diff --git a/Makefile b/Makefile index 8c0369c..a97edba 100644 --- a/Makefile +++ b/Makefile @@ -180,6 +180,14 @@ CFLAGS_x86_32 += -mno-mmx endif +ifeq ($(CONFIG_MAINBOARD_SUPPORTED_ON_BRANCH),y) +$(info This mainboard is not supported in this branch. Please check out branch $(CONFIG_MAINBOARD_BRANCH) to build it.) +$(info Run the command 'git checkout $(CONFIG_MAINBOARD_BRANCH)' to build this board.) +$(info You must also set up your board in Kconfig again.) +$(shell echo "Note: We could run a script here to offer to check out that branch for the user." >&2) +$(error Halting) +endif + ifneq ($(UNIT_TEST),1) include toolchain.inc endif diff --git a/src/Kconfig b/src/Kconfig index dc81979..e63ff59 100644 --- a/src/Kconfig +++ b/src/Kconfig @@ -2,6 +2,7 @@ mainmenu "coreboot configuration" +if ! MAINBOARD_SUPPORTED_ON_BRANCH menu "General setup" config COREBOOT_BUILD @@ -464,11 +465,14 @@ If this option is enabled, coreboot will scan only PCI devices marked as mandatory in devicetree.cb endmenu +endif menu "Mainboard" source "src/mainboard/Kconfig" +if ! MAINBOARD_SUPPORTED_ON_BRANCH + config DEVICETREE string default "devicetree.cb" @@ -514,11 +518,15 @@ binaries. This symbol should only be used to generate a default FMAP and is unused when a non-default fmd file is provided via CONFIG_FMDFILE. +endif # MAINBOARD_SUPPORTED_ON_BRANCH + endmenu # load site-local kconfig to allow user specific defaults and overrides source "site-local/Kconfig" +if ! MAINBOARD_SUPPORTED_ON_BRANCH + config SYSTEM_TYPE_LAPTOP default n bool @@ -1374,3 +1382,11 @@ bool default n if RAMPAYLOAD default y + +endif # MAINBOARD_SUPPORTED_ON_BRANCH + +comment "This platform is supported in the 4.11 branch." +depends on MAINBOARD_SUPPORTED_ON_BRANCH_4_11 + +comment "Please check out that branch to build this platform." +depends on MAINBOARD_SUPPORTED_ON_BRANCH diff --git a/src/mainboard/Kconfig b/src/mainboard/Kconfig index 8f9b48c..9c24cdf 100644 --- a/src/mainboard/Kconfig +++ b/src/mainboard/Kconfig @@ -1,5 +1,12 @@ comment "Important: Run 'make distclean' before switching boards" +config SHOW_BRANCH_SUPPORTED_PLATFORMS + bool "Show boards that are no longer supported on the master branch" + default y + help + This option shows or hides the boards that are supported on release + branches instead of on the master branch. + choice prompt "Mainboard vendor" default VENDOR_EMULATION @@ -10,6 +17,8 @@ source "src/mainboard/*/Kconfig" +if ! MAINBOARD_SUPPORTED_ON_BRANCH + config MAINBOARD_DIR string @@ -243,3 +252,17 @@ default 0 endif # HAVE_POWER_STATE_AFTER_FAILURE + +endif # MAINBOARD_SUPPORTED_ON_BRANCH + +config MAINBOARD_SUPPORTED_ON_BRANCH + def_bool n + +config MAINBOARD_SUPPORTED_ON_BRANCH_4_11 + def_bool n + select MAINBOARD_SUPPORTED_ON_BRANCH + +config MAINBOARD_BRANCH + string + default "4.11_branch" if MAINBOARD_SUPPORTED_ON_BRANCH_4_11 + default "unknown" diff --git a/src/mainboard/adi/Kconfig b/src/mainboard/adi/Kconfig new file mode 100644 index 0000000..76afb7b --- /dev/null +++ b/src/mainboard/adi/Kconfig @@ -0,0 +1,14 @@ +if VENDOR_ADI + +choice + prompt "Mainboard model" + +source "src/mainboard/adi/Kconfig.branch" + +endchoice + +config MAINBOARD_VENDOR + string + default "ADI" + +endif # VENDOR_ADI diff --git a/src/mainboard/adi/Kconfig.branch b/src/mainboard/adi/Kconfig.branch new file mode 100644 index 0000000..efcad74 --- /dev/null +++ b/src/mainboard/adi/Kconfig.branch @@ -0,0 +1,4 @@ +config BOARD_ADI_RCC_DFF + bool "ADI RCC-DFF (supported on 4.11 branch)" + depends on SHOW_BRANCH_SUPPORTED_PLATFORMS + select MAINBOARD_SUPPORTED_ON_BRANCH_4_11 diff --git a/src/mainboard/adi/Kconfig.name b/src/mainboard/adi/Kconfig.name new file mode 100644 index 0000000..f66687b --- /dev/null +++ b/src/mainboard/adi/Kconfig.name @@ -0,0 +1,8 @@ +# All vendor platforms are now supported on branches, so don't show +# in the vendor menu +if SHOW_BRANCH_SUPPORTED_PLATFORMS + +config VENDOR_ADI + bool "ADI" + +endif # SHOW_BRANCH_SUPPORTED_PLATFORMS diff --git a/src/mainboard/advansus/Kconfig b/src/mainboard/advansus/Kconfig new file mode 100644 index 0000000..1d6bc66 --- /dev/null +++ b/src/mainboard/advansus/Kconfig @@ -0,0 +1,14 @@ +if VENDOR_ADVANSUS + +choice + prompt "Mainboard model" + +source "src/mainboard/advansus/Kconfig.branch" + +endchoice + +config MAINBOARD_VENDOR + string + default "Advansus" + +endif # VENDOR_ADVANSUS diff --git a/src/mainboard/advansus/Kconfig.branch b/src/mainboard/advansus/Kconfig.branch new file mode 100644 index 0000000..9daab69 --- /dev/null +++ b/src/mainboard/advansus/Kconfig.branch @@ -0,0 +1,4 @@ +config BOARD_ADVANSUS_A785E_I + bool "A785E-I (supported on 4.11 branch)" + depends on SHOW_BRANCH_SUPPORTED_PLATFORMS + select MAINBOARD_SUPPORTED_ON_BRANCH_4_11 diff --git a/src/mainboard/advansus/Kconfig.name b/src/mainboard/advansus/Kconfig.name new file mode 100644 index 0000000..2370e0b --- /dev/null +++ b/src/mainboard/advansus/Kconfig.name @@ -0,0 +1,8 @@ +# All vendor platforms are now supported on branches, so don't show +# in the vendor menu +if SHOW_BRANCH_SUPPORTED_PLATFORMS + +config VENDOR_ADVANSUS + bool "Advansus" + +endif # SHOW_BRANCH_SUPPORTED_PLATFORMS diff --git a/src/mainboard/amd/Kconfig b/src/mainboard/amd/Kconfig index 2e40199..b3924c8 100644 --- a/src/mainboard/amd/Kconfig +++ b/src/mainboard/amd/Kconfig @@ -4,6 +4,7 @@ prompt "Mainboard model" source "src/mainboard/amd/*/Kconfig.name" +source "src/mainboard/amd/Kconfig.branch" endchoice diff --git a/src/mainboard/amd/Kconfig.branch b/src/mainboard/amd/Kconfig.branch new file mode 100644 index 0000000..0e18b5d --- /dev/null +++ b/src/mainboard/amd/Kconfig.branch @@ -0,0 +1,44 @@ +config BOARD_AMD_BETTONG + bool "Bettong (supported on 4.11 branch)" + depends on SHOW_BRANCH_SUPPORTED_PLATFORMS + select MAINBOARD_SUPPORTED_ON_BRANCH_4_11 + +config BOARD_AMD_BIMINI_FAM10 + bool "Bimini (Fam10) (supported on 4.11 branch)" + depends on SHOW_BRANCH_SUPPORTED_PLATFORMS + select MAINBOARD_SUPPORTED_ON_BRANCH_4_11 + +config BOARD_AMD_DB_FT3B_LC + bool "DB-FT3b-LC (supported on 4.11 branch)" + depends on SHOW_BRANCH_SUPPORTED_PLATFORMS + select MAINBOARD_SUPPORTED_ON_BRANCH_4_11 + +config BOARD_AMD_LAMAR + bool "Lamar (supported on 4.11 branch)" + depends on SHOW_BRANCH_SUPPORTED_PLATFORMS + select MAINBOARD_SUPPORTED_ON_BRANCH_4_11 + +config BOARD_AMD_MAHOGANY_FAM10 + bool "Mahogany (Fam10) (supported on 4.11 branch)" + depends on SHOW_BRANCH_SUPPORTED_PLATFORMS + select MAINBOARD_SUPPORTED_ON_BRANCH_4_11 + +config BOARD_AMD_OLIVEHILLPLUS + bool "Olive Hill Plus (supported on 4.11 branch)" + depends on SHOW_BRANCH_SUPPORTED_PLATFORMS + select MAINBOARD_SUPPORTED_ON_BRANCH_4_11 + +config BOARD_AMD_SERENGETI_CHEETAH_FAM10 + bool "Serengeti Cheetah (Fam10) (supported on 4.11 branch)" + depends on SHOW_BRANCH_SUPPORTED_PLATFORMS + select MAINBOARD_SUPPORTED_ON_BRANCH_4_11 + +config BOARD_AMD_TILAPIA_FAM10 + bool "Tilapia (Fam10) (supported on 4.11 branch)" + depends on SHOW_BRANCH_SUPPORTED_PLATFORMS + select MAINBOARD_SUPPORTED_ON_BRANCH_4_11 + +config BOARD_AMD_TORPEDO + bool "Torpedo (supported on 4.11 branch)" + depends on SHOW_BRANCH_SUPPORTED_PLATFORMS + select MAINBOARD_SUPPORTED_ON_BRANCH_4_11 -- To view, visit https://review.coreboot.org/c/coreboot/+/63754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5fe1c508e97b52a6b70b33107c6e17cc7d7faeb2 Gerrit-Change-Number: 63754 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/purism/librem_mini: Rework front status LED to show all disk activity
by Matt DeVillier (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Angel Pons. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63749 ) Change subject: mb/purism/librem_mini: Rework front status LED to show all disk activity ...................................................................... Patch Set 2: (3 comments) Patchset: PS1: > Interesting, do other OSes work with this? As in Windows? Untested, but assume not based on the ASL and how closely coupled it is to the Linux gpio-leds driver File src/mainboard/purism/librem_cnl/variants/librem_mini/include/variant/acpi/variant.asl: PS1: > If you're bored, a drivers/generic/gpio_leds chip driver to generate the AML might be nice to have ? […] that sounds like a great idea for a GSOC project ;-) https://review.coreboot.org/c/coreboot/+/63749/comment/221aa178_95ee32cd PS1, Line 18: Scope (\_SB) : { : Device (LEDS) : { : Name (_HID, "PRP0001") : Name (_DDN, "GPIO LEDs device") : : Name (_CRS, ResourceTemplate () { : GpioIo ( : Exclusive, // Not shared : PullNone, // No need for pulls : 0, // Debounce timeout : 0, // Drive strength : IoRestrictionOutputOnly, // Only used as output : "\\_SB.PCI0.GPIO", // GPIO controller : 0) // Must be 0 : { : 296, // GPP_E8 - STATUSLED# : } : }) : : Name (_DSD, Package () { : ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), : Package () { : Package () { "compatible", Package() { "gpio-leds" } }, : }, : ToUUID("dbb8e3e6-5886-4ba6-8795-1319f52a966b"), : Package () { : Package () {"led-0", "LED0"}, : } : }) : : /* : * For more information about these bindings see: : * Documentation/devicetree/bindings/leds/common.yaml, : * Documentation/devicetree/bindings/leds/leds-gpio.yaml and : * Documentation/firmware-guide/acpi/gpio-properties.rst. : */ : Name (LED0, Package () { : ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), : Package () { : Package () {"label", "blue:status"}, : Package () {"default-state", "keep"}, : Package () {"linux,default-trigger", "disk-activity"}, : Package () {"gpios", Package () {^LEDS, 0, 0, 1}}, : Package () {"retain-state-suspended", 1}, : } : }) : } : } > Please use tabs. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/63749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I34c2a5f3fd1038266f4514544abfc1020da6f85b Gerrit-Change-Number: 63749 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Thu, 21 Apr 2022 03:35:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/purism/librem_mini: Rework front status LED to show all disk activity
by Matt DeVillier (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Matt DeVillier. Hello build bot (Jenkins), Tim Wawrzynczak, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63749 to look at the new patch set (#2). Change subject: mb/purism/librem_mini: Rework front status LED to show all disk activity ...................................................................... mb/purism/librem_mini: Rework front status LED to show all disk activity The front status LED on the Librem Mini is driven by the SATALED# GPIO line configured for native function, so only shows disk activity for SATA drives, but not NVMe. To allow it to show disk activity for NVMe drives as well, reconfigure the GPIO as GPIO-OUT (rather than native function), and configure it via ACPI so that the linux gpio-leds driver will attach and use it accordingly. This has the added benefit of allowing the user to reconfigure the LED as they see fit via sysfs. Test: boot Linux (PureOS) on Librem Mini v2 with NVMe drive, observe status LED blinks during periods of disk activity (tested via 'stress'). Change-Id: I34c2a5f3fd1038266f4514544abfc1020da6f85b Signed-off-by: Matt DeVillier <matt.devillier(a)puri.sm> --- M src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c M src/mainboard/purism/librem_cnl/variants/librem_mini/include/variant/acpi/variant.asl 2 files changed, 53 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/63749/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63749 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I34c2a5f3fd1038266f4514544abfc1020da6f85b Gerrit-Change-Number: 63749 Gerrit-PatchSet: 2 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede/var/beadrix: Add a Proximity Sensor SX9324 for SAR
by Ivan Chen (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Henry Sun, Super Ni, Teddy Shih, Paul Menzel, Simon Yang, Aseda Aboagye, Karthik Ramasubramanian, Felix Held. Ivan Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63652 ) Change subject: mb/google/dedede/var/beadrix: Add a Proximity Sensor SX9324 for SAR ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/63652 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If172d13aa62503547227adf91f049ea50b948888 Gerrit-Change-Number: 63652 Gerrit-PatchSet: 3 Gerrit-Owner: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Ivan Chen <yulunchen(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Reviewer: Super Ni <super.ni(a)intel.corp-partner.google.com> Gerrit-Reviewer: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Reviewer: Teddy Shih <teddyshihau(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eddy Lu <eddylu(a)ami.corp-partner.google.com> Gerrit-CC: Jack Cheng <jack.cheng(a)ecs.corp-partner.google.com> Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com> Gerrit-CC: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Super Ni <super.ni(a)intel.corp-partner.google.com> Gerrit-Attention: Teddy Shih <teddyshihau(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Attention: Simon Yang <simon1.yang(a)intel.corp-partner.google.com> Gerrit-Attention: Teddy Shih <teddyshih(a)ami.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 21 Apr 2022 03:32:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: Override SPI fast speed
by Kenneth Chan (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Bhanu Prakash Maiya, Rob Barnes, Karthik Ramasubramanian. Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63753 ) Change subject: mb/google/guybrush/var/dewatt: Override SPI fast speed ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/63753 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a3022d54bcec70f6b12492f494d3019e00d204a Gerrit-Change-Number: 63753 Gerrit-PatchSet: 1 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 21 Apr 2022 03:30:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/skyrim: Configure SD card reader power sequence.
by Ian Feng (Code Review) 21 Apr '22

21 Apr '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63739 to look at the new patch set (#4). Change subject: mb/google/skyrim: Configure SD card reader power sequence. ...................................................................... mb/google/skyrim: Configure SD card reader power sequence. Set the SD_AUX_RESET_L signal in the bootblock GPIO table. BUG=b:229181624 TEST=Build and boot to OS in Skyrim. Ensure that the SD Controller and SD Card are enumerated fine. 02:00.0 SD Host controller: Genesys Logic, Inc GL9750 (rev 01) Signed-off-by: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Change-Id: I03d88d90acc03cdebcb1e83ed2e799dda8b5b735 --- M src/mainboard/google/skyrim/variants/baseboard/gpio.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/63739/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/63739 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I03d88d90acc03cdebcb1e83ed2e799dda8b5b735 Gerrit-Change-Number: 63739 Gerrit-PatchSet: 4 Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: Override SPI fast speed
by Kenneth Chan (Code Review) 21 Apr '22

21 Apr '22

Kenneth Chan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63753 ) Change subject: mb/google/guybrush/var/dewatt: Override SPI fast speed ...................................................................... mb/google/guybrush/var/dewatt: Override SPI fast speed After assessing the signal integrity, 100 MHz SPI fast speed can be enabled for SPI ROM. BUG=b:213403891 TEST=Build and boot to OS testing in Dewatt EVT board (HW re-work). Change-Id: I4a3022d54bcec70f6b12492f494d3019e00d204a Signed-off-by: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> --- M src/mainboard/google/guybrush/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/63753/1 diff --git a/src/mainboard/google/guybrush/Kconfig b/src/mainboard/google/guybrush/Kconfig index 16deda5..ca96884 100644 --- a/src/mainboard/google/guybrush/Kconfig +++ b/src/mainboard/google/guybrush/Kconfig @@ -137,6 +137,7 @@ config OVERRIDE_EFS_SPI_SPEED_MIN_BOARD hex default 0x4 if BOARD_GOOGLE_GUYBRUSH + default 0x3 if BOARD_GOOGLE_DEWATT default 0x2 if BOARD_GOOGLE_NIPPERKIN default 0xffffffff help -- To view, visit https://review.coreboot.org/c/coreboot/+/63753 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a3022d54bcec70f6b12492f494d3019e00d204a Gerrit-Change-Number: 63753 Gerrit-PatchSet: 1 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/intel/common: Add Raptor Lake device IDs
by Jérémy Compostella (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Bora Guvendik, Anil Kumar K, Subrata Banik, Tim Wawrzynczak. Jérémy Compostella has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63750 ) Change subject: soc/intel/common: Add Raptor Lake device IDs ...................................................................... Patch Set 2: (5 comments) File src/include/device/pci_ids.h: https://review.coreboot.org/c/coreboot/+/63750/comment/e0b0a4cb_bbb98852 PS1, Line 3079: #define PCI_DID_INTEL_RPL_P_ESPI_1 0x519d > Documents are missing some of the device-ids, they are being updated. Done https://review.coreboot.org/c/coreboot/+/63750/comment/7fe0940a_d88043fa PS1, Line 4149: #define PCI_DID_INTEL_RPL_TCSS_XHCI 0xa71e > Documents are missing some of the device-ids, they are being updated. Done https://review.coreboot.org/c/coreboot/+/63750/comment/e311a4dc_12087a8a PS1, Line 4350: #define PCI_DID_INTEL_RPL_TBT_RP0 0xa76e > Documents are missing some of the device-ids, they are being updated. Done https://review.coreboot.org/c/coreboot/+/63750/comment/8e7e004e_c915230a PS1, Line 4394: #define PCI_DID_INTEL_RPL_IPU 0xa75d > Documents are missing some of the device-ids, they are being updated. Done File src/soc/intel/common/block/dtt/dtt.c: https://review.coreboot.org/c/coreboot/+/63750/comment/d82843b8_121eeb7f PS1, Line 8: PCI_DID_INTEL_RPL_DTT, > faster boot time? Well that depend on the platform 😊 -- To view, visit https://review.coreboot.org/c/coreboot/+/63750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39e655dec2314a672ea63ba90d8bb3fc53bf77ba Gerrit-Change-Number: 63750 Gerrit-PatchSet: 2 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Thu, 21 Apr 2022 02:37:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Bora Guvendik <bora.guvendik(a)intel.com> Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common: Add Raptor Lake device IDs
by Bora Guvendik (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Anil Kumar K, Subrata Banik, Jérémy Compostella, Tim Wawrzynczak. Bora Guvendik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63750 ) Change subject: soc/intel/common: Add Raptor Lake device IDs ...................................................................... Patch Set 2: (8 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63750/comment/5e8eba96_9aed0333 PS1, Line 9: Add Raptor Lake specific CPU, System Agent, PCH, > The line break is unnecessary as the line length is 64 characters. […] Done File src/include/cpu/intel/cpu_ids.h: https://review.coreboot.org/c/coreboot/+/63750/comment/ed3a989e_55a27bf5 PS1, Line 62: #define CPUID_RAPTORLAKE_J0 0xb06a2 > According the EDS section 15.0, there are two SKUs (P and S) with two different CPUIDs. […] I followed the naming convention but CPUID_RAPTORLAKE_P_J0 maybe good idea. I don't think we will need S SKU. Yes, J0 stepping. File src/include/device/pci_ids.h: https://review.coreboot.org/c/coreboot/+/63750/comment/4761fffc_0b5e71cd PS1, Line 3079: #define PCI_DID_INTEL_RPL_P_ESPI_1 0x519d > Where does this second eSPI MC comes from ? I don't find it in the PCH EDS. Documents are missing some of the device-ids, they are being updated. https://review.coreboot.org/c/coreboot/+/63750/comment/6c456e5a_6dd0295b PS1, Line 4149: #define PCI_DID_INTEL_RPL_TCSS_XHCI 0xa71e > Where is it defined? I could not find it. Documents are missing some of the device-ids, they are being updated. https://review.coreboot.org/c/coreboot/+/63750/comment/6745aca4_44bb37fb PS1, Line 4350: #define PCI_DID_INTEL_RPL_TBT_RP0 0xa76e > Where are they defined? I could not find them. Documents are missing some of the device-ids, they are being updated. https://review.coreboot.org/c/coreboot/+/63750/comment/faabe243_050a6f46 PS1, Line 4394: #define PCI_DID_INTEL_RPL_IPU 0xa75d > Where is it defined? I could not find it. Documents are missing some of the device-ids, they are being updated. File src/soc/intel/alderlake/cpu.c: https://review.coreboot.org/c/coreboot/+/63750/comment/b0af3bb1_e20d564f PS1, Line 262: adl_p_mch_ids > should be rpl_p_mch_ids right ? […] done. I think we can push func/macro in a separate patch File src/soc/intel/common/block/dtt/dtt.c: https://review.coreboot.org/c/coreboot/+/63750/comment/c095866d_aad1f824 PS1, Line 8: PCI_DID_INTEL_RPL_DTT, > Is there any reason why it is being added at the beginning ? faster boot time? -- To view, visit https://review.coreboot.org/c/coreboot/+/63750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39e655dec2314a672ea63ba90d8bb3fc53bf77ba Gerrit-Change-Number: 63750 Gerrit-PatchSet: 2 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Thu, 21 Apr 2022 02:07:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common: Add Raptor Lake device IDs
by Bora Guvendik (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Bora Guvendik, Anil Kumar K, Subrata Banik, Tim Wawrzynczak. Hello Anil Kumar K, build bot (Jenkins), Subrata Banik, Jérémy Compostella, Selma Bensaid, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63750 to look at the new patch set (#2). Change subject: soc/intel/common: Add Raptor Lake device IDs ...................................................................... soc/intel/common: Add Raptor Lake device IDs Add Raptor Lake specific CPU, System Agent, PCH, IGD device IDs. References: RaptorLake External Design Specification Volume 1 (640555) 600/700 Series PCH External Design Specification Volume 1 (626817) Change-Id: I39e655dec2314a672ea63ba90d8bb3fc53bf77ba Signed-off-by: Bora Guvendik <bora.guvendik(a)intel.com> --- M src/include/cpu/intel/cpu_ids.h M src/include/device/pci_ids.h M src/soc/intel/alderlake/bootblock/report_platform.c M src/soc/intel/alderlake/cpu.c M src/soc/intel/alderlake/include/soc/cpu.h M src/soc/intel/common/block/cpu/mp_init.c M src/soc/intel/common/block/dtt/dtt.c M src/soc/intel/common/block/graphics/graphics.c M src/soc/intel/common/block/ipu/ipu.c M src/soc/intel/common/block/lpc/lpc.c M src/soc/intel/common/block/pcie/pcie.c M src/soc/intel/common/block/systemagent/systemagent.c M src/soc/intel/common/block/usb4/usb4.c M src/soc/intel/common/block/usb4/xhci.c 14 files changed, 51 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/63750/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63750 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39e655dec2314a672ea63ba90d8bb3fc53bf77ba Gerrit-Change-Number: 63750 Gerrit-PatchSet: 2 Gerrit-Owner: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022