coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: mb/google/guybrush/var/dewatt: Override SPI fast speed
by Kenneth Chan (Code Review) 21 Apr '22

21 Apr '22

Kenneth Chan has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/63753 ) Change subject: mb/google/guybrush/var/dewatt: Override SPI fast speed ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/63753 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a3022d54bcec70f6b12492f494d3019e00d204a Gerrit-Change-Number: 63753 Gerrit-PatchSet: 1 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <martinroth(a)google.com> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: soc/intel/jasperlake: CNVi: Enable fewer wakeups to reduce SoC power ...
by Jamie Chen (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Tim Wawrzynczak, Karthik Ramasubramanian. Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63675 ) Change subject: soc/intel/jasperlake: CNVi: Enable fewer wakeups to reduce SoC power consumption ...................................................................... Patch Set 5: (2 comments) File src/soc/intel/jasperlake/chip.h: https://review.coreboot.org/c/coreboot/+/63675/comment/c544e271_dcb11447 PS5, Line 428: * Setting this on a system that supports S0i3 (set xtalsdqdis [Bit 22] in : * cppmvric1 register to 0) will break CNVI timing. > Should we have to assert xtalsdqdis bit is not set when this bit is set? The xtalsdqdis bit can be set or clear by ASL code or OS code. That's why I add comment here to warning developer instead of adding statement to check if xtalsdqis bit is 0. File src/soc/intel/jasperlake/finalize.c: https://review.coreboot.org/c/coreboot/+/63675/comment/38113da8_fab4a710 PS5, Line 63: if (config->cnvi_reduce_s0ix_pwr_usage) { > Also should we have to ensure that CNVI device is enabled in the devicetree. […] This is only for system with CNVi module to work around and keeping this enabled will not impact the system with discrete WIFI. -- To view, visit https://review.coreboot.org/c/coreboot/+/63675 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I56439a406547e2ee1e47d34be14ecc9a8df04693 Gerrit-Change-Number: 63675 Gerrit-PatchSet: 5 Gerrit-Owner: Jamie Chen <jamie.chen(a)intel.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kane Chen <kane.chen(a)intel.com> Gerrit-CC: Simon Yang <simon1.yang(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 21 Apr 2022 04:49:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: intel/common/../systemagent: Add sa_get_mchbar_base api
by Subrata Banik (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Wonkyu Kim, Tim Wawrzynczak, Paul Menzel, Michael Niewöhner. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63615 ) Change subject: intel/common/../systemagent: Add sa_get_mchbar_base api ...................................................................... Patch Set 11: (2 comments) File src/soc/intel/common/block/systemagent/systemagent_early.c: https://review.coreboot.org/c/coreboot/+/63615/comment/ecbe7bd9_8becf497 PS11, Line 89: if(mchbar_lo & 0x1) one space between if and brace ? https://review.coreboot.org/c/coreboot/+/63615/comment/d46fc664_54b7b189 PS11, Line 94: if(mchbar_base == 0) { one space between if and brace ? -- To view, visit https://review.coreboot.org/c/coreboot/+/63615 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie4c7af3ea8c2b2b6afcc76e1165fadbe15e0bceb Gerrit-Change-Number: 63615 Gerrit-PatchSet: 11 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Thu, 21 Apr 2022 04:49:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/nipperkin: Fix WLAN to GEN2 speed
by Rob Barnes (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Kevin Chiu, Bao Zheng. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63722 ) Change subject: mb/google/nipperkin: Fix WLAN to GEN2 speed ...................................................................... Patch Set 4: (1 comment) File src/mainboard/google/guybrush/variants/nipperkin/variant.c: https://review.coreboot.org/c/coreboot/+/63722/comment/00941ff3_604863d5 PS4, Line 10: /* Disable PSPP to avoid S0ix hangs - b/228830362 */ : memset(dxio_descriptors[WLAN].port_params, 0, : sizeof(dxio_descriptors[WLAN].port_params)); > Hi Rob, […] My understanding is PSPP is on but link speed is limited to a max of gen2 speeds. Link speed may go to gen1 on DC since PSPP policy is balanced. AMD may correct me. -- To view, visit https://review.coreboot.org/c/coreboot/+/63722 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I988365e51aca0d6515c5605b3032521cf59d8d30 Gerrit-Change-Number: 63722 Gerrit-PatchSet: 4 Gerrit-Owner: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Reviewer: Patrick Huang <patrick.huang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Comment-Date: Thu, 21 Apr 2022 04:40:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in qc_blobs[master]: sc7180/boot : Update qclib blobs binaries and release notes
by Sudheer Amrabadi (Code Review) 21 Apr '22

21 Apr '22

Sudheer Amrabadi has uploaded this change for review. ( https://review.coreboot.org/c/qc_blobs/+/63755 ) Change subject: sc7180/boot : Update qclib blobs binaries and release notes ...................................................................... sc7180/boot : Update qclib blobs binaries and release notes Change-Id: I957b45c99782ec3632035c8dca147927fa70dc6d --- M sc7180/boot/Pmic.bin M sc7180/boot/QcLib.elf M sc7180/boot/Release_Notes.txt 3 files changed, 22 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/qc_blobs refs/changes/55/63755/1 diff --git a/sc7180/boot/Pmic.bin b/sc7180/boot/Pmic.bin index c5100ec..2476dbb 100644 --- a/sc7180/boot/Pmic.bin +++ b/sc7180/boot/Pmic.bin Binary files differ diff --git a/sc7180/boot/QcLib.elf b/sc7180/boot/QcLib.elf index bfa4235..234c055 100644 --- a/sc7180/boot/QcLib.elf +++ b/sc7180/boot/QcLib.elf Binary files differ diff --git a/sc7180/boot/Release_Notes.txt b/sc7180/boot/Release_Notes.txt index 536a937..65734d8 100644 --- a/sc7180/boot/Release_Notes.txt +++ b/sc7180/boot/Release_Notes.txt @@ -1,3 +1,25 @@ +=================== Release 00040 ================================ +This Release Notes file covers these blobs: + * QcLib.elf + * Pmic.bin + +Version : 00040 + +Release Date : Apr, 2022 + +Supported Silicon : SC7180 + +No special instructions, requirements or dependencies, files must be +present in this folder to be pulled in during coreboot build + +Changes since last version : + * Qclib building with python3 + +Errata : Nothing to report + +Toolchain Version : LLVM 12.0.0 + +ABI Info : see qclib-interface.txt =================== Release 00037 ================================ This Release Notes file covers these blobs: * QcLib.elf -- To view, visit https://review.coreboot.org/c/qc_blobs/+/63755 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: qc_blobs Gerrit-Branch: master Gerrit-Change-Id: I957b45c99782ec3632035c8dca147927fa70dc6d Gerrit-Change-Number: 63755 Gerrit-PatchSet: 1 Gerrit-Owner: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: intel/common/../systemagent: Add sa_get_mchbar_base api
by Wonkyu Kim (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Paul Menzel, Michael Niewöhner. Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63615 ) Change subject: intel/common/../systemagent: Add sa_get_mchbar_base api ...................................................................... Patch Set 10: (2 comments) File src/soc/intel/common/block/systemagent/systemagent_early.c: https://review.coreboot.org/c/coreboot/+/63615/comment/72ba31c7_44b34ee2 PS8, Line 89: if (mchbar_lo & 0x1) > what if mchbar_lo and hi value is zero and BAR enable bit is set? we would run into the problem isn' […] Done https://review.coreboot.org/c/coreboot/+/63615/comment/630639d3_ddba776b PS8, Line 92: > tab ? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/63615 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie4c7af3ea8c2b2b6afcc76e1165fadbe15e0bceb Gerrit-Change-Number: 63615 Gerrit-PatchSet: 10 Gerrit-Owner: Wonkyu Kim <wonkyu.kim(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Thu, 21 Apr 2022 04:07:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: Override SPI fast speed
by Martin L Roth (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Kenneth Chan, Karthik Ramasubramanian. Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63753 ) Change subject: mb/google/guybrush/var/dewatt: Override SPI fast speed ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63753/comment/d8e93527_9bd17601 PS1, Line 9: 100 MHz SPI fast speed can be : enabled for SPI ROM. Awesome! File src/mainboard/google/guybrush/Kconfig: https://review.coreboot.org/c/coreboot/+/63753/comment/c3b2526b_1402398e PS1, Line 140: default 0x3 if BOARD_GOOGLE_DEWATT Nit: Could we get a comment like the lines above saying what the speed for '3' is? Really it could go on all of these, but if you could do it for dewatt, that'd be a start. -- To view, visit https://review.coreboot.org/c/coreboot/+/63753 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a3022d54bcec70f6b12492f494d3019e00d204a Gerrit-Change-Number: 63753 Gerrit-PatchSet: 1 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin L Roth <martinroth(a)google.com> Gerrit-Attention: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 21 Apr 2022 03:59:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: Override SPI fast speed
by Rob Barnes (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Kenneth Chan, Karthik Ramasubramanian. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63753 ) Change subject: mb/google/guybrush/var/dewatt: Override SPI fast speed ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: The same CL is open here: https://review.coreboot.org/c/coreboot/+/63747 -- To view, visit https://review.coreboot.org/c/coreboot/+/63753 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4a3022d54bcec70f6b12492f494d3019e00d204a Gerrit-Change-Number: 63753 Gerrit-PatchSet: 1 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 21 Apr 2022 03:58:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush/var/dewatt: Override SPI fast speed
by Kenneth Chan (Code Review) 21 Apr '22

21 Apr '22

Kenneth Chan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63685 ) Change subject: mb/google/guybrush/var/dewatt: Override SPI fast speed ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/guybrush/Kconfig: https://review.coreboot.org/c/coreboot/+/63685/comment/66582850_0cef1e5d PS2, Line 143: 0x2 > I believe it should be 3 for Dewatt. Sorry for the delayed response. Thank your minding, re-upload CL with board id 0x03: https://review.coreboot.org/c/coreboot/+/63753 -- To view, visit https://review.coreboot.org/c/coreboot/+/63685 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7301d873e36bec4ee46c9d18293f924500ea9aba Gerrit-Change-Number: 63685 Gerrit-PatchSet: 2 Gerrit-Owner: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Kenneth Chan <kenneth.chan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Comment-Date: Thu, 21 Apr 2022 03:54:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: RFC: Kconfig - show boards supported on 4.11 branch (POC)
by Martin L Roth (Code Review) 21 Apr '22

21 Apr '22

Martin L Roth has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/63754 ) Change subject: RFC: Kconfig - show boards supported on 4.11 branch (POC) ...................................................................... RFC: Kconfig - show boards supported on 4.11 branch (POC) This patch is a proof of concept for the idea of showing boards that are no longer supported on the master branch. They can be selected in Kconfig, but the user is told 3 different ways which branch the board is supported in. 1) When selecting the mainboard, it's in the mainboard name. 2) When exiting from Kconfig, the main menu is gone, and a note saying that the user needs to check out a branch to build that board. 3) When make is run after saving the .config file, it halts, telling the user what needs to be checked out. As a proof of concept, I've only implemented a few boards from the 4.11 branch, but the concept is similar for any board on any branch. We could check out the branch for the user, but there was debate in the leadership meeting about whether that would be expected or not, so it's not implemented in this patch, but it would be simple to add a script that would check the branch out for you. There were also concerns about the Kconfig that was generated not working correctly in the branch. That should be fixed with this change as the saved .config is very minimal. By excluding the rest of the Kconfig if a branch build is selected, the resulting Kconfig basically just has the board vendor and defaults, thus acts similar to a defconfig. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: I5fe1c508e97b52a6b70b33107c6e17cc7d7faeb2 --- M Makefile M src/Kconfig M src/mainboard/Kconfig A src/mainboard/adi/Kconfig A src/mainboard/adi/Kconfig.branch A src/mainboard/adi/Kconfig.name A src/mainboard/advansus/Kconfig A src/mainboard/advansus/Kconfig.branch A src/mainboard/advansus/Kconfig.name M src/mainboard/amd/Kconfig A src/mainboard/amd/Kconfig.branch 11 files changed, 144 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/63754/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5fe1c508e97b52a6b70b33107c6e17cc7d7faeb2 Gerrit-Change-Number: 63754 Gerrit-PatchSet: 2 Gerrit-Owner: Martin L Roth <martinroth(a)google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022