Attention is currently required from: Elyes Haouas.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/60748
to look at the new patch set (#2).
Change subject: mainboard/google: Remove unused <boardid.h>
......................................................................
mainboard/google: Remove unused <boardid.h>
Found using:
diff <(git grep -l '#include <boardid.h>' -- src/) <(git grep -l 'UNDEFINED_STRAPPING_ID\|BOARD_ID_UNKNOWN\|BOARD_ID_INIT\|board_id(\|ram_code(\|sku_id(' -- src/) |grep "<"
Change-Id: I2611be41e8730a9b189b1b0aa3fe62be0757b371
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
---
M src/mainboard/google/dedede/variants/haboki/gpio.c
M src/mainboard/google/guybrush/variants/dewatt/gpio.c
M src/mainboard/google/herobrine/board.h
M src/mainboard/google/herobrine/mainboard.c
M src/mainboard/google/octopus/variants/bloog/variant.c
M src/mainboard/google/octopus/variants/bobba/gpio.c
M src/mainboard/google/octopus/variants/bobba/variant.c
M src/mainboard/google/octopus/variants/dood/gpio.c
M src/mainboard/google/octopus/variants/foob/gpio.c
M src/mainboard/google/octopus/variants/garg/gpio.c
M src/mainboard/google/octopus/variants/garg/variant.c
M src/mainboard/google/veyron/board.h
M src/mainboard/google/veyron_mickey/board.h
M src/mainboard/google/veyron_rialto/board.h
14 files changed, 0 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/60748/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/60748
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2611be41e8730a9b189b1b0aa3fe62be0757b371
Gerrit-Change-Number: 60748
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-MessageType: newpatchset
Attention is currently required from: Robert Chen.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63111 )
Change subject: mb/google/dedede/var/kracko: Add FW_CONFIG probe for EXT_VR
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/63111
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib12265591e679e6b9ed34299f1256db05147eaef
Gerrit-Change-Number: 63111
Gerrit-PatchSet: 5
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 21 Apr 2022 08:03:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Raul Rangel, Ian Feng, Karthik Ramasubramanian.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63739 )
Change subject: mb/google/skyrim: Configure SD card reader power sequence
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/skyrim/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/63739/comment/d3ab0d96_4199ca07
PS5, Line 201: PAD_GPO(GPIO_27, HIGH),
ramstage set high is enough, do we need set high here?
--
To view, visit https://review.coreboot.org/c/coreboot/+/63739
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03d88d90acc03cdebcb1e83ed2e799dda8b5b735
Gerrit-Change-Number: 63739
Gerrit-PatchSet: 5
Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 21 Apr 2022 08:00:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Robert Chen.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63110 )
Change subject: mb/google/dedede/var/drawcia: Add FW_CONFIG probe for EXT_VR
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/63110
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I683049e9d2b10fc9455ef782ce798f1c453073bc
Gerrit-Change-Number: 63110
Gerrit-PatchSet: 6
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 21 Apr 2022 07:57:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Robert Chen.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63112 )
Change subject: mb/google/dedede/var/lantis: Add FW_CONFIG probe for EXT_VR
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/63112
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d8eec1d2f962d42f3be225eef8498e8b722aace
Gerrit-Change-Number: 63112
Gerrit-PatchSet: 5
Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tony Huang <tony-huang(a)quanta.corp-partner.google.com>
Gerrit-CC: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Robert Chen <robert.chen(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 21 Apr 2022 07:55:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: YH Lin, Leo Chou.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63442 )
Change subject: mb/google/brya/var/taniks: Configure Acoustic noise mitigation
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/63442
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I262ef14032e0e412c63403dbb8c8fbc6a8b03dd5
Gerrit-Change-Number: 63442
Gerrit-PatchSet: 2
Gerrit-Owner: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Leo Chou <leo.chou(a)lcfc.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 21 Apr 2022 07:53:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Arthur Heymans, Sridhar Siricilla.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63734 )
Change subject: soc/intel/common: Fix buggy code tries to access DESC region
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
could you add this bus? b:229003612 , this CL is fix this issue right?
--
To view, visit https://review.coreboot.org/c/coreboot/+/63734
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib144cc0845b7527e5a3032529b0802f961944b87
Gerrit-Change-Number: 63734
Gerrit-PatchSet: 3
Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Comment-Date: Thu, 21 Apr 2022 07:47:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Julius Werner.
Mattias Nissler has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62639 )
Change subject: util/cbmem: add an option to append timestamp
......................................................................
Patch Set 4:
(4 comments)
File util/cbmem/cbmem.c:
https://review.coreboot.org/c/coreboot/+/62639/comment/b4589820_6d85d251
PS3, Line 32: #if defined(__x86_64__)
> Can we make this […]
Done
https://review.coreboot.org/c/coreboot/+/62639/comment/0f96777f_2ffc2a29
PS3, Line 467: return tsc_freq_khz / 1000;
> I'm not sure this is correct, tbh. […]
I did try this code out on volteer/brya platforms, and it actually produces a frequency that is incorrect, i.e. not the TSC frequency, and that seemed wrong with respect to the firmware side code. So this change was really a best effort to improve things. I guess ancient coreboot wouldn't be affected given that the TSC_INFO table entry was introduced in 2016, but you're correct that there's a risk of breaking things, so let me back this out.
https://review.coreboot.org/c/coreboot/+/62639/comment/f8170dd0_eb0007c8
PS3, Line 557: #if defined(__x86_64__)
> here too
Done
https://review.coreboot.org/c/coreboot/+/62639/comment/4306585a_a222dc04
PS3, Line 583: if (!strcmp(timestamp_ids[i].name, name))
> How do you expect this to be used... […]
Ah, that's much better, thanks for the suggestion! Done.
--
To view, visit https://review.coreboot.org/c/coreboot/+/62639
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic99e5a11d8cc3f9fffae8eaf2787652105cf4842
Gerrit-Change-Number: 62639
Gerrit-PatchSet: 4
Gerrit-Owner: Mattias Nissler <mnissler(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 21 Apr 2022 07:31:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Mattias Nissler, Paul Menzel.
Hello build bot (Jenkins), Julius Werner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62639
to look at the new patch set (#4).
Change subject: util/cbmem: add an option to append timestamp
......................................................................
util/cbmem: add an option to append timestamp
Add an option to the cbmem utility that can be used to append an entry
to the cbmem timestamp table from userspace. This is useful for
bookkeeping of post-coreboot timing information while still being able
to use cbmem-based tooling for processing the generated data.
BUG=b:217638034
BRANCH=none
TEST=Manual: cbmem -a 1234 to append timestamp, verify that cbmem -t
shows the added timestamp.
Change-Id: Ic99e5a11d8cc3f9fffae8eaf2787652105cf4842
Signed-off-by: Mattias Nissler <mnissler(a)chromium.org>
---
M util/cbmem/cbmem.c
1 file changed, 96 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/62639/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/62639
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic99e5a11d8cc3f9fffae8eaf2787652105cf4842
Gerrit-Change-Number: 62639
Gerrit-PatchSet: 4
Gerrit-Owner: Mattias Nissler <mnissler(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Mattias Nissler <mnissler(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset