coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: {drivers,northbridge,security}: Remove unused <cpu/x86/lapic.h>
by Elyes Haouas (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Andrey Petrov, Patrick Rudolph. Hello build bot (Jenkins), Andrey Petrov, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/61048 to look at the new patch set (#2). Change subject: {drivers,northbridge,security}: Remove unused <cpu/x86/lapic.h> ...................................................................... {drivers,northbridge,security}: Remove unused <cpu/x86/lapic.h> Found using: diff <(git grep -l '#include <cpu/x86/lapic.h>' -- src/) <(git grep -l 'xapic_read\|xapic_write\|xapic_send_ipi\|xapic_busy\|x2apic_read\|x2apic_write\|x2apic_send_ipi\|is_x2apic_mode\|lapic_read\|lapic_write\|lapic_update32\|lapic_send_ipi\|lapic_busy\|initial_lapicid\|lapicid\|stop_this_cpu\|enable_lapic\|disable_lapic\|setup_lapic' -- src/) |grep ">" Change-Id: Ie8fcf61a0604281c23cd3f589f1aa0cdbbd9366b Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/drivers/generic/ioapic/ioapic.c M src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c M src/northbridge/amd/pi/00730F01/northbridge.c M src/security/intel/txt/common.c M src/security/intel/txt/getsec.c 5 files changed, 0 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/61048/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61048 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie8fcf61a0604281c23cd3f589f1aa0cdbbd9366b Gerrit-Change-Number: 61048 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mainboard/samsung: Remove unused <acpi/acpi.h>
by Elyes Haouas (Code Review) 21 Apr '22

21 Apr '22

1 0

Change in coreboot[master]: cpu/intel: Remove unused <acpi/acpi.h>
by Elyes Haouas (Code Review) 21 Apr '22

21 Apr '22

1 0

Change in coreboot[master]: drivers: Remove unused <acpi/acpi.h>
by Elyes Haouas (Code Review) 21 Apr '22

21 Apr '22

1 0

Change in coreboot[master]: {arch,cpu}: Remove redundant <arch/cpu.h>
by Elyes Haouas (Code Review) 21 Apr '22

21 Apr '22

1 0

Change in coreboot[master]: soc/intel: Remove unused <acpi/acpi.h>
by Elyes Haouas (Code Review) 21 Apr '22

21 Apr '22

1 0

Change in coreboot[master]: soc/intel: Remove unused <cpu/x86/tsc.h>
by Elyes Haouas (Code Review) 21 Apr '22

21 Apr '22

1 0

Change in coreboot[master]: soc/intel: Remove unused <cpu/intel/common/common.h>
by Elyes Haouas (Code Review) 21 Apr '22

21 Apr '22

1 0

Change in coreboot[master]: libpayload: Support x86 payload loaded via Linux Boot Protocol
by Nico Huber (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Tim Wawrzynczak, Julius Werner. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63748 ) Change subject: libpayload: Support x86 payload loaded via Linux Boot Protocol ...................................................................... Patch Set 1: (2 comments) File payloads/libpayload/arch/x86/head.S: https://review.coreboot.org/c/coreboot/+/63748/comment/26591d80_89cd28e8 PS1, Line 86: jne 1f > (Note that as far as I can tell, this hasn't worked in a long time, maybe ever(?)... […] Good to know. I only had a quick look at it and couldn't find that CB_MAGIC in coreboot. I also seem to remember that we simply pass a pointer to cbtables. https://review.coreboot.org/c/coreboot/+/63748/comment/e24a1cd4_c9e93802 PS1, Line 105: esi > Where does %esi come from? Is the caller supposed to set it? That would be a problem for callers tha […] The caller points to a configuration struct (aka. zero page) in %esi. If we always run into this path, I guess it's best to add a Kconfig so we always know what to expect? I could also add some sanity check on the value, e.g. %esi <= 0xa0000 || 0x100000 <= %esi <= 0x2000000 (the C code assumes at least 32MiB are available, IIRC). But not sure if it's worth trying to get this perfect, as the whole thing feels like just a rather custom quirk. -- To view, visit https://review.coreboot.org/c/coreboot/+/63748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ief6bca8534d07458b9c5a315f297cb62d727917f Gerrit-Change-Number: 63748 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Thu, 21 Apr 2022 08:21:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/qualcomm: Replace <cbfs.h> with <program_loading.h>
by Elyes Haouas (Code Review) 21 Apr '22

21 Apr '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/61035 to look at the new patch set (#3). Change subject: soc/qualcomm: Replace <cbfs.h> with <program_loading.h> ...................................................................... soc/qualcomm: Replace <cbfs.h> with <program_loading.h> Change-Id: I0cd9960be80330b0b0bf476213bdc242db647e98 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/qualcomm/common/aop_load_reset.c M src/soc/qualcomm/sc7280/cpucp_load_reset.c M src/soc/qualcomm/sc7280/shrm_load_reset.c 3 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/61035/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/61035 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0cd9960be80330b0b0bf476213bdc242db647e98 Gerrit-Change-Number: 61035 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022