coreboot-gerrit April 2022

coreboot-gerrit@coreboot.org

1 participants
5879 discussions

Change in coreboot[master]: soc/intel/common: Fix buggy code tries to access DESC region
by Sridhar Siricilla (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Arthur Heymans, Sridhar Siricilla. Hello Arthur Heymans, build bot (Jenkins), Rizwan Qureshi, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63734 to look at the new patch set (#4). Change subject: soc/intel/common: Fix buggy code tries to access DESC region ...................................................................... soc/intel/common: Fix buggy code tries to access DESC region The patch fixes the buggy code which tries to access the Descriptor Region. The existing code doesn't use correct APIs to access the Descriptor Region. Hence, error message is getting displayed during the boot. BUG=b:229003612 TEST=Build and verify no errors seen while accessing the Descriptor Region. Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Change-Id: Ib144cc0845b7527e5a3032529b0802f961944b87 --- M src/soc/intel/common/basecode/debug/debug_feature.c 1 file changed, 3 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/63734/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/63734 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib144cc0845b7527e5a3032529b0802f961944b87 Gerrit-Change-Number: 63734 Gerrit-PatchSet: 4 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: Fix TOLUD bit field mask
by Elyes Haouas (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Petr Cvek. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63752 ) Change subject: Fix TOLUD bit field mask ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63752/comment/17403997_6013ab5d PS2, Line 7: Fix TOLUD bit field mask maybe : nb/intel/i945/memmap.c: Fix TOLUD bit field mask -- To view, visit https://review.coreboot.org/c/coreboot/+/63752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia27661084e11ea93d5f0dc20bafb488ae2995b49 Gerrit-Change-Number: 63752 Gerrit-PatchSet: 2 Gerrit-Owner: Petr Cvek <petrcvekcz(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Petr Cvek <petrcvekcz(a)gmail.com> Gerrit-Comment-Date: Thu, 21 Apr 2022 08:43:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Fix TOLUD bit field mask
by Elyes Haouas (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Petr Cvek. Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63752 ) Change subject: Fix TOLUD bit field mask ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia27661084e11ea93d5f0dc20bafb488ae2995b49 Gerrit-Change-Number: 63752 Gerrit-PatchSet: 2 Gerrit-Owner: Petr Cvek <petrcvekcz(a)gmail.com> Gerrit-Reviewer: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Petr Cvek <petrcvekcz(a)gmail.com> Gerrit-Comment-Date: Thu, 21 Apr 2022 08:38:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Add SBOM (Software Bill of Materials) Generation
by Christian Walter (Code Review) 21 Apr '22

21 Apr '22

Attention is currently required from: Martin L Roth, Maximilian Brune. Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63639 ) Change subject: Add SBOM (Software Bill of Materials) Generation ...................................................................... Patch Set 5: (1 comment) File src/southbridge/intel/common/firmware/Kconfig: https://review.coreboot.org/c/coreboot/+/63639/comment/2c76f390_70288c55 PS5, Line 23: string "Path and filename of the descriptor.bin file" Should this also get an SBOM file? -- To view, visit https://review.coreboot.org/c/coreboot/+/63639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icb7481d4903f95d200eddbfed7728fbec51819d0 Gerrit-Change-Number: 63639 Gerrit-PatchSet: 5 Gerrit-Owner: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Reviewer: Martin L Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Christian Walter <christian.walter(a)9elements.com> Gerrit-CC: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <martinroth(a)google.com> Gerrit-Attention: Maximilian Brune <maximilian.brune(a)9elements.com> Gerrit-Comment-Date: Thu, 21 Apr 2022 08:27:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/qualcomm: Remove unused <timer.h>
by Elyes Haouas (Code Review) 21 Apr '22

21 Apr '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/60611 to look at the new patch set (#4). Change subject: soc/qualcomm: Remove unused <timer.h> ...................................................................... soc/qualcomm: Remove unused <timer.h> Found using: diff <(git grep -l '#include <timer.h>' -- src/) <(git grep -l 'NSECS_PER_SEC\|USECS_PER_SEC\|MSECS_PER_SEC\|USECS_PER_MSEC\|mono_time\|microseconds\|timeout_callback\|expiration\|timer_monotonic_get\|timers_run\|timer_sched_callback\|mono_time_set_usecs\|mono_time_set_msecs\|mono_time_add_usecs\|mono_time_add_msecs\|mono_time_cmp\|mono_time_after\|mono_time_before\|mono_time_diff_microseconds\|stopwatch\|stopwatch_init\|stopwatch_init_usecs_expire\|stopwatch_init_msecs_expire\|stopwatch_tick\|stopwatch_expired\|stopwatch_wait_until_expired\|stopwatch_duration_usecs\|stopwatch_duration_msecs\|wait_us\|wait_ms' -- src/) Change-Id: Ibc08ea20263623159c78b634d34899ac7da0d3c6 Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/soc/qualcomm/sc7180/clock.c M src/soc/qualcomm/sc7280/clock.c 2 files changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/60611/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/60611 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc08ea20263623159c78b634d34899ac7da0d3c6 Gerrit-Change-Number: 60611 Gerrit-PatchSet: 4 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mainboard/intel: Remove unused <acpi/acpi.h>
by Elyes Haouas (Code Review) 21 Apr '22

21 Apr '22

1 0

Change in coreboot[master]: mainboard/lenovo: Remove unused <acpi/acpi.h>
by Elyes Haouas (Code Review) 21 Apr '22

21 Apr '22

1 0

Change in coreboot[master]: northbridge/intel: Remove unused <acpi/acpi.h>
by Elyes Haouas (Code Review) 21 Apr '22

21 Apr '22

1 0

Change in coreboot[master]: southbridge/intel: Remove unused <acpi/acpi.h>
by Elyes Haouas (Code Review) 21 Apr '22

21 Apr '22

1 0

Change in coreboot[master]: cpu/amd: Remove unused <cpu/x86/pae.h>
by Elyes Haouas (Code Review) 21 Apr '22

21 Apr '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/61047 to look at the new patch set (#3). Change subject: cpu/amd: Remove unused <cpu/x86/pae.h> ...................................................................... cpu/amd: Remove unused <cpu/x86/pae.h> Found using: diff <(git grep -l '#include <cpu/x86/pae.h>' -- src/) <(git grep -l 'memset_pae\|MEMSET_PAE_\|MAPPING_ERROR\|map_2M_page\|paging_identity_map_addr\|paging_enable_for_car\|paging_set_default_pat\|paging_set_pat\|PAT_ENCODE\|PAT_UC_MINUS\|PAT_WB\|PAT_WP\|PAT_WT\|PAT_WC\|PAT_UC\|paging_set_nxe\|paging_disable_pae\|paging_enable_pae\|paging_enable_pae_cr3' -- src/) Change-Id: I4cab4b66c3d123dbb8a948a5596aa4975b31139b Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr> --- M src/cpu/amd/agesa/family14/model_14_init.c M src/cpu/amd/agesa/family15tn/model_15_init.c M src/cpu/amd/agesa/family16kb/model_16_init.c M src/cpu/amd/pi/00730F01/model_16_init.c 4 files changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/61047/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/61047 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4cab4b66c3d123dbb8a948a5596aa4975b31139b Gerrit-Change-Number: 61047 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2022