coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: [WIP]mb/prodrive/hermes: Change gfx init depending on eeprom config
by build bot (Jenkins) (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Patrick Rudolph, Christian Walter. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62649 ) Change subject: [WIP]mb/prodrive/hermes: Change gfx init depending on eeprom config ...................................................................... Patch Set 2: Verified+1 (1 comment) File src/mainboard/prodrive/hermes/mainboard.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143389): https://review.coreboot.org/c/coreboot/+/62649/comment/c302c360_0715b79a PS2, Line 290: dev = dev_find_device(PCI_VENDOR_ID_ASPEED, PCI_DEVICE_ID_ASPEED_AST2050_VGA, NULL); line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/62649 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I24d9ebc2055dc246e7f257aa2f3853b22c8af370 Gerrit-Change-Number: 62649 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Comment-Date: Mon, 07 Mar 2022 17:38:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP]mb/prodrive/hermes: Add libgfxinit support
by Arthur Heymans (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Arthur Heymans, Patrick Rudolph, Christian Walter. Hello build bot (Jenkins), Patrick Rudolph, Christian Walter, Arthur Heymans, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62648 to look at the new patch set (#2). Change subject: [WIP]mb/prodrive/hermes: Add libgfxinit support ...................................................................... [WIP]mb/prodrive/hermes: Add libgfxinit support UNTESTED Change-Id: Ib71d06e1d83cd26b0fef37acc64f699c452c13dc Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/mainboard/prodrive/hermes/Kconfig M src/mainboard/prodrive/hermes/Makefile.inc A src/mainboard/prodrive/hermes/gma-mainboard.ads 3 files changed, 23 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/62648/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62648 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib71d06e1d83cd26b0fef37acc64f699c452c13dc Gerrit-Change-Number: 62648 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/hatch/var/jinlon: Fix EPS detection and disablement
by Matt DeVillier (Code Review) 07 Mar '22

07 Mar '22

Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62593 ) Change subject: mb/google/hatch/var/jinlon: Fix EPS detection and disablement ...................................................................... mb/google/hatch/var/jinlon: Fix EPS detection and disablement Commit ebf14826 [mb/google/hatch/var/jinlon: Switch to using device pointers] broke jinlon boards without an electronic privacy screen (EPS) by disabling the parent device (iGPU) instead of the EPS when determined to be not present via SKU ID. Commit c5a3a4a6 [mb/google/hatch (baseboard): add ACPI backlight support] broke EPS detection by adding a duplicate iGPU device to the devicetree, resulting in the EPS entry being skipped. Fix both of these issues by assigning the device alias to the EPS child device, not the parent (iGPU). Rename the alias for clarity, and combine the duplicate device definitions for the iGPU. Test: build/boot google/jinlon SKU w/o EPS, observe GPU functional in both firmware boot screens and Linux OS. Change-Id: I0615ce361497abe6872085b0dec83292607e53dd Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/62593 Reviewed-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/mainboard/google/hatch/variants/jinlon/mainboard.c M src/mainboard/google/hatch/variants/jinlon/overridetree.cb 2 files changed, 5 insertions(+), 7 deletions(-) Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved diff --git a/src/mainboard/google/hatch/variants/jinlon/mainboard.c b/src/mainboard/google/hatch/variants/jinlon/mainboard.c index d2e5b43..51ef346 100644 --- a/src/mainboard/google/hatch/variants/jinlon/mainboard.c +++ b/src/mainboard/google/hatch/variants/jinlon/mainboard.c @@ -20,20 +20,20 @@ static void check_for_eps(uint32_t sku_id) { - struct device *gfx_dev = DEV_PTR(igpu); + struct device *eps_dev = DEV_PTR(eps); if (eps_sku(sku_id)) { printk(BIOS_INFO, "SKU ID %u has EPS\n", sku_id); return; } - if (!gfx_dev) { + if (!eps_dev) { printk(BIOS_ERR, "Error! No EPS dev, view-angle-management won't work\n"); return; } printk(BIOS_INFO, "SKU ID %u doesn't have EPS, disabling...\n", sku_id); - gfx_dev->enabled = 0; + eps_dev->enabled = 0; } void variant_devtree_update(void) diff --git a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb index b3887d4..88c9a54 100644 --- a/src/mainboard/google/hatch/variants/jinlon/overridetree.cb +++ b/src/mainboard/google/hatch/variants/jinlon/overridetree.cb @@ -69,10 +69,8 @@ register "ScsEmmcHs400Enabled" = "1" device domain 0 on - device pci 02.0 alias igpu on # Integrated Graphics Device - register "gfx" = "GMA_DEFAULT_PANEL(0)" - end device pci 02.0 on + register "gfx" = "GMA_DEFAULT_PANEL(0)" chip drivers/gfx/generic register "device_count" = "1" register "device[0].name" = ""LCD"" @@ -80,7 +78,7 @@ register "device[0].addr" = "0x80010400" register "device[0].privacy.enabled" = "1" register "device[0].privacy.gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E0)" - device generic 0 on end + device generic 0 alias eps on end end end # Integrated Graphics Device device pci 14.0 on -- To view, visit https://review.coreboot.org/c/coreboot/+/62593 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0615ce361497abe6872085b0dec83292607e53dd Gerrit-Change-Number: 62593 Gerrit-PatchSet: 3 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: drivers/pcie/generic: Add support to generate code under companion de...
by Tim Wawrzynczak (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Bora Guvendik, Raul Rangel, Nico Huber, Cliff Huang, Selma Bensaid, Paul Menzel, Felix Held. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62301 ) Change subject: drivers/pcie/generic: Add support to generate code under companion device instead ...................................................................... Patch Set 5: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/62301/comment/04838da7_19472bb3 PS5, Line 34: firmwaBRANCH=firmware-brya-14505.Bre-brya-14505.B `BRANCH=firmware-brya-14505.B` Patchset: PS5: > so the problem this patch should solve is when there are multiple drivers that add acpi code to a de […] Basically, yes. little background: Right now we're working with Microsoft and upstream Linux to add support for this `DmaProperty` (https://docs.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-…) to to indicate DMA trust boundaries (example: https://docs.microsoft.com/en-us/windows/security/information-protection/ke…), and we want to use it similarly. Thus, we want to drop the `UID` property and then attach it to (at a mininum) 1) Wifi/WLAN devices (and any associated root port) 2) WWAN devices (and any associated root port) so for brya&redrix devices, that's 3 places (CNVi device, WWAN root port, and WWAN device). Thus, I needed to attach arbitrary properties to PCIe root ports. Since that root port already had a soc/intel/common/block/pcie/rtd3 driver for adding the RTD3 support, I figured a separate chip driver might be cleaner than adding it to N other chip drivers if possible. -- To view, visit https://review.coreboot.org/c/coreboot/+/62301 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I80634bbfc2927f26f2a55a9c244eca517c437079 Gerrit-Change-Number: 62301 Gerrit-PatchSet: 5 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cliff Huang <cliff.huang(a)intel.corp-partner.google.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 07 Mar 2022 17:35:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP]mb/prodrive/hermes: Change gfx init depending on eeprom config
by Angel Pons (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Arthur Heymans, Patrick Rudolph, Christian Walter. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62649 ) Change subject: [WIP]mb/prodrive/hermes: Change gfx init depending on eeprom config ...................................................................... Patch Set 1: (3 comments) File src/mainboard/prodrive/hermes/mainboard.c: https://review.coreboot.org/c/coreboot/+/62649/comment/cb6f4781_0932fd0b PS1, Line 262: internale_gfx There's a typo, and enum type is unused anyway. I'd also move it closer to `mainboard_configure_internal_gfx()` https://review.coreboot.org/c/coreboot/+/62649/comment/da1727e3_ad4ca10e PS1, Line 280: mainboard_configure_internal_gfx Why not call this from `mainboard_early()`? https://review.coreboot.org/c/coreboot/+/62649/comment/e1a6f1fe_cb2abd57 PS1, Line 283: board_cfg This can be NULL. -- To view, visit https://review.coreboot.org/c/coreboot/+/62649 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I24d9ebc2055dc246e7f257aa2f3853b22c8af370 Gerrit-Change-Number: 62649 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 07 Mar 2022 17:35:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [WIP]mb/prodrive/hermes: Add libgfxinit support
by Angel Pons (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Arthur Heymans, Patrick Rudolph, Christian Walter. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62648 ) Change subject: [WIP]mb/prodrive/hermes: Add libgfxinit support ...................................................................... Patch Set 1: (1 comment) File src/mainboard/prodrive/hermes/Makefile.inc: https://review.coreboot.org/c/coreboot/+/62648/comment/67b93251_e7f0ab3a PS1, Line 16: gma-mainboard.ads Where is this file? -- To view, visit https://review.coreboot.org/c/coreboot/+/62648 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib71d06e1d83cd26b0fef37acc64f699c452c13dc Gerrit-Change-Number: 62648 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Mon, 07 Mar 2022 17:31:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sb/intel/common/firmware: Hook up adding 10GbE LAN firmware
by Angel Pons (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Felix Singer, Jeff Daly, Martin Roth, Paul Menzel, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60877 ) Change subject: sb/intel/common/firmware: Hook up adding 10GbE LAN firmware ...................................................................... Patch Set 16: Code-Review+2 (1 comment) File src/southbridge/intel/common/firmware/Kconfig: https://review.coreboot.org/c/coreboot/+/60877/comment/ac2f95c1_266efe60 PS16, Line 168: depends on MAINBOARD_USES_IFD_10GBE_0_REGION > this is in order to ensure no misconfiguration by an unknowing/careless developer. […] Ah, I see. Thanks for the detailed explanation. -- To view, visit https://review.coreboot.org/c/coreboot/+/60877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id45ab4b69a85a5f8e52c0c4b130b6d729222b4c3 Gerrit-Change-Number: 60877 Gerrit-PatchSet: 16 Gerrit-Owner: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 07 Mar 2022 17:26:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Jeff Daly <jeffd(a)silicom-usa.com> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: sb/intel/common/firmware: Hook up adding 10GbE LAN firmware
by Jeff Daly (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Felix Singer, Martin Roth, Paul Menzel, Angel Pons, Patrick Rudolph. Jeff Daly has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60877 ) Change subject: sb/intel/common/firmware: Hook up adding 10GbE LAN firmware ...................................................................... Patch Set 16: (1 comment) File src/southbridge/intel/common/firmware/Kconfig: https://review.coreboot.org/c/coreboot/+/60877/comment/64b17b47_769b9136 PS16, Line 168: depends on MAINBOARD_USES_IFD_10GBE_0_REGION > I'd drop this dependency. […] this is in order to ensure no misconfiguration by an unknowing/careless developer. 10GbE 1 is only supported in combination with 10GbE 0. you *can't* have only 10GbE 1 LAN. it's possible to have a platform that only uses LAN 1 on the board (perhaps for board routing reasons), but the hardware and strapping options can only enable LAN 1 if LAN 0 is also enabled. it *is* possible to have only LAN 0 enabled in hardware/strapping though. -- To view, visit https://review.coreboot.org/c/coreboot/+/60877 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id45ab4b69a85a5f8e52c0c4b130b6d729222b4c3 Gerrit-Change-Number: 60877 Gerrit-PatchSet: 16 Gerrit-Owner: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 07 Mar 2022 17:22:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/glados: Restore ChromeEC tablet mode switch for caroline, cave
by Felix Held (Code Review) 07 Mar '22

07 Mar '22

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62447 ) Change subject: mb/google/glados: Restore ChromeEC tablet mode switch for caroline, cave ...................................................................... mb/google/glados: Restore ChromeEC tablet mode switch for caroline, cave Commit 017b5c453a72f57ec785da1764939e24651ac5eb [ec/google/chromeec/acpi: Rename EC_ENABLE_TABLET_EVENT config] broke tablet mode on google/caroline and cave in mainline Linux kernels by changing the inclusion of the ChromeEC tablet mode ACPI handler. Fix this by addding it back (using the updated name guarding the inclusion of the tmbc ACPI). Test: build/boot google/cave under Linux 5.16, observe tablet mode handled correctly. Change-Id: Ie0ae5b6a61f104b5e973383344d289cc2e2a7b8d Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com> Reviewed-on: https://review.coreboot.org/c/coreboot/+/62447 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/google/glados/variants/caroline/include/variant/ec.h M src/mainboard/google/glados/variants/cave/include/variant/ec.h 2 files changed, 6 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved diff --git a/src/mainboard/google/glados/variants/caroline/include/variant/ec.h b/src/mainboard/google/glados/variants/caroline/include/variant/ec.h index d0001b4..a03b43e 100644 --- a/src/mainboard/google/glados/variants/caroline/include/variant/ec.h +++ b/src/mainboard/google/glados/variants/caroline/include/variant/ec.h @@ -2,3 +2,6 @@ /* EC ENABLE MULTIPLE DPTF PROFILES */ #define EC_ENABLE_MULTIPLE_DPTF_PROFILES + +/* Enable Tablet switch */ +#define EC_ENABLE_TBMC_DEVICE diff --git a/src/mainboard/google/glados/variants/cave/include/variant/ec.h b/src/mainboard/google/glados/variants/cave/include/variant/ec.h index 8f6aa5e..293cb69 100644 --- a/src/mainboard/google/glados/variants/cave/include/variant/ec.h +++ b/src/mainboard/google/glados/variants/cave/include/variant/ec.h @@ -8,3 +8,6 @@ /* EC ENABLE MULTIPLE DPTF PROFILES */ #define EC_ENABLE_MULTIPLE_DPTF_PROFILES + +/* Enable Tablet switch */ +#define EC_ENABLE_TBMC_DEVICE 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/62447 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie0ae5b6a61f104b5e973383344d289cc2e2a7b8d Gerrit-Change-Number: 62447 Gerrit-PatchSet: 4 Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: drivers/pcie/generic: Add support to generate code under companion de...
by Felix Held (Code Review) 07 Mar '22

07 Mar '22

Attention is currently required from: Bora Guvendik, Raul Rangel, Nico Huber, Cliff Huang, Selma Bensaid, Paul Menzel. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62301 ) Change subject: drivers/pcie/generic: Add support to generate code under companion device instead ...................................................................... Patch Set 5: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/62301/comment/02b1feb7_04820346 PS5, Line 11: to th with the Patchset: PS5: so the problem this patch should solve is when there are multiple drivers that add acpi code to a device, right? not sure if adding a setting to attach the acpi code to a different device is the best approach here File src/drivers/pcie/generic/chip.h: https://review.coreboot.org/c/coreboot/+/62301/comment/3b190ef3_d24f09a7 PS5, Line 10: DEVTREE_CONST struct device *companion_dev; would be helpful to have a comment here to know what the companion_dev is about without having to look into the code that uses this struct element -- To view, visit https://review.coreboot.org/c/coreboot/+/62301 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I80634bbfc2927f26f2a55a9c244eca517c437079 Gerrit-Change-Number: 62301 Gerrit-PatchSet: 5 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cliff Huang <cliff.huang(a)intel.corp-partner.google.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 07 Mar 2022 17:21:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022