coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: soc/mediatek/mt8186: Modify internal capid to 0xE0
by Yu-Ping Wu (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62563 ) Change subject: soc/mediatek/mt8186: Modify internal capid to 0xE0 ...................................................................... Patch Set 10: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62563/comment/79865a36_e4782d15 PS10, Line 12: meets is met -- To view, visit https://review.coreboot.org/c/coreboot/+/62563 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2139e6b3456d7a50e3cdc8fc606e5f6ea3406044 Gerrit-Change-Number: 62563 Gerrit-PatchSet: 10 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Comment-Date: Wed, 09 Mar 2022 10:13:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brask/variants/moli: Reduce PSysMax to 11 A
by Raihow Shi (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: YH Lin, Tim Wawrzynczak, Paul Menzel, Angel Pons, Zoey Wu, Felix Held. Raihow Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62374 ) Change subject: mb/google/brask/variants/moli: Reduce PSysMax to 11 A ...................................................................... Patch Set 13: (1 comment) File src/mainboard/google/brya/variants/moli/ramstage.c: https://review.coreboot.org/c/coreboot/+/62374/comment/03d5ca35_2d7a8059 PS9, Line 13: PCI_DEVICE_ID_INTEL_ADL_P_ID_10 > You need to rebase this on top of current master, you can do it using the "Rebase" button on Gerrit' […] done -- To view, visit https://review.coreboot.org/c/coreboot/+/62374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61f4813f3527123a590d80b4a6e49d76ebb71c99 Gerrit-Change-Number: 62374 Gerrit-PatchSet: 13 Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Peter Chi <peter_chi(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 09 Mar 2022 10:04:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Comment-In-Reply-To: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brask/variants/moli: Reduce PSysMax to 11 A
by Angel Pons (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: YH Lin, Tim Wawrzynczak, Paul Menzel, Zoey Wu, Raihow Shi, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62374 ) Change subject: mb/google/brask/variants/moli: Reduce PSysMax to 11 A ...................................................................... Patch Set 12: Code-Review+1 (1 comment) File src/mainboard/google/brya/variants/moli/ramstage.c: https://review.coreboot.org/c/coreboot/+/62374/comment/526a54b6_2d6cf7b1 PS9, Line 13: PCI_DEVICE_ID_INTEL_ADL_P_ID_10 > I refer to pci_ids. […] You need to rebase this on top of current master, you can do it using the "Rebase" button on Gerrit's Web UI. -- To view, visit https://review.coreboot.org/c/coreboot/+/62374 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61f4813f3527123a590d80b4a6e49d76ebb71c99 Gerrit-Change-Number: 62374 Gerrit-PatchSet: 12 Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Peter Chi <peter_chi(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 09 Mar 2022 09:45:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brask/variants/moli: Change DDR4 Interleave to Non-Interleave
by Angel Pons (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: YH Lin, Zoey Wu, Felix Held. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62478 ) Change subject: mb/google/brask/variants/moli: Change DDR4 Interleave to Non-Interleave ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62478 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iab153f16a3b729e7fa9daaa3dbfbccc70e6d789d Gerrit-Change-Number: 62478 Gerrit-PatchSet: 5 Gerrit-Owner: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Chi <peter_chi(a)wistron.corp-partner.google.com> Gerrit-CC: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 09 Mar 2022 09:45:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/dell/optiplex_9010/sch5545_ec.c: Fix HWM initialization bugs
by Michał Żygowski (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Martin Roth. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62210 ) Change subject: mb/dell/optiplex_9010/sch5545_ec.c: Fix HWM initialization bugs ...................................................................... Patch Set 2: (1 comment) File src/mainboard/dell/optiplex_9010/sch5545_ec.c: https://review.coreboot.org/c/coreboot/+/62210/comment/5c259a17_a3c864c6 PS1, Line 676: ec_read_write_reg(EC_HWM_LDN, 0x0027, &val, READ_OP); > This could probably use a better commit title than "fix small bugs" Right, I made a too big shortcut. Please have a look now. -- To view, visit https://review.coreboot.org/c/coreboot/+/62210 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c0e1c00e69d66848a602ad91a3e83375a095f44 Gerrit-Change-Number: 62210 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Wed, 09 Mar 2022 09:39:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/dell: Convert OptiPlex 9010 into directory with variants
by Michał Żygowski (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Michał Żygowski. Hello build bot (Jenkins), Martin Roth, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62211 to look at the new patch set (#2). Change subject: mb/dell: Convert OptiPlex 9010 into directory with variants ...................................................................... mb/dell: Convert OptiPlex 9010 into directory with variants New boards like Dell Precision T1650 will be added as variants, in subsequent commit. They share most of the code, except some EC initialization tables, PCIe port configuration and subsystem ID. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I4075f0ae3b24892fcc2be07061a01f8070659239 --- D src/mainboard/dell/optiplex_9010/Kconfig.name R src/mainboard/dell/snb_ivb_workstations/Kconfig A src/mainboard/dell/snb_ivb_workstations/Kconfig.name R src/mainboard/dell/snb_ivb_workstations/Makefile.inc R src/mainboard/dell/snb_ivb_workstations/acpi/ec.asl R src/mainboard/dell/snb_ivb_workstations/acpi/platform.asl R src/mainboard/dell/snb_ivb_workstations/acpi/superio.asl R src/mainboard/dell/snb_ivb_workstations/board_info.txt R src/mainboard/dell/snb_ivb_workstations/cmos.default R src/mainboard/dell/snb_ivb_workstations/cmos.layout R src/mainboard/dell/snb_ivb_workstations/devicetree.cb R src/mainboard/dell/snb_ivb_workstations/dsdt.asl R src/mainboard/dell/snb_ivb_workstations/early_init.c R src/mainboard/dell/snb_ivb_workstations/gma-mainboard.ads R src/mainboard/dell/snb_ivb_workstations/gpio.c C src/mainboard/dell/snb_ivb_workstations/hda_verb.c R src/mainboard/dell/snb_ivb_workstations/mainboard.c R src/mainboard/dell/snb_ivb_workstations/romstage.c R src/mainboard/dell/snb_ivb_workstations/sch5545_ec.c R src/mainboard/dell/snb_ivb_workstations/sch5545_ec_early.c R src/mainboard/dell/snb_ivb_workstations/smihandler.c C src/mainboard/dell/snb_ivb_workstations/variants/baseboard/devicetree.cb R src/mainboard/dell/snb_ivb_workstations/variants/baseboard/include/baseboard/sch5545_ec.h R src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_sff/data.vbt R src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_sff/hda_verb.c A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_sff/include/variant/sch5545_ec_tables.h A src/mainboard/dell/snb_ivb_workstations/variants/optiplex_9010_sff/overridetree.cb 27 files changed, 323 insertions(+), 271 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/62211/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62211 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4075f0ae3b24892fcc2be07061a01f8070659239 Gerrit-Change-Number: 62211 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/dell/optiplex_9010/sch5545_ec.c: Fix HWM initialization bugs
by Michał Żygowski (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Michał Żygowski. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62210 to look at the new patch set (#2). Change subject: mb/dell/optiplex_9010/sch5545_ec.c: Fix HWM initialization bugs ...................................................................... mb/dell/optiplex_9010/sch5545_ec.c: Fix HWM initialization bugs Fix the HWM sequence matching to the chassis. HWM sequence for SFF was incorrectly passed to MT chassis HWM initialization. Vendor code also applies a fix-up for MT/DT chassis. This fixup was missing one register read compared to the vendor code. Add the missing read and guard the fixup depening on the returned value to match the vendor code behavior. Not doing so resulted in increased fan speeds on Dell Precision T1650 compared to Dell's firmware. TEST=Boot Dell Precision T1650 and hear the fans are as silent as on Dell's firmware Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I5c0e1c00e69d66848a602ad91a3e83375a095f44 --- M src/mainboard/dell/optiplex_9010/sch5545_ec.c 1 file changed, 24 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/62210/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62210 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c0e1c00e69d66848a602ad91a3e83375a095f44 Gerrit-Change-Number: 62210 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/dell/optiplex_9010: Fix chassis types
by Michał Żygowski (Code Review) 09 Mar '22

09 Mar '22

Michał Żygowski has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62209 ) Change subject: mb/dell/optiplex_9010: Fix chassis types ...................................................................... mb/dell/optiplex_9010: Fix chassis types Discovered this chassis identification number on Dell Precision T1650 which is much OptiPlex 9010 alike. Precision T1650 is a Mid Tower (MT) chassis. Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I2266fe39606b947a3d30a9462377fd56c39c2fa7 Reviewed-on: https://review.coreboot.org/c/coreboot/+/62209 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martinroth(a)google.com> --- M src/mainboard/dell/optiplex_9010/mainboard.c M src/mainboard/dell/optiplex_9010/sch5545_ec.c 2 files changed, 2 insertions(+), 4 deletions(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved diff --git a/src/mainboard/dell/optiplex_9010/mainboard.c b/src/mainboard/dell/optiplex_9010/mainboard.c index 8a619c0..25f9196 100644 --- a/src/mainboard/dell/optiplex_9010/mainboard.c +++ b/src/mainboard/dell/optiplex_9010/mainboard.c @@ -64,16 +64,13 @@ printk(BIOS_DEBUG, "Chassis type: "); switch (pin_sts) { case 0: + case 4: printk(BIOS_DEBUG, "MT\n"); break; case 3: case 11: printk(BIOS_DEBUG, "USFF\n"); break; - case 4: - /* As per table in schematics, but don't know what this is */ - printk(BIOS_DEBUG, "Comoros\n"); - break; case 1: case 9: case 5: diff --git a/src/mainboard/dell/optiplex_9010/sch5545_ec.c b/src/mainboard/dell/optiplex_9010/sch5545_ec.c index 60cde7d..fa78a98 100644 --- a/src/mainboard/dell/optiplex_9010/sch5545_ec.c +++ b/src/mainboard/dell/optiplex_9010/sch5545_ec.c @@ -547,6 +547,7 @@ /* This mapping will determine which EC init sequence to use */ switch (chassis_id) { case 0x0: + case 0x4: return 5; case 0x8: return 4; -- To view, visit https://review.coreboot.org/c/coreboot/+/62209 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2266fe39606b947a3d30a9462377fd56c39c2fa7 Gerrit-Change-Number: 62209 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: mb/dell/optiplex_9010/mainboard.c: Add missing space
by Michał Żygowski (Code Review) 09 Mar '22

09 Mar '22

Michał Żygowski has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62208 ) Change subject: mb/dell/optiplex_9010/mainboard.c: Add missing space ...................................................................... mb/dell/optiplex_9010/mainboard.c: Add missing space Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> Change-Id: I3487b0ab94e565862ed727e9a91bd1efb364d43d Reviewed-on: https://review.coreboot.org/c/coreboot/+/62208 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Martin Roth <martinroth(a)google.com> --- M src/mainboard/dell/optiplex_9010/mainboard.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved diff --git a/src/mainboard/dell/optiplex_9010/mainboard.c b/src/mainboard/dell/optiplex_9010/mainboard.c index 4490c14..8a619c0 100644 --- a/src/mainboard/dell/optiplex_9010/mainboard.c +++ b/src/mainboard/dell/optiplex_9010/mainboard.c @@ -61,7 +61,7 @@ pin_sts |= get_gpio(GPIO_CHASSIS_ID2) << 2; pin_sts |= get_gpio(GPIO_FRONT_PANEL_CHASSIS_DET_L) << 3; - printk(BIOS_DEBUG, "Chassis type:"); + printk(BIOS_DEBUG, "Chassis type: "); switch (pin_sts) { case 0: printk(BIOS_DEBUG, "MT\n"); -- To view, visit https://review.coreboot.org/c/coreboot/+/62208 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3487b0ab94e565862ed727e9a91bd1efb364d43d Gerrit-Change-Number: 62208 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/mediatek/mt8186: Modify internal capid to 0xE0
by Rex-BC Chen (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62563 ) Change subject: soc/mediatek/mt8186: Modify internal capid to 0xE0 ...................................................................... Patch Set 10: Code-Review+1 (1 comment) Patchset: PS10: xtal test pass. @yu-ping, please help to review. -- To view, visit https://review.coreboot.org/c/coreboot/+/62563 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2139e6b3456d7a50e3cdc8fc606e5f6ea3406044 Gerrit-Change-Number: 62563 Gerrit-PatchSet: 10 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Wed, 09 Mar 2022 09:15:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022