coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: commonlib/timestamp_serialized: Add timestamp enum to name mapping
by Jakub Czapiga (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Jakub Czapiga. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62709 to look at the new patch set (#3). Change subject: commonlib/timestamp_serialized: Add timestamp enum to name mapping ...................................................................... commonlib/timestamp_serialized: Add timestamp enum to name mapping Some solutions require readable form of timestamps, which does not contain spaces. Current descriptive timestamp names do not meet this criteria. Also, mapping enums to their text representation allows for quick grepping (use of grep command) to find relevant timestamps in the code. Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> Change-Id: Ifd49f20d6b00a5bbd21804cea3a50b8cef074cd1 --- M src/commonlib/include/commonlib/timestamp_serialized.h 1 file changed, 136 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/62709/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/62709 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd49f20d6b00a5bbd21804cea3a50b8cef074cd1 Gerrit-Change-Number: 62709 Gerrit-PatchSet: 3 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/cbmem: Add FlameGraph-compatible timestamps output
by build bot (Jenkins) (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Jakub Czapiga, Tim Wawrzynczak, Paul Menzel, Alex Levin, Julius Werner, Jan Dabros. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62474 ) Change subject: util/cbmem: Add FlameGraph-compatible timestamps output ...................................................................... Patch Set 6: Verified-1 (3 comments) File src/commonlib/include/commonlib/timestamp_serialized.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143597): https://review.coreboot.org/c/coreboot/+/62474/comment/7e184bb8_59d8bb64 PS6, Line 515: >>>>>>> c8d4738992 (util/cbmem: Add FlameGraph-compatible timestamps output) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143597): https://review.coreboot.org/c/coreboot/+/62474/comment/69634d20_7414e7a8 PS6, Line 515: >>>>>>> c8d4738992 (util/cbmem: Add FlameGraph-compatible timestamps output) spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143597): https://review.coreboot.org/c/coreboot/+/62474/comment/c31d4133_6f2ab78f PS6, Line 515: >>>>>>> c8d4738992 (util/cbmem: Add FlameGraph-compatible timestamps output) spaces required around that ':' (ctx:VxW) -- To view, visit https://review.coreboot.org/c/coreboot/+/62474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a4e20a267e9e0fbc6b3a4d6a2409b32ce8fca33 Gerrit-Change-Number: 62474 Gerrit-PatchSet: 6 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Alex Levin <levinale(a)google.com> Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alex Levin <levinale(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com> Gerrit-Comment-Date: Wed, 09 Mar 2022 11:46:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common: Use heci_reset() in the CSE TX and RX flows
by Sridhar Siricilla (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Tim Wawrzynczak, Sridhar Siricilla, Patrick Rudolph. Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62587 ) Change subject: soc/intel/common: Use heci_reset() in the CSE TX and RX flows ...................................................................... Patch Set 3: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62587/comment/66d0dff4_91c65c6e PS2, Line 12: cse > nit: `CSE`, like you wrote above Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/62587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e4a97800cbc5d95b8fd259e6e34a32fc82d8563 Gerrit-Change-Number: 62587 Gerrit-PatchSet: 3 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sridhar Siricilla <sridhar.nest(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 09 Mar 2022 11:31:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/common: Retry END_OF_POST command
by Sridhar Siricilla (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Anil Kumar K, Tim Wawrzynczak, Patrick Rudolph. Hello build bot (Jenkins), Anil Kumar K, Subrata Banik, Tim Wawrzynczak, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62192 to look at the new patch set (#11). Change subject: soc/intel/common: Retry END_OF_POST command ...................................................................... soc/intel/common: Retry END_OF_POST command The patch adds retry mechanism for EOP command. If coreboot fails to send or receive the EOP command/response, it retries the EOP command max 3 times before triggering the error handling flow. BUG=b:200251277 TEST=Verify EOP retry mechanism for brya board. Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Change-Id: Ieaec4d5564e3d962c1cc866351e9e7eaa8e58683 --- M src/soc/intel/common/block/cse/cse_eop.c 1 file changed, 33 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/62192/11 -- To view, visit https://review.coreboot.org/c/coreboot/+/62192 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieaec4d5564e3d962c1cc866351e9e7eaa8e58683 Gerrit-Change-Number: 62192 Gerrit-PatchSet: 11 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sridhar Siricilla <sridhar.nest(a)gmail.com> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common: Retry MEI CSE DISABLE command
by Sridhar Siricilla (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph. Hello build bot (Jenkins), Tim Wawrzynczak, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62560 to look at the new patch set (#5). Change subject: soc/intel/common: Retry MEI CSE DISABLE command ...................................................................... soc/intel/common: Retry MEI CSE DISABLE command The patch retries MEI CSE DISABLE command if cse doesn't respond or sends the garbled response. It retries the command additionally 2 more times. TEST=build and boot the Brya board Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Change-Id: Id38a172d670a0cd44643744f27b85ca7e368ccdb --- M src/soc/intel/common/block/cse/cse_eop.c 1 file changed, 10 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/62560/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/62560 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id38a172d670a0cd44643744f27b85ca7e368ccdb Gerrit-Change-Number: 62560 Gerrit-PatchSet: 5 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sridhar Siricilla <sridhar.nest(a)gmail.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common: Use generic enum type values
by Sridhar Siricilla (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Patrick Rudolph. Hello build bot (Jenkins), Subrata Banik, Tim Wawrzynczak, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62708 to look at the new patch set (#2). Change subject: soc/intel/common: Use generic enum type values ...................................................................... soc/intel/common: Use generic enum type values The patch uses generic enum type values for EOP command handler. So, it renames cse_eop_result enum type to cse_cmd_result and also renames the enum values to have generic name. TEST=Build the code for Gimble Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Change-Id: Ie0efa8fff08318ed863010db289959d113f4767e --- M src/soc/intel/common/block/cse/cse_eop.c 1 file changed, 20 insertions(+), 20 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/62708/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62708 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie0efa8fff08318ed863010db289959d113f4767e Gerrit-Change-Number: 62708 Gerrit-PatchSet: 2 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Sridhar Siricilla <sridhar.nest(a)gmail.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/common: Use heci_reset() in the CSE TX and RX flows
by Sridhar Siricilla (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Patrick Rudolph. Hello build bot (Jenkins), Tim Wawrzynczak, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62587 to look at the new patch set (#4). Change subject: soc/intel/common: Use heci_reset() in the CSE TX and RX flows ...................................................................... soc/intel/common: Use heci_reset() in the CSE TX and RX flows The patch implements error handling as per the ME BWG guide. The BWG recommends HECI interface reset if there is a timeout or malformed response is received from the CSE. Also, the patch triggers HECI interface reset if the CSE link state is not ready in the heci_send() API. TEST=Verify HECI Interface reset in the simulated error scenarios. Signed-off-by: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Change-Id: I3e4a97800cbc5d95b8fd259e6e34a32fc82d8563 --- M src/soc/intel/common/block/cse/cse.c 1 file changed, 6 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/62587/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/62587 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3e4a97800cbc5d95b8fd259e6e34a32fc82d8563 Gerrit-Change-Number: 62587 Gerrit-PatchSet: 4 Gerrit-Owner: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/cbmem: Add FlameGraph-compatible timestamps output
by build bot (Jenkins) (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Alex Levin, Julius Werner, Jan Dabros. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62474 ) Change subject: util/cbmem: Add FlameGraph-compatible timestamps output ...................................................................... Patch Set 5: (3 comments) File src/commonlib/include/commonlib/timestamp_serialized.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143591): https://review.coreboot.org/c/coreboot/+/62474/comment/6d99fb53_0a7f7661 PS5, Line 515: >>>>>>> c8d4738992 (util/cbmem: Add FlameGraph-compatible timestamps output) space prohibited between function name and open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143591): https://review.coreboot.org/c/coreboot/+/62474/comment/99c40b78_19616e40 PS5, Line 515: >>>>>>> c8d4738992 (util/cbmem: Add FlameGraph-compatible timestamps output) spaces required around that '>' (ctx:OxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-143591): https://review.coreboot.org/c/coreboot/+/62474/comment/0590fd6e_7d3c6be0 PS5, Line 515: >>>>>>> c8d4738992 (util/cbmem: Add FlameGraph-compatible timestamps output) spaces required around that ':' (ctx:VxW) -- To view, visit https://review.coreboot.org/c/coreboot/+/62474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a4e20a267e9e0fbc6b3a4d6a2409b32ce8fca33 Gerrit-Change-Number: 62474 Gerrit-PatchSet: 5 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Alex Levin <levinale(a)google.com> Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alex Levin <levinale(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com> Gerrit-Comment-Date: Wed, 09 Mar 2022 11:27:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: commonlib/timestamp_serialized: Add timestamp enum to name mapping
by Jakub Czapiga (Code Review) 09 Mar '22

09 Mar '22

Jakub Czapiga has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62709 ) Change subject: commonlib/timestamp_serialized: Add timestamp enum to name mapping ...................................................................... commonlib/timestamp_serialized: Add timestamp enum to name mapping Some solutions require readable form of timestamps, which does not contain spaces. Current descriptive timestamp names do not meet this criteria. Also, mapping enums to their text representation allows for quick grepping (use of grep command) to find relevant timestamps in the code. Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> Change-Id: Ifd49f20d6b00a5bbd21804cea3a50b8cef074cd1 --- M src/commonlib/include/commonlib/timestamp_serialized.h 1 file changed, 136 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/62709/1 diff --git a/src/commonlib/include/commonlib/timestamp_serialized.h b/src/commonlib/include/commonlib/timestamp_serialized.h index 492508e..0952011 100644 --- a/src/commonlib/include/commonlib/timestamp_serialized.h +++ b/src/commonlib/include/commonlib/timestamp_serialized.h @@ -313,4 +313,140 @@ { TS_END_POSTCAR, "end of postcar" }, }; +#define ts_str(x) #x +#define ts_enum_to_name_pair(e) { e, ts_str(e) } + +static const struct timestamp_id_to_enum_name { + uint32_t id; + const char *name; +} timestamp_enum_ids[] = { + { 0, "TS_START"}, + ts_enum_to_name_pair(TS_START_ROMSTAGE), + ts_enum_to_name_pair(TS_BEFORE_INITRAM), + ts_enum_to_name_pair(TS_AFTER_INITRAM), + ts_enum_to_name_pair(TS_END_ROMSTAGE), + ts_enum_to_name_pair(TS_START_VBOOT), + ts_enum_to_name_pair(TS_END_VBOOT), + ts_enum_to_name_pair(TS_START_COPYRAM), + ts_enum_to_name_pair(TS_END_COPYRAM), + ts_enum_to_name_pair(TS_START_RAMSTAGE), + ts_enum_to_name_pair(TS_START_BOOTBLOCK), + ts_enum_to_name_pair(TS_END_BOOTBLOCK), + ts_enum_to_name_pair(TS_START_COPYROM), + ts_enum_to_name_pair(TS_END_COPYROM), + ts_enum_to_name_pair(TS_START_ULZMA), + ts_enum_to_name_pair(TS_END_ULZMA), + ts_enum_to_name_pair(TS_START_ULZ4F), + ts_enum_to_name_pair(TS_END_ULZ4F), + ts_enum_to_name_pair(TS_DEVICE_ENUMERATE), + ts_enum_to_name_pair(TS_DEVICE_CONFIGURE), + ts_enum_to_name_pair(TS_DEVICE_ENABLE), + ts_enum_to_name_pair(TS_DEVICE_INITIALIZE), + ts_enum_to_name_pair(TS_OPROM_INITIALIZE), + ts_enum_to_name_pair(TS_OPROM_COPY_END), + ts_enum_to_name_pair(TS_OPROM_END), + ts_enum_to_name_pair(TS_DEVICE_DONE), + ts_enum_to_name_pair(TS_CBMEM_POST), + ts_enum_to_name_pair(TS_WRITE_TABLES), + ts_enum_to_name_pair(TS_FINALIZE_CHIPS), + ts_enum_to_name_pair(TS_LOAD_PAYLOAD), + ts_enum_to_name_pair(TS_ACPI_WAKE_JUMP), + ts_enum_to_name_pair(TS_SELFBOOT_JUMP), + ts_enum_to_name_pair(TS_START_POSTCAR), + ts_enum_to_name_pair(TS_END_POSTCAR), + ts_enum_to_name_pair(TS_DELAY_START), + ts_enum_to_name_pair(TS_DELAY_END), + ts_enum_to_name_pair(TS_READ_UCODE_START), + ts_enum_to_name_pair(TS_READ_UCODE_END), + ts_enum_to_name_pair(TS_ELOG_INIT_START), + ts_enum_to_name_pair(TS_ELOG_INIT_END), + ts_enum_to_name_pair(TS_START_COPYVER), + ts_enum_to_name_pair(TS_END_COPYVER), + ts_enum_to_name_pair(TS_START_TPMINIT), + ts_enum_to_name_pair(TS_END_TPMINIT), + ts_enum_to_name_pair(TS_START_VERIFY_SLOT), + ts_enum_to_name_pair(TS_END_VERIFY_SLOT), + ts_enum_to_name_pair(TS_START_HASH_BODY), + ts_enum_to_name_pair(TS_DONE_LOADING), + ts_enum_to_name_pair(TS_DONE_HASHING), + ts_enum_to_name_pair(TS_END_HASH_BODY), + ts_enum_to_name_pair(TS_START_TPMPCR), + ts_enum_to_name_pair(TS_END_TPMPCR), + ts_enum_to_name_pair(TS_START_TPMLOCK), + ts_enum_to_name_pair(TS_END_TPMLOCK), + ts_enum_to_name_pair(TS_START_EC_SYNC), + ts_enum_to_name_pair(TS_EC_HASH_READY), + ts_enum_to_name_pair(TS_EC_POWER_LIMIT_WAIT), + ts_enum_to_name_pair(TS_END_EC_SYNC), + ts_enum_to_name_pair(TS_START_COPYVPD), + ts_enum_to_name_pair(TS_END_COPYVPD_RO), + ts_enum_to_name_pair(TS_END_COPYVPD_RW), + ts_enum_to_name_pair(TS_START_TPM_ENABLE_UPDATE), + ts_enum_to_name_pair(TS_END_TPM_ENABLE_UPDATE), + ts_enum_to_name_pair(TS_AGESA_INIT_RESET_START), + ts_enum_to_name_pair(TS_AGESA_INIT_RESET_DONE), + ts_enum_to_name_pair(TS_AGESA_INIT_EARLY_START), + ts_enum_to_name_pair(TS_AGESA_INIT_EARLY_DONE), + ts_enum_to_name_pair(TS_AGESA_INIT_POST_START), + ts_enum_to_name_pair(TS_AGESA_INIT_POST_DONE), + ts_enum_to_name_pair(TS_AGESA_INIT_ENV_START), + ts_enum_to_name_pair(TS_AGESA_INIT_ENV_DONE), + ts_enum_to_name_pair(TS_AGESA_INIT_MID_START), + ts_enum_to_name_pair(TS_AGESA_INIT_MID_DONE), + ts_enum_to_name_pair(TS_AGESA_INIT_LATE_START), + ts_enum_to_name_pair(TS_AGESA_INIT_LATE_DONE), + ts_enum_to_name_pair(TS_AGESA_INIT_RTB_START), + ts_enum_to_name_pair(TS_AGESA_INIT_RTB_DONE), + ts_enum_to_name_pair(TS_AGESA_INIT_RESUME_START), + ts_enum_to_name_pair(TS_AGESA_INIT_RESUME_DONE), + ts_enum_to_name_pair(TS_AGESA_S3_LATE_START), + ts_enum_to_name_pair(TS_AGESA_S3_LATE_DONE), + ts_enum_to_name_pair(TS_AGESA_S3_FINAL_START), + ts_enum_to_name_pair(TS_AGESA_S3_FINAL_DONE), + ts_enum_to_name_pair(TS_AMD_APOB_READ_START), + ts_enum_to_name_pair(TS_AMD_APOB_ERASE_START), + ts_enum_to_name_pair(TS_AMD_APOB_WRITE_START), + ts_enum_to_name_pair(TS_AMD_APOB_DONE), + ts_enum_to_name_pair(TS_ME_INFORM_DRAM_WAIT), + ts_enum_to_name_pair(TS_ME_INFORM_DRAM_DONE), + ts_enum_to_name_pair(TS_ME_BEFORE_END_OF_POST), + ts_enum_to_name_pair(TS_ME_AFTER_END_OF_POST), + ts_enum_to_name_pair(TS_ME_BOOT_STALL_DONE), + ts_enum_to_name_pair(TS_ME_ICC_CONFIG_START), + ts_enum_to_name_pair(TS_ME_HOST_BOOT_PREP_DONE), + ts_enum_to_name_pair(TS_ME_RECEIVED_CRDA_FROM_PMC), + ts_enum_to_name_pair(TS_START_CSE_FW_SYNC), + ts_enum_to_name_pair(TS_END_CSE_FW_SYNC), + ts_enum_to_name_pair(TS_FSP_MEMORY_INIT_START), + ts_enum_to_name_pair(TS_FSP_MEMORY_INIT_END), + ts_enum_to_name_pair(TS_FSP_TEMP_RAM_EXIT_START), + ts_enum_to_name_pair(TS_FSP_TEMP_RAM_EXIT_END), + ts_enum_to_name_pair(TS_FSP_SILICON_INIT_START), + ts_enum_to_name_pair(TS_FSP_SILICON_INIT_END), + ts_enum_to_name_pair(TS_FSP_BEFORE_ENUMERATE), + ts_enum_to_name_pair(TS_FSP_AFTER_ENUMERATE), + ts_enum_to_name_pair(TS_FSP_BEFORE_FINALIZE), + ts_enum_to_name_pair(TS_FSP_AFTER_FINALIZE), + ts_enum_to_name_pair(TS_FSP_BEFORE_END_OF_FIRMWARE), + ts_enum_to_name_pair(TS_FSP_AFTER_END_OF_FIRMWARE), + ts_enum_to_name_pair(TS_FSP_MULTI_PHASE_SI_INIT_START), + ts_enum_to_name_pair(TS_FSP_MULTI_PHASE_SI_INIT_END), + ts_enum_to_name_pair(TS_FSP_MEMORY_INIT_LOAD), + ts_enum_to_name_pair(TS_FSP_SILICON_INIT_LOAD), + ts_enum_to_name_pair(TS_ME_ROM_START), + ts_enum_to_name_pair(TS_DC_START), + ts_enum_to_name_pair(TS_RO_PARAMS_INIT), + ts_enum_to_name_pair(TS_RO_VB_INIT), + ts_enum_to_name_pair(TS_RO_VB_SELECT_FIRMWARE), + ts_enum_to_name_pair(TS_RO_VB_SELECT_AND_LOAD_KERNEL), + ts_enum_to_name_pair(TS_RW_VB_SELECT_AND_LOAD_KERNEL), + ts_enum_to_name_pair(TS_VB_SELECT_AND_LOAD_KERNEL), + ts_enum_to_name_pair(TS_VB_EC_VBOOT_DONE), + ts_enum_to_name_pair(TS_VB_STORAGE_INIT_DONE), + ts_enum_to_name_pair(TS_VB_READ_KERNEL_DONE), + ts_enum_to_name_pair(TS_VB_VBOOT_DONE), + ts_enum_to_name_pair(TS_START_KERNEL), + ts_enum_to_name_pair(TS_KERNEL_DECOMPRESSION), +}; + #endif -- To view, visit https://review.coreboot.org/c/coreboot/+/62709 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd49f20d6b00a5bbd21804cea3a50b8cef074cd1 Gerrit-Change-Number: 62709 Gerrit-PatchSet: 1 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: util/cbmem: Add FlameGraph-compatible timestamps output
by Jakub Czapiga (Code Review) 09 Mar '22

09 Mar '22

Attention is currently required from: Tim Wawrzynczak, Paul Menzel, Alex Levin, Julius Werner, Jan Dabros. Hello build bot (Jenkins), Tim Wawrzynczak, Alex Levin, Julius Werner, Jan Dabros, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62474 to look at the new patch set (#5). Change subject: util/cbmem: Add FlameGraph-compatible timestamps output ...................................................................... util/cbmem: Add FlameGraph-compatible timestamps output Flame graphs are used to visualize hierarchical data, like call stacks. Timestamps collected by coreboot can be processed to resemble profiler-like output, and thus can be feed to flame graph generation tools. Generating flame graph using https://github.com/brendangregg/FlameGraph: cbmem -S > trace.txt FlameGraph/flamegraph.pl --flamechart trace.txt > output.svg TEST=Run on coreboot-enabled device and extract timestamps using -t/-T/-S options Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> Change-Id: I3a4e20a267e9e0fbc6b3a4d6a2409b32ce8fca33 --- M src/commonlib/include/commonlib/timestamp_serialized.h M util/cbmem/cbmem.c 2 files changed, 235 insertions(+), 26 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/62474/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/62474 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3a4e20a267e9e0fbc6b3a4d6a2409b32ce8fca33 Gerrit-Change-Number: 62474 Gerrit-PatchSet: 5 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Alex Levin <levinale(a)google.com> Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Alex Levin <levinale(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022