coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: mb/google/trogdor: Add variant Gelarshie
by Douglas Anderson (Code Review) 10 Mar '22

10 Mar '22

Attention is currently required from: Paul Menzel, Bob Moragues, Julius Werner, Mars Chen. Douglas Anderson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62642 ) Change subject: mb/google/trogdor: Add variant Gelarshie ...................................................................... Patch Set 5: (1 comment) File src/mainboard/google/trogdor/Kconfig: https://review.coreboot.org/c/coreboot/+/62642/comment/56e8b712_bdd05cad PS5, Line 77: ault "Gelarshie" i ...and here G comes before H? -- To view, visit https://review.coreboot.org/c/coreboot/+/62642 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie83df3c753d0863841430fe62805250ef8efeae9 Gerrit-Change-Number: 62642 Gerrit-PatchSet: 5 Gerrit-Owner: Mars Chen <chenxiangrui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bob Moragues <moragues(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Mars Chen <chenxiangrui(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Thu, 10 Mar 2022 22:21:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/trogdor: Add variant Gelarshie
by Douglas Anderson (Code Review) 10 Mar '22

10 Mar '22

Attention is currently required from: Paul Menzel, Bob Moragues, Julius Werner, Mars Chen. Douglas Anderson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62642 ) Change subject: mb/google/trogdor: Add variant Gelarshie ...................................................................... Patch Set 5: -Code-Review (1 comment) File src/mainboard/google/trogdor/Kconfig.name: https://review.coreboot.org/c/coreboot/+/62642/comment/3796a400_a6e3a960 PS5, Line 17: config BOARD_GOOGLE_GELARSHIE : bool "-> Gelarshie" : select BOARD_GOOGLE_TROGDOR_COMMON : : Oh, actually. Here G comes before H too. -- To view, visit https://review.coreboot.org/c/coreboot/+/62642 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie83df3c753d0863841430fe62805250ef8efeae9 Gerrit-Change-Number: 62642 Gerrit-PatchSet: 5 Gerrit-Owner: Mars Chen <chenxiangrui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bob Moragues <moragues(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Mars Chen <chenxiangrui(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Thu, 10 Mar 2022 22:21:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/trogdor: Add variant Gelarshie
by Douglas Anderson (Code Review) 10 Mar '22

10 Mar '22

Attention is currently required from: Paul Menzel, Bob Moragues, Julius Werner, Mars Chen. Douglas Anderson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62642 ) Change subject: mb/google/trogdor: Add variant Gelarshie ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62642 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie83df3c753d0863841430fe62805250ef8efeae9 Gerrit-Change-Number: 62642 Gerrit-PatchSet: 5 Gerrit-Owner: Mars Chen <chenxiangrui(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Bob Moragues <moragues(a)google.com> Gerrit-Reviewer: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bob Moragues <moragues(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Mars Chen <chenxiangrui(a)huaqin.corp-partner.google.com> Gerrit-Comment-Date: Thu, 10 Mar 2022 22:20:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/herobrine: consolidate hoglin/herobrine QUP inits
by Shelley Chen (Code Review) 10 Mar '22

10 Mar '22

Attention is currently required from: mturney mturney, Ravi Kumar Bokka, Sudheer Amrabadi, Julius Werner. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62743 ) Change subject: mb/google/herobrine: consolidate hoglin/herobrine QUP inits ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Hi Qualcomm, Can you verify that this change is ok for Hoglin? My understanding is that the hoglin and herobrine proto1 GPIOs should be the same, so I think hoglin inits can just fall into the else clause. -- To view, visit https://review.coreboot.org/c/coreboot/+/62743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I48ce42760f2c75f04619b967a05909d2b3f28e2c Gerrit-Change-Number: 62743 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-Reviewer: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Attention: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Thu, 10 Mar 2022 22:19:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/herobrine: consolidate hoglin/herobrine QUP inits
by Shelley Chen (Code Review) 10 Mar '22

10 Mar '22

Shelley Chen has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/62743 ) Change subject: mb/google/herobrine: consolidate hoglin/herobrine QUP inits ...................................................................... mb/google/herobrine: consolidate hoglin/herobrine QUP inits Hoglin and Herobrine (proto1) should share majority of GPIOs. Conslidating the QUP initializations in mainboard. Also, putting fingerprint init in a conditional as not all devices will have an FP sensor. BUG=b:182963902,b:223826899 BRANCH=None TEST=booted BIOS on hoglin and check for i2c errors in dmesg Change-Id: I48ce42760f2c75f04619b967a05909d2b3f28e2c Signed-off-by: Shelley Chen <shchen(a)google.com> --- M src/mainboard/google/herobrine/mainboard.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/62743/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I48ce42760f2c75f04619b967a05909d2b3f28e2c Gerrit-Change-Number: 62743 Gerrit-PatchSet: 2 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/herobrine: conslidate hoglin/herobrine QUP initialtions
by Shelley Chen (Code Review) 10 Mar '22

10 Mar '22

Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62743 ) Change subject: mb/google/herobrine: conslidate hoglin/herobrine QUP initialtions ...................................................................... mb/google/herobrine: conslidate hoglin/herobrine QUP initialtions Hoglin and Herobrine (proto1) should share majority of GPIOs. Conslidating the QUP initializations in mainboard. Also, putting fingerprint init in a conditional as not all devices have an FP sensor. BUG=b:182963902,b:223826899 BRANCH=None TEST=booted BIOS on hoglin and check for i2c errors in dmesg Change-Id: I48ce42760f2c75f04619b967a05909d2b3f28e2c Signed-off-by: Shelley Chen <shchen(a)google.com> --- M src/mainboard/google/herobrine/mainboard.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/43/62743/1 diff --git a/src/mainboard/google/herobrine/mainboard.c b/src/mainboard/google/herobrine/mainboard.c index 34e5d4a..7bdede0 100644 --- a/src/mainboard/google/herobrine/mainboard.c +++ b/src/mainboard/google/herobrine/mainboard.c @@ -77,8 +77,7 @@ qupv3_se_fw_load_and_init(QUPV3_0_SE2, SE_PROTOCOL_I2C, MIXED); /* Fingerprint SPI */ qupv3_se_fw_load_and_init(QUPV3_1_SE3, SE_PROTOCOL_SPI, MIXED); - } else if (CONFIG(BOARD_GOOGLE_SENOR) || CONFIG(BOARD_GOOGLE_PIGLIN) || - CONFIG(BOARD_GOOGLE_HOGLIN)) { + } else if (CONFIG(BOARD_GOOGLE_SENOR) || CONFIG(BOARD_GOOGLE_PIGLIN)) { /* APPS I2C */ qupv3_se_fw_load_and_init(QUPV3_0_SE1, SE_PROTOCOL_I2C, GSI); /* ESIM SPI */ @@ -93,7 +92,8 @@ /* Audio I2C */ qupv3_se_fw_load_and_init(QUPV3_0_SE2, SE_PROTOCOL_I2C, MIXED); /* Fingerprint SPI */ - qupv3_se_fw_load_and_init(QUPV3_1_SE1, SE_PROTOCOL_SPI, MIXED); + if (CONFIG(HEROBRINE_HAS_FINGERPRINT)) + qupv3_se_fw_load_and_init(QUPV3_1_SE1, SE_PROTOCOL_SPI, MIXED); } /* Take FPMCU out of reset. Power was already applied -- To view, visit https://review.coreboot.org/c/coreboot/+/62743 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I48ce42760f2c75f04619b967a05909d2b3f28e2c Gerrit-Change-Number: 62743 Gerrit-PatchSet: 1 Gerrit-Owner: Shelley Chen <shchen(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/guybrush: Enable EC SMI handler
by Raul Rangel (Code Review) 10 Mar '22

10 Mar '22

Attention is currently required from: Rob Barnes, Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62599 ) Change subject: mb/google/guybrush: Enable EC SMI handler ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/guybrush/ec.c: https://review.coreboot.org/c/coreboot/+/62599/comment/69acce6e_bb912659 PS2, Line 35: configure_smi(SMITYPE_ESPI_SMI, SMI_MODE_SMI); > Deptcharge does disable lid_close event explicitly for few other use-cases like TCPC FW update - htt […] Yeah, we could probably remove that as well if we disable the SMI handler when depthcharge starts. -- To view, visit https://review.coreboot.org/c/coreboot/+/62599 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52b96b1b7c3c25a8355eaba4e84dbce49451b7f8 Gerrit-Change-Number: 62599 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 10 Mar 2022 21:37:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Enable EC SMI handler
by Karthik Ramasubramanian (Code Review) 10 Mar '22

10 Mar '22

Attention is currently required from: Raul Rangel, Rob Barnes. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62599 ) Change subject: mb/google/guybrush: Enable EC SMI handler ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/guybrush/ec.c: https://review.coreboot.org/c/coreboot/+/62599/comment/5ed25c98_4dca7ca4 PS2, Line 35: configure_smi(SMITYPE_ESPI_SMI, SMI_MODE_SMI); > So doing some more tracing: […] Deptcharge does disable lid_close event explicitly for few other use-cases like TCPC FW update - https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/pla… -- To view, visit https://review.coreboot.org/c/coreboot/+/62599 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52b96b1b7c3c25a8355eaba4e84dbce49451b7f8 Gerrit-Change-Number: 62599 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Comment-Date: Thu, 10 Mar 2022 21:33:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Enable EC SMI handler
by Raul Rangel (Code Review) 10 Mar '22

10 Mar '22

Attention is currently required from: Rob Barnes, Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62599 ) Change subject: mb/google/guybrush: Enable EC SMI handler ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/guybrush/ec.c: https://review.coreboot.org/c/coreboot/+/62599/comment/a9078475_d0927f04 PS2, Line 35: configure_smi(SMITYPE_ESPI_SMI, SMI_MODE_SMI); > Ack. I am not concerned about having the LID_HANDLER event enabled. […] So doing some more tracing: * https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/pla… * https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/pla… depthcharge cleanup handlers that get run when depthcharge shuts down. The SMI handler will run before depthcharge has a chance to processes the lid closed event, so we will not run the cleanup handlers. I think this might cause NVME boot delays as it needs to verify its internal state next boot. IMO, depthcharge should disable the lid closed SMI event regardless of `VB2_GBB_FLAG_DISABLE_LID_SHUTDOWN`. It has code to handle checking it. It could then re-enable it before handing off to the payload just to catch any problems before ACPI is enabled. -- To view, visit https://review.coreboot.org/c/coreboot/+/62599 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I52b96b1b7c3c25a8355eaba4e84dbce49451b7f8 Gerrit-Change-Number: 62599 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 10 Mar 2022 21:28:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: ec/starlabs/merlin: Don't store EC values on change
by Sean Rhodes (Code Review) 10 Mar '22

10 Mar '22

Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62742 ) Change subject: ec/starlabs/merlin: Don't store EC values on change ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/62742 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0ea392afae4a4d3c605cdea3c5896fbff606215 Gerrit-Change-Number: 62742 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Thu, 10 Mar 2022 21:23:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022