coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: mb/starlabs/labtop: Remove unused return value from MWAK
by Sean Rhodes (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Sean Rhodes. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62420 to look at the new patch set (#4). Change subject: mb/starlabs/labtop: Remove unused return value from MWAK ...................................................................... mb/starlabs/labtop: Remove unused return value from MWAK Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I00f8ea86a7e03a0b1bf9e68f75582a2ae70aef02 --- M src/mainboard/starlabs/labtop/acpi/sleep.asl 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/62420/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/62420 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00f8ea86a7e03a0b1bf9e68f75582a2ae70aef02 Gerrit-Change-Number: 62420 Gerrit-PatchSet: 4 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/starlabs/labtop: Remove unused return value from MAWK
by Angel Pons (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Sean Rhodes. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62420 ) Change subject: mb/starlabs/labtop: Remove unused return value from MAWK ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62420/comment/99b1824d_5dfe5731 PS3, Line 7: MAWK typo: MWAK -- To view, visit https://review.coreboot.org/c/coreboot/+/62420 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I00f8ea86a7e03a0b1bf9e68f75582a2ae70aef02 Gerrit-Change-Number: 62420 Gerrit-PatchSet: 3 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Fri, 11 Mar 2022 09:52:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: MAINTAINERS: Remove myself
by Angel Pons (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62754 ) Change subject: MAINTAINERS: Remove myself ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie75912698e58088ff4a334403cb331542abb40fd Gerrit-Change-Number: 62754 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Fri, 11 Mar 2022 09:51:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/siemens/mc_ehl: Increase SPD buffer size to 512 bytes
by Angel Pons (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Paul Menzel, Mario Scheithauer, Werner Zeh. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62698 ) Change subject: mb/siemens/mc_ehl: Increase SPD buffer size to 512 bytes ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/mainboard/siemens/mc_ehl/romstage_fsp_params.c: https://review.coreboot.org/c/coreboot/+/62698/comment/2b095e05_108ca650 PS3, Line 17: 0x200 How about `CONFIG_DIMM_SPD_SIZE` instead? -- To view, visit https://review.coreboot.org/c/coreboot/+/62698 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b88df7818cfd62b3579d69f9f5bb14880f49c8c Gerrit-Change-Number: 62698 Gerrit-PatchSet: 3 Gerrit-Owner: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mario Scheithauer <mario.scheithauer(a)siemens.com> Gerrit-Attention: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Comment-Date: Fri, 11 Mar 2022 09:50:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/starlabs/lite: Move Verb Table to variant directory
by Sean Rhodes (Code Review) 11 Mar '22

11 Mar '22

Sean Rhodes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62755 ) Change subject: mb/starlabs/lite: Move Verb Table to variant directory ...................................................................... mb/starlabs/lite: Move Verb Table to variant directory Move the verb table to variant directory to allow for different tables for different variants. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I4260188057d1c3b4e6ea7c82f085fad0cc244881 --- M src/mainboard/starlabs/lite/Makefile.inc M src/mainboard/starlabs/lite/variants/glk/Makefile.inc R src/mainboard/starlabs/lite/variants/glk/hda_verb.c 3 files changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/62755/1 diff --git a/src/mainboard/starlabs/lite/Makefile.inc b/src/mainboard/starlabs/lite/Makefile.inc index 019d560..e7f8277 100644 --- a/src/mainboard/starlabs/lite/Makefile.inc +++ b/src/mainboard/starlabs/lite/Makefile.inc @@ -6,7 +6,6 @@ bootblock-y += bootblock.c ramstage-y += devtree.c -ramstage-y += hda_verb.c ramstage-y += mainboard.c ramstage-y += smbios.c ramstage-$(CONFIG_MAINBOARD_USE_LIBGFXINIT) += gma-mainboard.ads diff --git a/src/mainboard/starlabs/lite/variants/glk/Makefile.inc b/src/mainboard/starlabs/lite/variants/glk/Makefile.inc index 05b0677..ae3ec84 100644 --- a/src/mainboard/starlabs/lite/variants/glk/Makefile.inc +++ b/src/mainboard/starlabs/lite/variants/glk/Makefile.inc @@ -3,5 +3,6 @@ bootblock-y += gpio.c ramstage-y += gpio.c +ramstage-y += hda_verb.c romstage-y += romstage.c diff --git a/src/mainboard/starlabs/lite/hda_verb.c b/src/mainboard/starlabs/lite/variants/glk/hda_verb.c similarity index 100% rename from src/mainboard/starlabs/lite/hda_verb.c rename to src/mainboard/starlabs/lite/variants/glk/hda_verb.c -- To view, visit https://review.coreboot.org/c/coreboot/+/62755 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4260188057d1c3b4e6ea7c82f085fad0cc244881 Gerrit-Change-Number: 62755 Gerrit-PatchSet: 1 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/mediatek/common: Add halt() after triggering wdt reset
by Rex-BC Chen (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62752 ) Change subject: soc/mediatek/common: Add halt() after triggering wdt reset ...................................................................... Patch Set 2: (1 comment) File src/soc/mediatek/common/wdt.c: https://review.coreboot.org/c/coreboot/+/62752/comment/e6f66336_e578190f PS1, Line 39: /* : * We trigger secondary reset by triggering WDT hardware to send signal to EC. : * We do not use do_board_reset() to send signal to EC : * which is controlled by software driver. : * Before triggering secondary reset, clean the data cache so the logs in cbmem : * console (either in SRAM or DRAM) can be flushed. : */ > move these comments into the new function. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/62752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I726ba1599841f63b37062f9ce2e04840e4f250bb Gerrit-Change-Number: 62752 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 11 Mar 2022 09:30:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/common: Add halt() after triggering wdt reset
by Rex-BC Chen (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Rex-BC Chen, Yu-Ping Wu. Hello Hung-Te Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62752 to look at the new patch set (#2). Change subject: soc/mediatek/common: Add halt() after triggering wdt reset ...................................................................... soc/mediatek/common: Add halt() after triggering wdt reset It's more reasonable to halt when we trigger watchdog reset because whole system should be reset after we trigger watchdog reset. BUG=b:222217317 TEST=build pass Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Change-Id: I726ba1599841f63b37062f9ce2e04840e4f250bb --- M src/soc/mediatek/common/wdt.c 1 file changed, 20 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/62752/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I726ba1599841f63b37062f9ce2e04840e4f250bb Gerrit-Change-Number: 62752 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: src/mediatek/mt8186: Get dram size from CBMEM_ID_MEMINFO
by Hung-Te Lin (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Xixi Chen, Yu-Ping Wu. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62065 ) Change subject: src/mediatek/mt8186: Get dram size from CBMEM_ID_MEMINFO ...................................................................... Patch Set 11: (2 comments) File src/soc/mediatek/mt8186/emi.c: https://review.coreboot.org/c/coreboot/+/62065/comment/162c134b_79097a7a PS11, Line 15: mem_chip mem_chip_info ? https://review.coreboot.org/c/coreboot/+/62065/comment/0df1f27e_c8047b0b PS11, Line 18: CBMEM_ID_MEMINFO CBMEM_ID_MEM_CHIP_INFO -- To view, visit https://review.coreboot.org/c/coreboot/+/62065 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I017e9d1a2d6e26f1fc21b67b5962dfb5c6ade8a5 Gerrit-Change-Number: 62065 Gerrit-PatchSet: 11 Gerrit-Owner: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 11 Mar 2022 09:27:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: MAINTAINERS: Remove myself
by Patrick Rudolph (Code Review) 11 Mar '22

11 Mar '22

Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62754 ) Change subject: MAINTAINERS: Remove myself ...................................................................... MAINTAINERS: Remove myself Change-Id: Ie75912698e58088ff4a334403cb331542abb40fd Signed-off-by: Patrick Rudolph <siro(a)das-labor.org> --- M MAINTAINERS 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/54/62754/1 diff --git a/MAINTAINERS b/MAINTAINERS index a8d279c..520ed10 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -322,7 +322,6 @@ LENOVO MAINBOARDS M: Alexander Couzens <lynxis(a)fe80.eu> -M: Patrick Rudolph <siro(a)das-labor.org> S: Maintained F: src/mainboard/lenovo/ @@ -574,7 +573,6 @@ F: src/include/cpu/amd/ INTEL SUPPORT -M: Patrick Rudolph <siro(a)das-labor.org> S: Maintained F: src/vendorcode/intel/ F: src/cpu/intel/ -- To view, visit https://review.coreboot.org/c/coreboot/+/62754 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie75912698e58088ff4a334403cb331542abb40fd Gerrit-Change-Number: 62754 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/mediatek/common: Add halt() after triggering wdt reset
by Hung-Te Lin (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Rex-BC Chen, Yu-Ping Wu. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62752 ) Change subject: soc/mediatek/common: Add halt() after triggering wdt reset ...................................................................... Patch Set 1: (1 comment) File src/soc/mediatek/common/wdt.c: https://review.coreboot.org/c/coreboot/+/62752/comment/72342439_8233817e PS1, Line 39: /* : * We trigger secondary reset by triggering WDT hardware to send signal to EC. : * We do not use do_board_reset() to send signal to EC : * which is controlled by software driver. : * Before triggering secondary reset, clean the data cache so the logs in cbmem : * console (either in SRAM or DRAM) can be flushed. : */ move these comments into the new function. -- To view, visit https://review.coreboot.org/c/coreboot/+/62752 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I726ba1599841f63b37062f9ce2e04840e4f250bb Gerrit-Change-Number: 62752 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 11 Mar 2022 09:24:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022