coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: hp/z220_cmt_workstation: Add variant of z220_sff_workstation
by Damien Zammit (Code Review) 12 Mar '22

12 Mar '22

Attention is currently required from: Angel Pons. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62759 to look at the new patch set (#2). Change subject: hp/z220_cmt_workstation: Add variant of z220_sff_workstation ...................................................................... hp/z220_cmt_workstation: Add variant of z220_sff_workstation This is based on work done by a good friend of mine. The code in this commit is untested as I reworked his port into a variant. We will be testing it on the CMT soon. Change-Id: I187dba9d9332aa3a8ee9207fc224a7d87da22c6f Signed-off-by: Damien Zammit <damien(a)zamaudio.com> --- M src/mainboard/hp/z220_sff_workstation/Kconfig M src/mainboard/hp/z220_sff_workstation/Kconfig.name M src/mainboard/hp/z220_sff_workstation/Makefile.inc M src/mainboard/hp/z220_sff_workstation/devicetree.cb A src/mainboard/hp/z220_sff_workstation/variants/z220_cmt_workstation/gpio.c A src/mainboard/hp/z220_sff_workstation/variants/z220_cmt_workstation/overridetree.cb R src/mainboard/hp/z220_sff_workstation/variants/z220_sff_workstation/gpio.c A src/mainboard/hp/z220_sff_workstation/variants/z220_sff_workstation/overridetree.cb 8 files changed, 246 insertions(+), 7 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/62759/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I187dba9d9332aa3a8ee9207fc224a7d87da22c6f Gerrit-Change-Number: 62759 Gerrit-PatchSet: 2 Gerrit-Owner: Damien Zammit Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: hp/z220_cmt_workstation: Add variant of z220_sff_workstation
by Damien Zammit (Code Review) 12 Mar '22

12 Mar '22

Attention is currently required from: Angel Pons. Damien Zammit has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62759 ) Change subject: hp/z220_cmt_workstation: Add variant of z220_sff_workstation ...................................................................... Patch Set 1: (6 comments) Patchset: PS1: Patch revised, pushing now. File src/mainboard/hp/z220_sff_workstation/Kconfig: https://review.coreboot.org/c/coreboot/+/62759/comment/112afbbb_f91a3e3f PS1, Line 1: BOARD_HP_Z220_VARIANT > As this symbol is for a group of boards, I'd rename it to `BOARD_HP_Z220_SERIES` Done https://review.coreboot.org/c/coreboot/+/62759/comment/6801f42f_983daf82 PS1, Line 52: > Please don't make a copy of data.vbt, just keep it where it is and add this here: […] Done https://review.coreboot.org/c/coreboot/+/62759/comment/08af6cad_644c5fa4 PS1, Line 53: config VGA_BIOS_FILE : string : default "pci8086,0102.rom" : : config VGA_BIOS_ID : string : default "8086,0102" > Where did this come from? Please remove, it doesn't make sense for a board with a socketed CPU. Done File src/mainboard/hp/z220_sff_workstation/Kconfig.name: https://review.coreboot.org/c/coreboot/+/62759/comment/1f4f5320_571bcc0b PS1, Line 3: > nit: spaces not needed Done File src/mainboard/hp/z220_sff_workstation/variants/z220_cmt_workstation/gpio.c: PS1: > Are there many differences between the GPIO settings? There's a handful of gpios that are different, not many. You can diff the two files easily as the whitespace is the same. -- To view, visit https://review.coreboot.org/c/coreboot/+/62759 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I187dba9d9332aa3a8ee9207fc224a7d87da22c6f Gerrit-Change-Number: 62759 Gerrit-PatchSet: 1 Gerrit-Owner: Damien Zammit Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sat, 12 Mar 2022 03:08:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Rename infrastructure section
by Michael Niewöhner (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Felix Singer, Paul Menzel. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62441 ) Change subject: Documentation: Rename infrastructure section ...................................................................... Patch Set 13: Code-Review+1 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62441/comment/1f213c9c_22570efc PS13, Line 9: to for -- To view, visit https://review.coreboot.org/c/coreboot/+/62441 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1ba8a2e2070a79d8c9e955133203f9bb9f58cb8e Gerrit-Change-Number: 62441 Gerrit-PatchSet: 13 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 11 Mar 2022 20:57:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/pcie/generic: Add support to generate code under companion de...
by Nico Huber (Code Review) 11 Mar '22

11 Mar '22

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62301 ) Change subject: drivers/pcie/generic: Add support to generate code under companion device instead ...................................................................... Patch Set 9: (1 comment) File src/drivers/pcie/generic/generic.c: https://review.coreboot.org/c/coreboot/+/62301/comment/51168443_de0f57f3 PS9, Line 36: present > sorry. 'is present'. Oh, nevermind. I just realized I read it wrong. Somehow I read `instead of`. It makes perfectly sense. Sorry for the confusion. -- To view, visit https://review.coreboot.org/c/coreboot/+/62301 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I80634bbfc2927f26f2a55a9c244eca517c437079 Gerrit-Change-Number: 62301 Gerrit-PatchSet: 9 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Cliff Huang <cliff.huang(a)intel.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 11 Mar 2022 20:40:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com> Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Move firmware flashing tutorial to tutorial section
by Felix Singer (Code Review) 11 Mar '22

11 Mar '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62424 ) Change subject: Documentation: Move firmware flashing tutorial to tutorial section ...................................................................... Documentation: Move firmware flashing tutorial to tutorial section There is no need that the tutorial for flashing firmware has its own point in the main menu. Thus, move it to the tutorial section. Change-Id: Ife6d97254af4c006fe01480a78c76303f9cb34bb Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/62424 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Thomas Heijligen <src(a)posteo.de> --- M Documentation/contributing/gsoc.md M Documentation/index.md M Documentation/mainboard/acer/g43t-am3.md M Documentation/mainboard/asrock/h110m-dvs.md M Documentation/mainboard/asrock/h77pro4-m.md M Documentation/mainboard/asus/p5q.md M Documentation/mainboard/gigabyte/ga-g41m-es2l.md M Documentation/mainboard/hp/2560p.md M Documentation/mainboard/lenovo/Ivy_Bridge_series.md M Documentation/mainboard/lenovo/Sandy_Bridge_series.md M Documentation/mainboard/lenovo/ivb_internal_flashing.md M Documentation/mainboard/lenovo/t410.md M Documentation/mainboard/lenovo/t420.md M Documentation/mainboard/lenovo/t430.md M Documentation/mainboard/lenovo/w530.md M Documentation/mainboard/lenovo/x1.md M Documentation/mainboard/lenovo/x230s.md M Documentation/mainboard/lenovo/x301.md M Documentation/mainboard/msi/ms7707/ms7707.md M Documentation/mainboard/prodrive/hermes.md M Documentation/mainboard/supermicro/x10slm-f.md M Documentation/mainboard/supermicro/x11-lga1151-series/x11-lga1151-series.md M Documentation/mainboard/supermicro/x9sae.md M Documentation/northbridge/intel/sandybridge/me_cleaner.md R Documentation/tutorial/flashing_firmware/ext_power.md R Documentation/tutorial/flashing_firmware/ext_standalone.md R Documentation/tutorial/flashing_firmware/flash_ic_diode.svg R Documentation/tutorial/flashing_firmware/flash_ic_no_diode.svg R Documentation/tutorial/flashing_firmware/index.md R Documentation/tutorial/flashing_firmware/int_flashrom.md R Documentation/tutorial/flashing_firmware/no_ext_power.md M Documentation/tutorial/index.md 32 files changed, 26 insertions(+), 26 deletions(-) Approvals: build bot (Jenkins): Verified Thomas Heijligen: Looks good to me, approved diff --git a/Documentation/contributing/gsoc.md b/Documentation/contributing/gsoc.md index ba94f20..4f85426 100644 --- a/Documentation/contributing/gsoc.md +++ b/Documentation/contributing/gsoc.md @@ -260,7 +260,7 @@ [mailing list]: https://mail.coreboot.org/postorius/lists/coreboot.coreboot.org [Getting started]: ../getting_started/index.md [Tutorial]: ../tutorial/index.md -[Flashing firmware tutorial]: ../flash_tutorial/index.md +[Flashing firmware tutorial]: ../tutorial/flashing_firmware/index.md [Coding style]: coding_style.md [Code of Conduct]: ../community/code_of_conduct.md [Language style]: ../community/language_style.md diff --git a/Documentation/index.md b/Documentation/index.md index aecea35..16997ed 100644 --- a/Documentation/index.md +++ b/Documentation/index.md @@ -190,4 +190,3 @@ * [Utilities](util.md) * [coreboot infrastructure](infrastructure/index.md) * [Release notes](releases/index.md) -* [Flashing firmware tutorial](flash_tutorial/index.md) diff --git a/Documentation/mainboard/acer/g43t-am3.md b/Documentation/mainboard/acer/g43t-am3.md index 2e9b8d6..e57009c 100644 --- a/Documentation/mainboard/acer/g43t-am3.md +++ b/Documentation/mainboard/acer/g43t-am3.md @@ -124,7 +124,7 @@ ```eval_rst In addition to the information here, please see the -:doc:`../../flash_tutorial/index`. +:doc:`../../tutorial/flashing_firmware/index`. ``` ### External flashing diff --git a/Documentation/mainboard/asrock/h110m-dvs.md b/Documentation/mainboard/asrock/h110m-dvs.md index 4d26cfd..4a20bb6 100644 --- a/Documentation/mainboard/asrock/h110m-dvs.md +++ b/Documentation/mainboard/asrock/h110m-dvs.md @@ -58,7 +58,7 @@ the BIOS region of the flash is writable. If you wish to change any other region, such as the Management Engine or firmware descriptor, then an external programmer is required (unless you find a clever way around -the flash protection). More information about this [here](../../flash_tutorial/index.md). +the flash protection). More information about this [here](../../tutorial/flashing_firmware/index.md). ### External programming diff --git a/Documentation/mainboard/asrock/h77pro4-m.md b/Documentation/mainboard/asrock/h77pro4-m.md index 45c603d..7b4487d 100644 --- a/Documentation/mainboard/asrock/h77pro4-m.md +++ b/Documentation/mainboard/asrock/h77pro4-m.md @@ -115,7 +115,7 @@ ```eval_rst In addition to the information here, please see the -:doc:`../../flash_tutorial/index`. +:doc:`../../tutorial/flashing_firmware/index`. ``` ## Hardware monitoring and fan control diff --git a/Documentation/mainboard/asus/p5q.md b/Documentation/mainboard/asus/p5q.md index 39a8591..ec20887 100644 --- a/Documentation/mainboard/asus/p5q.md +++ b/Documentation/mainboard/asus/p5q.md @@ -130,5 +130,5 @@ echo 2000 >/sys/class/hwmon/hwmon2/pwm1_tolerance [ASUS P5Q]: https://www.asus.com/Motherboards/P5Q -[this guide]: ../../flash_tutorial/int_flashrom.md +[this guide]: ../../tutorial/flashing_firmware/int_flashrom.md [kernel docs]: https://www.kernel.org/doc/Documentation/hwmon/w83627ehf.rst diff --git a/Documentation/mainboard/gigabyte/ga-g41m-es2l.md b/Documentation/mainboard/gigabyte/ga-g41m-es2l.md index 6c17f4c..57c4945 100644 --- a/Documentation/mainboard/gigabyte/ga-g41m-es2l.md +++ b/Documentation/mainboard/gigabyte/ga-g41m-es2l.md @@ -142,7 +142,7 @@ ```eval_rst In addition to the information here, please see the -:doc:`../../flash_tutorial/index`. +:doc:`../../tutorial/flashing_firmware/index`. ``` ### Do backup diff --git a/Documentation/mainboard/hp/2560p.md b/Documentation/mainboard/hp/2560p.md index 0b51a89..65a87d1 100644 --- a/Documentation/mainboard/hp/2560p.md +++ b/Documentation/mainboard/hp/2560p.md @@ -94,6 +94,6 @@ [HP EliteBook 2560p]: https://support.hp.com/us-en/product/hp-elitebook-2560p-notebook-pc/5071201 [Maintenance and Service Guide]: http://h10032.www1.hp.com/ctg/Manual/c03011618 -[flashing tutorial]: ../../flash_tutorial/ext_power.md +[flashing tutorial]: ../../tutorial/flashing_firmware/ext_power.md [Lab One]: https://www.laboneinside.com/hp-elitebook-2560p-schematic-diagram/ [bug #141]: https://ticket.coreboot.org/issues/141 diff --git a/Documentation/mainboard/lenovo/Ivy_Bridge_series.md b/Documentation/mainboard/lenovo/Ivy_Bridge_series.md index ca02b3c..bf49f5d 100644 --- a/Documentation/mainboard/lenovo/Ivy_Bridge_series.md +++ b/Documentation/mainboard/lenovo/Ivy_Bridge_series.md @@ -38,7 +38,7 @@ * ROM chip size should be set to 12MiB. ```eval_rst -Please also have a look at :doc:`../../flash_tutorial/index`. +Please also have a look at :doc:`../../tutorial/flashing_firmware/index`. ``` ## Splitting the coreboot.rom @@ -90,4 +90,4 @@ [me_cleaner]: ../../northbridge/intel/sandybridge/me_cleaner.md -[external programmer]: ../../flash_tutorial/index.md +[external programmer]: ../../tutorial/flashing_firmware/index.md diff --git a/Documentation/mainboard/lenovo/Sandy_Bridge_series.md b/Documentation/mainboard/lenovo/Sandy_Bridge_series.md index e1d9c77..2a53df3 100644 --- a/Documentation/mainboard/lenovo/Sandy_Bridge_series.md +++ b/Documentation/mainboard/lenovo/Sandy_Bridge_series.md @@ -70,5 +70,5 @@ [me_cleaner]: ../../northbridge/intel/sandybridge/me_cleaner.md -[external programmer]: ../../flash_tutorial/index.md -[flashing tutorial]: ../../flash_tutorial/index.md +[external programmer]: ../../tutorial/flashing_firmware/index.md +[flashing tutorial]: ../../tutorial/flashing_firmware/index.md diff --git a/Documentation/mainboard/lenovo/ivb_internal_flashing.md b/Documentation/mainboard/lenovo/ivb_internal_flashing.md index 1aeea8b..40afd6f 100644 --- a/Documentation/mainboard/lenovo/ivb_internal_flashing.md +++ b/Documentation/mainboard/lenovo/ivb_internal_flashing.md @@ -361,4 +361,4 @@ It will help you recover if you flash non-working ROM by mistake. -[flash internally]: ../../flash_tutorial/int_flashrom.md +[flash internally]: ../../tutorial/flashing_firmware/int_flashrom.md diff --git a/Documentation/mainboard/lenovo/t410.md b/Documentation/mainboard/lenovo/t410.md index 980c959..80d54f8 100644 --- a/Documentation/mainboard/lenovo/t410.md +++ b/Documentation/mainboard/lenovo/t410.md @@ -37,7 +37,7 @@ Do not rely on dots painted in the corner of the chip (such as the blue dot pictured) to orient the pins! -[Flashing tutorial](../../flash_tutorial/no_ext_power.md) +[Flashing tutorial](../../tutorial/flashing_firmware/no_ext_power.md) Steps to access the flash IC are described here [T4xx series]. diff --git a/Documentation/mainboard/lenovo/t420.md b/Documentation/mainboard/lenovo/t420.md index 189649b..726dbd8 100644 --- a/Documentation/mainboard/lenovo/t420.md +++ b/Documentation/mainboard/lenovo/t420.md @@ -53,5 +53,5 @@ * Suspend (Windows 10) [T4xx series]: t4xx_series.md -[flashing tutorial]: ../../flash_tutorial/ext_power.md +[flashing tutorial]: ../../tutorial/flashing_firmware/ext_power.md [T420 / T520 / X220 / T420s / W520 common]: Sandy_Bridge_series.md diff --git a/Documentation/mainboard/lenovo/t430.md b/Documentation/mainboard/lenovo/t430.md index c2cddca..87eedba 100644 --- a/Documentation/mainboard/lenovo/t430.md +++ b/Documentation/mainboard/lenovo/t430.md @@ -9,6 +9,6 @@ Steps to access the flash IC are described here [T4xx series]. -[flashing tutorial]: ../../flash_tutorial/ext_power.md +[flashing tutorial]: ../../tutorial/flashing_firmware/ext_power.md [T4xx series]: t4xx_series.md [T430 / T530 / X230 / T430s / W530 common]: Ivy_Bridge_series.md diff --git a/Documentation/mainboard/lenovo/w530.md b/Documentation/mainboard/lenovo/w530.md index e3fe6b8..c9dcd50 100644 --- a/Documentation/mainboard/lenovo/w530.md +++ b/Documentation/mainboard/lenovo/w530.md @@ -22,5 +22,5 @@ [w530-2]: w530-2.jpg -[flashing tutorial]: ../../flash_tutorial/ext_power.md +[flashing tutorial]: ../../tutorial/flashing_firmware/ext_power.md [T430 / T530 / X230 / T430s / W530 common]: Ivy_Bridge_series.md diff --git a/Documentation/mainboard/lenovo/x1.md b/Documentation/mainboard/lenovo/x1.md index 9f915bc..5e8ec29 100644 --- a/Documentation/mainboard/lenovo/x1.md +++ b/Documentation/mainboard/lenovo/x1.md @@ -18,5 +18,5 @@ Steps to access the flash IC are described here [X2xx series]. [X2xx series]: x2xx_series.md -[flashing tutorial]: ../../flash_tutorial/ext_power.md +[flashing tutorial]: ../../tutorial/flashing_firmware/ext_power.md [T420 / T520 / X220 / T420s / W520 common]: Sandy_Bridge_series.md diff --git a/Documentation/mainboard/lenovo/x230s.md b/Documentation/mainboard/lenovo/x230s.md index 845410e..eedc5f4 100644 --- a/Documentation/mainboard/lenovo/x230s.md +++ b/Documentation/mainboard/lenovo/x230s.md @@ -16,4 +16,4 @@ Unlike [most Ivy Bridge ThinkPads](Ivy_Bridge_series.md), X230s has a single 16MiB SPI flash chip. -The general [flashing tutorial](../../flash_tutorial/index.md) has more details. +The general [flashing tutorial](../../tutorial/flashing_firmware/index.md) has more details. diff --git a/Documentation/mainboard/lenovo/x301.md b/Documentation/mainboard/lenovo/x301.md index b273fc5..4166b3f 100644 --- a/Documentation/mainboard/lenovo/x301.md +++ b/Documentation/mainboard/lenovo/x301.md @@ -43,5 +43,5 @@ Linux payload (Heads) and SeaBIOS. -[flashing tutorial]: ../../flash_tutorial/ext_power.md +[flashing tutorial]: ../../tutorial/flashing_firmware/ext_power.md diff --git a/Documentation/mainboard/msi/ms7707/ms7707.md b/Documentation/mainboard/msi/ms7707/ms7707.md index 9309596..c92e674 100644 --- a/Documentation/mainboard/msi/ms7707/ms7707.md +++ b/Documentation/mainboard/msi/ms7707/ms7707.md @@ -110,4 +110,4 @@ [Winbond 25Q32BV datasheet]: https://www.winbond.com/resource-files/w25q32bv_revi_100413_wo_automotive.p… [Fintek F71808A datasheet]: https://www.alldatasheet.com/datasheet-pdf/pdf/459069/FINTEK/F71808A.html [flashlayout]: flashlayout.svg -[flashing methods]: ../../../flash_tutorial/index.md +[flashing methods]: ../../../tutorial/flashing_firmware/index.md diff --git a/Documentation/mainboard/prodrive/hermes.md b/Documentation/mainboard/prodrive/hermes.md index 6a12c3a..3b73ee0 100644 --- a/Documentation/mainboard/prodrive/hermes.md +++ b/Documentation/mainboard/prodrive/hermes.md @@ -49,6 +49,6 @@ ## Extra links [flashrom]: https://flashrom.org/Flashrom -[flashing tutorial]: ../../../../flash_tutorial/ext_power.md +[flashing tutorial]: ../../../../tutorial/flashing_firmware/ext_power.md [Intel FSP2.0]: ../../../../soc/intel/fsp/index.md [AST2500]: https://www.aspeedtech.com/products.php?fPath=20&rId=440 diff --git a/Documentation/mainboard/supermicro/x10slm-f.md b/Documentation/mainboard/supermicro/x10slm-f.md index 7036080..97c78d6 100644 --- a/Documentation/mainboard/supermicro/x10slm-f.md +++ b/Documentation/mainboard/supermicro/x10slm-f.md @@ -42,7 +42,7 @@ ```eval_rst In addition to the information here, please see the -:doc:`../../flash_tutorial/index`. +:doc:`../../tutorial/flashing_firmware/index`. ``` ### Internal programming diff --git a/Documentation/mainboard/supermicro/x11-lga1151-series/x11-lga1151-series.md b/Documentation/mainboard/supermicro/x11-lga1151-series/x11-lga1151-series.md index 692e5e3..394e0a98 100644 --- a/Documentation/mainboard/supermicro/x11-lga1151-series/x11-lga1151-series.md +++ b/Documentation/mainboard/supermicro/x11-lga1151-series/x11-lga1151-series.md @@ -56,6 +56,6 @@ [Supermicro X11 LGA1151 series]: https://www.supermicro.com/products/motherboard/Xeon3000/#1151 [OpenBMC]: https://www.openbmc.org/ [flashrom]: https://flashrom.org/Flashrom -[flashing tutorial]: ../../../../flash_tutorial/ext_power.md +[flashing tutorial]: ../../../../tutorial/flashing_firmware/ext_power.md [Intel FSP2.0]: ../../../../soc/intel/fsp/index.md [AST2400]: https://www.aspeedtech.com/products.php?fPath=20&rId=376 diff --git a/Documentation/mainboard/supermicro/x9sae.md b/Documentation/mainboard/supermicro/x9sae.md index b66ae92..406785d 100644 --- a/Documentation/mainboard/supermicro/x9sae.md +++ b/Documentation/mainboard/supermicro/x9sae.md @@ -105,4 +105,4 @@ [X9SAE-V]: https://www.supermicro.com/products/motherboard/xeon/c216/x9sae-v.cfm [W25Q128FVSG]: https://static.chipdip.ru/lib/093/DOC001093213.pdf [flashrom]: https://flashrom.org/Flashrom -[flash internally]: ../../flash_tutorial/int_flashrom.md +[flash internally]: ../../tutorial/flashing_firmware/int_flashrom.md diff --git a/Documentation/northbridge/intel/sandybridge/me_cleaner.md b/Documentation/northbridge/intel/sandybridge/me_cleaner.md index b457dcd..c888d58 100644 --- a/Documentation/northbridge/intel/sandybridge/me_cleaner.md +++ b/Documentation/northbridge/intel/sandybridge/me_cleaner.md @@ -81,4 +81,4 @@ * ME * BIOS -[external programmer]: ../../../flash_tutorial/index.md +[external programmer]: ../../../tutorial/flashing_firmware/index.md diff --git a/Documentation/flash_tutorial/ext_power.md b/Documentation/tutorial/flashing_firmware/ext_power.md similarity index 100% rename from Documentation/flash_tutorial/ext_power.md rename to Documentation/tutorial/flashing_firmware/ext_power.md diff --git a/Documentation/flash_tutorial/ext_standalone.md b/Documentation/tutorial/flashing_firmware/ext_standalone.md similarity index 100% rename from Documentation/flash_tutorial/ext_standalone.md rename to Documentation/tutorial/flashing_firmware/ext_standalone.md diff --git a/Documentation/flash_tutorial/flash_ic_diode.svg b/Documentation/tutorial/flashing_firmware/flash_ic_diode.svg similarity index 100% rename from Documentation/flash_tutorial/flash_ic_diode.svg rename to Documentation/tutorial/flashing_firmware/flash_ic_diode.svg diff --git a/Documentation/flash_tutorial/flash_ic_no_diode.svg b/Documentation/tutorial/flashing_firmware/flash_ic_no_diode.svg similarity index 100% rename from Documentation/flash_tutorial/flash_ic_no_diode.svg rename to Documentation/tutorial/flashing_firmware/flash_ic_no_diode.svg diff --git a/Documentation/flash_tutorial/index.md b/Documentation/tutorial/flashing_firmware/index.md similarity index 100% rename from Documentation/flash_tutorial/index.md rename to Documentation/tutorial/flashing_firmware/index.md diff --git a/Documentation/flash_tutorial/int_flashrom.md b/Documentation/tutorial/flashing_firmware/int_flashrom.md similarity index 100% rename from Documentation/flash_tutorial/int_flashrom.md rename to Documentation/tutorial/flashing_firmware/int_flashrom.md diff --git a/Documentation/flash_tutorial/no_ext_power.md b/Documentation/tutorial/flashing_firmware/no_ext_power.md similarity index 100% rename from Documentation/flash_tutorial/no_ext_power.md rename to Documentation/tutorial/flashing_firmware/no_ext_power.md diff --git a/Documentation/tutorial/index.md b/Documentation/tutorial/index.md index 8b3d88a..384f840 100644 --- a/Documentation/tutorial/index.md +++ b/Documentation/tutorial/index.md @@ -4,3 +4,4 @@ * [Part 2: Submitting a patch to coreboot.org](part2.md) * [Part 3: Writing unit tests](part3.md) * [Managing local additions](managing_local_additions.md) +* [Flashing firmware](flashing_firmware/index.md) 12 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/62424 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ife6d97254af4c006fe01480a78c76303f9cb34bb Gerrit-Change-Number: 62424 Gerrit-PatchSet: 14 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: Documentation: Use file paths to flashing firmware tutorial
by Felix Singer (Code Review) 11 Mar '22

11 Mar '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62452 ) Change subject: Documentation: Use file paths to flashing firmware tutorial ...................................................................... Documentation: Use file paths to flashing firmware tutorial In preperation for CB:62424, replace HTTP links pointing to the flashing firmware tutorial with file paths to the Markdown files. Change-Id: I6a271a912348cbe002bc9cced9922ed743e1133c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/62452 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Thomas Heijligen <src(a)posteo.de> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M Documentation/mainboard/asus/p5q.md M Documentation/mainboard/lenovo/ivb_internal_flashing.md M Documentation/mainboard/msi/ms7707/ms7707.md M Documentation/mainboard/supermicro/x9sae.md 4 files changed, 13 insertions(+), 9 deletions(-) Approvals: build bot (Jenkins): Verified Thomas Heijligen: Looks good to me, but someone else must approve Angel Pons: Looks good to me, but someone else must approve Michael Niewöhner: Looks good to me, approved diff --git a/Documentation/mainboard/asus/p5q.md b/Documentation/mainboard/asus/p5q.md index 3b3cdb4..39a8591 100644 --- a/Documentation/mainboard/asus/p5q.md +++ b/Documentation/mainboard/asus/p5q.md @@ -130,5 +130,5 @@ echo 2000 >/sys/class/hwmon/hwmon2/pwm1_tolerance [ASUS P5Q]: https://www.asus.com/Motherboards/P5Q -[this guide]: https://doc.coreboot.org/flash_tutorial/int_flashrom.html +[this guide]: ../../flash_tutorial/int_flashrom.md [kernel docs]: https://www.kernel.org/doc/Documentation/hwmon/w83627ehf.rst diff --git a/Documentation/mainboard/lenovo/ivb_internal_flashing.md b/Documentation/mainboard/lenovo/ivb_internal_flashing.md index 1d02cac..1aeea8b 100644 --- a/Documentation/mainboard/lenovo/ivb_internal_flashing.md +++ b/Documentation/mainboard/lenovo/ivb_internal_flashing.md @@ -353,9 +353,12 @@ Bingo! -Now you can [flash internally](/flash_tutorial/int_flashrom.md). -Remember to flash only the `bios` region (use `--ifd -i bios -N` -flashrom arguments). `fd` and `me` are still locked. +Now you can [flash internally]. Remember to flash only the `bios` region +(use `--ifd -i bios -N` flashrom arguments). `fd` and `me` are still +locked. Note that you should have an external SPI programmer as a backup method. It will help you recover if you flash non-working ROM by mistake. + + +[flash internally]: ../../flash_tutorial/int_flashrom.md diff --git a/Documentation/mainboard/msi/ms7707/ms7707.md b/Documentation/mainboard/msi/ms7707/ms7707.md index 83b860c..9309596 100644 --- a/Documentation/mainboard/msi/ms7707/ms7707.md +++ b/Documentation/mainboard/msi/ms7707/ms7707.md @@ -74,7 +74,7 @@ Put all back in place and restart the board. It might need 1-2 AC power cycles to reinitialize (running at full fan speed - don't panic). * External flashing has been tested with RPi2 without main power connected. -3.3V provided by RPi2. Read more about flashing methods [here](https://doc.coreboot.org/flash_tutorial/index.html). +3.3V provided by RPi2. Read more about [flashing methods]. * In case of going back to proprietary BIOS create/save CMOS settings as early as possible (do not leave BIOS on first start without saving settings). The BIOS might corrupt nvram (not cmos!) and leave the system in a dead state @@ -110,3 +110,4 @@ [Winbond 25Q32BV datasheet]: https://www.winbond.com/resource-files/w25q32bv_revi_100413_wo_automotive.p… [Fintek F71808A datasheet]: https://www.alldatasheet.com/datasheet-pdf/pdf/459069/FINTEK/F71808A.html [flashlayout]: flashlayout.svg +[flashing methods]: ../../../flash_tutorial/index.md diff --git a/Documentation/mainboard/supermicro/x9sae.md b/Documentation/mainboard/supermicro/x9sae.md index ddc5ac7..b66ae92 100644 --- a/Documentation/mainboard/supermicro/x9sae.md +++ b/Documentation/mainboard/supermicro/x9sae.md @@ -41,10 +41,9 @@ The following command may be used to flash coreboot. (To do so, linux kernel could be started with `iomem=relaxed` or unload the `lpc_ich` kernel module) -Now you can [flash internally](/flash_tutorial/int_flashrom.md). It is -recommended to flash only the `bios` region (use `--ifd -i bios -N` flashrom -arguments), in order to minimize the chances of messing something up in the -beginning. +Now you can [flash internally]. It is recommended to flash only the `bios` +region (use `--ifd -i bios -N` flashrom arguments), in order to minimize the +chances of messing something up in the beginning. The flash chip is a SOIC-8 SPI flash, and may be socketed, so it's also easy to do in-system programming, or remove and flash externally if it is socketed. @@ -106,3 +105,4 @@ [X9SAE-V]: https://www.supermicro.com/products/motherboard/xeon/c216/x9sae-v.cfm [W25Q128FVSG]: https://static.chipdip.ru/lib/093/DOC001093213.pdf [flashrom]: https://flashrom.org/Flashrom +[flash internally]: ../../flash_tutorial/int_flashrom.md 9 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. -- To view, visit https://review.coreboot.org/c/coreboot/+/62452 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6a271a912348cbe002bc9cced9922ed743e1133c Gerrit-Change-Number: 62452 Gerrit-PatchSet: 11 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: Documentation: Move firmware flashing tutorial to tutorial section
by Felix Singer (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Michael Niewöhner. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62424 ) Change subject: Documentation: Move firmware flashing tutorial to tutorial section ...................................................................... Patch Set 13: (1 comment) Patchset: PS12: > Hmmm, just some thoughts: Why `Tutorial`, why not `Getting started`? Should we merge `Getting starte […] I have similar plans, but for now I would like to avoid changes which would have too much impact on something (like merging two sections) and rather do small steps. Your comment contains very good thoughts. There is definitely work to do, but should be discussed with more people. -- To view, visit https://review.coreboot.org/c/coreboot/+/62424 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ife6d97254af4c006fe01480a78c76303f9cb34bb Gerrit-Change-Number: 62424 Gerrit-PatchSet: 13 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Fri, 11 Mar 2022 19:19:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Add companion device name to WWAN PCIe generic device
by Cliff Huang (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Bora Guvendik, Selma Bensaid, Tim Wawrzynczak. Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62330 ) Change subject: mb/google/brya: Add companion device name to WWAN PCIe generic device ...................................................................... Patch Set 10: (1 comment) File src/mainboard/google/brya/variants/brya0/overridetree.cb: https://review.coreboot.org/c/coreboot/+/62330/comment/05b5fce5_19ce1122 PS10, Line 213: rp6_wwan > We are supposed to have the DmaProperty in 3 places total: […] I like your PCIe generic approach better. Unlike GPIO pins, those properties are system specific and are not been used by the drivers themselves. It makes sense to stay in the system-oriented common code. In case we need to add more properties or generating new APCI objects, we can only update PCIe generic driver and its chip.h, PCIe instances in the cb files without modifying all the related drivers code and chip.h, which requires more separate code commits. Further, we don't need to keep our eyes on new drivers for a new part to ensure they does the same for those properties and _DSD. We can add PCIe generic devices to CNVi and do the same as WWAN. In fact, it might not be a bad idea to merge rtd3 to be part of PCIe generic so that we can separate out driver and system specific in two places. Just my thought. -- To view, visit https://review.coreboot.org/c/coreboot/+/62330 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia343c7545cf30bdbcd1de19e5eb84049dbb2977f Gerrit-Change-Number: 62330 Gerrit-PatchSet: 10 Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com> Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Cliff Huang <cliff.huang(a)intel.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Fri, 11 Mar 2022 19:12:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Move firmware flashing tutorial to tutorial section
by Michael Niewöhner (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Felix Singer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62424 ) Change subject: Documentation: Move firmware flashing tutorial to tutorial section ...................................................................... Patch Set 12: (1 comment) Patchset: PS12: Hmmm, just some thoughts: Why `Tutorial`, why not `Getting started`? Should we merge `Getting started` and `Tutorial`? Why are `Setting up GPIOs` and `Writing Documentation` in `Getting started` instead of being part of `Tutorial`? Oh, and why isn't `Tutorial>Writing unit tests for coreboot` part of `Technotes>Unit testing coreboot`... hmpf -- To view, visit https://review.coreboot.org/c/coreboot/+/62424 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ife6d97254af4c006fe01480a78c76303f9cb34bb Gerrit-Change-Number: 62424 Gerrit-PatchSet: 12 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Fri, 11 Mar 2022 19:08:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Use file paths to flashing firmware tutorial
by Felix Singer (Code Review) 11 Mar '22

11 Mar '22

Attention is currently required from: Thomas Heijligen, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62452 ) Change subject: Documentation: Use file paths to flashing firmware tutorial ...................................................................... Patch Set 10: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62452/comment/22bc97a0_73c9d28f PS9, Line 9: to > for Done -- To view, visit https://review.coreboot.org/c/coreboot/+/62452 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6a271a912348cbe002bc9cced9922ed743e1133c Gerrit-Change-Number: 62452 Gerrit-PatchSet: 10 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 11 Mar 2022 19:05:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022