Attention is currently required from: Paul Menzel.
Hello build bot (Jenkins), Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62442
to look at the new patch set (#14).
Change subject: Documentation: Move services page to infrastructure section
......................................................................
Documentation: Move services page to infrastructure section
The services page documents various services and tools which are
provided by the project. It's more related to the infrastructure and
less related to the community section.
Thus, move it to the infrastructure section.
Change-Id: I0ca2aba8ae817cf874367fa17e567065aec99a93
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M Documentation/community/index.md
M Documentation/infrastructure/index.md
R Documentation/infrastructure/services.md
3 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/62442/14
--
To view, visit https://review.coreboot.org/c/coreboot/+/62442
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ca2aba8ae817cf874367fa17e567065aec99a93
Gerrit-Change-Number: 62442
Gerrit-PatchSet: 14
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer.
Hello build bot (Jenkins), Thomas Heijligen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62424
to look at the new patch set (#13).
Change subject: Documentation: Move firmware flashing tutorial to tutorial section
......................................................................
Documentation: Move firmware flashing tutorial to tutorial section
There is no need that the tutorial for flashing firmware has its own
point in the main menu. Thus, move it to the tutorial section.
Change-Id: Ife6d97254af4c006fe01480a78c76303f9cb34bb
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M Documentation/contributing/gsoc.md
M Documentation/index.md
M Documentation/mainboard/acer/g43t-am3.md
M Documentation/mainboard/asrock/h110m-dvs.md
M Documentation/mainboard/asrock/h77pro4-m.md
M Documentation/mainboard/asus/p5q.md
M Documentation/mainboard/gigabyte/ga-g41m-es2l.md
M Documentation/mainboard/hp/2560p.md
M Documentation/mainboard/lenovo/Ivy_Bridge_series.md
M Documentation/mainboard/lenovo/Sandy_Bridge_series.md
M Documentation/mainboard/lenovo/ivb_internal_flashing.md
M Documentation/mainboard/lenovo/t410.md
M Documentation/mainboard/lenovo/t420.md
M Documentation/mainboard/lenovo/t430.md
M Documentation/mainboard/lenovo/w530.md
M Documentation/mainboard/lenovo/x1.md
M Documentation/mainboard/lenovo/x230s.md
M Documentation/mainboard/lenovo/x301.md
M Documentation/mainboard/msi/ms7707/ms7707.md
M Documentation/mainboard/prodrive/hermes.md
M Documentation/mainboard/supermicro/x10slm-f.md
M Documentation/mainboard/supermicro/x11-lga1151-series/x11-lga1151-series.md
M Documentation/mainboard/supermicro/x9sae.md
M Documentation/northbridge/intel/sandybridge/me_cleaner.md
R Documentation/tutorial/flashing_firmware/ext_power.md
R Documentation/tutorial/flashing_firmware/ext_standalone.md
R Documentation/tutorial/flashing_firmware/flash_ic_diode.svg
R Documentation/tutorial/flashing_firmware/flash_ic_no_diode.svg
R Documentation/tutorial/flashing_firmware/index.md
R Documentation/tutorial/flashing_firmware/int_flashrom.md
R Documentation/tutorial/flashing_firmware/no_ext_power.md
M Documentation/tutorial/index.md
32 files changed, 26 insertions(+), 26 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/62424/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/62424
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife6d97254af4c006fe01480a78c76303f9cb34bb
Gerrit-Change-Number: 62424
Gerrit-PatchSet: 13
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Paul Menzel.
Hello build bot (Jenkins), Thomas Heijligen, Paul Menzel, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62441
to look at the new patch set (#13).
Change subject: Documentation: Rename infrastructure section
......................................................................
Documentation: Rename infrastructure section
In preparation to CB:62442, rename the section for infrastructure
related things to "Project infrastructure & services".
Change-Id: I1ba8a2e2070a79d8c9e955133203f9bb9f58cb8e
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M Documentation/index.md
M Documentation/infrastructure/index.md
2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/62441/13
--
To view, visit https://review.coreboot.org/c/coreboot/+/62441
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ba8a2e2070a79d8c9e955133203f9bb9f58cb8e
Gerrit-Change-Number: 62441
Gerrit-PatchSet: 13
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons.
Hello build bot (Jenkins), Thomas Heijligen, Angel Pons, Michael Niewöhner,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62452
to look at the new patch set (#10).
Change subject: Documentation: Use file paths to flashing firmware tutorial
......................................................................
Documentation: Use file paths to flashing firmware tutorial
In preperation for CB:62424, replace HTTP links pointing to the flashing
firmware tutorial with file paths to the Markdown files.
Change-Id: I6a271a912348cbe002bc9cced9922ed743e1133c
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M Documentation/mainboard/asus/p5q.md
M Documentation/mainboard/lenovo/ivb_internal_flashing.md
M Documentation/mainboard/msi/ms7707/ms7707.md
M Documentation/mainboard/supermicro/x9sae.md
4 files changed, 13 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/62452/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/62452
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a271a912348cbe002bc9cced9922ed743e1133c
Gerrit-Change-Number: 62452
Gerrit-PatchSet: 10
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62452 )
Change subject: Documentation: Use file paths to flashing firmware tutorial
......................................................................
Patch Set 9:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62452/comment/e786d8fa_0baff902
PS9, Line 9: to
for
--
To view, visit https://review.coreboot.org/c/coreboot/+/62452
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a271a912348cbe002bc9cced9922ed743e1133c
Gerrit-Change-Number: 62452
Gerrit-PatchSet: 9
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 11 Mar 2022 18:58:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62452 )
Change subject: Documentation: Use file paths to flashing firmware tutorial
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
File Documentation/mainboard/msi/ms7707/ms7707.md:
https://review.coreboot.org/c/coreboot/+/62452/comment/a90cf80c_a61f9bcb
PS5, Line 77: Read more about [flashing methods]
> There are other cases in the documentation, which are similar. I only changed the link because "here" isn't a proper reference link in the link list below.
I agree. Having `[here]: ...` in the reference list would be a bit strange
--
To view, visit https://review.coreboot.org/c/coreboot/+/62452
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a271a912348cbe002bc9cced9922ed743e1133c
Gerrit-Change-Number: 62452
Gerrit-PatchSet: 9
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Fri, 11 Mar 2022 18:57:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Nick Vaccaro, Eric Lai, Patrick Rudolph, Zhuohao Lee.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62738 )
Change subject: {mb, soc}: Move mrc_cache invalidating logic into `memory` common code
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
> Better to verify on Brask or SODIMM variant for SPD cache again.
Yes, I will wait for Zhuohao to verify.
--
To view, visit https://review.coreboot.org/c/coreboot/+/62738
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6f18e18adc6572571871dd6da1698186e4e3d671
Gerrit-Change-Number: 62738
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org>
Gerrit-Comment-Date: Fri, 11 Mar 2022 15:35:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: YH Lin, Nick Vaccaro, Mark Hsieh, Zhuohao Lee, EricR Lai, Felix Held.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62739 )
Change subject: mb/google/brya: set GPP_D0 to GPO and unlocked
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/62739
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I164ffff6bd3b4058d6e28247eb7c3ed46d3891b5
Gerrit-Change-Number: 62739
Gerrit-PatchSet: 4
Gerrit-Owner: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com>
Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com>
Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com>
Gerrit-CC: Will Tsai <will_tsai(a)wistron.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 11 Mar 2022 15:33:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62301 )
Change subject: drivers/pcie/generic: Add support to generate code under companion device instead
......................................................................
Patch Set 9:
(2 comments)
Patchset:
PS5:
> I'm all ears, but that's what we have at the moment 😐
Technically we don't have proper support for device drivers in sconfig. What
we do all the time is to repurpose the chip drivers. We could add support for
device drivers, i.e. sconfig syntax to attach specific device-ops and config
structs like we have for chip drivers. However for this particular case, we'd
have to make it a list of device-ops, I guess¹ (a little overhead and a lot
more implementation effort). Having the sconfig syntax would solve other
issues too, though. For instance, the singleton PCI ID lists for SoC-integrated
devices that are becoming more and more controversial would become obsolete.
¹ I'm not sure why there is an additional device in the devicetree. Is it
just to have something for the chip-driver semantics?
File src/drivers/pcie/generic/generic.c:
https://review.coreboot.org/c/coreboot/+/62301/comment/9c1f2a01_5a8da3e5
PS9, Line 36: present
Not sure, was this meant to be `parent`?
--
To view, visit https://review.coreboot.org/c/coreboot/+/62301
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80634bbfc2927f26f2a55a9c244eca517c437079
Gerrit-Change-Number: 62301
Gerrit-PatchSet: 9
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Cliff Huang <cliff.huang(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Fri, 11 Mar 2022 15:27:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment