coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: soc/intel/alderlake: Allow mainboard to configure c1-state auto-demotion
by Nick Vaccaro (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Felix Singer, Anil Kumar K, Maulik V Vaghela, Patrick Rudolph. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62629 ) Change subject: soc/intel/alderlake: Allow mainboard to configure c1-state auto-demotion ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62629 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d7839d8fecd7b5403f52f3926d1d0bc06728ed9 Gerrit-Change-Number: 62629 Gerrit-PatchSet: 12 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Selma Bensaid <selma.bensaid(a)intel.com> Gerrit-CC: Vinay Kumar <vinay.kumar(a)intel.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 15 Mar 2022 18:01:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/adl/chip.h: Convert all camel case variables to snake case
by Nick Vaccaro (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, 9elements QA, Patrick Rudolph. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62645 ) Change subject: soc/intel/adl/chip.h: Convert all camel case variables to snake case ...................................................................... Patch Set 12: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62645 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieda567a89ec9287e3d988d489f3b3769dffcf9e0 Gerrit-Change-Number: 62645 Gerrit-PatchSet: 12 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Tue, 15 Mar 2022 17:59:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/qualcomm/common: Add dram information to CBMEM table
by Shelley Chen (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Ravi kumar, Paul Menzel, mturney mturney, Sudheer Amrabadi, Julius Werner. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59195 ) Change subject: soc/qualcomm/common: Add dram information to CBMEM table ...................................................................... Patch Set 40: (1 comment) File src/soc/qualcomm/common/qclib.c: https://review.coreboot.org/c/coreboot/+/59195/comment/1fd0e958_9e542db8 PS40, Line 38: mem_region_base = cbmem_add(CBMEM_ID_MEM_CHIP_INFO, sizeof(struct mem_chip_info)); > line over 96 characters Please fix. -- To view, visit https://review.coreboot.org/c/coreboot/+/59195 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0f1dd05ee224bf8284661c0afaa01d0a9d71daa7 Gerrit-Change-Number: 59195 Gerrit-PatchSet: 40 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-CC: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-CC: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com> Gerrit-CC: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-Comment-Date: Tue, 15 Mar 2022 17:50:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: libpayload: Parse DDR Information using coreboot tables
by Shelley Chen (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Felix Singer, Ravi kumar, Paul Menzel, mturney mturney, Ravi Kumar Bokka, Julius Werner, Angel Pons, Arthur Heymans, Yu-Ping Wu. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59193 ) Change subject: libpayload: Parse DDR Information using coreboot tables ...................................................................... Patch Set 40: (1 comment) File src/commonlib/bsd/include/commonlib/bsd/mem_chip_info.h: https://review.coreboot.org/c/coreboot/+/59193/comment/5cb7cb47_efcc11bb PS40, Line 8: 38 > 0x38 And 40 --> 0x40 as well -- To view, visit https://review.coreboot.org/c/coreboot/+/59193 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieca7e9fc0e1a018fcb2e9315aebee088edac858e Gerrit-Change-Number: 59193 Gerrit-PatchSet: 40 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-CC: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-CC: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com> Gerrit-CC: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org> Gerrit-Attention: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: mturney mturney <quic_mturney(a)quicinc.com> Gerrit-Comment-Date: Tue, 15 Mar 2022 17:50:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util: Add amdfwread utility
by Robert Zieba (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Robert Zieba. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62795 to look at the new patch set (#5). Change subject: util: Add amdfwread utility ...................................................................... util: Add amdfwread utility Amdfwtool creates AMD firmware images however there is currently no way to get information from an existing image. This commit adds amdfwread to support that functionality. At the moment only reading PSP soft fuse flags is supported. BUG=b:202397678 TEST=Ran amdfwread and verified that it correctly read the soft fuse bits Signed-off-by: Robert Zieba <robertzieba(a)google.com> Change-Id: I15fa07c9cad8e4640e9c40e5539b0dab44424850 --- A util/amdfwread/Makefile A util/amdfwread/amdfwread.c A util/amdfwread/description.md 3 files changed, 405 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/62795/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/62795 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15fa07c9cad8e4640e9c40e5539b0dab44424850 Gerrit-Change-Number: 62795 Gerrit-PatchSet: 5 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: drivers/intel/fsp2_0: Fix compilation issues
by Anil Kumar K (Code Review) 15 Mar '22

15 Mar '22

Anil Kumar K has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62277 ) Change subject: drivers/intel/fsp2_0: Fix compilation issues ...................................................................... Patch Set 5: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/62277 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1f372e4c1aae0a78dbf96931c694882acaf0f0e9 Gerrit-Change-Number: 62277 Gerrit-PatchSet: 5 Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Tue, 15 Mar 2022 17:08:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util: Add amdfwread utility
by Robert Zieba (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Robert Zieba. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62795 to look at the new patch set (#4). Change subject: util: Add amdfwread utility ...................................................................... util: Add amdfwread utility Amdfwtool creates AMD firmware images however there is currently no way to get information from an existing image. This commit adds amdfwread to support that functionality. At the moment only reading PSP soft fuse flags is supported. BUG=b:202397678 TEST=Ran amdfwread and verified that it correctly read the soft fuse bits Signed-off-by: Robert Zieba <robertzieba(a)google.com> Change-Id: I15fa07c9cad8e4640e9c40e5539b0dab44424850 --- A util/amdfwread/Makefile A util/amdfwread/amdfwread.c A util/amdfwread/description.md 3 files changed, 405 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/62795/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/62795 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15fa07c9cad8e4640e9c40e5539b0dab44424850 Gerrit-Change-Number: 62795 Gerrit-PatchSet: 4 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util: Add amdfwread utility
by build bot (Jenkins) (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Robert Zieba. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62795 ) Change subject: util: Add amdfwread utility ...................................................................... Patch Set 3: (9 comments) File util/amdfwread/amdfwread.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144015): https://review.coreboot.org/c/coreboot/+/62795/comment/28adbf7d_da0249af PS3, Line 163: static uint64_t relative_offset(const psp_directory_header* header, uint32_t header_offset, "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144015): https://review.coreboot.org/c/coreboot/+/62795/comment/84e695e6_024d1ec0 PS3, Line 164: const psp_directory_entry* entry, size_t entry_index) "foo* bar" should be "foo *bar" Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144015): https://review.coreboot.org/c/coreboot/+/62795/comment/972829ad_dae0526c PS3, Line 206: psp_directory_header *header, psp_directory_entry **entries, size_t *num_entries) line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144015): https://review.coreboot.org/c/coreboot/+/62795/comment/16369895_fc91b7c0 PS3, Line 254: &current_entries,&num_current_entries) != 0) space required after that ',' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144015): https://review.coreboot.org/c/coreboot/+/62795/comment/1382b9e5_7a26376e PS3, Line 254: &current_entries,&num_current_entries) != 0) space required before that '&' (ctx:OxV) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144015): https://review.coreboot.org/c/coreboot/+/62795/comment/2dab88db_ffbb5847 PS3, Line 257: while (1) { trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144015): https://review.coreboot.org/c/coreboot/+/62795/comment/66e2734e_658b3f76 PS3, Line 265: uint64_t fuse = mode << 62 | addr; trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144015): https://review.coreboot.org/c/coreboot/+/62795/comment/2f6710a7_99edc9c0 PS3, Line 285: &current_entries,&num_current_entries) != 0) space required after that ',' (ctx:VxO) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144015): https://review.coreboot.org/c/coreboot/+/62795/comment/1009e63d_9e369484 PS3, Line 285: &current_entries,&num_current_entries) != 0) space required before that '&' (ctx:OxV) -- To view, visit https://review.coreboot.org/c/coreboot/+/62795 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15fa07c9cad8e4640e9c40e5539b0dab44424850 Gerrit-Change-Number: 62795 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-Comment-Date: Tue, 15 Mar 2022 16:51:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util: Add amdfwread utility
by Robert Zieba (Code Review) 15 Mar '22

15 Mar '22

Attention is currently required from: Robert Zieba. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62795 to look at the new patch set (#3). Change subject: util: Add amdfwread utility ...................................................................... util: Add amdfwread utility Amdfwtool creates AMD firmware images however there is currently no way to get information from an existing image. This commit adds amdfwread to support that functionality. At the moment only reading PSP soft fuse flags is supported. BUG=b:202397678 TEST=Ran amdfwread and verified that it correctly read the soft fuse bits Signed-off-by: Robert Zieba <robertzieba(a)google.com> Change-Id: I15fa07c9cad8e4640e9c40e5539b0dab44424850 --- A util/amdfwread/Makefile A util/amdfwread/amdfwread.c A util/amdfwread/description.md 3 files changed, 404 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/62795/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/62795 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15fa07c9cad8e4640e9c40e5539b0dab44424850 Gerrit-Change-Number: 62795 Gerrit-PatchSet: 3 Gerrit-Owner: Robert Zieba <robertzieba(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Robert Zieba <robertzieba(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in gerrit-avatars[master]: Add logo to profile ben-starlabs
by Ben McMillen (Code Review) 15 Mar '22

15 Mar '22

Ben McMillen has submitted this change. ( https://review.coreboot.org/c/gerrit-avatars/+/62839 ) Change subject: Add logo to profile ben-starlabs ...................................................................... Add logo to profile ben-starlabs Signed-off-by: Ben-StarLabs <ben(a)starlabs.systems> Change-Id: Ia935e21269ae8f14610528e0d94844690022c385 --- A 1004216.jpg 1 file changed, 0 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified; Looks good to me, approved diff --git a/1004216.jpg b/1004216.jpg new file mode 100644 index 0000000..c74869e --- /dev/null +++ b/1004216.jpg Binary files differ -- To view, visit https://review.coreboot.org/c/gerrit-avatars/+/62839 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: gerrit-avatars Gerrit-Branch: master Gerrit-Change-Id: Ia935e21269ae8f14610528e0d94844690022c385 Gerrit-Change-Number: 62839 Gerrit-PatchSet: 1 Gerrit-Owner: Ben McMillen <ben(a)starlabs.systems> Gerrit-Reviewer: Ben McMillen <ben(a)starlabs.systems> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022