coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: docs/contributing/gsoc: Add reference to easy projects
by Felix Singer (Code Review) 17 Mar '22

17 Mar '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62906 ) Change subject: docs/contributing/gsoc: Add reference to easy projects ...................................................................... docs/contributing/gsoc: Add reference to easy projects Change-Id: I22e4a7c6385ffb9ba77e10edad41ef3d027ba694 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/62906 Reviewed-by: Michael Niewöhner <foss(a)mniewoehner.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M Documentation/contributing/gsoc.md 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved diff --git a/Documentation/contributing/gsoc.md b/Documentation/contributing/gsoc.md index 4f85426..dfed54f 100644 --- a/Documentation/contributing/gsoc.md +++ b/Documentation/contributing/gsoc.md @@ -91,8 +91,8 @@ process and common issues. * Get signed up for Gerrit and push at least one patch to Gerrit for review. - Check Easy projects or ask for simple tasks on the [mailing list] or on our - other [community forums] if you need ideas. + Check the [easy project list][Project ideas] or ask for simple tasks on + the [mailing list] or on our other [community forums] if you need ideas. ### During the program @@ -264,6 +264,7 @@ [Coding style]: coding_style.md [Code of Conduct]: ../community/code_of_conduct.md [Language style]: ../community/language_style.md +[Project ideas]: project_ideas.md [GSoC Timeline]: https://developers.google.com/open-source/gsoc/timeline [GSoC Roles and Responsibilities]: https://developers.google.com/open-source/gsoc/help/responsibilities [GSoC Contributor Guide]: https://google.github.io/gsocguides/student -- To view, visit https://review.coreboot.org/c/coreboot/+/62906 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22e4a7c6385ffb9ba77e10edad41ef3d027ba694 Gerrit-Change-Number: 62906 Gerrit-PatchSet: 5 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: docs/contributing/gsoc: Add reference to easy projects
by Michael Niewöhner (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Felix Singer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62906 ) Change subject: docs/contributing/gsoc: Add reference to easy projects ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62906 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22e4a7c6385ffb9ba77e10edad41ef3d027ba694 Gerrit-Change-Number: 62906 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Comment-Date: Thu, 17 Mar 2022 22:09:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation/contributing/projects: Add "easy projects" section
by Felix Singer (Code Review) 17 Mar '22

17 Mar '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/62206 ) Change subject: Documentation/contributing/projects: Add "easy projects" section ...................................................................... Documentation/contributing/projects: Add "easy projects" section Change-Id: Ibf91a879478e03b584756dc24fe33fb013803f9d Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-on: https://review.coreboot.org/c/coreboot/+/62206 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M Documentation/contributing/project_ideas.md 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved diff --git a/Documentation/contributing/project_ideas.md b/Documentation/contributing/project_ideas.md index 75c78ca..cea7f7b 100644 --- a/Documentation/contributing/project_ideas.md +++ b/Documentation/contributing/project_ideas.md @@ -20,6 +20,24 @@ with the projects. We can then try together to figure out if you're a good match for a project, even when requirements might not all be met. +## Easy projects + +This is a collection of tasks which don't require deep knowledge on +coreboot itself. If you are a beginner and want to get familiar with the +the project and the code base, or if you just want to get your hands +dirty with some easy tasks, then these are for you. + + * Resolve static analysis issues reported by [scan-build] and + [Coverity scan]. More details on the page for + [Coverity scan integration]. + + * Resolve issues reported by the [linter][Linter issues] + +[scan-build]: https://coreboot.org/scan-build/ +[Coverity scan]: https://scan.coverity.com/projects/coreboot +[Coverity scan integration]: ../infrastructure/coverity.md +[Linter issues]: https://qa.coreboot.org/job/untested-coreboot-files/lastSuccessfulBuild/art… + ## Provide toolchain binaries Our crossgcc subproject provides a uniform compiler environment for working on coreboot and related projects. Sadly, building it takes hours, -- To view, visit https://review.coreboot.org/c/coreboot/+/62206 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibf91a879478e03b584756dc24fe33fb013803f9d Gerrit-Change-Number: 62206 Gerrit-PatchSet: 11 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: docs/contributing/gsoc: Add reference to easy projects
by Felix Singer (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Michael Niewöhner. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62906 ) Change subject: docs/contributing/gsoc: Add reference to easy projects ...................................................................... Patch Set 4: (1 comment) File Documentation/contributing/gsoc.md: https://review.coreboot.org/c/coreboot/+/62906/comment/82b31574_5b932f8a PS2, Line 94: easy projects from our project list > just `easy projects list`? Done -- To view, visit https://review.coreboot.org/c/coreboot/+/62906 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22e4a7c6385ffb9ba77e10edad41ef3d027ba694 Gerrit-Change-Number: 62906 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Thu, 17 Mar 2022 22:08:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: docs/contributing/gsoc: Add reference to easy projects
by Felix Singer (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62906 to look at the new patch set (#4). Change subject: docs/contributing/gsoc: Add reference to easy projects ...................................................................... docs/contributing/gsoc: Add reference to easy projects Change-Id: I22e4a7c6385ffb9ba77e10edad41ef3d027ba694 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M Documentation/contributing/gsoc.md 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/62906/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/62906 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22e4a7c6385ffb9ba77e10edad41ef3d027ba694 Gerrit-Change-Number: 62906 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: docs/contributing/gsoc: Add reference to easy projects
by Felix Singer (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Felix Singer. Hello build bot (Jenkins), Michael Niewöhner, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62906 to look at the new patch set (#3). Change subject: docs/contributing/gsoc: Add reference to easy projects ...................................................................... docs/contributing/gsoc: Add reference to easy projects Change-Id: I22e4a7c6385ffb9ba77e10edad41ef3d027ba694 Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M Documentation/contributing/gsoc.md 1 file changed, 4 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/62906/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/62906 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22e4a7c6385ffb9ba77e10edad41ef3d027ba694 Gerrit-Change-Number: 62906 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: commonlib/timestamp_serialized: Add timestamp enum to name mapping
by Julius Werner (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Jakub Czapiga, Tim Wawrzynczak. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62709 ) Change subject: commonlib/timestamp_serialized: Add timestamp enum to name mapping ...................................................................... Patch Set 5: (1 comment) File src/commonlib/include/commonlib/timestamp_serialized.h: https://review.coreboot.org/c/coreboot/+/62709/comment/82751221_f8a9c70b PS3, Line 316: #define ts_str(x) #x > Could we add STRINGIFY to cbmem as well? Good point, we should probably move STRINGIFY() to commonlib/bsd/helpers.h -- To view, visit https://review.coreboot.org/c/coreboot/+/62709 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifd49f20d6b00a5bbd21804cea3a50b8cef074cd1 Gerrit-Change-Number: 62709 Gerrit-PatchSet: 5 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Thu, 17 Mar 2022 22:02:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/skyrim: Add DXIO descriptors
by Jon Murphy (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Raul Rangel, Karthik Ramasubramanian, Felix Held. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62903 ) Change subject: mb/google/skyrim: Add DXIO descriptors ...................................................................... Patch Set 8: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/62903/comment/5f1e3617_5f59229e PS3, Line 13: TEST=Builds > I don't have hardware, we could send it to the factory, or wait until Google receives hardware? Requested assistance from factory bring up team in testing the patch -- To view, visit https://review.coreboot.org/c/coreboot/+/62903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib68cf3d64641b006e0f2c4805af22b44a505a0d1 Gerrit-Change-Number: 62903 Gerrit-PatchSet: 8 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 17 Mar 2022 22:00:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jon Murphy <jpmurphy(a)google.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/skyrim: Add DXIO descriptors
by Jon Murphy (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Raul Rangel, Karthik Ramasubramanian, Felix Held. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62903 ) Change subject: mb/google/skyrim: Add DXIO descriptors ...................................................................... Patch Set 8: (1 comment) File src/mainboard/google/skyrim/variants/baseboard/include/baseboard/variants.h: https://review.coreboot.org/c/coreboot/+/62903/comment/55398edb_1204199d PS3, Line 10: #define WLAN_DEVFN PCIE_GPP_2_0_DEVFN : #define SD_DEVFN PCIE_GPP_2_1_DEVFN > maybe i looked at the wrong page of the schematics Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/62903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib68cf3d64641b006e0f2c4805af22b44a505a0d1 Gerrit-Change-Number: 62903 Gerrit-PatchSet: 8 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 17 Mar 2022 22:00:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/skyrim: Add DXIO descriptors
by Jon Murphy (Code Review) 17 Mar '22

17 Mar '22

Attention is currently required from: Raul Rangel, Karthik Ramasubramanian, Felix Held. Hello build bot (Jenkins), Raul Rangel, Karthik Ramasubramanian, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62903 to look at the new patch set (#8). Change subject: mb/google/skyrim: Add DXIO descriptors ...................................................................... mb/google/skyrim: Add DXIO descriptors Add Skyrim DXIO descriptors using info from AMD and skyrim bouard shematics. BUG=b:225179599 TEST=Builds Signed-off-by: Jon Murphy <jpmurphy(a)google.com> Change-Id: Ib68cf3d64641b006e0f2c4805af22b44a505a0d1 --- M src/mainboard/google/skyrim/port_descriptors.c M src/mainboard/google/skyrim/variants/baseboard/devicetree.cb M src/mainboard/google/skyrim/variants/baseboard/include/baseboard/variants.h 3 files changed, 121 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/62903/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/62903 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib68cf3d64641b006e0f2c4805af22b44a505a0d1 Gerrit-Change-Number: 62903 Gerrit-PatchSet: 8 Gerrit-Owner: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022