coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: mb/google/zork/var/dirinboz: Add fw_config probe for ALC5682-VD & VS
by Robert Chen (Code Review) 18 Mar '22

18 Mar '22

Attention is currently required from: Paul Menzel, Rob Barnes. Robert Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61781 ) Change subject: mb/google/zork/var/dirinboz: Add fw_config probe for ALC5682-VD & VS ...................................................................... Patch Set 8: (1 comment) Patchset: PS8: Hi Rob, Could you please help to review? -- To view, visit https://review.coreboot.org/c/coreboot/+/61781 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icd4321ec0a284e35511dd4b860a16506f54cf663 Gerrit-Change-Number: 61781 Gerrit-PatchSet: 8 Gerrit-Owner: Robert Chen <robert.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Yu-hsuan Hsu <yuhsuan(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kevin Chiu <kevin.chiu.17802(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Comment-Date: Fri, 18 Mar 2022 00:48:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "Revert "drivers/intel/fsp2_0: Allow `mp_startup_all_cpus()` t...
by Nick Vaccaro (Code Review) 18 Mar '22

18 Mar '22

Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Paul Menzel, Andrey Petrov. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62907 ) Change subject: Revert "Revert "drivers/intel/fsp2_0: Allow `mp_startup_all_cpus()` to run serially"" ...................................................................... Patch Set 5: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/62907/comment/9baa6dc9_d7799ab6 PS4, Line 12: ACPI > `APIC` Ack https://review.coreboot.org/c/coreboot/+/62907/comment/cbafd907_3891d3d5 PS4, Line 12: end of detecting the cores, > this is the FSP MP initialization sequence Thanks. -- To view, visit https://review.coreboot.org/c/coreboot/+/62907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88c15a51c5d27fbd243478c923e75962d3f8d67d Gerrit-Change-Number: 62907 Gerrit-PatchSet: 5 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Fri, 18 Mar 2022 00:44:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "Revert "drivers/intel/fsp2_0: Allow `mp_startup_all_cpus()` t...
by Nick Vaccaro (Code Review) 18 Mar '22

18 Mar '22

Attention is currently required from: Subrata Banik, Paul Menzel, Nick Vaccaro, Andrey Petrov. Hello build bot (Jenkins), Subrata Banik, Tim Wawrzynczak, Andrey Petrov, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62907 to look at the new patch set (#5). Change subject: Revert "Revert "drivers/intel/fsp2_0: Allow `mp_startup_all_cpus()` to run serially"" ...................................................................... Revert "Revert "drivers/intel/fsp2_0: Allow `mp_startup_all_cpus()` to run serially"" This reverts a change that was causing hangs and exceptions during boot on an ADL brya4es. The hang (or APIC exception) occurs at what appears to be the FSP MP initialization sequence, prior to the "Display FSP Version Info HOB" log being displayed : [DEBUG] Detected 10 core, 12 thread CPU. [DEBUG] Display FSP Version Info HOB This reverts commit 40ca79714ad7d5f2aa201d83db4d97f21260d924. BUG=b:224873032 TEST=`emerge-brya coreboot chromeos-bootimage`, flash and verify brya4es is able to successfully reboot 200 times without any issues. Change-Id: I88c15a51c5d27fbd243478c923e75962d3f8d67d Signed-off-by: Nick Vaccaro <nvaccaro(a)google.com> --- M src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c 1 file changed, 17 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/62907/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/62907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88c15a51c5d27fbd243478c923e75962d3f8d67d Gerrit-Change-Number: 62907 Gerrit-PatchSet: 5 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/{}: Add SBU orientation property for Type C Mux
by Eric Lai (Code Review) 18 Mar '22

18 Mar '22

Attention is currently required from: Subrata Banik, Maulik V Vaghela, Meera Ravindranath, Nick Vaccaro, Prashant Malani. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61622 ) Change subject: mb/google/brya/{}: Add SBU orientation property for Type C Mux ...................................................................... Patch Set 5: Code-Review+1 (1 comment) Patchset: PS5: Still didn't get it, since it worked w/wo this change -- To view, visit https://review.coreboot.org/c/coreboot/+/61622 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6f7f9554b75f4d62298aac9938e66c71c3e7cee9 Gerrit-Change-Number: 61622 Gerrit-PatchSet: 5 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Prashant Malani <pmalani(a)chromium.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Prashant Malani <pmalani(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Prashant Malani <pmalani(a)chromium.org> Gerrit-Comment-Date: Fri, 18 Mar 2022 00:25:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/adl: Send EOP early in the boot sequence
by Tim Wawrzynczak (Code Review) 18 Mar '22

18 Mar '22

Attention is currently required from: Maulik V Vaghela. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62272 ) Change subject: soc/intel/adl: Send EOP early in the boot sequence ...................................................................... Patch Set 11: (1 comment) File src/soc/intel/alderlake/chip.c: https://review.coreboot.org/c/coreboot/+/62272/comment/198f6a2b_6798a7f8 PS11, Line 158: Intel CSE team recommends to send EOP close to FW init (between FSP-S exit and : * current boot sequence) to reduce message response time from CSE hence moving : * sending EOP to earlier stage. > what about cnl,tgl? is this a general recommendation? The reason we are doing this is we have performance metrics to meet, and if you wait "too long", the CSE may start to become busy doing other things, and you end up polling for the response to EOP for dozens of milliseconds. -- To view, visit https://review.coreboot.org/c/coreboot/+/62272 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9401d5e36ad43cdc0dfe947aabc82528d824df9b Gerrit-Change-Number: 62272 Gerrit-PatchSet: 11 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com> Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Comment-Date: Fri, 18 Mar 2022 00:14:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Revert "Revert "drivers/intel/fsp2_0: Allow `mp_startup_all_cpus()` t...
by Tim Wawrzynczak (Code Review) 18 Mar '22

18 Mar '22

Attention is currently required from: Subrata Banik, Paul Menzel, Nick Vaccaro, Andrey Petrov. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62907 ) Change subject: Revert "Revert "drivers/intel/fsp2_0: Allow `mp_startup_all_cpus()` to run serially"" ...................................................................... Patch Set 4: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/62907/comment/fb51f081_a4488c4b PS4, Line 12: ACPI `APIC` https://review.coreboot.org/c/coreboot/+/62907/comment/899a5fd9_c2bfc555 PS4, Line 12: end of detecting the cores, this is the FSP MP initialization sequence -- To view, visit https://review.coreboot.org/c/coreboot/+/62907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88c15a51c5d27fbd243478c923e75962d3f8d67d Gerrit-Change-Number: 62907 Gerrit-PatchSet: 4 Gerrit-Owner: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Comment-Date: Fri, 18 Mar 2022 00:06:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [RFC]soc/intel/icelake: Drop unmaintained platform
by Michael Niewöhner (Code Review) 18 Mar '22

18 Mar '22

Attention is currently required from: Arthur Heymans, Patrick Rudolph, Maulik V Vaghela, Paul Menzel, Christian Walter, Subrata Banik. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60053 ) Change subject: [RFC]soc/intel/icelake: Drop unmaintained platform ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60053 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ded90d2cc7595cddbf067a76cb9984936e1dcbf Gerrit-Change-Number: 60053 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 17 Mar 2022 23:57:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [RFC]soc/intel/icelake: Drop unmaintained platform
by Michael Niewöhner (Code Review) 18 Mar '22

18 Mar '22

Attention is currently required from: Arthur Heymans, Patrick Rudolph, Maulik V Vaghela, Paul Menzel, Christian Walter, Subrata Banik. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60053 ) Change subject: [RFC]soc/intel/icelake: Drop unmaintained platform ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: rebased -- To view, visit https://review.coreboot.org/c/coreboot/+/60053 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ded90d2cc7595cddbf067a76cb9984936e1dcbf Gerrit-Change-Number: 60053 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 17 Mar 2022 23:57:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [RFC]soc/intel/icelake: Drop unmaintained platform
by Michael Niewöhner (Code Review) 18 Mar '22

18 Mar '22

Attention is currently required from: Arthur Heymans, Patrick Rudolph, Maulik V Vaghela, Paul Menzel, Christian Walter, Subrata Banik, Michael Niewöhner. Michael Niewöhner has uploaded a new patch set (#3) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/60053 ) Change subject: [RFC]soc/intel/icelake: Drop unmaintained platform ...................................................................... [RFC]soc/intel/icelake: Drop unmaintained platform The only user of this platform was the CRB board. From the looks of it the code never was ready for production as only engineering sample CPUID are supported. Change-Id: I3ded90d2cc7595cddbf067a76cb9984936e1dcbf Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> Signed-off-by: Michael Niewöhner <foss(a)mniewoehner.de> --- M Documentation/mainboard/index.md D Documentation/mainboard/intel/icelake_rvp.md D Documentation/soc/intel/icelake/iceLake_coreboot_development.md D Documentation/soc/intel/icelake/index.md M Documentation/soc/intel/index.md D src/mainboard/intel/icelake_rvp/Kconfig D src/mainboard/intel/icelake_rvp/Kconfig.name D src/mainboard/intel/icelake_rvp/Makefile.inc D src/mainboard/intel/icelake_rvp/board_id.c D src/mainboard/intel/icelake_rvp/board_id.h D src/mainboard/intel/icelake_rvp/board_info.txt D src/mainboard/intel/icelake_rvp/bootblock.c D src/mainboard/intel/icelake_rvp/chromeos.c D src/mainboard/intel/icelake_rvp/chromeos.fmd D src/mainboard/intel/icelake_rvp/dsdt.asl D src/mainboard/intel/icelake_rvp/hda_verb.c D src/mainboard/intel/icelake_rvp/mainboard.c D src/mainboard/intel/icelake_rvp/romstage_fsp_params.c D src/mainboard/intel/icelake_rvp/spd/Makefile.inc D src/mainboard/intel/icelake_rvp/spd/empty.spd.hex D src/mainboard/intel/icelake_rvp/spd/samsung_K4F6E304HBMGCJ.spd.hex D src/mainboard/intel/icelake_rvp/spd/spd.h D src/mainboard/intel/icelake_rvp/spd/spd_util.c D src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/ec.h D src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/gpio.h D src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/hda_verb.h D src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/variants.h D src/mainboard/intel/icelake_rvp/variants/icl_u/Makefile.inc D src/mainboard/intel/icelake_rvp/variants/icl_u/devicetree.cb D src/mainboard/intel/icelake_rvp/variants/icl_u/gpio.c D src/mainboard/intel/icelake_rvp/variants/icl_y/Makefile.inc D src/mainboard/intel/icelake_rvp/variants/icl_y/devicetree.cb D src/mainboard/intel/icelake_rvp/variants/icl_y/gpio.c M src/soc/intel/common/block/cpu/mp_init.c D src/soc/intel/icelake/Kconfig D src/soc/intel/icelake/Makefile.inc D src/soc/intel/icelake/acpi.c D src/soc/intel/icelake/acpi/gpio.asl D src/soc/intel/icelake/acpi/pch_hda.asl D src/soc/intel/icelake/acpi/pci_irqs.asl D src/soc/intel/icelake/acpi/pcie.asl D src/soc/intel/icelake/acpi/scs.asl D src/soc/intel/icelake/acpi/serialio.asl D src/soc/intel/icelake/acpi/southbridge.asl D src/soc/intel/icelake/acpi/xhci.asl D src/soc/intel/icelake/bootblock/bootblock.c D src/soc/intel/icelake/bootblock/pch.c D src/soc/intel/icelake/bootblock/report_platform.c D src/soc/intel/icelake/chip.c D src/soc/intel/icelake/chip.h D src/soc/intel/icelake/cpu.c D src/soc/intel/icelake/elog.c D src/soc/intel/icelake/espi.c D src/soc/intel/icelake/finalize.c D src/soc/intel/icelake/fsp_params.c D src/soc/intel/icelake/gpio.c D src/soc/intel/icelake/gspi.c D src/soc/intel/icelake/i2c.c D src/soc/intel/icelake/include/soc/bootblock.h D src/soc/intel/icelake/include/soc/cpu.h D src/soc/intel/icelake/include/soc/espi.h D src/soc/intel/icelake/include/soc/gpe.h D src/soc/intel/icelake/include/soc/gpio.h D src/soc/intel/icelake/include/soc/gpio_defs.h D src/soc/intel/icelake/include/soc/gpio_soc_defs.h D src/soc/intel/icelake/include/soc/iomap.h D src/soc/intel/icelake/include/soc/irq.h D src/soc/intel/icelake/include/soc/itss.h D src/soc/intel/icelake/include/soc/me.h D src/soc/intel/icelake/include/soc/msr.h D src/soc/intel/icelake/include/soc/nvs.h D src/soc/intel/icelake/include/soc/p2sb.h D src/soc/intel/icelake/include/soc/pch.h D src/soc/intel/icelake/include/soc/pci_devs.h D src/soc/intel/icelake/include/soc/pcr_ids.h D src/soc/intel/icelake/include/soc/pm.h D src/soc/intel/icelake/include/soc/pmc.h D src/soc/intel/icelake/include/soc/ramstage.h D src/soc/intel/icelake/include/soc/romstage.h D src/soc/intel/icelake/include/soc/serialio.h D src/soc/intel/icelake/include/soc/smbus.h D src/soc/intel/icelake/include/soc/soc_chip.h D src/soc/intel/icelake/include/soc/systemagent.h D src/soc/intel/icelake/include/soc/usb.h D src/soc/intel/icelake/lockdown.c D src/soc/intel/icelake/me.c D src/soc/intel/icelake/p2sb.c D src/soc/intel/icelake/pmc.c D src/soc/intel/icelake/pmutil.c D src/soc/intel/icelake/reset.c D src/soc/intel/icelake/romstage/Makefile.inc D src/soc/intel/icelake/romstage/fsp_params.c D src/soc/intel/icelake/romstage/romstage.c D src/soc/intel/icelake/romstage/systemagent.c D src/soc/intel/icelake/sd.c D src/soc/intel/icelake/smihandler.c D src/soc/intel/icelake/spi.c D src/soc/intel/icelake/systemagent.c D src/soc/intel/icelake/uart.c 99 files changed, 0 insertions(+), 8,115 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/60053/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/60053 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ded90d2cc7595cddbf067a76cb9984936e1dcbf Gerrit-Change-Number: 60053 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: qualcomm/sc7280: Add support for edp and mdp driver
by Shelley Chen (Code Review) 18 Mar '22

18 Mar '22

Attention is currently required from: Ravi kumar, Julius Werner. Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61342 ) Change subject: qualcomm/sc7280: Add support for edp and mdp driver ...................................................................... Patch Set 13: (1 comment) File src/soc/qualcomm/sc7280/display/edp_ctrl.c: https://review.coreboot.org/c/coreboot/+/61342/comment/9a9dd9d4_09e3bdc2 PS13, Line 360: gpio_output(GPIO(80), 1); : mdelay(20); : gpio_configure(GPIO(60), GPIO_FUNC_GPIO, : GPIO_PULL_DOWN, GPIO_2MA, GPIO_INPUT); : mdelay(10); : gpio_output(GPIO(8), 1); : mdelay(20); any chance that we can clarify what these GPIOs are? Either #define them or at least add comments to what these 3 GPIOs are. -- To view, visit https://review.coreboot.org/c/coreboot/+/61342 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If89abb76028766b19450e756889a5d7776106f95 Gerrit-Change-Number: 61342 Gerrit-PatchSet: 13 Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Vinod Polimera <vpolimer(a)qualcomm.corp-partner.google.com> Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Thu, 17 Mar 2022 23:45:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022