coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: [set offset, enable rth and energy report]
by build bot (Jenkins) (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62959 ) Change subject: [set offset, enable rth and energy report] ...................................................................... Patch Set 1: (6 comments) File src/soc/intel/alderlake/fsp_params.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144355): https://review.coreboot.org/c/coreboot/+/62959/comment/8f0d05f0_9bc5eadb PS1, Line 726: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144355): https://review.coreboot.org/c/coreboot/+/62959/comment/1388b107_03080f5c PS1, Line 728: s_cfg->RaceToHalt = 0x1; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144355): https://review.coreboot.org/c/coreboot/+/62959/comment/1a51faee_b1bc973c PS1, Line 729: s_cfg->ImonSlope[0] = 143; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144355): https://review.coreboot.org/c/coreboot/+/62959/comment/32ef7bc6_f46e1b6d PS1, Line 730: s_cfg->ImonSlope[1] = 103; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144355): https://review.coreboot.org/c/coreboot/+/62959/comment/e8dcb51d_0f04815b PS1, Line 731: s_cfg->VccInAuxImonSlope = 111; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144355): https://review.coreboot.org/c/coreboot/+/62959/comment/3d623030_9d6c4ecb PS1, Line 733: trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/62959 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia66768d280028e92781caf112bb5007bd88170d5 Gerrit-Change-Number: 62959 Gerrit-PatchSet: 1 Gerrit-Owner: Anshul Bansal <anshul.bansal(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Mon, 21 Mar 2022 12:57:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: [set offset, enable rth and energy report]
by Anshul Bansal (Code Review) 21 Mar '22

21 Mar '22

Anshul Bansal has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/62959 ) Change subject: [set offset, enable rth and energy report] ...................................................................... [set offset, enable rth and energy report] Reported-by: Bansal, Anshul <anshul.bansal(a)intel.com> Signed-off-by: Bansal, Anshul <anshul.bansal(a)intel.com> Change-Id: Ia66768d280028e92781caf112bb5007bd88170d5 --- M src/soc/intel/alderlake/fsp_params.c 1 file changed, 8 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/62959/1 diff --git a/src/soc/intel/alderlake/fsp_params.c b/src/soc/intel/alderlake/fsp_params.c old mode 100644 new mode 100755 index 2f3027d..3cefc40 --- a/src/soc/intel/alderlake/fsp_params.c +++ b/src/soc/intel/alderlake/fsp_params.c @@ -723,6 +723,14 @@ } s_cfg->C1StateAutoDemotion = !config->disable_c1_state_auto_demotion; + + s_cfg->PchPmDisableEnergyReport = 0x0; + s_cfg->RaceToHalt = 0x1; + s_cfg->ImonSlope[0] = 143; + s_cfg->ImonSlope[1] = 103; + s_cfg->VccInAuxImonSlope = 111; + + } static void fill_fsps_irq_params(FSP_S_CONFIG *s_cfg, -- To view, visit https://review.coreboot.org/c/coreboot/+/62959 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia66768d280028e92781caf112bb5007bd88170d5 Gerrit-Change-Number: 62959 Gerrit-PatchSet: 1 Gerrit-Owner: Anshul Bansal <anshul.bansal(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/brask/variants/moli: init overridetree for moli
by Raihow Shi (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: YH Lin, Tim Wawrzynczak, Johnny Li, Zhuohao Lee, Felix Held. Raihow Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62321 ) Change subject: mb/google/brask/variants/moli: init overridetree for moli ...................................................................... Patch Set 28: (1 comment) Patchset: PS27: > i think we need to settle the FW_CONFIG bitmasks first otherwise LGTM Ok, I abandoned this CL, and squashed into CB:62852. -- To view, visit https://review.coreboot.org/c/coreboot/+/62321 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8829d4b39d48ae574eeccbfc62e79b671211ae2d Gerrit-Change-Number: 62321 Gerrit-PatchSet: 28 Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com> Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-CC: Johnny Li <johnny_li(a)wistron.corp-partner.google.com> Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Peter Chi <peter_chi(a)wistron.corp-partner.google.com> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Will Tsai <will_tsai(a)wistron.corp-partner.google.com> Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Johnny Li <johnny_li(a)wistron.corp-partner.google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 21 Mar 2022 12:54:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/clevo/tgl-u: Add Clevo NV41 Tiger Lake laptop support
by Michał Żygowski (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Felix Singer, Michał Kopeć, Michael Niewöhner. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62498 ) Change subject: mb/clevo/tgl-u: Add Clevo NV41 Tiger Lake laptop support ...................................................................... Patch Set 3: (3 comments) File src/mainboard/clevo/tgl-u/Kconfig.name: https://review.coreboot.org/c/coreboot/+/62498/comment/a96be924_dc263ebb PS1, Line 5: select BOARD_CLEVO_NV4X_BASE > hmm, but that's exactly how it's done in clevo/cml-u/Kconfig{,. […] I saw patches shifting these selects to the Kconfig.name to Kconfig files, e.g. CB:62816 Michał, let's apply it as well. File src/mainboard/clevo/tgl-u/board.fmd: PS1: > Why is this needed? Nothing special here. All handled automatically by build system. Michał you can remove the file. File src/mainboard/clevo/tgl-u/variants/baseboard/devicetree.cb: https://review.coreboot.org/c/coreboot/+/62498/comment/f4c8adde_c245e156 PS1, Line 58: register "LpmStateDisableMask" = " : LPM_S0i2_1 | : LPM_S0i2_2 | : LPM_S0i3_1 | : LPM_S0i3_2 | : LPM_S0i3_3 | : LPM_S0i3_4 : > well, this is already covered in src/soc/intel/tigerlake/lpm. […] Yes, but it does not handle the LPM_S0i2_1. We can remove the rest I believe -- To view, visit https://review.coreboot.org/c/coreboot/+/62498 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib373d62d9d18bafdfde2e1acb4e00e3a20ae09bc Gerrit-Change-Number: 62498 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Mon, 21 Mar 2022 12:30:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Michał Kopeć <michal.kopec(a)3mdeb.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/adl-n: Add device ID for TCSS XHCI
by Maulik V Vaghela (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Kangheui Won, Tim Wawrzynczak, Rizwan Qureshi, Krishna P Bhat D. Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62955 ) Change subject: soc/intel/adl-n: Add device ID for TCSS XHCI ...................................................................... Patch Set 4: (1 comment) File src/include/device/pci_ids.h: https://review.coreboot.org/c/coreboot/+/62955/comment/4f7fd4f1_ea41cabf PS3, Line 4134: 0x464e > Ah, okay, I had to download the latest revision. Thank you for the review :) -- To view, visit https://review.coreboot.org/c/coreboot/+/62955 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id5d42d60eb05137406ef45b9e87e27948fc3b674 Gerrit-Change-Number: 62955 Gerrit-PatchSet: 4 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Usha P <usha.p(a)intel.com> Gerrit-CC: harsha.b.r(a)intel.com Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Comment-Date: Mon, 21 Mar 2022 12:24:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/pc80/tpm/tis.c: Use fixed TPM ACPI path
by Michał Żygowski (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Matt DeVillier, Michał Kopeć, Paul Menzel, Christian Walter, Michael Niewöhner. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62493 ) Change subject: drivers/pc80/tpm/tis.c: Use fixed TPM ACPI path ...................................................................... Patch Set 3: Code-Review+2 (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/62493/comment/21214e16_7fb4d150 PS1, Line 9: Windows 11 expect the TPM to reside under \\_SB_.PCI0 in ACPI device : hierarchy, otherwise the TPM is not detected. > Updated Ack https://review.coreboot.org/c/coreboot/+/62493/comment/c9bbd295_d8b1f2a8 PS1, Line 13: TEST=Boot Windows 11 on Clevo NV41MZ and see the TPm is detected > No change on Linux, everything still works as expected. Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/62493 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If0b3136e3eb8eb1bb132132a5f3a7034bdd3b424 Gerrit-Change-Number: 62493 Gerrit-PatchSet: 3 Gerrit-Owner: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Comment-Date: Mon, 21 Mar 2022 12:17:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com> Comment-In-Reply-To: Michał Kopeć <michal.kopec(a)3mdeb.com> Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/adl-n: Add device ID for TCSS XHCI
by Subrata Banik (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Maulik V Vaghela, Kangheui Won, Tim Wawrzynczak, Rizwan Qureshi, Krishna P Bhat D. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62955 ) Change subject: soc/intel/adl-n: Add device ID for TCSS XHCI ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62955 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id5d42d60eb05137406ef45b9e87e27948fc3b674 Gerrit-Change-Number: 62955 Gerrit-PatchSet: 4 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Usha P <usha.p(a)intel.com> Gerrit-CC: harsha.b.r(a)intel.com Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Comment-Date: Mon, 21 Mar 2022 12:16:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/adl-n: Add device ID for TCSS XHCI
by Subrata Banik (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Maulik V Vaghela, Kangheui Won, Tim Wawrzynczak, Rizwan Qureshi, Krishna P Bhat D. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62955 ) Change subject: soc/intel/adl-n: Add device ID for TCSS XHCI ...................................................................... Patch Set 4: (1 comment) File src/include/device/pci_ids.h: https://review.coreboot.org/c/coreboot/+/62955/comment/bfb5ab38_3c1e9246 PS3, Line 4134: 0x464e > Hi Subrata, […] Ah, okay, I had to download the latest revision. -- To view, visit https://review.coreboot.org/c/coreboot/+/62955 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id5d42d60eb05137406ef45b9e87e27948fc3b674 Gerrit-Change-Number: 62955 Gerrit-PatchSet: 4 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Usha P <usha.p(a)intel.com> Gerrit-CC: harsha.b.r(a)intel.com Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Comment-Date: Mon, 21 Mar 2022 12:16:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Comment-In-Reply-To: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/adl-n: Add device ID for TCSS XHCI
by Maulik V Vaghela (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Subrata Banik, Kangheui Won, Tim Wawrzynczak, Rizwan Qureshi, Krishna P Bhat D. Hello build bot (Jenkins), Subrata Banik, Kangheui Won, Tim Wawrzynczak, Rizwan Qureshi, Krishna P Bhat D, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/62955 to look at the new patch set (#4). Change subject: soc/intel/adl-n: Add device ID for TCSS XHCI ...................................................................... soc/intel/adl-n: Add device ID for TCSS XHCI This patch adds TCSS XHCI device ID for ADL-N PCH which is required for USB3 port enumeration. Document Reference: 645548 revision 1.0 (Chapter 2.3) BUG=None BRANCH=None TEST=Check if device is detected correctly and ACPI entries are generated for device 0d.0 Change-Id: Id5d42d60eb05137406ef45b9e87e27948fc3b674 Signed-off-by: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> --- M src/include/device/pci_ids.h M src/soc/intel/common/block/usb4/xhci.c 2 files changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/62955/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/62955 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id5d42d60eb05137406ef45b9e87e27948fc3b674 Gerrit-Change-Number: 62955 Gerrit-PatchSet: 4 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Usha P <usha.p(a)intel.com> Gerrit-CC: harsha.b.r(a)intel.com Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/adl-n: Add device ID for TCSS XHCI
by Maulik V Vaghela (Code Review) 21 Mar '22

21 Mar '22

Attention is currently required from: Subrata Banik, Kangheui Won, Tim Wawrzynczak, Rizwan Qureshi, Krishna P Bhat D. Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62955 ) Change subject: soc/intel/adl-n: Add device ID for TCSS XHCI ...................................................................... Patch Set 3: (1 comment) File src/include/device/pci_ids.h: https://review.coreboot.org/c/coreboot/+/62955/comment/2eba9674_011eeb48 PS3, Line 4134: 0x464e > @Maulik, I don't see this ID in doc 645548 Hi Subrata, Can you please tell me revision of the document? I was referring to revision 1.0 -- To view, visit https://review.coreboot.org/c/coreboot/+/62955 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id5d42d60eb05137406ef45b9e87e27948fc3b674 Gerrit-Change-Number: 62955 Gerrit-PatchSet: 3 Gerrit-Owner: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Usha P <usha.p(a)intel.com> Gerrit-CC: harsha.b.r(a)intel.com Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Kangheui Won <khwon(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Comment-Date: Mon, 21 Mar 2022 12:12:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Subrata Banik <subratabanik(a)google.com> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022