Attention is currently required from: Frank Wu, Tim Wawrzynczak, Amanda Hwang.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62998 )
Change subject: mb/google/brya/var/brya0: Replace amp max98357 with max98360
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62998/comment/422049c5_ce71b828
PS2, Line 617: register "hid" = ""MX98360A""
tab
--
To view, visit https://review.coreboot.org/c/coreboot/+/62998
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3033e31cf5c2dade02dc19531f5e5365eeeb7a78
Gerrit-Change-Number: 62998
Gerrit-PatchSet: 2
Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 23 Mar 2022 02:41:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Kangheui Won, Tim Wawrzynczak, Reka Norman, Christian Walter.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63011 )
Change subject: drivers/i2c/tpm: Add workaround for Ti50
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63011/comment/654d2eb2_82942800
PS2, Line 9: Ti50 FW under 0.15 is not support board cfg. And ODM
: stocks are 0.12 pre-flashed. Add workaroud for the old
: Ti50 chip.
> 72 characters wide
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/63011
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieec7842ca66b4c690df04a400cebcf45138c745d
Gerrit-Change-Number: 63011
Gerrit-PatchSet: 3
Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Wed, 23 Mar 2022 02:40:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Kangheui Won, Reka Norman, Christian Walter, Eric Lai.
Hello build bot (Jenkins), Kangheui Won, Tim Wawrzynczak, Reka Norman, Christian Walter,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63011
to look at the new patch set (#3).
Change subject: drivers/i2c/tpm: Add workaround for Ti50
......................................................................
drivers/i2c/tpm: Add workaround for Ti50
Ti50 FW under 0.15 is not support board cfg. And ODM stocks are 0.12
pre-flashed. Add workaroud for the old Ti50 chip.
BUG=b:224650720
TEST=no I2C errors in coreboot.
[ERROR] cr50_i2c_read: Address write failed
[INFO ] .I2C stop bit not received
Signed-off-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Change-Id: Ieec7842ca66b4c690df04a400cebcf45138c745d
---
M src/drivers/i2c/tpm/Kconfig
M src/drivers/i2c/tpm/cr50.c
M src/mainboard/google/brya/Kconfig
3 files changed, 11 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/63011/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/63011
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieec7842ca66b4c690df04a400cebcf45138c745d
Gerrit-Change-Number: 63011
Gerrit-PatchSet: 3
Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Frank Wu, Tim Wawrzynczak, Eric Lai.
Amanda Hwang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62998 )
Change subject: mb/google/brya/var/brya0: Replace amp max98357 with max98360
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS1:
> Will this broken the OEM string, looks like a little long? try dmidecode to see the OEM string
I have verified with local build kernel to test OEM string, and works fine.
Handle 0x0009, DMI type 11, 5 bytes
OEM Strings
String 1: AUDIO-MAX98360_ALC5682I_I2S_AMP_SSP2
String 2: DB_LTE-LTE_PCIE
String 3: UFC-UFC_MIPI_IMX208
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/62998/comment/45fdeed9_c138a7e8
PS1, Line 15: option AUDIO_UNKNOWN 0
: option MAX98357_ALC5682I_I2S 1
: option MAX98373_ALC5682_SNDW 2
: option MAX98373_NAU88L25B_I2S 3
: option ALC1019_NAU88L25B_I2S 4
: option MAX98360_ALC5682I_I2S_AMP_SSP2 5
> can you please align the right-hand side of all of these to match?
Done.
--
To view, visit https://review.coreboot.org/c/coreboot/+/62998
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3033e31cf5c2dade02dc19531f5e5365eeeb7a78
Gerrit-Change-Number: 62998
Gerrit-PatchSet: 2
Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 23 Mar 2022 02:35:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Kangheui Won, Reka Norman, Christian Walter, Eric Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63011 )
Change subject: drivers/i2c/tpm: Add workaround for Ti50
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63011/comment/92fbd172_38b0d01a
PS2, Line 9: Ti50 FW under 0.15 is not support board cfg. And ODM
: stocks are 0.12 pre-flashed. Add workaroud for the old
: Ti50 chip.
72 characters wide
--
To view, visit https://review.coreboot.org/c/coreboot/+/63011
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieec7842ca66b4c690df04a400cebcf45138c745d
Gerrit-Change-Number: 63011
Gerrit-PatchSet: 2
Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 23 Mar 2022 02:33:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Kangheui Won, Reka Norman, Christian Walter, Tim Wawrzynczak.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63011 )
Change subject: drivers/i2c/tpm: Add workaround for Ti50
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/i2c/tpm/cr50.c:
https://review.coreboot.org/c/coreboot/+/63011/comment/27e1a525_72edfe20
PS1, Line 506: if (!CONFIG(MAINBOARD_HAS_I2C_TI50) && tpm_first_access_this_boot()) {
> okay, will change.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/63011
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieec7842ca66b4c690df04a400cebcf45138c745d
Gerrit-Change-Number: 63011
Gerrit-PatchSet: 2
Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Wed, 23 Mar 2022 02:25:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kangheui Won <khwon(a)chromium.org>
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Kangheui Won, Reka Norman, Christian Walter, Tim Wawrzynczak.
Hello build bot (Jenkins), Kangheui Won, Reka Norman, Christian Walter, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63011
to look at the new patch set (#2).
Change subject: drivers/i2c/tpm: Add workaround for Ti50
......................................................................
drivers/i2c/tpm: Add workaround for Ti50
Ti50 FW under 0.15 is not support board cfg. And ODM
stocks are 0.12 pre-flashed. Add workaroud for the old
Ti50 chip.
BUG=b:224650720
TEST=no I2C errors in coreboot.
[ERROR] cr50_i2c_read: Address write failed
[INFO ] .I2C stop bit not received
Signed-off-by: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Change-Id: Ieec7842ca66b4c690df04a400cebcf45138c745d
---
M src/drivers/i2c/tpm/Kconfig
M src/drivers/i2c/tpm/cr50.c
M src/mainboard/google/brya/Kconfig
3 files changed, 11 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/63011/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/63011
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieec7842ca66b4c690df04a400cebcf45138c745d
Gerrit-Change-Number: 63011
Gerrit-PatchSet: 2
Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Frank Wu, Amanda Hwang.
Hello Frank Wu, build bot (Jenkins), Tim Wawrzynczak, Eric Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62998
to look at the new patch set (#2).
Change subject: mb/google/brya/var/brya0: Replace amp max98357 with max98360
......................................................................
mb/google/brya/var/brya0: Replace amp max98357 with max98360
Based on Brya EVT schametic, replace audio amp max98357 with max98360.
Add a new audio FW_CONFIG field to support ALC5682I+MAX98360.
BUG=b:224423056
BRANCH=firmware-brya-14505.B
TEST=dmidecode -t 11
Change-Id: I3033e31cf5c2dade02dc19531f5e5365eeeb7a78
Signed-off-by: Amanda Huang <amanda_hwang(a)compal.corp-partner.google.com>
---
M src/mainboard/google/brya/variants/brya0/fw_config.c
M src/mainboard/google/brya/variants/brya0/overridetree.cb
2 files changed, 22 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/62998/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/62998
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3033e31cf5c2dade02dc19531f5e5365eeeb7a78
Gerrit-Change-Number: 62998
Gerrit-PatchSet: 2
Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Attention: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Attention: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Kangheui Won, Reka Norman, Christian Walter, Tim Wawrzynczak.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63011 )
Change subject: drivers/i2c/tpm: Add workaround for Ti50
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/i2c/tpm/cr50.c:
https://review.coreboot.org/c/coreboot/+/63011/comment/51764bb3_69600c0e
PS1, Line 506: if (!CONFIG(MAINBOARD_HAS_I2C_TI50) && tpm_first_access_this_boot()) {
> I think the Kconfig name is misleading, probably something like MAINBOARD_I2C_TI50_WORKAROUND would […]
okay, will change.
--
To view, visit https://review.coreboot.org/c/coreboot/+/63011
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieec7842ca66b4c690df04a400cebcf45138c745d
Gerrit-Change-Number: 63011
Gerrit-PatchSet: 1
Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Wed, 23 Mar 2022 02:17:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kangheui Won <khwon(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Reka Norman, Christian Walter, Tim Wawrzynczak, Eric Lai.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63011 )
Change subject: drivers/i2c/tpm: Add workaround for Ti50
......................................................................
Patch Set 1:
(1 comment)
File src/drivers/i2c/tpm/cr50.c:
https://review.coreboot.org/c/coreboot/+/63011/comment/3d773069_3d1f1bf5
PS1, Line 506: if (!CONFIG(MAINBOARD_HAS_I2C_TI50) && tpm_first_access_this_boot()) {
I think the Kconfig name is misleading, probably something like MAINBOARD_I2C_TI50_WORKAROUND would be better. Eventually it is supposed to fixed and should be compatible with existing drivers.
--
To view, visit https://review.coreboot.org/c/coreboot/+/63011
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieec7842ca66b4c690df04a400cebcf45138c745d
Gerrit-Change-Number: 63011
Gerrit-PatchSet: 1
Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 23 Mar 2022 02:16:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment