coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: soc/mediatek: Add mtk_early_init for passing data across sessions
by Rex-BC Chen (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Hung-Te Lin, Paul Menzel, Angel Pons, Yu-Ping Wu, Jianjun Wang. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63019 ) Change subject: soc/mediatek: Add mtk_early_init for passing data across sessions ...................................................................... Patch Set 1: (1 comment) File src/soc/mediatek/common/early_init.c: https://review.coreboot.org/c/coreboot/+/63019/comment/8ec52dd0_f834f480 PS1, Line 25: void mtk_pcie_save_timestamp(void) Will it better if we move these pcie function to common/pcie.c? -- To view, visit https://review.coreboot.org/c/coreboot/+/63019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I01f91b7fe2cbe4f73b5c616bb7aae778dee27d9a Gerrit-Change-Number: 63019 Gerrit-PatchSet: 1 Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Thu, 24 Mar 2022 01:46:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/arm: Fix assembling files with clang
by Julius Werner (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Arthur Heymans. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63058 ) Change subject: arch/arm: Fix assembling files with clang ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > > Are we trying to do clang again? I thought we figured out it was a lost cause last time? […] I mean, feel free to try it out and if it happens to work I guess there's no harm in offering the option. I just think I recall there were more issues with clang, maybe things have changed now. We sometimes have to rely on some pretty specific GCC extensions to make things work well the way we need them, and while I think clang is compatible to most of those, if there are cases where it isn't I'd rather stick to being GCC only than have to resort to inferior solutions to allow clang support. -- To view, visit https://review.coreboot.org/c/coreboot/+/63058 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia320dc2c460c99d934b8f17dee7748a9def4e750 Gerrit-Change-Number: 63058 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 24 Mar 2022 01:24:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Arthur Heymans <arthur.heymans(a)9elements.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: security/tpm/crtm.c: Remove set but unused variable
by Julius Werner (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Arthur Heymans, Christian Walter. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63070 ) Change subject: security/tpm/crtm.c: Remove set but unused variable ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63070 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3c97cb57fe13adee217783973691748d6c542abe Gerrit-Change-Number: 63070 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 24 Mar 2022 01:20:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/*: Use __fallthrough statement
by Julius Werner (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Arthur Heymans. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63068 ) Change subject: soc/*: Use __fallthrough statement ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63068 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I78f87d80bd4f366ed6cfa74619dd107ac61bc935 Gerrit-Change-Number: 63068 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 24 Mar 2022 01:19:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: amdfwtool: Add support for AMD's BIOS recovery feature
by Felix Held (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Bao Zheng, Martin Roth, Zheng Bao. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57131 ) Change subject: amdfwtool: Add support for AMD's BIOS recovery feature ...................................................................... Patch Set 49: (3 comments) File util/amdfwtool/amdfwtool.c: https://review.coreboot.org/c/coreboot/+/57131/comment/c1863f1e_b0f974bc PS49, Line 587: uint32_t index; : : index = 0; i'd combine those two lines into uint32_t index = 0; https://review.coreboot.org/c/coreboot/+/57131/comment/d65e3ebc_c87e7515 PS49, Line 592: break; you could do a return index instead of the break here and replace the if/else construct in lines 596-599 with a return -1, since there's no other code after that https://review.coreboot.org/c/coreboot/+/57131/comment/cca35563_b080736a PS49, Line 1899: 0x20000 should this be TABLE_ALIGNMENT? -- To view, visit https://review.coreboot.org/c/coreboot/+/57131 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2671b95fe089aafdaf61b55bc9d2e8dcf6a66dbc Gerrit-Change-Number: 57131 Gerrit-PatchSet: 49 Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Reviewer: Zheng Bao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Bao Zheng <zheng.bao(a)amd.corp-partner.google.com> Gerrit-CC: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Bao Zheng <fishbaozi(a)gmail.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Zheng Bao Gerrit-Comment-Date: Thu, 24 Mar 2022 01:00:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/i2c/tpm: Work around missing board_cfg in Ti50 FW under 0.15
by Eric Lai (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Reka Norman, Paul Menzel, Tim Wawrzynczak, Christian Walter. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63011 ) Change subject: drivers/i2c/tpm: Work around missing board_cfg in Ti50 FW under 0.15 ...................................................................... Patch Set 7: (3 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63011/comment/0ea61c87_848da272 PS4, Line 7: drivers/i2c/tpm: Add workaround for Ti50 > I agree that Paul's suggestion would be clearer. Maybe: […] Done Patchset: PS7: Thank you, Reka. File src/drivers/i2c/tpm/Kconfig: https://review.coreboot.org/c/coreboot/+/63011/comment/b675748e_ad57736d PS4, Line 31: Board has a Ti50 I2C workaround which Ti50 FW under 0.15 > I agree we could add some more details here. Maybe something like: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/63011 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieec7842ca66b4c690df04a400cebcf45138c745d Gerrit-Change-Number: 63011 Gerrit-PatchSet: 7 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Comment-Date: Thu, 24 Mar 2022 00:57:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Reka Norman <rekanorman(a)chromium.org> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/sifive/ux00ddr.h: Remove set but unused variables
by build bot (Jenkins) (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Philipp Hug, Arthur Heymans, ron minnich. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63074 ) Change subject: soc/sifive/ux00ddr.h: Remove set but unused variables ...................................................................... Patch Set 1: (4 comments) File src/soc/sifive/fu540/ux00ddr.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144623): https://review.coreboot.org/c/coreboot/+/63074/comment/f8eb3e01_3904907c PS1, Line 179: /* char slicelsc = '0'; */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144623): https://review.coreboot.org/c/coreboot/+/63074/comment/5ed3b7b3_7e355218 PS1, Line 180: /* char slicemsc = '0'; */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144623): https://review.coreboot.org/c/coreboot/+/63074/comment/fff0c38d_35e7b1a4 PS1, Line 181: /* slicelsc += (dq % 10); */ code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-144623): https://review.coreboot.org/c/coreboot/+/63074/comment/40342864_4cbb8729 PS1, Line 182: /* slicemsc += (dq / 10); */ code indent should use tabs where possible -- To view, visit https://review.coreboot.org/c/coreboot/+/63074 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I442a42e297f2968dd2c824a93a9a1e2bc74ea2f4 Gerrit-Change-Number: 63074 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-Comment-Date: Thu, 24 Mar 2022 00:54:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/i2c/tpm: Add workaround for Ti50 with FW under 0.15
by Reka Norman (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Christian Walter, Eric Lai. Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63011 ) Change subject: drivers/i2c/tpm: Add workaround for Ti50 with FW under 0.15 ...................................................................... Patch Set 6: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/63011/comment/8ddb54b8_247e848f PS4, Line 7: drivers/i2c/tpm: Add workaround for Ti50 > Done I agree that Paul's suggestion would be clearer. Maybe: ``` Work around missing board_cfg in Ti50 FW under 0.15 ``` File src/drivers/i2c/tpm/Kconfig: https://review.coreboot.org/c/coreboot/+/63011/comment/539a3775_fbd96e93 PS4, Line 31: Board has a Ti50 I2C workaround which Ti50 FW under 0.15 > Done I agree we could add some more details here. Maybe something like: ``` Ti50 FW versions below 0.15 don't support the firmware_version or board_cfg registers, and trying to access them causes I2C errors. This config will skip accesses to these registers, and should be selected for boards using Ti50 chips with FW < 0.15. The config will be removed once all Ti50 stocks are updated to 0.15 or higher. ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/63011 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieec7842ca66b4c690df04a400cebcf45138c745d Gerrit-Change-Number: 63011 Gerrit-PatchSet: 6 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 24 Mar 2022 00:53:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/arm: Fix assembling files with clang
by Arthur Heymans (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Julius Werner, Arthur Heymans. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63058 ) Change subject: arch/arm: Fix assembling files with clang ...................................................................... Patch Set 1: (2 comments) Patchset: PS1: > Are we trying to do clang again? I thought we figured out it was a lost cause last time? Not sure who tried last time, but in the mean time things improved. I think the Linux kernel can properly build on some arch with clang now although arm might be an exception. With coreboot it seems to work well for x86. On other arch the compiler is confused because the flags don't align as well with gcc. Maybe for arm the sane thing to do is to depend on CONFIG_COMPILER_GCC and drop this? File src/arch/arm/libgcc/lib1funcs.S: https://review.coreboot.org/c/coreboot/+/63058/comment/c5f2da88_4ae818e5 PS1, Line 70: movne \curbit, \curbit, lsr #4 @ No, any more bits to do? > Are you trying to copy what 'ARM: 8844/1: use unified assembler in assembly files' did in Linux? That just replaced the MOVNES with MOVSNE, which is just a different syntax for the same instruction. But you're actually removing the S bit and turning this into a different instruction here, which would break the code. Sorry I was not very careful with this CL. I should have marked it WIP and check that it's binary identical. -- To view, visit https://review.coreboot.org/c/coreboot/+/63058 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia320dc2c460c99d934b8f17dee7748a9def4e750 Gerrit-Change-Number: 63058 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 24 Mar 2022 00:32:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/sifive/ux00ddr.h: Remove set but unused variables
by Arthur Heymans (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Philipp Hug, Arthur Heymans, ron minnich. Hello Arthur Heymans, I'd like you to do a code review. Please visit https://review.coreboot.org/c/coreboot/+/63074 to review the following change. Change subject: soc/sifive/ux00ddr.h: Remove set but unused variables ...................................................................... soc/sifive/ux00ddr.h: Remove set but unused variables It looks like this code was not finished so it's left commented out for now. Change-Id: I442a42e297f2968dd2c824a93a9a1e2bc74ea2f4 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/sifive/fu540/ux00ddr.h 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/74/63074/1 diff --git a/src/soc/sifive/fu540/ux00ddr.h b/src/soc/sifive/fu540/ux00ddr.h index cc67508..bf856f3 100644 --- a/src/soc/sifive/fu540/ux00ddr.h +++ b/src/soc/sifive/fu540/ux00ddr.h @@ -176,10 +176,10 @@ if (failc0 || failc1) { //if (fails==0) uart_puts((void*) UART0_CTRL_ADDR, "DDR error in fixing up \n"); fails |= (1<<dq); - char slicelsc = '0'; - char slicemsc = '0'; - slicelsc += (dq % 10); - slicemsc += (dq / 10); + /* char slicelsc = '0'; */ + /* char slicemsc = '0'; */ + /* slicelsc += (dq % 10); */ + /* slicemsc += (dq / 10); */ //uart_puts((void*) UART0_CTRL_ADDR, "S "); //uart_puts((void*) UART0_CTRL_ADDR, &slicemsc); //uart_puts((void*) UART0_CTRL_ADDR, &slicelsc); -- To view, visit https://review.coreboot.org/c/coreboot/+/63074 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I442a42e297f2968dd2c824a93a9a1e2bc74ea2f4 Gerrit-Change-Number: 63074 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx> Gerrit-Reviewer: ron minnich <rminnich(a)gmail.com> Gerrit-Attention: Philipp Hug <philipp(a)hug.cx> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: ron minnich <rminnich(a)gmail.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022