coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: soc/mediatek: Add mtk_early_init for passing data across sessions
by Yu-Ping Wu (Code Review) 23 Mar '22

23 Mar '22

1 0

Change in coreboot[master]: soc/mediatek/mt8195: Add early init support
by Hung-Te Lin (Code Review) 23 Mar '22

23 Mar '22

Attention is currently required from: Paul Menzel, Rex-BC Chen, Angel Pons, Yu-Ping Wu, Jianjun Wang. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63020 ) Change subject: soc/mediatek/mt8195: Add early init support ...................................................................... Patch Set 1: (2 comments) File src/mainboard/google/cherry/bootblock.c: https://review.coreboot.org/c/coreboot/+/63020/comment/32cfcdc1_ceba0e85 PS1, Line 49: mtk_clear_early_init(); > Can we do this in bootblock_soc_init()? agree, if bootblock_soc_init runs earlier than bootblock_mainboard_init then we should do it there https://review.coreboot.org/c/coreboot/+/63020/comment/2c1a76a5_ff118c52 PS1, Line 51: if (CONFIG(PCI)) : mtk_pcie_pre_init(); shouldn't we do this only if MEDIATEK_EARLY_INIT is set? -- To view, visit https://review.coreboot.org/c/coreboot/+/63020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4eb7da53ff76c385cab18bbf84970e96b61662ac Gerrit-Change-Number: 63020 Gerrit-PatchSet: 1 Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Thu, 24 Mar 2022 02:46:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8195: Add early init support
by Yu-Ping Wu (Code Review) 23 Mar '22

23 Mar '22

Attention is currently required from: Hung-Te Lin, Paul Menzel, Rex-BC Chen, Angel Pons, Jianjun Wang. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63020 ) Change subject: soc/mediatek/mt8195: Add early init support ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/cherry/bootblock.c: https://review.coreboot.org/c/coreboot/+/63020/comment/7e9808ad_4adbb537 PS1, Line 49: mtk_clear_early_init(); Can we do this in bootblock_soc_init()? -- To view, visit https://review.coreboot.org/c/coreboot/+/63020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4eb7da53ff76c385cab18bbf84970e96b61662ac Gerrit-Change-Number: 63020 Gerrit-PatchSet: 1 Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Thu, 24 Mar 2022 02:45:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek: Add mtk_early_init for passing data across sessions
by Yu-Ping Wu (Code Review) 23 Mar '22

23 Mar '22

1 0

Change in coreboot[master]: soc/mediatek: Add mtk_early_init for passing data across sessions
by Yu-Ping Wu (Code Review) 23 Mar '22

23 Mar '22

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Paul Menzel, Angel Pons, Jianjun Wang. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63019 ) Change subject: soc/mediatek: Add mtk_early_init for passing data across sessions ...................................................................... Patch Set 1: (7 comments) File src/soc/mediatek/common/early_init.c: https://review.coreboot.org/c/coreboot/+/63019/comment/1cfa4734_c08cd354 PS1, Line 11: assert This could be _Static_assert. https://review.coreboot.org/c/coreboot/+/63019/comment/eb4f9865_fc95c221 PS1, Line 25: void mtk_pcie_save_timestamp(void) > Will it better if we move these pcie function to common/pcie. […] Absolutely. This function doesn't belong here. https://review.coreboot.org/c/coreboot/+/63019/comment/c5bce85c_9b12ef98 PS1, Line 27: timestamp cur_time https://review.coreboot.org/c/coreboot/+/63019/comment/98652661_b3ef3493 PS1, Line 35: microseconds We shouldn't access the field directly (see the comment in include/timer.h). The whole mono_time struct should be stored in the mtk_early_init region, and the elapsed time should be obtained by mono_time_diff_microseconds(). File src/soc/mediatek/common/include/soc/early_init.h: https://review.coreboot.org/c/coreboot/+/63019/comment/6f56041a_4d89fba9 PS1, Line 10: mtk_early_init I'd prefer "early_init_data". https://review.coreboot.org/c/coreboot/+/63019/comment/0360c98e_e5427606 PS1, Line 10: mtk_early_init I'd prefer "early_init_data". https://review.coreboot.org/c/coreboot/+/63019/comment/fe7c1642_e004bab4 PS1, Line 17: mtk_pcie_save_timestamp > What about […] This also works. Then we can keep these functions in this file. -- To view, visit https://review.coreboot.org/c/coreboot/+/63019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I01f91b7fe2cbe4f73b5c616bb7aae778dee27d9a Gerrit-Change-Number: 63019 Gerrit-PatchSet: 1 Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Thu, 24 Mar 2022 02:42:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/smmstore: Move SMMSTORE block size to Kconfig
by Matt DeVillier (Code Review) 23 Mar '22

23 Mar '22

Attention is currently required from: Sean Rhodes, Patrick Rudolph, Arthur Heymans. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62990 ) Change subject: drivers/smmstore: Move SMMSTORE block size to Kconfig ...................................................................... Patch Set 2: (4 comments) File src/drivers/smmstore/Kconfig: https://review.coreboot.org/c/coreboot/+/62990/comment/b4a96eb5_eb9b1a3d PS2, Line 35: "SMMSTORE Block size" do we want this user overrideable? https://review.coreboot.org/c/coreboot/+/62990/comment/7e7d7442_bb77e2fe PS2, Line 41: that use : 8MiB SPI's maybe 'have 8MiB ROM' or 'have 8MiB flash' ? https://review.coreboot.org/c/coreboot/+/62990/comment/9bc9e4df_a77afe3b PS2, Line 42: it's not possible to align SMMSTORE to 64KiB due to xyz? File src/include/smmstore.h: https://review.coreboot.org/c/coreboot/+/62990/comment/0c967e99_bcecfafe PS2, Line 39: The Version 2 protocol separates the SMMSTORE into 64KiB blocks, each : * of which can be read/written/cleared in an independent manner. The : * data format isn't specified. See documentation page for more details. probably need to adjust this comment and the documentation as well -- To view, visit https://review.coreboot.org/c/coreboot/+/62990 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieeed9f5895b8ddde753ebf596b803e8f440d5b74 Gerrit-Change-Number: 62990 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 24 Mar 2022 02:42:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/i2c.c: Remove unused variables
by Hung-Te Lin (Code Review) 23 Mar '22

23 Mar '22

Attention is currently required from: Arthur Heymans. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63023 ) Change subject: soc/mediatek/i2c.c: Remove unused variables ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa643feb76530cc74acf4d714d8a7f96709be1cf Gerrit-Change-Number: 63023 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 24 Mar 2022 02:38:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/i2c.c: Remove unused variables
by Rex-BC Chen (Code Review) 23 Mar '22

23 Mar '22

Attention is currently required from: Arthur Heymans. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63023 ) Change subject: soc/mediatek/i2c.c: Remove unused variables ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/63023 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaa643feb76530cc74acf4d714d8a7f96709be1cf Gerrit-Change-Number: 63023 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Thu, 24 Mar 2022 02:37:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek: Add timestamp to measure PERST# time
by Hung-Te Lin (Code Review) 23 Mar '22

23 Mar '22

Attention is currently required from: Rex-BC Chen, Paul Menzel, Angel Pons, Yu-Ping Wu, Jianjun Wang. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62933 ) Change subject: soc/mediatek: Add timestamp to measure PERST# time ...................................................................... Patch Set 3: (1 comment) File src/soc/mediatek/common/pcie.c: https://review.coreboot.org/c/coreboot/+/62933/comment/1ece871d_777f76ea PS3, Line 238: perst_time_us = mtk_pcie_perst_elapsed_time(); : printk(BIOS_DEBUG, "%s: %lld us elapsed since assert PERST#\n", : __func__, perst_time_us); : : /* : * Described in PCIe CEM specification sections 2.2 : * (PERST# Signal) and 2.2.1 (Initial Power-Up (G3 to S0)). : * The deassertion of PERST# should be delayed 100ms (TPVPERL) : * for the power and clock to become stable. : */ : if (perst_time_us < 100000) : printk(BIOS_WARNING, "%s: PERST# assert time %lld us may not enough for link up\n", : __func__, perst_time_us); : I think we should do it like: perst_time_us = mtk_pcie_perst_elapsed_time(); if (!perst_time_us) { /* enable the prest */ } if (perst_time_us > 100000) perst_time_us = 100000; sleep(100000 - perst_time_us); So the PCIE link would work no matter if people did early init or not. -- To view, visit https://review.coreboot.org/c/coreboot/+/62933 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie2b7b6174abdf951af5796ab5ed141c45f32fc71 Gerrit-Change-Number: 62933 Gerrit-PatchSet: 3 Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Thu, 24 Mar 2022 02:28:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek: Add mtk_early_init for passing data across sessions
by Hung-Te Lin (Code Review) 23 Mar '22

23 Mar '22

Attention is currently required from: Paul Menzel, Angel Pons, Yu-Ping Wu, Jianjun Wang. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63019 ) Change subject: soc/mediatek: Add mtk_early_init for passing data across sessions ...................................................................... Patch Set 1: (1 comment) File src/soc/mediatek/common/Kconfig: https://review.coreboot.org/c/coreboot/+/63019/comment/f441d4a4_03b4f32c PS1, Line 53: config MEDIATEK_EARLY_INIT : bool : help : This option allows passing data across sessions. I think we don't need to make this a config, because in memlayout.ld you always have to reserve the section, and it's not super large. -- To view, visit https://review.coreboot.org/c/coreboot/+/63019 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I01f91b7fe2cbe4f73b5c616bb7aae778dee27d9a Gerrit-Change-Number: 63019 Gerrit-PatchSet: 1 Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Thu, 24 Mar 2022 02:24:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022