coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: soc/amd/sabrina/cpu.c: Skip SMMINFO init in S3 resume
by Raul Rangel (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Jason Glenesk, Marshall Dawson, Fred Reitberger, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63088 ) Change subject: soc/amd/sabrina/cpu.c: Skip SMMINFO init in S3 resume ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63088 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I58e25075a007505e53962525ec4d9acd2ce6c7ae Gerrit-Change-Number: 63088 Gerrit-PatchSet: 1 Gerrit-Owner: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 24 Mar 2022 14:49:13 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/dmi.c: Fix implicit enum typing
by Raul Rangel (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Arthur Heymans, Jason Glenesk, Marshall Dawson, Fred Reitberger, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63051 ) Change subject: soc/amd/dmi.c: Fix implicit enum typing ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I20aba3bd3af8a7292e04d2496c3cba1ab6ba3019 Gerrit-Change-Number: 63051 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 24 Mar 2022 14:47:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/pi/amd_late_init.c: Fix implicit enum conversion
by Raul Rangel (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Arthur Heymans, Jason Glenesk, Marshall Dawson, Fred Reitberger, Felix Held. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63053 ) Change subject: soc/amd/pi/amd_late_init.c: Fix implicit enum conversion ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63053 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifda9be8996703b06fe9ee30ffb5f56a91629e065 Gerrit-Change-Number: 63053 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 24 Mar 2022 14:47:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Adjust FMD file to chromeos.fmd for kano
by David Wu (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Grace Kao, Tracy Wu, Ren Kuo. David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63086 ) Change subject: mb/google/brya: Adjust FMD file to chromeos.fmd for kano ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63086/comment/ead95ac1_6e7484d4 PS1, Line 9: This patch adjusts FMD file to chromeos.fmd for kano > Suggestion: […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/63086 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09833039a450fa014e8e501bde9fec6e7ed59c7a Gerrit-Change-Number: 63086 Gerrit-PatchSet: 2 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Grace Kao <grace.kao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tracy Wu <tracy.wu(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Grace Kao <grace.kao(a)intel.corp-partner.google.com> Gerrit-Attention: Tracy Wu <tracy.wu(a)intel.corp-partner.google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 24 Mar 2022 14:21:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Adjust FMD file to chromeos.fmd for kano
by David Wu (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Grace Kao, David Wu, Tracy Wu, Ren Kuo. Hello build bot (Jenkins), Grace Kao, Tracy Wu, Tim Wawrzynczak, Ren Kuo, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63086 to look at the new patch set (#2). Change subject: mb/google/brya: Adjust FMD file to chromeos.fmd for kano ...................................................................... mb/google/brya: Adjust FMD file to chromeos.fmd for kano The separate FMD file for Kano is no longer required, as it was only required for early prototype testers, and those devices will be retired soon, therefore switch back to the original FMD file. BUG=b:226018550 TEST=Build pass. Signed-off-by: David Wu <david_wu(a)quanta.corp-partner.google.com> Change-Id: I09833039a450fa014e8e501bde9fec6e7ed59c7a --- M src/mainboard/google/brya/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/63086/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63086 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09833039a450fa014e8e501bde9fec6e7ed59c7a Gerrit-Change-Number: 63086 Gerrit-PatchSet: 2 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Grace Kao <grace.kao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tracy Wu <tracy.wu(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Grace Kao <grace.kao(a)intel.corp-partner.google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tracy Wu <tracy.wu(a)intel.corp-partner.google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya: Adjust FMD file to chromeos.fmd for kano
by Tim Wawrzynczak (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Grace Kao, David Wu, Tracy Wu, Ren Kuo. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63086 ) Change subject: mb/google/brya: Adjust FMD file to chromeos.fmd for kano ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/63086/comment/b35a82fa_99ccea26 PS1, Line 9: This patch adjusts FMD file to chromeos.fmd for kano Suggestion: ``` The separate FMD file for Kano is no longer required, as it was only required for early prototype testers, and those devices will be retired soon, therefore switch back to the original FMD file. ``` -- To view, visit https://review.coreboot.org/c/coreboot/+/63086 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09833039a450fa014e8e501bde9fec6e7ed59c7a Gerrit-Change-Number: 63086 Gerrit-PatchSet: 1 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Grace Kao <grace.kao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tracy Wu <tracy.wu(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Grace Kao <grace.kao(a)intel.corp-partner.google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tracy Wu <tracy.wu(a)intel.corp-partner.google.com> Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 24 Mar 2022 13:56:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8186: add pmif driver setting
by Rex-BC Chen (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Hung-Te Lin. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63089 ) Change subject: soc/mediatek/mt8186: add pmif driver setting ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: wait for verify. -- To view, visit https://review.coreboot.org/c/coreboot/+/63089 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d02198f19f9cb052fba612c02404a6af1a10adb Gerrit-Change-Number: 63089 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Comment-Date: Thu, 24 Mar 2022 13:05:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8186: add pmif driver setting
by Rex-BC Chen (Code Review) 24 Mar '22

24 Mar '22

Rex-BC Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63089 ) Change subject: soc/mediatek/mt8186: add pmif driver setting ...................................................................... soc/mediatek/mt8186: add pmif driver setting Add pmif low power setting for MT8186. BUG=b:215639203 TEST=build pass Signed-off-by: Zhiyong Tao <zhiyong.tao(a)mediatek.com> Change-Id: I2d02198f19f9cb052fba612c02404a6af1a10adb --- M src/soc/mediatek/mt8186/Makefile.inc M src/soc/mediatek/mt8186/include/soc/addressmap.h A src/soc/mediatek/mt8186/include/soc/pmif.h M src/soc/mediatek/mt8186/mt6366.c A src/soc/mediatek/mt8186/pmif.c 5 files changed, 42 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/63089/1 diff --git a/src/soc/mediatek/mt8186/Makefile.inc b/src/soc/mediatek/mt8186/Makefile.inc index 0d56f15..5d327e0 100644 --- a/src/soc/mediatek/mt8186/Makefile.inc +++ b/src/soc/mediatek/mt8186/Makefile.inc @@ -40,7 +40,7 @@ romstage-y += ../common/timer.c timer.c romstage-y += ../common/uart.c romstage-y += ../common/wdt.c wdt.c -romstage-y += ../common/pmic_wrap.c pmic_wrap.c mt6366.c +romstage-y += ../common/pmic_wrap.c pmic_wrap.c pmif.c mt6366.c romstage-y += ../common/rtc.c ../common/rtc_osc_init.c rtc.c ramstage-y += ../common/auxadc.c @@ -64,7 +64,7 @@ ramstage-y += ../common/uart.c ramstage-y += ../common/usb.c usb.c ramstage-y += ../common/wdt.c wdt.c -ramstage-y += ../common/pmic_wrap.c pmic_wrap.c mt6366.c +ramstage-y += ../common/pmic_wrap.c pmic_wrap.c pmif.c mt6366.c ramstage-y += ../common/rtc.c ../common/rtc_osc_init.c rtc.c BL31_MAKEARGS += PLAT=mt8186 diff --git a/src/soc/mediatek/mt8186/include/soc/addressmap.h b/src/soc/mediatek/mt8186/include/soc/addressmap.h index c90e0cd..069e31d 100644 --- a/src/soc/mediatek/mt8186/include/soc/addressmap.h +++ b/src/soc/mediatek/mt8186/include/soc/addressmap.h @@ -30,6 +30,7 @@ PWRAP_BASE = IO_PHYS + 0x0000D000, DEVAPC_AO_INFRA_PERI_BASE = IO_PHYS + 0x0000E000, DEVAPC_AO_MM_BASE = IO_PHYS + 0x0000F000, + PMIF_BASE = IO_PHYS + 0x00015000, SYSTIMER_BASE = IO_PHYS + 0x00017000, I2C0_DMA_BASE = IO_PHYS + 0x00200100, I2C1_DMA_BASE = IO_PHYS + 0x00200200, diff --git a/src/soc/mediatek/mt8186/include/soc/pmif.h b/src/soc/mediatek/mt8186/include/soc/pmif.h new file mode 100644 index 0000000..5b85325 --- /dev/null +++ b/src/soc/mediatek/mt8186/include/soc/pmif.h @@ -0,0 +1,16 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +/* + * This file is created based on MT8186 Functional Specification + * Chapter number: 3.7 + */ + +#ifndef __SOC_MEDIATEK_PMIF_H__ +#define __SOC_MEDIATEK_PMIF_H__ + +#include <soc/addressmap.h> +#include <types.h> + +void pmif_spmi_set_lp_mode(void); + +#endif /*__SOC_MEDIATEK_PMIF_H__*/ diff --git a/src/soc/mediatek/mt8186/mt6366.c b/src/soc/mediatek/mt8186/mt6366.c index 30ae5e0..8dd2997 100644 --- a/src/soc/mediatek/mt8186/mt6366.c +++ b/src/soc/mediatek/mt8186/mt6366.c @@ -10,6 +10,7 @@ #include <delay.h> #include <soc/mt6366.h> #include <soc/pmic_wrap.h> +#include <soc/pmif.h> #include <soc/regulator.h> #include <timer.h> @@ -953,6 +954,7 @@ wk_sleep_voltage_by_ddr(); wk_power_down_seq(); mt6366_lp_setting(); + pmif_spmi_set_lp_mode(); while (!stopwatch_expired(&voltage_settled)) /* wait for voltages to settle */; diff --git a/src/soc/mediatek/mt8186/pmif.c b/src/soc/mediatek/mt8186/pmif.c new file mode 100644 index 0000000..b909609 --- /dev/null +++ b/src/soc/mediatek/mt8186/pmif.c @@ -0,0 +1,21 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +/* + * This file is created based on MT8186 Functional Specification + * Chapter number: 3.7 + */ + +#include <device/mmio.h> +#include <soc/pmif.h> + +#define SLEEP_PROT_CTRL 0x3F0 + +DEFINE_BITFIELD(SPM_SLEEP_REQ_SEL, 1, 0) +DEFINE_BITFIELD(SCP_SLEEP_REQ_SEL, 10, 9) + +void pmif_spmi_set_lp_mode(void) +{ + SET32_BITFIELDS((void *)(PMIF_BASE + SLEEP_PROT_CTRL), + SPM_SLEEP_REQ_SEL, 0, + SCP_SLEEP_REQ_SEL, 0); +} -- To view, visit https://review.coreboot.org/c/coreboot/+/63089 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d02198f19f9cb052fba612c02404a6af1a10adb Gerrit-Change-Number: 63089 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: libpayload: Add support for PCI MMIO CONFIG access.
by Ravi Kumar Bokka (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Shelley Chen, Furquan Shaikh, Arthur Heymans, Prasad Malisetty. Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57615 ) Change subject: libpayload: Add support for PCI MMIO CONFIG access. ...................................................................... Patch Set 40: (8 comments) File payloads/libpayload/drivers/pci_io_ops.c: https://review.coreboot.org/c/coreboot/+/57615/comment/e0bfcc30_bc22ef85 PS29, Line 70: pcidev_t *dev) > This is still not fixed. Done File payloads/libpayload/drivers/pci_mmio_ops.c: https://review.coreboot.org/c/coreboot/+/57615/comment/202835b7_facf0a37 PS29, Line 2: Copyright > nit: missing space before Copyright Done https://review.coreboot.org/c/coreboot/+/57615/comment/dec22c57_f67a2bdd PS29, Line 4: Redistribution > nit: missing space before Redistribution. Done https://review.coreboot.org/c/coreboot/+/57615/comment/c43eca8b_b00ecfb4 PS29, Line 26: / > nit: missing space at the beginning of this line. Done https://review.coreboot.org/c/coreboot/+/57615/comment/e6a6effc_067b4e79 PS29, Line 74: pcidev_t *dev) > still an issue. Done File payloads/libpayload/drivers/qc_pci_mmio_ops.c: https://review.coreboot.org/c/coreboot/+/57615/comment/ec8f839e_9deecbb2 PS37, Line 107: cfg_address = (void*) pci_mmio_info->config_base; > > "(void*)" should be "(void *)" […] Done File payloads/libpayload/include/qc_pci.h: https://review.coreboot.org/c/coreboot/+/57615/comment/b9d36c75_e89e57cb PS37, Line 70: #endif > > trailing whitespace […] Done File payloads/libpayload/include/qc_pci.h: https://review.coreboot.org/c/coreboot/+/57615/comment/ed41be0e_81356d83 PS29, Line 70: #endif > > trailing whitespace […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/57615 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7d1217502cbd7d4d0cdd298919ae82435630d61c Gerrit-Change-Number: 57615 Gerrit-PatchSet: 40 Gerrit-Owner: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Prasad Malisetty <pmaliset(a)qualcomm.corp-partner.google.com> Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com> Gerrit-CC: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan.m.shaikh(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Prasad Malisetty <pmaliset(a)qualcomm.corp-partner.google.com> Gerrit-Comment-Date: Thu, 24 Mar 2022 12:57:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Shelley Chen <shchen(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/qualcomm/common: verify size of memchipinfo structure
by Ravi Kumar Bokka (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Julius Werner. Ravi Kumar Bokka has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63026 ) Change subject: soc/qualcomm/common: verify size of memchipinfo structure ...................................................................... Patch Set 2: (7 comments) File src/commonlib/bsd/include/commonlib/bsd/mem_chip_info.h: https://review.coreboot.org/c/coreboot/+/63026/comment/28bc89a0_bacdd618 PS1, Line 5: > This needs to #include <stddef.h> for size_t now. Done https://review.coreboot.org/c/coreboot/+/63026/comment/a521263c_acdf73ad PS1, Line 28: static inline size_t mem_chip_info_size(struct mem_chip_info *info) { > > open brace '{' following function definitions go on the next line […] Done https://review.coreboot.org/c/coreboot/+/63026/comment/32a2e73c_c69afd9e PS1, Line 29: return sizeof(*info) + sizeof(info->channel[0]) * info->num_channels; > > please, no spaces at the start of a line […] Done File src/soc/qualcomm/common/qclib.c: https://review.coreboot.org/c/coreboot/+/63026/comment/4ed6119f_c1a230d8 PS1, Line 31: mem_chip_info_size(&memchip) > No you're supposed to check the mem_chip_info at te->blob_address, not some random mem_chip_info you […] Done https://review.coreboot.org/c/coreboot/+/63026/comment/b7b963a3_d170c361 PS1, Line 51: sizeof(struct mem_chip_info) > mem_chip_info_size(mem_chip_addr) Done https://review.coreboot.org/c/coreboot/+/63026/comment/42899f55_f88643f4 PS1, Line 55: memchip > Again this is supposed to be mem_chip_addr here. Done https://review.coreboot.org/c/coreboot/+/63026/comment/6d53fffe_0027fc6f PS1, Line 186: mem_chip_addr, sizeof(mem_chip_addr), 0); > I left more comments in the other CL, please address all of them (and mark them Done in that CL so w […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/63026 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d59669adaf287d0eb7b58ccb0fe3f98e3d23281 Gerrit-Change-Number: 63026 Gerrit-PatchSet: 2 Gerrit-Owner: Ravi Kumar Bokka <rbokka(a)codeaurora.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Thu, 24 Mar 2022 12:56:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022