coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in coreboot[master]: mb/google/brya: change loglevel prefix
by Eric Lai (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: John Su, Tim Wawrzynczak. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63099 ) Change subject: mb/google/brya: change loglevel prefix ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I suspect it from CBI access https://source.chromium.org/chromiumos/chromiumos/codesearch/+/main:src/pla… -- To view, visit https://review.coreboot.org/c/coreboot/+/63099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I83d3eec6dba7b8cd006b58b93a7c53842ad6ce0a Gerrit-Change-Number: 63099 Gerrit-PatchSet: 1 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Fri, 25 Mar 2022 02:58:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: change loglevel prefix
by Eric Lai (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: John Su, Tim Wawrzynczak. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63099 ) Change subject: mb/google/brya: change loglevel prefix ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: We can see EC return -3 from time to time. Check EC code is EC_RES_INVALID_PARAM. We should find which command is wrong. -- To view, visit https://review.coreboot.org/c/coreboot/+/63099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I83d3eec6dba7b8cd006b58b93a7c53842ad6ce0a Gerrit-Change-Number: 63099 Gerrit-PatchSet: 1 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Attention: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Fri, 25 Mar 2022 02:56:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Set pciexp_hotplug_dummy_ops.set_resources as no-op
by John Su (Code Review) 24 Mar '22

24 Mar '22

John Su has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63101 ) Change subject: mb/google/brya: Set pciexp_hotplug_dummy_ops.set_resources as no-op ...................................................................... mb/google/brya: Set pciexp_hotplug_dummy_ops.set_resources as no-op Without setting the set_resources field for pciexp_hotplug_dummy_ops, we will get an error during pciexp_hotplug_dummy. [ERROR] NONE missing set_resources Because the set_resources field is considered mandatory, explicitly set it as no-op noop_set_resources. BUG=b:220639445 TEST=emerge-brya coreboot Signed-off-by: John Su <john_su(a)compal.corp-partner.google.com> Change-Id: Ifee7479c69cf16025dbd4e3924056ed7f8e253cf --- M src/device/pciexp_device.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/63101/1 diff --git a/src/device/pciexp_device.c b/src/device/pciexp_device.c index c525301..3614340 100644 --- a/src/device/pciexp_device.c +++ b/src/device/pciexp_device.c @@ -585,6 +585,7 @@ static struct device_operations pciexp_hotplug_dummy_ops = { .read_resources = pciexp_hotplug_dummy_read_resources, + .set_resources = noop_set_resources, }; void pciexp_hotplug_scan_bridge(struct device *dev) -- To view, visit https://review.coreboot.org/c/coreboot/+/63101 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifee7479c69cf16025dbd4e3924056ed7f8e253cf Gerrit-Change-Number: 63101 Gerrit-PatchSet: 1 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/mediatek/mt8195: Add PCIe pre_init support in bootblock stage
by Jianjun Wang (Code Review) 24 Mar '22

24 Mar '22

Jianjun Wang has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/63018 ) Change subject: soc/mediatek/mt8195: Add PCIe pre_init support in bootblock stage ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/63018 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic27f3ed7f1a6e3ff623d8754061547b55cd75d19 Gerrit-Change-Number: 63018 Gerrit-PatchSet: 1 Gerrit-Owner: Jianjun Wang <jianjun.wang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: mb/google/cherry: Add MAX98390 support for DOJO
by Trevor Wu (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu. Trevor Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63083 ) Change subject: mb/google/cherry: Add MAX98390 support for DOJO ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/cherry/Kconfig: https://review.coreboot.org/c/coreboot/+/63083/comment/73bc3a19_c3af738d PS2, Line 66: BOARD_GOOGLE_CHERRY || BOARD_GOOGLE_TOMATO > what about […] This way was discussed in RT1011 upstream. More codec support in cherry is highly possible. As discussed offline, we keep the expression here, because it is clear and easy for more codec support. -- To view, visit https://review.coreboot.org/c/coreboot/+/63083 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9b6bc5a5520292dd502b0389217f5062479b4490 Gerrit-Change-Number: 63083 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Trevor Wu <trevor.wu(a)mediatek.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 25 Mar 2022 02:31:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: change loglevel prefix
by John Su (Code Review) 24 Mar '22

24 Mar '22

John Su has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63099 ) Change subject: mb/google/brya: change loglevel prefix ...................................................................... mb/google/brya: change loglevel prefix Change EC check result loglevel from "BIOS_ERR" to "BIOS_WARNING" Because this message is not really an error message. BUG=b:220639445 TEST=emerge-brya coreboot Signed-off-by: John Su <john_su(a)compal.corp-partner.google.com> Change-Id: I83d3eec6dba7b8cd006b58b93a7c53842ad6ce0a --- M src/ec/google/chromeec/ec_lpc.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/63099/1 diff --git a/src/ec/google/chromeec/ec_lpc.c b/src/ec/google/chromeec/ec_lpc.c index a82ea5d..8640b3e 100644 --- a/src/ec/google/chromeec/ec_lpc.c +++ b/src/ec/google/chromeec/ec_lpc.c @@ -239,7 +239,7 @@ /* Check result */ cec_command->cmd_code = read_byte(EC_LPC_ADDR_HOST_DATA); if (cec_command->cmd_code) { - printk(BIOS_ERR, "EC returned error result code %d\n", + printk(BIOS_WARNING, "EC returned error result code %d\n", cec_command->cmd_code); return -i; } -- To view, visit https://review.coreboot.org/c/coreboot/+/63099 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I83d3eec6dba7b8cd006b58b93a7c53842ad6ce0a Gerrit-Change-Number: 63099 Gerrit-PatchSet: 1 Gerrit-Owner: John Su <john_su(a)compal.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/mediatek: Include 'console/console.h' when appropriate
by Hung-Te Lin (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Xi Chen, Elyes Haouas. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61043 ) Change subject: soc/mediatek: Include 'console/console.h' when appropriate ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/61043 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I93f930de5a2a477ec4c0d8e5c8c57b25f5e4252c Gerrit-Change-Number: 61043 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Xixi Chen <xixi.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 25 Mar 2022 02:23:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/soc/mediatek: Remove unused <console/console.h>
by Hung-Te Lin (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Xi Chen, Elyes Haouas. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60917 ) Change subject: src/soc/mediatek: Remove unused <console/console.h> ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60917 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ifc85ed8b5660eca11be50fddda0cf32aa1dd611c Gerrit-Change-Number: 60917 Gerrit-PatchSet: 3 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 25 Mar 2022 02:22:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src: Remove unused <bootmode.h>
by Hung-Te Lin (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Andrey Petrov, Patrick Rudolph, Elyes Haouas. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60911 ) Change subject: src: Remove unused <bootmode.h> ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/60911 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ebd472e0cfc641bd7e465b8d29272fd2f7520a1 Gerrit-Change-Number: 60911 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 25 Mar 2022 02:22:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src: Remove unused <bootmode.h>
by Hung-Te Lin (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Andrey Petrov, Patrick Rudolph, Elyes Haouas. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60911 ) Change subject: src: Remove unused <bootmode.h> ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/60911 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2ebd472e0cfc641bd7e465b8d29272fd2f7520a1 Gerrit-Change-Number: 60911 Gerrit-PatchSet: 2 Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Elyes Haouas <ehaouas(a)noos.fr> Gerrit-Comment-Date: Fri, 25 Mar 2022 02:22:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022