coreboot-gerrit March 2022

coreboot-gerrit@coreboot.org

1 participants
6700 discussions

Change in blobs[master]: Revert "soc/mediatek/mt8186: Update SPM firmware to pcm_suspend_v0215...
by Rex-BC Chen (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Hello Hung-Te Lin, Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/blobs/+/63097 to look at the new patch set (#2). Change subject: Revert "soc/mediatek/mt8186: Update SPM firmware to pcm_suspend_v0215_v10" ...................................................................... Revert "soc/mediatek/mt8186: Update SPM firmware to pcm_suspend_v0215_v10" This reverts commit bb10a0047c0e6665e8337f46904b3906de7e7a6d. Revert reason: original SPM firmware is used to prevent suspend fail. We disable 26M clock to bypass PMIC wrap when suspending. We found the root cause of suspend fail and it's because the error setting of PMIF. (Fixed in CB:63089) Therefore, we revert the original patch to enable 26M clock. BUG=b:215639203 TEST=test of suspend and resume pass. Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Change-Id: I63923188b814f0b44690784b55bcec9aff9b3d23 --- M soc/mediatek/mt8186/spm_firmware.bin M soc/mediatek/mt8186/spm_firmware.bin.md5 M soc/mediatek/mt8186/spm_release_notes.txt 3 files changed, 1 insertion(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/97/63097/2 -- To view, visit https://review.coreboot.org/c/blobs/+/63097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: I63923188b814f0b44690784b55bcec9aff9b3d23 Gerrit-Change-Number: 63097 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in blobs[master]: Revert "soc/mediatek/mt8186: Update SPM firmware to pcm_suspend_v0215...
by Rex-BC Chen (Code Review) 24 Mar '22

24 Mar '22

Rex-BC Chen has uploaded this change for review. ( https://review.coreboot.org/c/blobs/+/63097 ) Change subject: Revert "soc/mediatek/mt8186: Update SPM firmware to pcm_suspend_v0215_v10" ...................................................................... Revert "soc/mediatek/mt8186: Update SPM firmware to pcm_suspend_v0215_v10" This reverts commit bb10a0047c0e6665e8337f46904b3906de7e7a6d. Revert reason: original SPM firmware is used to prevent suspend fail. We disable 26M clock to bypass PMIC wrap when suspending. We found the root cause of suspend fail and it's because the error setting of PMIF. (Fixed in CB:63089) Therefore, we revert the original patch to enable 26M clock. Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Change-Id: I63923188b814f0b44690784b55bcec9aff9b3d23 --- M soc/mediatek/mt8186/spm_firmware.bin M soc/mediatek/mt8186/spm_firmware.bin.md5 M soc/mediatek/mt8186/spm_release_notes.txt 3 files changed, 1 insertion(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/blobs refs/changes/97/63097/1 diff --git a/soc/mediatek/mt8186/spm_firmware.bin b/soc/mediatek/mt8186/spm_firmware.bin index c1b2804..7e0ca8d 100644 --- a/soc/mediatek/mt8186/spm_firmware.bin +++ b/soc/mediatek/mt8186/spm_firmware.bin Binary files differ diff --git a/soc/mediatek/mt8186/spm_firmware.bin.md5 b/soc/mediatek/mt8186/spm_firmware.bin.md5 index 7d43cf2..910cf06 100644 --- a/soc/mediatek/mt8186/spm_firmware.bin.md5 +++ b/soc/mediatek/mt8186/spm_firmware.bin.md5 @@ -1 +1 @@ -265ce2c876ca4d6d7febe9cbcc2dd005 *spm_firmware.bin +7db456c2374b3a76daa9e6f0f2b4fd71 *spm_firmware.bin diff --git a/soc/mediatek/mt8186/spm_release_notes.txt b/soc/mediatek/mt8186/spm_release_notes.txt index 568e414..7d72463 100644 --- a/soc/mediatek/mt8186/spm_release_notes.txt +++ b/soc/mediatek/mt8186/spm_release_notes.txt @@ -1,7 +1,4 @@ ** Build from MediaTek Internal ** -# pcm_suspend_v0215_v10 -1. Disable 26MHz clock while suspending. - # pcm_suspend_mp_v1109 1. SPM suspend can turn 26M clock off when system goes into suspend. -- To view, visit https://review.coreboot.org/c/blobs/+/63097 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: blobs Gerrit-Branch: master Gerrit-Change-Id: I63923188b814f0b44690784b55bcec9aff9b3d23 Gerrit-Change-Number: 63097 Gerrit-PatchSet: 1 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/mediatek/mt8186: add pmif driver setting
by Rex-BC Chen (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63089 ) Change subject: soc/mediatek/mt8186: add pmif driver setting ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: verify pass -- To view, visit https://review.coreboot.org/c/coreboot/+/63089 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d02198f19f9cb052fba612c02404a6af1a10adb Gerrit-Change-Number: 63089 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Fri, 25 Mar 2022 01:54:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8186: add pmif driver setting
by Rex-BC Chen (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Hung-Te Lin. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63089 ) Change subject: soc/mediatek/mt8186: add pmif driver setting ...................................................................... Patch Set 2: Code-Review-1 -- To view, visit https://review.coreboot.org/c/coreboot/+/63089 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d02198f19f9cb052fba612c02404a6af1a10adb Gerrit-Change-Number: 63089 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Comment-Date: Fri, 25 Mar 2022 01:51:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8186: add pmif driver setting
by Rex-BC Chen (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Hung-Te Lin. Hello Hung-Te Lin, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/63089 to look at the new patch set (#2). Change subject: soc/mediatek/mt8186: add pmif driver setting ...................................................................... soc/mediatek/mt8186: add pmif driver setting We encounter a issue of suspend fail, and the root cause is that the default pmif register setting is not correct for low power mode. Therefore, we add the correct setting of pmif low power. This implementation is based on chapter 3.7 in MT8186 Functional Specification. BUG=b:215639203 TEST=test of suspend and resume pass. Signed-off-by: Zhiyong Tao <zhiyong.tao(a)mediatek.com> Change-Id: I2d02198f19f9cb052fba612c02404a6af1a10adb --- M src/soc/mediatek/mt8186/Makefile.inc M src/soc/mediatek/mt8186/include/soc/addressmap.h A src/soc/mediatek/mt8186/include/soc/pmif.h M src/soc/mediatek/mt8186/mt6366.c A src/soc/mediatek/mt8186/pmif.c 5 files changed, 42 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/63089/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63089 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2d02198f19f9cb052fba612c02404a6af1a10adb Gerrit-Change-Number: 63089 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya: Adjust FMD file to chromeos.fmd for kano
by Ren Kuo (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Grace Kao, David Wu, Tracy Wu. Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63086 ) Change subject: mb/google/brya: Adjust FMD file to chromeos.fmd for kano ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63086 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I09833039a450fa014e8e501bde9fec6e7ed59c7a Gerrit-Change-Number: 63086 Gerrit-PatchSet: 2 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Grace Kao <grace.kao(a)intel.corp-partner.google.com> Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tracy Wu <tracy.wu(a)intel.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Grace Kao <grace.kao(a)intel.corp-partner.google.com> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Tracy Wu <tracy.wu(a)intel.corp-partner.google.com> Gerrit-Comment-Date: Fri, 25 Mar 2022 01:42:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp: Select VBOOT_MOCK_SECDATA for ADL-N
by Kangheui Won (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Krishna P Bhat D, Balaji Manigandan, Usha P. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62957 ) Change subject: mb/intel/adlrvp: Select VBOOT_MOCK_SECDATA for ADL-N ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/62957 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc0112545dbd80921d89d48eff58c512729243af Gerrit-Change-Number: 62957 Gerrit-PatchSet: 1 Gerrit-Owner: Usha P <usha.p(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com> Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Attention: Usha P <usha.p(a)intel.com> Gerrit-Comment-Date: Fri, 25 Mar 2022 01:08:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/i2c/tpm: Work around missing board_cfg in Ti50 FW under 0.15
by Kangheui Won (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Paul Menzel, Christian Walter, Eric Lai. Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63011 ) Change subject: drivers/i2c/tpm: Work around missing board_cfg in Ti50 FW under 0.15 ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/63011 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ieec7842ca66b4c690df04a400cebcf45138c745d Gerrit-Change-Number: 63011 Gerrit-PatchSet: 8 Gerrit-Owner: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org> Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Thu, 24 Mar 2022 23:52:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/skyrim: Call espi_switch_to_spi2_pads
by Jon Murphy (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Raul Rangel, Karthik Ramasubramanian. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63096 ) Change subject: mb/google/skyrim: Call espi_switch_to_spi2_pads ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/63096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I43713d7376a28ced2be635668836464ceec46392 Gerrit-Change-Number: 63096 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 24 Mar 2022 23:28:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/sabrina: Add espi_switch_to_spi2_pads
by Jon Murphy (Code Review) 24 Mar '22

24 Mar '22

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Fred Reitberger, Karthik Ramasubramanian, Felix Held. Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63095 ) Change subject: soc/amd/sabrina: Add espi_switch_to_spi2_pads ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/63095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96baf6b9c169ed61d221352b29ac676bca40da21 Gerrit-Change-Number: 63095 Gerrit-PatchSet: 2 Gerrit-Owner: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jon Murphy <jpmurphy(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Thu, 24 Mar 2022 23:28:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit March 2022