Attention is currently required from: Paul Menzel.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59956 )
Change subject: soc/mediatek/common/usb: Remove weak function `mtk_usb_prepare()`
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
@Paul do you still want to merge this?
If yes please add an empty impl for mt8183 so we won't break builds.
--
To view, visit https://review.coreboot.org/c/coreboot/+/59956
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa7806b0430ea5ae1f3c699e6305476b0082e544
Gerrit-Change-Number: 59956
Gerrit-PatchSet: 2
Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Fri, 25 Mar 2022 02:22:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: YH Lin, Subrata Banik, Tim Wawrzynczak, Eric Lai, Zhuohao Lee, Felix Held.
Raihow Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63080 )
Change subject: mb/google/brask/variants/moli: update overridetree for moli
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
> Please add my new account. And I would expect you use this config in this CL.
Ok, I add it.
--
To view, visit https://review.coreboot.org/c/coreboot/+/63080
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If83031edcd90ea746704590765102b9b0dee03c1
Gerrit-Change-Number: 63080
Gerrit-PatchSet: 7
Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com>
Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com>
Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.com>
Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Peter Chi <peter_chi(a)wistron.corp-partner.google.com>
Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com>
Gerrit-CC: Will Tsai <will_tsai(a)wistron.corp-partner.google.com>
Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 25 Mar 2022 02:15:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: YH Lin, Subrata Banik, Tim Wawrzynczak, Zhuohao Lee, Raihow Shi, Felix Held.
Raihow Shi has removed EricR Lai from this change. ( https://review.coreboot.org/c/coreboot/+/63080 )
Change subject: mb/google/brask/variants/moli: update overridetree for moli
......................................................................
Removed reviewer EricR Lai.
--
To view, visit https://review.coreboot.org/c/coreboot/+/63080
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If83031edcd90ea746704590765102b9b0dee03c1
Gerrit-Change-Number: 63080
Gerrit-PatchSet: 7
Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com>
Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com>
Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.com>
Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Peter Chi <peter_chi(a)wistron.corp-partner.google.com>
Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com>
Gerrit-CC: Will Tsai <will_tsai(a)wistron.corp-partner.google.com>
Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Attention: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: deleteReviewer
Amanda Hwang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62998 )
Change subject: mb/google/brya/var/brya0: Replace amp max98357 with max98360
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Hi Tim,
Could you help to cherry-pick this change to chromium, thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/62998
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3033e31cf5c2dade02dc19531f5e5365eeeb7a78
Gerrit-Change-Number: 62998
Gerrit-PatchSet: 4
Gerrit-Owner: Amanda Hwang <amanda_hwang(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 25 Mar 2022 02:11:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: YH Lin, Subrata Banik, Tim Wawrzynczak, Zhuohao Lee, EricR Lai, Raihow Shi, Felix Held.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63080 )
Change subject: mb/google/brask/variants/moli: update overridetree for moli
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
Please add my new account. And I would expect you use this config in this CL.
--
To view, visit https://review.coreboot.org/c/coreboot/+/63080
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If83031edcd90ea746704590765102b9b0dee03c1
Gerrit-Change-Number: 63080
Gerrit-PatchSet: 7
Gerrit-Owner: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com>
Gerrit-CC: Ariel Fang <ariel_fang(a)wistron.corp-partner.google.com>
Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-CC: Eric Lai <eric_lai(a)quanta.corp-partner.google.com>
Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.com>
Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Peter Chi <peter_chi(a)wistron.corp-partner.google.com>
Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-CC: Terry Chen <terry_chen(a)wistron.corp-partner.google.com>
Gerrit-CC: Will Tsai <will_tsai(a)wistron.corp-partner.google.com>
Gerrit-CC: Zoey Wu <zoey_wu(a)wistron.corp-partner.google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Attention: Raihow Shi <raihow_shi(a)wistron.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 25 Mar 2022 02:06:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Hello Hung-Te Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/blobs/+/63097
to look at the new patch set (#4).
Change subject: Revert "soc/mediatek/mt8186: Update SPM firmware to pcm_suspend_v0215_v10"
......................................................................
Revert "soc/mediatek/mt8186: Update SPM firmware to pcm_suspend_v0215_v10"
This reverts commit d13ba18eb0daaa6d6cd708bb981ee0a562ac4789.
Revert reason:
original SPM firmware is used to prevent suspend fail. We disable
26M clock to bypass pmic wrap when suspending.
We found the root cause of suspend fail and it's because the error
setting of pmif. (Fixed in CB:63089)
Therefore, we revert the original patch to enable 26M clock.
BUG=b:215639203
TEST=test of suspend and resume pass.
Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Change-Id: I63923188b814f0b44690784b55bcec9aff9b3d23
---
M soc/mediatek/mt8186/spm_firmware.bin
M soc/mediatek/mt8186/spm_firmware.bin.md5
M soc/mediatek/mt8186/spm_release_notes.txt
3 files changed, 1 insertion(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/blobs refs/changes/97/63097/4
--
To view, visit https://review.coreboot.org/c/blobs/+/63097
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: I63923188b814f0b44690784b55bcec9aff9b3d23
Gerrit-Change-Number: 63097
Gerrit-PatchSet: 4
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Hung-Te Lin, Yu-Ping Wu.
Hello Hung-Te Lin, Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/blobs/+/63097
to look at the new patch set (#3).
Change subject: Revert "soc/mediatek/mt8186: Update SPM firmware to pcm_suspend_v0215_v10"
......................................................................
Revert "soc/mediatek/mt8186: Update SPM firmware to pcm_suspend_v0215_v10"
This reverts commit d13ba18eb0daaa6d6cd708bb981ee0a562ac4789.
Revert reason:
original SPM firmware is used to prevent suspend fail. We disable
26M clock to bypass pmic wrap when suspending.
We found the root cause of suspend fail and it's because the error
setting of pmif. (Fixed in CB:63089)
Therefore, we revert the original patch to enable 26M clock.
BUG=b:215639203
TEST=test of suspend and resume pass.
Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Change-Id: I63923188b814f0b44690784b55bcec9aff9b3d23
---
M soc/mediatek/mt8186/spm_firmware.bin
M soc/mediatek/mt8186/spm_firmware.bin.md5
M soc/mediatek/mt8186/spm_release_notes.txt
3 files changed, 1 insertion(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/blobs refs/changes/97/63097/3
--
To view, visit https://review.coreboot.org/c/blobs/+/63097
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: blobs
Gerrit-Branch: master
Gerrit-Change-Id: I63923188b814f0b44690784b55bcec9aff9b3d23
Gerrit-Change-Number: 63097
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-MessageType: newpatchset